<https://github.com/cofacts/rumors-line-bot/pull/312|#312 Revamp feedback sending mechanism>
cofacts.github.io
Web site created using create-react-app
Migration report on production • Migration: 2022/7/1 1:11:53 ~ • Feedbacks matching criteria: 320,260 • Feedbacks cannot be migrated:
Migration report on production • Migration: 2022/7/1 1:11:53 ~ 1:26:13 • Feedbacks matching criteria: 320,260 • Feedbacks cannot be migrated: 2,848
*Pull Request Test Coverage Report for <https://coveralls.io/builds/50550970|Build 2604839024>* • *1* of *5* *(20.0%)* changed or added relevant lines in *3* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage decreased (*-0.2%*) to *85.487%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*
*Pull Request Test Coverage Report for <https://coveralls.io/builds/50550973|Build 2604842471>* • *1* of *5* *(20.0%)* changed or added relevant lines in *3* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage decreased (*-0.2%*) to *85.487%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*
Website w/ enlarged font <https://www.figma.com/file/6yJZnwNYJciyH7mrhPvyZs/Cofacts-website-(Interview)?node-id=5081%3A1216|https://www.figma.com/file/6yJZnwNYJciyH7mrhPvyZs/Cofacts-website-(Interview)?node-id=5081%3A1216>
Website w/ enlarged font <https://www.figma.com/file/6yJZnwNYJciyH7mrhPvyZs/Cofacts-website-(Interview)?node-id=5081%3A1216|https://www.figma.com/file/6yJZnwNYJciyH7mrhPvyZs/Cofacts-website-(Interview)?node-id=5081%3A1216>
*:loudspeaker: What role does civic tech play in confronting disinformation?* Digital disinformation continues to erode our democracies. Civic tech groups around the world have launched a flurry of efforts to mitigate this pervasive threat. *<https://codeforall.org/|Code for All>* and the *<http://ndi.org|National Democratic Institute>* have enlisted *<https://codeforall.org/2022/06/22/fighting-disinformation-with-matt-stempeck/|Matt Stempeck>* to learn and share how civic tech organizations can confront disinformation. *Head over to our blog and get to know more about his work! :bulb: If you would like to stay involved in this practitioner community as we get going, please reach out to *Matt* at *<mailto:info@civictech.guide|info@civictech.guide>* <https://g0v-tw.slack.com/archives/C02G2SXKX/p1657036416676189|View original message>
*:loudspeaker: What role does civic tech play in confronting disinformation?* Digital disinformation continues to erode our democracies. Civic tech groups around the world have launched a flurry of efforts to mitigate this pervasive threat. *<https://codeforall.org/|Code for All>* and the *<http://ndi.org|National Democratic Institute>* have enlisted *<https://codeforall.org/2022/06/22/fighting-disinformation-with-matt-stempeck/|Matt Stempeck>* to learn and share how civic tech organizations can confront disinformation. *Head over to our blog and get to know more about his work! :bulb: If you would like to stay involved in this practitioner community as we get going, please reach out to *Matt* at *<mailto:info@civictech.guide|info@civictech.guide>* <https://g0v-tw.slack.com/archives/C02G2SXKX/p1657036416676189|View original message>
g0v.hackmd.io
![]()
<https://github.com/cofacts/rumors-fb-bot/pull/37|#37 Bump moment from 2.22.2 to 2.29.4>
Bumps <https://github.com/moment/moment|moment> from 2.22.2 to 2.29.4. Changelog _Sourced from <https://github.com/moment/moment/blob/develop/CHANGELOG.md|moment's changelog>._ > *2.29.4* > > • Release Jul 6, 2022 > • <https://github-redirect.dependabot.com/moment/moment/pull/6015|#6015> [bugfix] Fix ReDoS in preprocessRFC2822 regex > > *2.29.3 <https://gist.github.com/ichernev/edebd440f49adcaec72e5e77b791d8be|Full changelog>* > > • Release Apr 17, 2022 > • <https://github-redirect.dependabot.com/moment/moment/pull/5995|#5995> [bugfix] Remove const usage > • <https://github-redirect.dependabot.com/moment/moment/pull/5990|#5990> misc: fix advisory link > > *2.29.2 <https://gist.github.com/ichernev/1904b564f6679d9aac1ae08ce13bc45c|See full changelog>* > > • Release Apr 3 2022 > > Address <https://github.com/moment/moment/security/advisories/GHSA-8hfj-j24r-96c4|GHSA-8hfj-j24r-96c4> > > *2.29.1 <https://gist.github.com/marwahaha/cc478ba01a1292ab4bd4e861d164d99b|See full changelog>* > > • Release Oct 6, 2020 > > Updated deprecation message, bugfix in hi locale > > *2.29.0 <https://gist.github.com/marwahaha/b0111718641a6461800066549957ec14|See full changelog>* > > • Release Sept 22, 2020 > > New locales (es-mx, bn-bd). Minor bugfixes and locale improvements. More tests. Moment is in maintenance mode. Read more at this link: <https://momentjs.com/docs/#/-project-status/|https://momentjs.com/docs/#/-project-status/> > > *2.28.0 <https://gist.github.com/marwahaha/028fd6c2b2470b2804857cfd63c0e94f|See full changelog>* > > • Release Sept 13, 2020 > > Fix bug where .format() modifies original instance, and locale updates > > *2.27.0 <https://gist.github.com/marwahaha/5100c9c2f42019067b1f6cefc333daa7|See full changelog>* > > • Release June 18, 2020 > > Added Turkmen locale, other locale improvements, slight TypeScript fixes > > *2.26.0 <https://gist.github.com/marwahaha/0725c40740560854a849b096ea7b7590|See full changelog>* > > • Release May 19, 2020 ... (truncated) Commits • <https://github.com/moment/moment/commit/000ac1800e620f770f4eb31b5ae908f6167b0ab2|`000ac18`> Build 2.24.4 • <https://github.com/moment/moment/commit/f2006b647939466f4f403721b8c7816d844c038c|`f2006b6`> Bump version to 2.24.4 • <https://github.com/moment/moment/commit/536ad0c348f2f99009755698f491080757a48221|`536ad0c`> Update changelog for 2.29.4 • <https://github.com/moment/moment/commit/9a3b5894f3d5d602948ac8a02e4ee528a49ca3a3|`9a3b589`> [bugfix] Fix redos in preprocessRFC2822 regex (<https://github-redirect.dependabot.com/moment/moment/issues/6015|#6015>) • <https://github.com/moment/moment/commit/6374fd860aeff75e6c9d9d11540c6b22bc7ef175|`6374fd8`> Merge branch 'master' into develop • <https://github.com/moment/moment/commit/b4e615307ee350b58ac9899e3587ce43972b0753|`b4e6153`> Revert "[bugfix] Fix redos in preprocessRFC2822 regex (<https://github-redirect.dependabot.com/moment/moment/issues/6015|#6015>)" • <https://github.com/moment/moment/commit/7aebb1617fc9bced87ab6bc4c317644019b23ce7|`7aebb16`> [bugfix] Fix redos in preprocessRFC2822 regex (<https://github-redirect.dependabot.com/moment/moment/issues/6015|#6015>) • <https://github.com/moment/moment/commit/57c90622e402c929504cc6d6f3de4ebe2a9ffc73|`57c9062`> Build 2.29.3 • <https://github.com/moment/moment/commit/aaf50b6bca4075f40a3372c291ae8072fb4e9dcf|`aaf50b6`> Fixup release complaints • <https://github.com/moment/moment/commit/26f4aef9ca0b4c998107bf7e2cf1c33c30368d44|`26f4aef`> Bump version to 2.29.3 • Additional commits viewable in <https://github.com/moment/moment/compare/2.22.2...2.29.4|compare view> <https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores|Dependabot compatibility score> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. * * * Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: • `@dependabot rebase` will rebase this PR • `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it • `@dependabot merge` will merge this PR after your CI passes on it • `@dependabot squash and merge` will squash and merge this PR after your CI passes on it • `@dependabot cancel merge` will cancel a previously requested merge and block automerging • `@dependabot reopen` will reopen this PR if it is closed • `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually • `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) • `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) • `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) • `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language • `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language • `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language • `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the <https://github.com/cofacts/rumors-fb-bot/network/alerts|Security Alerts page>.
<https://github.com/cofacts/rumors-fb-bot/pull/37|#37 Bump moment from 2.22.2 to 2.29.4>
Bumps <https://github.com/moment/moment|moment> from 2.22.2 to 2.29.4. Changelog _Sourced from <https://github.com/moment/moment/blob/develop/CHANGELOG.md|moment's changelog>._ > *2.29.4* > > • Release Jul 6, 2022 > • <https://github-redirect.dependabot.com/moment/moment/pull/6015|#6015> [bugfix] Fix ReDoS in preprocessRFC2822 regex > > *2.29.3 <https://gist.github.com/ichernev/edebd440f49adcaec72e5e77b791d8be|Full changelog>* > > • Release Apr 17, 2022 > • <https://github-redirect.dependabot.com/moment/moment/pull/5995|#5995> [bugfix] Remove const usage > • <https://github-redirect.dependabot.com/moment/moment/pull/5990|#5990> misc: fix advisory link > > *2.29.2 <https://gist.github.com/ichernev/1904b564f6679d9aac1ae08ce13bc45c|See full changelog>* > > • Release Apr 3 2022 > > Address <https://github.com/moment/moment/security/advisories/GHSA-8hfj-j24r-96c4|GHSA-8hfj-j24r-96c4> > > *2.29.1 <https://gist.github.com/marwahaha/cc478ba01a1292ab4bd4e861d164d99b|See full changelog>* > > • Release Oct 6, 2020 > > Updated deprecation message, bugfix in hi locale > > *2.29.0 <https://gist.github.com/marwahaha/b0111718641a6461800066549957ec14|See full changelog>* > > • Release Sept 22, 2020 > > New locales (es-mx, bn-bd). Minor bugfixes and locale improvements. More tests. Moment is in maintenance mode. Read more at this link: <https://momentjs.com/docs/#/-project-status/|https://momentjs.com/docs/#/-project-status/> > > *2.28.0 <https://gist.github.com/marwahaha/028fd6c2b2470b2804857cfd63c0e94f|See full changelog>* > > • Release Sept 13, 2020 > > Fix bug where .format() modifies original instance, and locale updates > > *2.27.0 <https://gist.github.com/marwahaha/5100c9c2f42019067b1f6cefc333daa7|See full changelog>* > > • Release June 18, 2020 > > Added Turkmen locale, other locale improvements, slight TypeScript fixes > > *2.26.0 <https://gist.github.com/marwahaha/0725c40740560854a849b096ea7b7590|See full changelog>* > > • Release May 19, 2020 ... (truncated) Commits • <https://github.com/moment/moment/commit/000ac1800e620f770f4eb31b5ae908f6167b0ab2|`000ac18`> Build 2.24.4 • <https://github.com/moment/moment/commit/f2006b647939466f4f403721b8c7816d844c038c|`f2006b6`> Bump version to 2.24.4 • <https://github.com/moment/moment/commit/536ad0c348f2f99009755698f491080757a48221|`536ad0c`> Update changelog for 2.29.4 • <https://github.com/moment/moment/commit/9a3b5894f3d5d602948ac8a02e4ee528a49ca3a3|`9a3b589`> [bugfix] Fix redos in preprocessRFC2822 regex (<https://github-redirect.dependabot.com/moment/moment/issues/6015|#6015>) • <https://github.com/moment/moment/commit/6374fd860aeff75e6c9d9d11540c6b22bc7ef175|`6374fd8`> Merge branch 'master' into develop • <https://github.com/moment/moment/commit/b4e615307ee350b58ac9899e3587ce43972b0753|`b4e6153`> Revert "[bugfix] Fix redos in preprocessRFC2822 regex (<https://github-redirect.dependabot.com/moment/moment/issues/6015|#6015>)" • <https://github.com/moment/moment/commit/7aebb1617fc9bced87ab6bc4c317644019b23ce7|`7aebb16`> [bugfix] Fix redos in preprocessRFC2822 regex (<https://github-redirect.dependabot.com/moment/moment/issues/6015|#6015>) • <https://github.com/moment/moment/commit/57c90622e402c929504cc6d6f3de4ebe2a9ffc73|`57c9062`> Build 2.29.3 • <https://github.com/moment/moment/commit/aaf50b6bca4075f40a3372c291ae8072fb4e9dcf|`aaf50b6`> Fixup release complaints • <https://github.com/moment/moment/commit/26f4aef9ca0b4c998107bf7e2cf1c33c30368d44|`26f4aef`> Bump version to 2.29.3 • Additional commits viewable in <https://github.com/moment/moment/compare/2.22.2...2.29.4|compare view> <https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores|Dependabot compatibility score> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. * * * Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: • `@dependabot rebase` will rebase this PR • `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it • `@dependabot merge` will merge this PR after your CI passes on it • `@dependabot squash and merge` will squash and merge this PR after your CI passes on it • `@dependabot cancel merge` will cancel a previously requested merge and block automerging • `@dependabot reopen` will reopen this PR if it is closed • `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually • `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) • `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) • `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) • `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language • `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language • `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language • `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the <https://github.com/cofacts/rumors-fb-bot/network/alerts|Security Alerts page>.
Superseded by <https://github.com/cofacts/rumors-fb-bot/pull/37|#37>.
Superseded by <https://github.com/cofacts/rumors-fb-bot/pull/37|#37>.
<https://github.com/cofacts/media-manager/commit/bbb3ab33771ab20761753bfa296d7a12d967f07e|Previously> we removed testing node v18 because our integration test would clear GCS bucket content under the specified prefix when setting up. This PR separates the bucket prefix used for each Github workflow run, attempt #, node version and target OS, so that each run will have their own prefix on GCS and thus does not interfere with each other. PR run #69 attempt 1: <https://github.com/cofacts/media-manager/actions/runs/2633901046/attempts/1|https://github.com/cofacts/media-manager/actions/runs/2633901046/attempts/1> Corresponding bucket content: <https://user-images.githubusercontent.com/108608/177917517-c9fae9b4-7311-40ba-8357-3a4c3428087f.png|image> PR run #69 rerun (attempt 2): <https://github.com/cofacts/media-manager/actions/runs/2633901046/attempts/2|https://github.com/cofacts/media-manager/actions/runs/2633901046/attempts/2> Corresponding bucket content: <https://user-images.githubusercontent.com/108608/177917789-b647c37d-1d7e-4d83-800d-6bdd4708c2d0.png|image>
![]()
<https://github.com/cofacts/media-manager/commit/bbb3ab33771ab20761753bfa296d7a12d967f07e|Previously> we removed testing node v18 because our integration test would clear GCS bucket content under the specified prefix when setting up. This PR separates the bucket prefix used for each Github workflow run, attempt #, node version and target OS, so that each run will have their own prefix on GCS and thus does not interfere with each other. *Test result* PR run #69 attempt 1: <https://github.com/cofacts/media-manager/actions/runs/2633901046/attempts/1|https://github.com/cofacts/media-manager/actions/runs/2633901046/attempts/1> Corresponding bucket content: <https://user-images.githubusercontent.com/108608/177917517-c9fae9b4-7311-40ba-8357-3a4c3428087f.png|image> PR run #69 rerun (attempt 2): <https://github.com/cofacts/media-manager/actions/runs/2633901046/attempts/2|https://github.com/cofacts/media-manager/actions/runs/2633901046/attempts/2> Corresponding bucket content: <https://user-images.githubusercontent.com/108608/177917789-b647c37d-1d7e-4d83-800d-6bdd4708c2d0.png|image> *Others* On the GCS we can setup object lifecycle so that artifacts of old workflow runs are deleted automatically. <https://user-images.githubusercontent.com/108608/177918354-b0f21421-9137-44fa-8021-79925ee4aef0.png|image>
![]()
:white_check_mark: All checks have passed
<https://github.com/cofacts/takedowns/pull/78|#78 Create 0708-ads.md>
<https://github.com/cofacts/takedowns/pull/78|#78 Create 0708-ads.md>
<https://github.com/cofacts/rumors-site/pull/493|#493 Support attachment variants>
Extends <https://github.com/cofacts/rumors-site/pull/490|#490> on task <https://github.com/cofacts/rumors-site/issues/483|#483> . Must merge after API PR <https://github.com/cofacts/rumors-api/pull/288|cofacts/rumors-api#288> is deployed. This PR: • Uses "thumbnail" variant for list • Uses "preview" variant for detail page • Constraints image height so that image articles does not take too much vertical space in lists • In article detail, add link to original file for logged in users Deployed to staging. *Screenshots* *Article list, desktop* <https://user-images.githubusercontent.com/108608/177980978-f3cb15c5-8c6e-4528-844c-18eb23d0b26d.png|image> *Article list, mobile* <https://user-images.githubusercontent.com/108608/177981067-33c3a3c1-d2a2-40c3-af99-2f53c9b96a02.png|image> *Reply list, desktop* <https://user-images.githubusercontent.com/108608/177981168-12361d87-6dd3-4e6d-89ff-db7ab37b6e06.png|image> *Reply list, mobile* <https://user-images.githubusercontent.com/108608/177981140-12a78fd0-22d9-49c0-86a1-cac41685f9c1.png|image> *Article detail, desktop* Note that only when user logs in, clicking the image in article detail would bring user to the original file <https://user-images.githubusercontent.com/108608/177980481-d692c7a5-d70b-489f-b3bf-7bd3886c56aa.png|image> *Storybook* *Article detail, mobile* <https://user-images.githubusercontent.com/108608/177980885-aee96402-7d1c-45ab-91d9-62e3dd1125e2.png|image>
![]()
<https://github.com/cofacts/rumors-site/pull/493|#493 Support attachment variants>
Extends <https://github.com/cofacts/rumors-site/pull/490|#490> on task <https://github.com/cofacts/rumors-site/issues/483|#483> . Must merge after API PR <https://github.com/cofacts/rumors-api/pull/288|cofacts/rumors-api#288> is deployed. This PR: • Uses "thumbnail" variant for list • Uses "preview" variant for detail page • Constraints image height so that image articles does not take too much vertical space in lists • In article detail, add link to original file for logged in users Deployed to staging. *Screenshots* *Article list, desktop* <https://user-images.githubusercontent.com/108608/177980978-f3cb15c5-8c6e-4528-844c-18eb23d0b26d.png|image> *Article list, mobile* <https://user-images.githubusercontent.com/108608/177981067-33c3a3c1-d2a2-40c3-af99-2f53c9b96a02.png|image> *Reply list, desktop* <https://user-images.githubusercontent.com/108608/177981168-12361d87-6dd3-4e6d-89ff-db7ab37b6e06.png|image> *Reply list, mobile* <https://user-images.githubusercontent.com/108608/177981140-12a78fd0-22d9-49c0-86a1-cac41685f9c1.png|image> *Profile page, desktop* <https://user-images.githubusercontent.com/108608/177982049-390b7ded-0676-4cfb-9f24-a6203ae4b141.png|image> *Profile page, mobile* <https://user-images.githubusercontent.com/108608/177982098-3052b3c2-0382-48cc-bd36-97921e65ffec.png|image> *Article detail, desktop* Note that only when user logs in, clicking the image in article detail would bring user to the original file <https://user-images.githubusercontent.com/108608/177980481-d692c7a5-d70b-489f-b3bf-7bd3886c56aa.png|image> *Article detail, mobile* <https://user-images.githubusercontent.com/108608/177980885-aee96402-7d1c-45ab-91d9-62e3dd1125e2.png|image> *Create reply message tab, mobile* <https://user-images.githubusercontent.com/108608/177982871-391a80bf-275c-4d53-9244-5afe84f22fe3.png|image> *Related reply, desktop* <https://user-images.githubusercontent.com/108608/177983052-72022652-7ca5-4a9f-8fde-f732b46eb5dd.png|image> *Related reply, mobile* <https://user-images.githubusercontent.com/108608/177982979-dcbf3c17-a150-42da-b849-4033681472cd.png|image> *Storybook* <https://user-images.githubusercontent.com/108608/177981957-725db20f-e6cd-4917-8980-fc236edc9e1f.png|image>
![]()
:white_check_mark: 4 other checks have passed
<https://coveralls.io/builds/50707454|Coverage Status> Coverage remained the same at 75.605% when pulling *<https://github.com/cofacts/rumors-site/commit/dd36e9a265413e38af647c51f85f941938a36f9e|dd36e9a> on attachment-variants* into *<https://github.com/cofacts/rumors-site/commit/2ac82d9fa7f58327b198c5062dd0be0555d3cacb|2ac82d9> on master*.
<https://coveralls.io/builds/50707235|Coverage Status> Coverage remained the same at 75.605% when pulling *<https://github.com/cofacts/rumors-site/commit/4b6773f3883765ca7835bfde1e011e8c3d695991|4b6773f> on attachment-variants* into *<https://github.com/cofacts/rumors-site/commit/2ac82d9fa7f58327b198c5062dd0be0555d3cacb|2ac82d9> on master*.
YouTube
Review on #311 Implement line content proxy
LGTM! :+1: :+1: :+1:
Review on #311 Implement line content proxy
LGTM! :+1: :+1: :+1:
Fixes <https://github.com/cofacts/rumors-site/issues/492|#492> • Add message count of filtered messages • Time filter and type filter should act on the users' article-reply, rather than any article replies in article. • Add a sort option that sorts by matching (user's) article reply. *Screenshots* Left: this PR; Right: staging, before this PR. *Search count & filter* • The updated time filter will properly apply the logic on the user's article reply, rather than applying on any reply of the article. • Count of searched result is displayed below the filter. <https://user-images.githubusercontent.com/108608/178222915-f3869595-8d83-4b73-8182-663108b1da08.png|image> *Article reply type update* The updated type filter will properly apply the logic on the user's article reply, rather than applying on any reply of the article. <https://user-images.githubusercontent.com/108608/178223554-146f6f5b-a928-4322-b56b-6433b734e911.png|image> *New sort options* • Most recently applied: default. Sort by the profile page users article replies that matches the search criteria. • Most recently applied by any user: The original sorting method before this PR. Sort by any article reply in the matching article. <https://user-images.githubusercontent.com/108608/178223803-94de74ce-3651-4004-b3c0-dd620186f618.png|image>
![]()
Fixes <https://github.com/cofacts/rumors-site/issues/492|#492> • Add message count of filtered messages • Time filter and type filter should act on the users' article-reply, rather than any article replies in article. • Add a sort option that sorts by matching (user's) article reply. *Screenshots* Left: this PR; Right: staging, before this PR. *Search count & filter* • The updated time filter will properly apply the logic on the user's article reply, rather than applying on any reply of the article. • Count of searched result is displayed below the filter. <https://user-images.githubusercontent.com/108608/178222915-f3869595-8d83-4b73-8182-663108b1da08.png|image> *Article reply type update* The updated type filter will properly apply the logic on the user's article reply, rather than applying on any reply of the article. <https://user-images.githubusercontent.com/108608/178223554-146f6f5b-a928-4322-b56b-6433b734e911.png|image> *New sort options* • Most recently applied: default. Sort by the profile page users article replies that matches the search criteria. • Most recently applied by any user: The original sorting method before this PR. Sort by any article reply in the matching article. <https://user-images.githubusercontent.com/108608/178224464-e7f51d2f-9cb4-4691-bd37-636fb504b61a.png|image>
![]()
:white_check_mark: All checks have passed
<https://coveralls.io/builds/50743929|Coverage Status> Coverage remained the same at 75.605% when pulling *<https://github.com/cofacts/rumors-site/commit/4ce1738566df82a686c5b601d13e0bde0bc56b76|4ce1738> on profile-filter-count* into *<https://github.com/cofacts/rumors-site/commit/6fe65df33537f0d8252c3e1c5036183906c61dfa|6fe65df> on master*.
<https://coveralls.io/builds/50744090|Coverage Status> Coverage remained the same at 75.605% when pulling *<https://github.com/cofacts/rumors-site/commit/eb4d12da1e16052c15deb1c8e897fb65f030ee45|eb4d12d> on profile-filter-count* into *<https://github.com/cofacts/rumors-site/commit/6fe65df33537f0d8252c3e1c5036183906c61dfa|6fe65df> on master*.
<https://github.com/cofacts/rumors-site/pull/495|#495 Fix current user missing in Google Analytics>
The issue is found in <https://g0v.hackmd.io/UopCx5bcRb-gt_3SdVqRdQ#%E5%B0%8F%E8%81%9A%E7%B1%8C%E5%82%99|20220706 meeting> Currently on production, if the user is already logged in, starts their session on the landing page, and then goes to other pages, their user ID will not be sent in Google Analytics actions. This is because • We push current user to Google Tag Manager in `useCurrentUser`'s `onCompleted` callback <https://user-images.githubusercontent.com/108608/178239220-cac32f61-efd3-4458-8ee5-cd015a438257.png|image> • Before this PR, landing page uses its own way to load user, and thus does not use `useCurrentUser` • Landing page loads all fields that is required by `useCurrentUser`, so that when user enters other page from landing page, `useCurrentUser` hook will not invoke new GraphQL queries, thus not calling `onCompleted` callback at all. This PR fixes the issue by using `useCurrentUser` in landing page as well. *Screenshot* *Before* `CURRENT_USER` is not pushed to `dataLayer` even after the user logs in on landing page <https://user-images.githubusercontent.com/108608/178239130-072393a5-f81b-481e-93a0-d98858a97d2b.png|image> *After* Can see that `CURRENT_USER` is pushed to `dataLayer` as expected. <https://user-images.githubusercontent.com/108608/178238832-0a5e6bad-cd64-4e0e-9857-0836ea73032b.png|image>
![]()
<https://github.com/cofacts/rumors-site/pull/495|#495 Fix current user missing in Google Analytics>
The issue is found in <https://g0v.hackmd.io/UopCx5bcRb-gt_3SdVqRdQ#%E5%B0%8F%E8%81%9A%E7%B1%8C%E5%82%99|20220706 meeting> Currently on production, if the user is already logged in, starts their session on the landing page, and then goes to other pages, their user ID will not be sent in Google Analytics actions. This is because • We push current user to Google Tag Manager in `useCurrentUser`'s `onCompleted` callback <https://user-images.githubusercontent.com/108608/178239220-cac32f61-efd3-4458-8ee5-cd015a438257.png|image> • Before this PR, landing page uses its own way to load user, and thus does not use `useCurrentUser` • Landing page loads all fields that is required by `useCurrentUser`, so that when user enters other page from landing page, `useCurrentUser` hook will not invoke new GraphQL queries, thus not calling `onCompleted` callback at all. This PR fixes the issue by using `useCurrentUser` in landing page as well. *Screenshot* *Before* `CURRENT_USER` is not pushed to `dataLayer` even after the user logs in on landing page <https://user-images.githubusercontent.com/108608/178239130-072393a5-f81b-481e-93a0-d98858a97d2b.png|image> *After* Can see that `CURRENT_USER` is pushed to `dataLayer` as expected. <https://user-images.githubusercontent.com/108608/178238832-0a5e6bad-cd64-4e0e-9857-0836ea73032b.png|image>
![]()
:white_check_mark: All checks have passed
<https://coveralls.io/builds/50746164|Coverage Status> Coverage remained the same at 75.605% when pulling *<https://github.com/cofacts/rumors-site/commit/9cda37378685ee496654d2030d4de4898c330e0f|9cda373> on fix-current-user* into *<https://github.com/cofacts/rumors-site/commit/eb4d12da1e16052c15deb1c8e897fb65f030ee45|eb4d12d> on profile-filter-count*.
<https://coveralls.io/builds/50746164|Coverage Status> Coverage remained the same at 75.605% when pulling *<https://github.com/cofacts/rumors-site/commit/9cda37378685ee496654d2030d4de4898c330e0f|9cda373> on fix-current-user* into *<https://github.com/cofacts/rumors-site/commit/eb4d12da1e16052c15deb1c8e897fb65f030ee45|eb4d12d> on profile-filter-count*.