<https://github.com/cofacts/rumors-api/pull/278|#278 Fix build by upgrade Node.JS>
Done in <https://github.com/cofacts/rumors-line-bot/pull/303|#303>
Done in <https://github.com/cofacts/rumors-line-bot/pull/303|#303>
Personally I don't know why this would change XD For DOM elements, `{true}` and `"true"` are probably identical
Personally I don't know why this would change XD For DOM elements, `{true}` and `"true"` are probably identical
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
g0v.hackmd.io
Close by <https://github.com/cofacts/rumors-site/pull/484|#484>
Close by <https://github.com/cofacts/rumors-site/pull/484|#484>
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
<https://github.com/dependabot|@dependabot> rebase
<https://github.com/dependabot|@dependabot> rebase
<https://github.com/dependabot|@dependabot> recreate
<https://github.com/dependabot|@dependabot> recreate
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot rebase`.
cofacts.github.io
Web site created using create-react-app
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
image / text in article list 混排 v.s. 分開排
image / text in article list 混排 v.s. 分開排
<https://github.com/cofacts/rumors-site/issues/486|#486 Cannot downvote categories>
Found in <https://g0v.hackmd.io/Y40dNpVBSbKF-NHqfmdGNQ#%E6%9C%AA%E7%AB%9F%E9%A0%85%E7%9B%AE|20220504 pre-release check> and can be reproduced easily on production.
<https://github.com/cofacts/rumors-site/issues/486|#486 Cannot downvote categories>
Found in <https://g0v.hackmd.io/Y40dNpVBSbKF-NHqfmdGNQ#%E6%9C%AA%E7%AB%9F%E9%A0%85%E7%9B%AE|20220504 pre-release check> and can be reproduced easily on production. Related incident report on slack: <https://g0v-slack-archive.g0v.ronny.tw/index/channel/C2PPMRQGP#ts-1651762349.5851|https://g0v-slack-archive.g0v.ronny.tw/index/channel/C2PPMRQGP#ts-1651762349.5851>
support.google.com
Universal Analytics will be going away - Analytics Help
Last updated: March 16, 2022. Visit this page in the coming months for the latest information. Google Analytics 4 is our next-generation measurement solution, and it's replacing Universal Analytics.
<https://user-images.githubusercontent.com/108608/168217864-f5b29c87-be44-4278-9f16-ee41ccaa4a9c.png|圖片> Root cause TBA
<https://user-images.githubusercontent.com/108608/168217864-f5b29c87-be44-4278-9f16-ee41ccaa4a9c.png|圖片> Root cause TBA
<https://github.com/cofacts/rumors-site/pull/487|#487 Fix downvote dialog by proper null handling>
Fixes <https://github.com/cofacts/rumors-site/issues/486|#486>. Root cause please see <https://github.com/cofacts/rumors-site/issues/486#issuecomment-1125673951|#486 (comment)> . I roughly checked other return value of `useQuery()`; other access of `data` prop are all properly guarded by `?.`. <https://user-images.githubusercontent.com/108608/168223209-bc464ec1-7532-4b9a-a4fe-bf17fd921593.png|圖片>
:white_check_mark: All checks have passed
<https://github.com/cofacts/rumors-site/pull/487|#487 Fix downvote dialog by proper null handling>
Fixes <https://github.com/cofacts/rumors-site/issues/486|#486>. Root cause please see <https://github.com/cofacts/rumors-site/issues/486#issuecomment-1125673951|#486 (comment)> . I roughly checked other return value of `useQuery()`; other access of `data` prop are all properly guarded by `?.`. <https://user-images.githubusercontent.com/108608/168223209-bc464ec1-7532-4b9a-a4fe-bf17fd921593.png|圖片>
:white_check_mark: All checks have passed
<https://coveralls.io/builds/49091667|Coverage Status> Coverage remained the same at 75.531% when pulling *<https://github.com/cofacts/rumors-site/commit/149ab491ea6baeaaea6ab2bce701f21ec9b6bf7c|149ab49> on fix-downvote* into *<https://github.com/cofacts/rumors-site/commit/5326cca07fbc3aaae66850059b392bc31670c899|5326cca> on master*.
<https://coveralls.io/builds/49091667|Coverage Status> Coverage remained the same at 75.531% when pulling *<https://github.com/cofacts/rumors-site/commit/149ab491ea6baeaaea6ab2bce701f21ec9b6bf7c|149ab49> on fix-downvote* into *<https://github.com/cofacts/rumors-site/commit/5326cca07fbc3aaae66850059b392bc31670c899|5326cca> on master*.
Currently after up-voting or down-voting a reply, the whole article page will become "Loading...". It seems that in @apollo/react-hooks v3.1.5 the `loading` state behavior is slightly different from 3.0. This PR avoids "Loading..." page after an article is already displayed on screen. <https://user-images.githubusercontent.com/108608/168229724-520b5401-f69d-49d7-8cd8-82460e217918.gif|upvote-downvote>
Currently after up-voting or down-voting a reply, the whole article page will become "Loading...". It seems that in @apollo/react-hooks v3.1.5 the `loading` state behavior is slightly different from 3.0. This PR avoids "Loading..." page after an article is already displayed on screen. <https://user-images.githubusercontent.com/108608/168229724-520b5401-f69d-49d7-8cd8-82460e217918.gif|upvote-downvote>
:white_check_mark: All checks have passed
<https://coveralls.io/builds/49092309|Coverage Status> Coverage remained the same at 75.531% when pulling *<https://github.com/cofacts/rumors-site/commit/1898fb0e0d4d1a8e631fbdd35f3415a3d8ac7f82|1898fb0> on avoid-flicker* into *<https://github.com/cofacts/rumors-site/commit/affe4651f733a16a9ffa165aa3d70411ef81399d|affe465> on master*.
<https://coveralls.io/builds/49092309|Coverage Status> Coverage remained the same at 75.531% when pulling *<https://github.com/cofacts/rumors-site/commit/1898fb0e0d4d1a8e631fbdd35f3415a3d8ac7f82|1898fb0> on avoid-flicker* into *<https://github.com/cofacts/rumors-site/commit/affe4651f733a16a9ffa165aa3d70411ef81399d|affe465> on master*.
This is deployed to staging: <https://dev.cofacts.tw/article/2889dua0k41ro|https://dev.cofacts.tw/article/2889dua0k41ro> Everyone can test it out on staging article page above. We can deliver it to production on Saturday to see if anything breaks. This should help the editor's meetup on Sunday as well.
This is deployed to staging: <https://dev.cofacts.tw/article/2889dua0k41ro|https://dev.cofacts.tw/article/2889dua0k41ro> Everyone can test it out on staging article page above. We can deliver it to production on Saturday to see if anything breaks. This should help the editor's meetup on Sunday as well.
g0v.hackmd.io
Currently after up-voting or down-voting a reply, the whole article page will become "Loading...". It seems that in @apollo/react-hooks v3.1.5 the `loading` state behavior is slightly different from 3.0. This PR avoids "Loading..." page after an article is already displayed on screen. <https://user-images.githubusercontent.com/108608/168229724-520b5401-f69d-49d7-8cd8-82460e217918.gif|upvote-downvote>
SurveyCake
您好:為維護所有進出台北 NPO 聚落人員的安全,請協助填寫下列疫情調查表,並依據您的身份對應填寫問卷調查的時間:1. Hubber & Maker 調查時間:每月 05 號至 08 號2. 場租者、場租工作人員調查時間:場租活動前 3 天 ※建議接種 3 劑疫苗,以確保工作人員、會員和參加者有更健康安全的場地環境3. 場租活動參與者調查時間:活動當天進入會場前 ※建議至少接種 2 劑疫苗,以確保工作人員、會員和參加者有更健康安全的場地環境4. 參訪活動參與者調查時間:活動當天進入會場前 ※建議至少接種 2 劑疫苗,以確保工作人員、會員和參加者有更健康安全的場地環境如您或同住親友過去 14 天內有出國旅遊史者、出現發燒、咳嗽、呼吸困難等症狀或您有收到政府通報之檢疫、自主健康管理等通知,請立刻就醫,並與我們聯繫。※ 透過本問卷所蒐集、處理及利用之個人資料類別包含您的識別類個人資料、聯絡電話、個人健康狀況、旅遊史及活動與接觸史等資料,除上述防疫目的外不另作他用。若有任何問題,歡迎聯絡台北 NPO 聚落聯絡電話:02-2301-2160聯絡信箱:taipei.npo@impacthub.net
<https://github.com/cofacts/rumors-site/pull/489|#489 Bump next from 9.5.5 to 12.1.0>
Bumps <https://github.com/vercel/next.js|next> from 9.5.5 to 12.1.0. Release notes _Sourced from <https://github.com/vercel/next.js/releases|next's releases>._ > *v12.1.0* > *Core Changes* > > • Relay Support in Rust Compiler: <https://github-redirect.dependabot.com/vercel/next.js/issues/33702|#33702> > • fix eslint link-passhref rule: <https://github-redirect.dependabot.com/vercel/next.js/issues/33857|#33857> > • update webpack: <https://github-redirect.dependabot.com/vercel/next.js/issues/33831|#33831> > • Flush buffered vitals metrics on page mount: <https://github-redirect.dependabot.com/vercel/next.js/issues/33867|#33867> > • fix problem with HMR when middleware and page reference the same node_module: <https://github-redirect.dependabot.com/vercel/next.js/issues/33873|#33873> > • Refactor page component getter in web server: <https://github-redirect.dependabot.com/vercel/next.js/issues/33759|#33759> > • update NextResponse default redirect status to 307 to match docs: <https://github-redirect.dependabot.com/vercel/next.js/issues/33505|#33505> > • Bug fix: dynamic page should not be interpreted as predefined page: <https://github-redirect.dependabot.com/vercel/next.js/issues/33808|#33808> > • Group streaming experimental apis: <https://github-redirect.dependabot.com/vercel/next.js/issues/33878|#33878> > • Encapsulate routing and initial hydration: <https://github-redirect.dependabot.com/vercel/next.js/issues/33875|#33875> > • Optimize offline condition judgment: <https://github-redirect.dependabot.com/vercel/next.js/issues/33238|#33238> > • Ensure external beforeFiles rewrites are handled with next/link: <https://github-redirect.dependabot.com/vercel/next.js/issues/33888|#33888> > • Fix parsing params for i18n optional route in minimal mode: <https://github-redirect.dependabot.com/vercel/next.js/issues/33896|#33896> > • Ensure browserslist extends works properly: <https://github-redirect.dependabot.com/vercel/next.js/issues/33890|#33890> > • Fix image cache race condition: <https://github-redirect.dependabot.com/vercel/next.js/issues/33883|#33883> > • Add support for Relay projects without `artifactDirectory`: <https://github-redirect.dependabot.com/vercel/next.js/issues/33918|#33918> > • fix: handle jsxspreadattribute in inline-script-id eslint rule: <https://github-redirect.dependabot.com/vercel/next.js/issues/32421|#32421> > • feat(next-swc): Update swc: <https://github-redirect.dependabot.com/vercel/next.js/issues/33724|#33724> > • Update to latest version of amphtml-validator: <https://github-redirect.dependabot.com/vercel/next.js/issues/33967|#33967> > • Warn in dev mode when script tags are added with next/head: <https://github-redirect.dependabot.com/vercel/next.js/issues/33968|#33968> > • Ensure optional chaining in swc matches babel: <https://github-redirect.dependabot.com/vercel/next.js/issues/33995|#33995> > • Use `react-dom/server.browser` in Node.js: <https://github-redirect.dependabot.com/vercel/next.js/issues/33950|#33950> > • Ensure external middleware rewrite is handled correctly: <https://github-redirect.dependabot.com/vercel/next.js/issues/33962|#33962> > • Update Terser to v5.10.0, fix minification issues: <https://github-redirect.dependabot.com/vercel/next.js/issues/33045|#33045> > • Warn in dev mode when stylesheets are added using next/head: <https://github-redirect.dependabot.com/vercel/next.js/issues/34004|#34004> > • Use `ReadableStream` in `RenderResult`: <https://github-redirect.dependabot.com/vercel/next.js/issues/34005|#34005> > • Fix suffix ordering while streaming: <https://github-redirect.dependabot.com/vercel/next.js/issues/34011|#34011> > • Don't use yarn if a package-lock.json file is found: <https://github-redirect.dependabot.com/vercel/next.js/issues/31926|#31926> > • Do not warn when application/ld+json scripts are used with next/head: <https://github-redirect.dependabot.com/vercel/next.js/issues/34021|#34021> > • Babel & next-swc: Fix exporting page config with AsExpression: <https://github-redirect.dependabot.com/vercel/next.js/issues/32702|#32702> > • Detect per page runtime config for functions manifest: <https://github-redirect.dependabot.com/vercel/next.js/issues/33945|#33945> > • Add JSDoc to config options: <https://github-redirect.dependabot.com/vercel/next.js/issues/32915|#32915> > • Update font-stylesheet-gathering-plugin.ts: <https://github-redirect.dependabot.com/vercel/next.js/issues/30709|#30709> > • Add decoratorMetadata flag if enabled by tsconfig: <https://github-redirect.dependabot.com/vercel/next.js/issues/32914|#32914> > • fix: data url handling in css-loader: <https://github-redirect.dependabot.com/vercel/next.js/issues/34034|#34034> > • Place 'charset' element at the top of : <https://github-redirect.dependabot.com/vercel/next.js/issues/28119|#28119> > • Fix detection of anchor click events inside svg: <https://github-redirect.dependabot.com/vercel/next.js/issues/23272|#23272> > • Allow passing nothing as custom jest config: <https://github-redirect.dependabot.com/vercel/next.js/issues/32328|#32328> > • Fixes <https://github-redirect.dependabot.com/vercel/next.js/issues/31240|#31240>: Adding a recursive addPackagePath function in webpack-config: <https://github-redirect.dependabot.com/vercel/next.js/issues/31264|#31264> > • Require component rendered as child of `Link` to pass event to `onClick` handler: <https://github-redirect.dependabot.com/vercel/next.js/issues/27723|#27723> > • Allow scroll prevention on hash change: <https://github-redirect.dependabot.com/vercel/next.js/issues/31921|#31921> > • Add support for async fn / promise in next.config.js/.mjs: <https://github-redirect.dependabot.com/vercel/next.js/issues/33662|#33662> > • Fix `lazyRoot` functionality for `next/image`: <https://github-redirect.dependabot.com/vercel/next.js/issues/33933|#33933> > • Change SWC minify from beta to release candidate: <https://github-redirect.dependabot.com/vercel/next.js/issues/34056|#34056> > • Make `Router` state immutable: <https://github-redirect.dependabot.com/vercel/next.js/issues/33925|#33925> > • Stop exposing internal `render` and `renderError` methods from `next/client`: <https://github-redirect.dependabot.com/vercel/next.js/issues/34069|#34069> > • Add api-utils helper for testing: <https://github-redirect.dependabot.com/vercel/next.js/issues/34078|#34078> ... (truncated) Commits • <https://github.com/vercel/next.js/commit/8545fd1bb02244ced9e8dc9584a764aeae296cd0|`8545fd1`> v12.1.0 • <https://github.com/vercel/next.js/commit/1605f3059c7773a346998da5e1de416d106d8f32|`1605f30`> v12.0.11-canary.21 • <https://github.com/vercel/next.js/commit/69aedbd6667753f02b76563598342c8afa646dfa|`69aedbd`> Fix typo (<https://github-redirect.dependabot.com/vercel/next.js/issues/34480|#34480>) • <https://github.com/vercel/next.js/commit/f0f322c0d1655d722d133f963a84e575a61a5708|`f0f322c`> Remove deprecation for relative URL usage in middlewares (<https://github-redirect.dependabot.com/vercel/next.js/issues/34461|#34461>) • <https://github.com/vercel/next.js/commit/d4d79b2d9b9c43ed1061a3d3beeb3099368669a8|`d4d79b2`> Fix chunk buffering for server components (<https://github-redirect.dependabot.com/vercel/next.js/issues/34474|#34474>) • <https://github.com/vercel/next.js/commit/74fa4d4b93673a355d082473318562056571900f|`74fa4d4`> update webpack (<https://github-redirect.dependabot.com/vercel/next.js/issues/34477|#34477>) • <https://github.com/vercel/next.js/commit/b70397e770a0badfbafe9e2db8cb8bfeb1b06f9e|`b70397e`> Revert "Allow reading request bodies in middlewares (<https://github-redirect.dependabot.com/vercel/next.js/issues/34294|#34294>)" (<https://github-redirect.dependabot.com/vercel/next.js/issues/34479|#34479>) • <https://github.com/vercel/next.js/commit/42020114d2ada652ed9651675ad62791743e432f|`4202011`> Update font-optimization test…
:white_check_mark: No checks have passed
<https://github.com/cofacts/rumors-site/pull/489|#489 Bump next from 9.5.5 to 12.1.0>
Bumps <https://github.com/vercel/next.js|next> from 9.5.5 to 12.1.0. Release notes _Sourced from <https://github.com/vercel/next.js/releases|next's releases>._ > *v12.1.0* > *Core Changes* > > • Relay Support in Rust Compiler: <https://github-redirect.dependabot.com/vercel/next.js/issues/33702|#33702> > • fix eslint link-passhref rule: <https://github-redirect.dependabot.com/vercel/next.js/issues/33857|#33857> > • update webpack: <https://github-redirect.dependabot.com/vercel/next.js/issues/33831|#33831> > • Flush buffered vitals metrics on page mount: <https://github-redirect.dependabot.com/vercel/next.js/issues/33867|#33867> > • fix problem with HMR when middleware and page reference the same node_module: <https://github-redirect.dependabot.com/vercel/next.js/issues/33873|#33873> > • Refactor page component getter in web server: <https://github-redirect.dependabot.com/vercel/next.js/issues/33759|#33759> > • update NextResponse default redirect status to 307 to match docs: <https://github-redirect.dependabot.com/vercel/next.js/issues/33505|#33505> > • Bug fix: dynamic page should not be interpreted as predefined page: <https://github-redirect.dependabot.com/vercel/next.js/issues/33808|#33808> > • Group streaming experimental apis: <https://github-redirect.dependabot.com/vercel/next.js/issues/33878|#33878> > • Encapsulate routing and initial hydration: <https://github-redirect.dependabot.com/vercel/next.js/issues/33875|#33875> > • Optimize offline condition judgment: <https://github-redirect.dependabot.com/vercel/next.js/issues/33238|#33238> > • Ensure external beforeFiles rewrites are handled with next/link: <https://github-redirect.dependabot.com/vercel/next.js/issues/33888|#33888> > • Fix parsing params for i18n optional route in minimal mode: <https://github-redirect.dependabot.com/vercel/next.js/issues/33896|#33896> > • Ensure browserslist extends works properly: <https://github-redirect.dependabot.com/vercel/next.js/issues/33890|#33890> > • Fix image cache race condition: <https://github-redirect.dependabot.com/vercel/next.js/issues/33883|#33883> > • Add support for Relay projects without `artifactDirectory`: <https://github-redirect.dependabot.com/vercel/next.js/issues/33918|#33918> > • fix: handle jsxspreadattribute in inline-script-id eslint rule: <https://github-redirect.dependabot.com/vercel/next.js/issues/32421|#32421> > • feat(next-swc): Update swc: <https://github-redirect.dependabot.com/vercel/next.js/issues/33724|#33724> > • Update to latest version of amphtml-validator: <https://github-redirect.dependabot.com/vercel/next.js/issues/33967|#33967> > • Warn in dev mode when script tags are added with next/head: <https://github-redirect.dependabot.com/vercel/next.js/issues/33968|#33968> > • Ensure optional chaining in swc matches babel: <https://github-redirect.dependabot.com/vercel/next.js/issues/33995|#33995> > • Use `react-dom/server.browser` in Node.js: <https://github-redirect.dependabot.com/vercel/next.js/issues/33950|#33950> > • Ensure external middleware rewrite is handled correctly: <https://github-redirect.dependabot.com/vercel/next.js/issues/33962|#33962> > • Update Terser to v5.10.0, fix minification issues: <https://github-redirect.dependabot.com/vercel/next.js/issues/33045|#33045> > • Warn in dev mode when stylesheets are added using next/head: <https://github-redirect.dependabot.com/vercel/next.js/issues/34004|#34004> > • Use `ReadableStream` in `RenderResult`: <https://github-redirect.dependabot.com/vercel/next.js/issues/34005|#34005> > • Fix suffix ordering while streaming: <https://github-redirect.dependabot.com/vercel/next.js/issues/34011|#34011> > • Don't use yarn if a package-lock.json file is found: <https://github-redirect.dependabot.com/vercel/next.js/issues/31926|#31926> > • Do not warn when application/ld+json scripts are used with next/head: <https://github-redirect.dependabot.com/vercel/next.js/issues/34021|#34021> > • Babel & next-swc: Fix exporting page config with AsExpression: <https://github-redirect.dependabot.com/vercel/next.js/issues/32702|#32702> > • Detect per page runtime config for functions manifest: <https://github-redirect.dependabot.com/vercel/next.js/issues/33945|#33945> > • Add JSDoc to config options: <https://github-redirect.dependabot.com/vercel/next.js/issues/32915|#32915> > • Update font-stylesheet-gathering-plugin.ts: <https://github-redirect.dependabot.com/vercel/next.js/issues/30709|#30709> > • Add decoratorMetadata flag if enabled by tsconfig: <https://github-redirect.dependabot.com/vercel/next.js/issues/32914|#32914> > • fix: data url handling in css-loader: <https://github-redirect.dependabot.com/vercel/next.js/issues/34034|#34034> > • Place 'charset' element at the top of : <https://github-redirect.dependabot.com/vercel/next.js/issues/28119|#28119> > • Fix detection of anchor click events inside svg: <https://github-redirect.dependabot.com/vercel/next.js/issues/23272|#23272> > • Allow passing nothing as custom jest config: <https://github-redirect.dependabot.com/vercel/next.js/issues/32328|#32328> > • Fixes <https://github-redirect.dependabot.com/vercel/next.js/issues/31240|#31240>: Adding a recursive addPackagePath function in webpack-config: <https://github-redirect.dependabot.com/vercel/next.js/issues/31264|#31264> > • Require component rendered as child of `Link` to pass event to `onClick` handler: <https://github-redirect.dependabot.com/vercel/next.js/issues/27723|#27723> > • Allow scroll prevention on hash change: <https://github-redirect.dependabot.com/vercel/next.js/issues/31921|#31921> > • Add support for async fn / promise in next.config.js/.mjs: <https://github-redirect.dependabot.com/vercel/next.js/issues/33662|#33662> > • Fix `lazyRoot` functionality for `next/image`: <https://github-redirect.dependabot.com/vercel/next.js/issues/33933|#33933> > • Change SWC minify from beta to release candidate: <https://github-redirect.dependabot.com/vercel/next.js/issues/34056|#34056> > • Make `Router` state immutable: <https://github-redirect.dependabot.com/vercel/next.js/issues/33925|#33925> > • Stop exposing internal `render` and `renderError` methods from `next/client`: <https://github-redirect.dependabot.com/vercel/next.js/issues/34069|#34069> > • Add api-utils helper for testing: <https://github-redirect.dependabot.com/vercel/next.js/issues/34078|#34078> ... (truncated) Commits • <https://github.com/vercel/next.js/commit/8545fd1bb02244ced9e8dc9584a764aeae296cd0|`8545fd1`> v12.1.0 • <https://github.com/vercel/next.js/commit/1605f3059c7773a346998da5e1de416d106d8f32|`1605f30`> v12.0.11-canary.21 • <https://github.com/vercel/next.js/commit/69aedbd6667753f02b76563598342c8afa646dfa|`69aedbd`> Fix typo (<https://github-redirect.dependabot.com/vercel/next.js/issues/34480|#34480>) • <https://github.com/vercel/next.js/commit/f0f322c0d1655d722d133f963a84e575a61a5708|`f0f322c`> Remove deprecation for relative URL usage in middlewares (<https://github-redirect.dependabot.com/vercel/next.js/issues/34461|#34461>) • <https://github.com/vercel/next.js/commit/d4d79b2d9b9c43ed1061a3d3beeb3099368669a8|`d4d79b2`> Fix chunk buffering for server components (<https://github-redirect.dependabot.com/vercel/next.js/issues/34474|#34474>) • <https://github.com/vercel/next.js/commit/74fa4d4b93673a355d082473318562056571900f|`74fa4d4`> update webpack (<https://github-redirect.dependabot.com/vercel/next.js/issues/34477|#34477>) • <https://github.com/vercel/next.js/commit/b70397e770a0badfbafe9e2db8cb8bfeb1b06f9e|`b70397e`> Revert "Allow reading request bodies in middlewares (<https://github-redirect.dependabot.com/vercel/next.js/issues/34294|#34294>)" (<https://github-redirect.dependabot.com/vercel/next.js/issues/34479|#34479>) • <https://github.com/vercel/next.js/commit/42020114d2ada652ed9651675ad62791743e432f|`4202011`> Update font-optimization test…
<https://github.com/cofacts/rumors-site/pull/490|#490 Feature/media article>
Make site able to show image and reply *Snapshots* <https://user-images.githubusercontent.com/6376572/168525843-e964eb7d-2362-4b6e-a705-7f57e3d889ff.png|Screen Shot 2022-05-16 at 13 25 27> <https://user-images.githubusercontent.com/6376572/168525820-f346beb4-9628-4ff2-beab-0c2ed946eb4e.png|Screen Shot 2022-05-16 at 13 25 01> <https://user-images.githubusercontent.com/6376572/168525848-ac850614-d021-4320-890a-c9cc5ae3331b.png|Screen Shot 2022-05-16 at 13 26 03> <https://user-images.githubusercontent.com/6376572/168525853-7e2a6c56-3e44-4fbe-810f-d9bc903d8e64.png|Screen Shot 2022-05-16 at 13 26 44>
Fix <https://github.com/cofacts/rumors-site/issues/483|#483> ☑︎ Messages (Article List) ☑︎ Replies (Reply List) ☑︎ For you ☑︎ Search reply *Snapshots* <https://user-images.githubusercontent.com/6376572/168525843-e964eb7d-2362-4b6e-a705-7f57e3d889ff.png|Screen Shot 2022-05-16 at 13 25 27> <https://user-images.githubusercontent.com/6376572/168525820-f346beb4-9628-4ff2-beab-0c2ed946eb4e.png|Screen Shot 2022-05-16 at 13 25 01> <https://user-images.githubusercontent.com/6376572/168525848-ac850614-d021-4320-890a-c9cc5ae3331b.png|Screen Shot 2022-05-16 at 13 26 03> <https://user-images.githubusercontent.com/6376572/168525853-7e2a6c56-3e44-4fbe-810f-d9bc903d8e64.png|Screen Shot 2022-05-16 at 13 26 44>
:white_check_mark: All checks have passed
<https://coveralls.io/builds/49136096|Coverage Status> Coverage increased (+0.03%) to 75.561% when pulling *<https://github.com/cofacts/rumors-site/commit/cc1906d7fef739321619d4e2674e76ee41ddc8eb|cc1906d> on feature/media-article* into *<https://github.com/cofacts/rumors-site/commit/47818e16ab7e415887829dc1a981d405a38ce120|47818e1> on master*.
<https://coveralls.io/builds/49136096|Coverage Status> Coverage increased (+0.03%) to 75.561% when pulling *<https://github.com/cofacts/rumors-site/commit/cc1906d7fef739321619d4e2674e76ee41ddc8eb|cc1906d> on feature/media-article* into *<https://github.com/cofacts/rumors-site/commit/47818e16ab7e415887829dc1a981d405a38ce120|47818e1> on master*.
I think instead of changing individual requests, we can • use env variable in `rumors-api` to determine if APIs should return all `articleTypes` • staging API shows all `articleTypes`; production API only returns `TEXT` by default before we finish implementation • `rumors-site` does not specify `articleTypes`
I think instead of changing individual requests, we can • use env variable in `rumors-api` to determine if APIs should return all `articleTypes` • staging API shows all `articleTypes`; production API only returns `TEXT` by default before we finish implementation • `rumors-site` does not specify `articleTypes`
Review on #490 Make website able to show image and can be replied
Thanks for the commit! I have some comments to discuss.
Review on #490 Make website able to show image and can be replied
Thanks for the commit! I have some comments to discuss.
Same as above Suggested change
Same as above Suggested change
Same as above. Suggested change
Same as above. Suggested change
Same as above. I think `bannerImage` is a bit too wide (100% width) on desktop. I think we can set `max-width` & `max-height` on them, and use `<a>` to link to the original image instead. Suggested change
Same as above. I think `bannerImage` is a bit too wide (100% width) on desktop. I think we can set `max-width` & `max-height` on them, and use `<a>` to link to the original image instead. Suggested change
nit: since we may add text for images in the future, suggest we do this instead: Suggested change
nit: since we may add text for images in the future, suggest we do this instead: Suggested change
After adding a category, currently there is no any visual feedback that tells the user that the category is added. <https://user-images.githubusercontent.com/108608/162559676-022d4169-ba14-4525-a804-47b988fd6df0.gif|no-response> Current workaround: refresh the whole page Expected: UI should show that the category is added immediately (or shortly after API response)
Add MEDIA_ARTICLE_SUPPORT env to switch default articleTypes filter as discuss in <https://github.com/cofacts/rumors-site/pull/490|cofacts/rumors-site#490>
:white_check_mark: No checks have passed
Add MEDIA_ARTICLE_SUPPORT env to switch default articleTypes filter as discuss in <https://github.com/cofacts/rumors-site/pull/490|cofacts/rumors-site#490>
<https://coveralls.io/builds/49203638|Coverage Status> Coverage remained the same at 87.473% when pulling *<https://github.com/cofacts/rumors-api/commit/0ca74bd9ededc86fefb7a3bfcec1bc3055c8c797|0ca74bd> on feature/env-media-article-support* into *<https://github.com/cofacts/rumors-api/commit/271bc9b210676f6390d4e03bf5f93165c48f2f05|271bc9b> on master*.
<https://coveralls.io/builds/49203638|Coverage Status> Coverage remained the same at 87.473% when pulling *<https://github.com/cofacts/rumors-api/commit/0ca74bd9ededc86fefb7a3bfcec1bc3055c8c797|0ca74bd> on feature/env-media-article-support* into *<https://github.com/cofacts/rumors-api/commit/271bc9b210676f6390d4e03bf5f93165c48f2f05|271bc9b> on master*.
Review on #282 Add MEDIA_ARTICLE_SUPPORT env to switch default articleTypes filter
LGTM, let's ship it <https://github.githubassets.com/images/icons/emoji/shipit.png|:shipit:>
Review on #282 Add MEDIA_ARTICLE_SUPPORT env to switch default articleTypes filter
LGTM, let's ship it <https://github.githubassets.com/images/icons/emoji/shipit.png|:shipit:>
Review on #490 Make website able to show image and can be replied
Thanks for the timely update! I have deployed the current branch to staging: <https://dev.cofacts.tw/articles|https://dev.cofacts.tw/articles> and have some comments on the current status.
Review on #490 Make website able to show image and can be replied
Thanks for the timely update! I have deployed the current branch to staging: <https://dev.cofacts.tw/articles|https://dev.cofacts.tw/articles> and have some comments on the current status. (Staging API also updated to <https://github.com/cofacts/rumors-api/pull/282|cofacts/rumors-api#282> and has `MEDIA_ARTICLE_SUPPORT` toggled on.)
Seems that 800 is a bit too high, vertical images can hit max-height first XD <https://user-images.githubusercontent.com/108608/168965648-bc9041ef-529c-4f9b-a11d-1f71c904094d.png|image> Suggest we `max-width` can be around 400, and we can remove `max-height` so that image height can be completely determined by image's apsect ratio.
Seems that 800 is a bit too high, vertical images can hit max-height first XD <https://user-images.githubusercontent.com/108608/168965648-bc9041ef-529c-4f9b-a11d-1f71c904094d.png|image> Suggest we `max-width` can be around 400, and we can remove `max-height` so that image height can be completely determined by image's apsect ratio.
Suggest that we can put a placeholder image so that the image shows up in Storybook, which helps development & maintenance in the future. Suggested change <https://user-images.githubusercontent.com/108608/168966985-45f1cb4e-c7d6-44ca-9619-8ca8596e1b1f.png|image>
Suggest that we can put a placeholder image so that the image shows up in Storybook, which helps development & maintenance in the future. Suggested change <https://user-images.githubusercontent.com/108608/168966985-45f1cb4e-c7d6-44ca-9619-8ca8596e1b1f.png|image>
Currently opened <https://github.com/cofacts/media-manager|https://github.com/cofacts/media-manager> • main branch: bootstrapped with <https://tsdx.io/|tsdx> • [WIP] MediaManager class implementation <https://github.com/cofacts/media-manager/pull/1/files|https://github.com/cofacts/media-manager/pull/1/files>
Currently opened <https://github.com/cofacts/media-manager|https://github.com/cofacts/media-manager> • main branch: bootstrapped with <https://tsdx.io/|tsdx> • [WIP] MediaManager class implementation <https://github.com/cofacts/media-manager/pull/1/files|https://github.com/cofacts/media-manager/pull/1/files>
HackMD
# Cofacts 會議記錄 ## 2022 - [20220518 會議記錄](/_HXxDu6OQPaK08WFwOshtg) - [20220511 會議記錄](/R_cEiQ8eRDmQ
Your site went down! *Code:* 0 - *Reason:* Timeout / Connection Refused
Your site went down! *Code:* 0 - *Reason:* Timeout / Connection Refused
Resolved in <https://github.com/cofacts/rumors-site/pull/484|#484>
Resolved in <https://github.com/cofacts/rumors-site/pull/484|#484>
Storybook is <https://dev.cofacts.tw/storybook/index.html|online>, no actions left
Storybook is <https://dev.cofacts.tw/storybook/index.html|online>, no actions left
*As-is* A form with anonymous avatar is shown. However, the user will be asked to login afterwards, and the submitted text will be cleared. <https://user-images.githubusercontent.com/108608/170654279-909a0ea7-2abc-4fe3-b53a-4337daa77961.png|圖片> *To-be* Replace the form to something as simple as a string, like what we did for "write reply" <https://user-images.githubusercontent.com/108608/170654382-6e056b4f-de58-40b1-bdf1-5daba525c757.png|圖片>
*As-is* A form with anonymous avatar is shown. However, the user will be asked to login afterwards, and the submitted text will be cleared. <https://user-images.githubusercontent.com/108608/170654279-909a0ea7-2abc-4fe3-b53a-4337daa77961.png|圖片> *To-be* Replace the form to something as simple as a string, like what we did for "write reply" <https://user-images.githubusercontent.com/108608/170654382-6e056b4f-de58-40b1-bdf1-5daba525c757.png|圖片>
Review on #490 Make website able to show image and can be replied
LGTM, let's ship it <https://github.githubassets.com/images/icons/emoji/shipit.png|:shipit:>
Review on #490 Make website able to show image and can be replied
LGTM, let's ship it <https://github.githubassets.com/images/icons/emoji/shipit.png|:shipit:>
Google Cloud
<https://github.com/cofacts/rumors-db/pull/59|#59 Analytics & contribution>
• Fixes <https://github.com/cofacts/rumors-db/issues/57|#57> • Fixes <https://github.com/cofacts/rumors-db/issues/58|#58> • Add automated test on the validity of the schema
:white_check_mark: 1 other check has passed
<https://github.com/cofacts/rumors-db/pull/59|#59 Analytics & contribution>
• Fixes <https://github.com/cofacts/rumors-db/issues/57|#57> • Fixes <https://github.com/cofacts/rumors-db/issues/58|#58> • Add automated test on the validity of the schema