cofacts

Month: 2020-06

2020-06-01

github 08:41:17

#42 Update all dependencies

This PR contains the following updates: * * * *Release Notes* elastic/elasticsearch-js *<https://togithub.com/elastic/elasticsearch-js/releases/v7.7.1|`v7.7.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.7.0...v7.7.1|Compare Source> <https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/current/changelog-client.html|Changelog> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.7.0|`v7.7.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.6.1...v7.7.0|Compare Source> Support for Elasticsearch `v7.7` <https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/7.x/changelog-client.html|Changelog> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.6.1|`v7.6.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.6.0...v7.6.1|Compare Source> *Fixes:* • Secure json parsing - <https://togithub.com/elastic/elasticsearch-js/issues/1110|#​1110> • ApiKey should take precedence over basic auth - <https://togithub.com/elastic/elasticsearch-js/issues/1115|#​1115> *Documentation:* • Fix typo in api reference - <https://togithub.com/elastic/elasticsearch-js/issues/1109|#​1109> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.6.0|`v7.6.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.5.1...v7.6.0|Compare Source> Support for Elasticsearch `v7.6`. *<https://togithub.com/elastic/elasticsearch-js/releases/v7.5.1|`v7.5.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.5.0...v7.5.1|Compare Source> *Fixes:* • Skip compression in case of empty string body - <https://togithub.com/elastic/elasticsearch-js/issues/1080|#​1080> • Fix typo in NoLivingConnectionsError - <https://togithub.com/elastic/elasticsearch-js/issues/1045|#​1045> • Change TransportRequestOptions.ignore to number[] - <https://togithub.com/elastic/elasticsearch-js/issues/1053|#​1053> • ClientOptions["cloud"] should have optional auth fields - <https://togithub.com/elastic/elasticsearch-js/issues/1032|#​1032> *Documentation:* • Docs: Return super in example Transport subclass - <https://togithub.com/elastic/elasticsearch-js/issues/980|#​980> • Add examples to reference - <https://togithub.com/elastic/elasticsearch-js/issues/1076|#​1076> • Added new examples - <https://togithub.com/elastic/elasticsearch-js/issues/1031|#​1031> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.5.0|`v7.5.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.4.0...v7.5.0|Compare Source> Support for Elasticsearch `v7.5`. *Features* • X-Opaque-Id support <https://togithub.com/elastic/elasticsearch-js/issues/997|#​997> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.4.0|`v7.4.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.3.0...v7.4.0|Compare Source> Support for Elasticsearch `v7.4`. *Fixes:* • Fix issue; node roles are defaulting to true when undefined is breaking usage of nodeFilter option - <https://togithub.com/elastic/elasticsearch-js/issues/967|#​967> *Documentation:* • Updated API reference doc - <https://togithub.com/elastic/elasticsearch-js/issues/945|#​945> <https://togithub.com/elastic/elasticsearch-js/issues/969|#​969> • Fix inaccurate description sniffEndpoint - <https://togithub.com/elastic/elasticsearch-js/issues/959|#​959> *Internals:* • Update code generation <https://togithub.com/elastic/elasticsearch-js/issues/969|#​969> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.3.0|`v7.3.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.2.0...v7.3.0|Compare Source> Support for Elasticsearch `v7.3`. *Features:* • Added `auth` option - <https://togithub.com/elastic/elasticsearch-js/issues/908|#​908> • Added support for `ApiKey` authentication - <https://togithub.com/elastic/elasticsearch-js/issues/908|#​908> *Fixes:* • fix(Typings): sniffInterval can also be boolean - <https://togithub.com/elastic/elasticsearch-js/issues/914|#​914> *Internals:* • Refactored connection pool - <https://togithub.com/elastic/elasticsearch-js/issues/913|#​913> *Documentation:* • Better reference code examples - <https://togithub.com/elastic/elasticsearch-js/issues/920|#​920> • Improve README - <https://togithub.com/elastic/elasticsearch-js/issues/909|#​909> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.2.0|`v7.2.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.1.0...v7.2.0|Compare Source> Support for Elasticsearch `v7.2` *Fixes:* • Remove auth data from inspect and toJSON in connection class - <https://togithub.com/elastic/elasticsearch-js/issues/887|#​887> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.1.0|`v7.1.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.0.1...v7.1.0|Compare Source> Support for Elasticsearch `v7.1` *Fixes:* • Support for non-friendly chars in url username and password - <https://togithub.com/elastic/elasticsearch-js/issues/858|#​858> • Patch deprecated parameters - <https://togithub.com/elastic/elasticsearch-js/issues/851|#​851> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.0.1|`v7.0.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.0.0...v7.0.1|Compare Source> *Fixes:* • Fix TypeScript export _(issue <https://togithub.com/elastic/elasticsearch-js/issues/841|#​841>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/842|#​842> • Fix http and https port handling _(issue <https://togithub.com/elastic/elasticsearch-js/issues/843|#​843>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/845|#​845> • Fix TypeScript definiton _(issue <https://togithub.com/elastic/elasticsearch-js/issues/803|#​803>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/846|#​846> • Added toJSON method to Connection class _(issue <https://togithub.com/elastic/elasticsearch-js/issues/848|#​848>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/849|#​849> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.0.0|`v7.0.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v6.8.7...v7.0.0|Compare Source> • Stable release. eslint/eslint *<https://togithub.com/eslint/eslint/releases/v7.1.0|`v7.1.0`>* <https://togithub.com/eslint/eslint/compare/v7.0.0...v7.1.0|Compare Source> • <https://togithub.com/eslint/eslint/commit/a93083af89c6f9714dcdd4a7f27c8655a0b0dba6|`a93083a`> Fix: astUtils.getNextLocation returns invalid location after CRLF (<https://togithub.com/eslint/eslint/issues/13275|#​13275>) (Milos Djermanovic) • <https://togithub.com/eslint/eslint/commit/df01af184d93b3d64b37cee786cad59bd0d7aacb|`df01af1`> Update: padded-blocks loc position changes (refs <https://togithub.com/eslint/eslint/issues/12334|#​12334>) (<https://togithub.com/eslint/eslint/issues/13328|#​13328>) (Anix) • <https://togithub.com/eslint/eslint/commit/bd3f092efa579944f75bfbc277b35f85e6d966ed|`bd3f092`> Fix: max-lines-per-function flagging arrow IIFEs (fixes <https://togithub.com/eslint/eslint/issues/13332|#​13332>) (<https://togithub.com/eslint/eslint/issues/13336|#​13336>) (cherryblossom000) • <https://togithub.com/eslint/eslint/commit/25462b23eac4ed1ded97eeae6187b5d8baa58e78|`25462b2`> Update: block-spacing changed loc for extra (refs <https://togithub.com/eslint/eslint/issues/12334|#​12334>) (<https://togithub.com/eslint/eslint/issues/13314|#​13314>) (Anix) • <https://togithub.com/eslint/eslint/commit/de0aab95005f172db72196fc3fd18e91ee9a5880|`de0aab9`> Fix: report end loc in one-var-declaration-per-line (refs <https://togithub.com/eslint/eslint/issues/12334|#​12334>) (<https://togithub.com/eslint/eslint/issues/13326|#​13326>) (YeonJuan) • <https://togithub.com/eslint/eslint/commit/1710296082083602a904b080908657bb431fb56c|`1710296`> Fix: no-new-symbol false positive with Symbol as an argument (<https://togithub.com/eslint/eslint/issues/13337|#​13337>) (Milos Djermanovic) • <https://togithub.com/eslint/eslint/commit/cc014514c29626e556acb0a528e3478b3725e284|`cc01451`> Fix: arrow-parens no reporting for comments inside (…

github 09:56:31

#173 Update all dependencies

This PR contains the following updates: * * * *Release Notes* elastic/elasticsearch-js *<https://togithub.com/elastic/elasticsearch-js/releases/v7.7.1|`v7.7.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.7.0...v7.7.1|Compare Source> <https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/current/changelog-client.html|Changelog> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.7.0|`v7.7.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.6.1...v7.7.0|Compare Source> Support for Elasticsearch `v7.7` <https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/7.x/changelog-client.html|Changelog> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.6.1|`v7.6.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.6.0...v7.6.1|Compare Source> *Fixes:* • Secure json parsing - <https://togithub.com/elastic/elasticsearch-js/issues/1110|#​1110> • ApiKey should take precedence over basic auth - <https://togithub.com/elastic/elasticsearch-js/issues/1115|#​1115> *Documentation:* • Fix typo in api reference - <https://togithub.com/elastic/elasticsearch-js/issues/1109|#​1109> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.6.0|`v7.6.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.5.1...v7.6.0|Compare Source> Support for Elasticsearch `v7.6`. *<https://togithub.com/elastic/elasticsearch-js/releases/v7.5.1|`v7.5.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.5.0...v7.5.1|Compare Source> *Fixes:* • Skip compression in case of empty string body - <https://togithub.com/elastic/elasticsearch-js/issues/1080|#​1080> • Fix typo in NoLivingConnectionsError - <https://togithub.com/elastic/elasticsearch-js/issues/1045|#​1045> • Change TransportRequestOptions.ignore to number[] - <https://togithub.com/elastic/elasticsearch-js/issues/1053|#​1053> • ClientOptions["cloud"] should have optional auth fields - <https://togithub.com/elastic/elasticsearch-js/issues/1032|#​1032> *Documentation:* • Docs: Return super in example Transport subclass - <https://togithub.com/elastic/elasticsearch-js/issues/980|#​980> • Add examples to reference - <https://togithub.com/elastic/elasticsearch-js/issues/1076|#​1076> • Added new examples - <https://togithub.com/elastic/elasticsearch-js/issues/1031|#​1031> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.5.0|`v7.5.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.4.0...v7.5.0|Compare Source> Support for Elasticsearch `v7.5`. *Features* • X-Opaque-Id support <https://togithub.com/elastic/elasticsearch-js/issues/997|#​997> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.4.0|`v7.4.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.3.0...v7.4.0|Compare Source> Support for Elasticsearch `v7.4`. *Fixes:* • Fix issue; node roles are defaulting to true when undefined is breaking usage of nodeFilter option - <https://togithub.com/elastic/elasticsearch-js/issues/967|#​967> *Documentation:* • Updated API reference doc - <https://togithub.com/elastic/elasticsearch-js/issues/945|#​945> <https://togithub.com/elastic/elasticsearch-js/issues/969|#​969> • Fix inaccurate description sniffEndpoint - <https://togithub.com/elastic/elasticsearch-js/issues/959|#​959> *Internals:* • Update code generation <https://togithub.com/elastic/elasticsearch-js/issues/969|#​969> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.3.0|`v7.3.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.2.0...v7.3.0|Compare Source> Support for Elasticsearch `v7.3`. *Features:* • Added `auth` option - <https://togithub.com/elastic/elasticsearch-js/issues/908|#​908> • Added support for `ApiKey` authentication - <https://togithub.com/elastic/elasticsearch-js/issues/908|#​908> *Fixes:* • fix(Typings): sniffInterval can also be boolean - <https://togithub.com/elastic/elasticsearch-js/issues/914|#​914> *Internals:* • Refactored connection pool - <https://togithub.com/elastic/elasticsearch-js/issues/913|#​913> *Documentation:* • Better reference code examples - <https://togithub.com/elastic/elasticsearch-js/issues/920|#​920> • Improve README - <https://togithub.com/elastic/elasticsearch-js/issues/909|#​909> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.2.0|`v7.2.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.1.0...v7.2.0|Compare Source> Support for Elasticsearch `v7.2` *Fixes:* • Remove auth data from inspect and toJSON in connection class - <https://togithub.com/elastic/elasticsearch-js/issues/887|#​887> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.1.0|`v7.1.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.0.1...v7.1.0|Compare Source> Support for Elasticsearch `v7.1` *Fixes:* • Support for non-friendly chars in url username and password - <https://togithub.com/elastic/elasticsearch-js/issues/858|#​858> • Patch deprecated parameters - <https://togithub.com/elastic/elasticsearch-js/issues/851|#​851> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.0.1|`v7.0.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.0.0...v7.0.1|Compare Source> *Fixes:* • Fix TypeScript export _(issue <https://togithub.com/elastic/elasticsearch-js/issues/841|#​841>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/842|#​842> • Fix http and https port handling _(issue <https://togithub.com/elastic/elasticsearch-js/issues/843|#​843>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/845|#​845> • Fix TypeScript definiton _(issue <https://togithub.com/elastic/elasticsearch-js/issues/803|#​803>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/846|#​846> • Added toJSON method to Connection class _(issue <https://togithub.com/elastic/elasticsearch-js/issues/848|#​848>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/849|#​849> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.0.0|`v7.0.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v6.8.7...v7.0.0|Compare Source> • Stable release. facebook/jest *<https://togithub.com/facebook/jest/blob/master/CHANGELOG.md#%E2%80%8B2601|`v26.0.1`>* <https://togithub.com/facebook/jest/compare/v26.0.0...v26.0.1|Compare Source> *Fixes* • `[jest-circus]` Backward compatibility for deprecated `DescribeBlock.tests` to not break e.g. Detox reporter *<https://togithub.com/facebook/jest/blob/master/CHANGELOG.md#%E2%80%8B2600|`v26.0.0`>* <https://togithub.com/facebook/jest/compare/v25.5.1...v26.0.0|Compare Source> *Features* • `[jest-environment-jsdom]` [*BREAKING*] Upgrade `jsdom` to v16 (<https://togithub.com/facebook/jest/pull/9606|#​9606>) • `[@jest/fake-timers]` Add possibility to use a modern implementation of fake timers, backed by `@sinonjs/fake-timers` (<https://togithub.com/facebook/jest/pull/7776|#​7776>) • `[jest-runtime]` Add `createMockFromModule` as an alias for `genMockFromModule` (<https://togithub.com/facebook/jest/pull/9962|#​9962>) *Fixes* • `[babel-jest]` Handle `null` being passed to `createTransformer` (<https://togithub.com/facebook/jest/pull/9955|#​9955>) • `[jest-circus, jest-console, jest-jasmine2, jest-reporters, jest-util, pretty-format]` Fix time durating formatting and consolidate time formatting code (<https://togithub.com/facebook/jest/pull/9765|#​9765>) • `[jest-circus]` [*BREAKING*] Fail tests if a test takes a done callback and have return values (<https://togithub.com/facebook/jest/pull/9129|#​9129>) • `[jest-circus]` [*BREAKING*] Throw a proper error if a test / hook is defined asynchronously (<https://togithub.com/facebook/jest/pull/8096|#​8096>) • `[jest-circus]` Throw more descriptive error if hook is defined inside test (<https://togithub.com/facebook/jest/pull/9957|#​9957>) • `[jest-circus]` [*BREAKING*] Align execution order of tests to match `jasmine`'s top to bottom order (<https://togithub.com/facebook/jest/pull/9965|#​9965>) • `[jest-config, jest-resolve]` [*BREAKING*] Rem…

github 09:59:03

Comment on #173 Update all dependencies

<https://coveralls.io/builds/31149862|Coverage Status> Coverage remained the same at 86.578% when pulling *<https://github.com/cofacts/rumors-api/commit/0e5bceddae3f11ff621f96737844962c031db52d|0e5bced> on renovate/all* into *<https://github.com/cofacts/rumors-api/commit/1ef3790da93aec2ee26426d5561766ff1708ae13|1ef3790> on master*.

github 10:59:18

#2 Update all dependencies

This PR contains the following updates: * * * *Release Notes* testing-library/jest-dom *<https://togithub.com/testing-library/jest-dom/releases/v5.9.0|`v5.9.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.8.0...v5.9.0|Compare Source> *Features* • Deprecate toBeEmpty in favour of toBeEmptyDomElement (<https://togithub.com/testing-library/jest-dom/issues/216|#​216>) (<https://togithub.com/testing-library/jest-dom/issues/254|#​254>) (<https://togithub.com/testing-library/jest-dom/commit/927c5a4f898369524ab6e96d67f2e1004f1714d5|927c5a4>) *<https://togithub.com/testing-library/jest-dom/releases/v5.8.0|`v5.8.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.7.0...v5.8.0|Compare Source> *Features* • add toBePartiallyChecked matcher (<https://togithub.com/testing-library/jest-dom/issues/249|#​249>) (<https://togithub.com/testing-library/jest-dom/commit/e46299b8fe4d57b6fbfc5ae8e312eacc8419ee34|e46299b>) *<https://togithub.com/testing-library/jest-dom/releases/v5.7.0|`v5.7.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.6.0...v5.7.0|Compare Source> *Features* • Allow to use regex on toHaveDisplayValue (<https://togithub.com/testing-library/jest-dom/issues/242|#​242>) (<https://togithub.com/testing-library/jest-dom/commit/5c9e8e5a1a18e58c0bf8147baaf568259c3c2a13|5c9e8e5>) *<https://togithub.com/testing-library/jest-dom/releases/v5.6.0|`v5.6.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.5.0...v5.6.0|Compare Source> *Features* • Add new custom matcher toHaveDescription (<https://togithub.com/testing-library/jest-dom/issues/244|#​244>) (<https://togithub.com/testing-library/jest-dom/commit/943a0c9783de6acc83a397b5dab22570f2611c3c|943a0c9>) *<https://togithub.com/testing-library/jest-dom/releases/v5.5.0|`v5.5.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.4.0...v5.5.0|Compare Source> *Features* • Add `toHaveDisplayValue()` matcher (<https://togithub.com/testing-library/jest-dom/issues/223|#​223>) (<https://togithub.com/testing-library/jest-dom/commit/840414f73864226852199b5f0c9cb591d7cfc140|840414f>) *<https://togithub.com/testing-library/jest-dom/releases/v5.4.0|`v5.4.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.3.0...v5.4.0|Compare Source> *Features* • add switch role to toBeChecked (<https://togithub.com/testing-library/jest-dom/issues/228|#​228>) (<https://togithub.com/testing-library/jest-dom/commit/144c647fcf5586312ae7e1a16ff4654713097209|144c647>) *<https://togithub.com/testing-library/jest-dom/releases/v5.3.0|`v5.3.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.2.0...v5.3.0|Compare Source> *Features* • add exact mode option for toHaveClass (<https://togithub.com/testing-library/jest-dom/issues/176|#​176>) (<https://togithub.com/testing-library/jest-dom/issues/217|#​217>) (<https://togithub.com/testing-library/jest-dom/commit/cc8721e10637137ec15e731db2aa8af4b13bf21e|cc8721e>) *<https://togithub.com/testing-library/jest-dom/releases/v5.2.0|`v5.2.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.1.1...v5.2.0|Compare Source> *Features* • *toHaveValue:* Enhanced error message with type information… (<https://togithub.com/testing-library/jest-dom/issues/219|#​219>) (<https://togithub.com/testing-library/jest-dom/commit/eb51c17438a6fbdaa027bc35cdd07a031a167338|eb51c17>) *<https://togithub.com/testing-library/jest-dom/releases/v5.1.1|`v5.1.1`>* <https://togithub.com/testing-library/jest-dom/compare/v5.1.0...v5.1.1|Compare Source> *Bug Fixes* • root matchers module (closes <https://togithub.com/testing-library/jest-dom/issues/197|#​197>) (<https://togithub.com/testing-library/jest-dom/issues/200|#​200>) (<https://togithub.com/testing-library/jest-dom/commit/3b98d4d16b51b7b8d9d9ca77172b5367503f203f|3b98d4d>) *<https://togithub.com/testing-library/jest-dom/releases/v5.1.0|`v5.1.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.0.2...v5.1.0|Compare Source> *Features* • Enhance toHaveStyle to accept JS as css (<https://togithub.com/testing-library/jest-dom/issues/196|#​196>) (<https://togithub.com/testing-library/jest-dom/commit/7921e4a0a9e21e419122951eb28ed270c13209c5|7921e4a>) *<https://togithub.com/testing-library/jest-dom/releases/v5.0.2|`v5.0.2`>* <https://togithub.com/testing-library/jest-dom/compare/v5.0.1...v5.0.2|Compare Source> *Bug Fixes* • toBeVisible ignoring Details element (<https://togithub.com/testing-library/jest-dom/issues/184|#​184>) (<https://togithub.com/testing-library/jest-dom/commit/e4d61c2ef16018197c316135f57f905bf5b2ca2a|e4d61c2>) *<https://togithub.com/testing-library/jest-dom/releases/v5.0.1|`v5.0.1`>* <https://togithub.com/testing-library/jest-dom/compare/v5.0.0...v5.0.1|Compare Source> *Bug Fixes* • Add <https://togithub.com/types/testing-library|@​types/testing-library>__jest-dom dependency (<https://togithub.com/testing-library/jest-dom/issues/189|#​189>) (<https://togithub.com/testing-library/jest-dom/commit/030da6207a2e4862035b7b9d9f915328c5ff4e2f|030da62>), closes <https://togithub.com/testing-library/jest-dom/issues/123|#​123> <https://togithub.com/testing-library/jest-dom/issues/160|#​160> <https://togithub.com/testing-library/jest-dom/issues/185|#​185> *<https://togithub.com/testing-library/jest-dom/releases/v5.0.0|`v5.0.0`>* <https://togithub.com/testing-library/jest-dom/compare/v4.2.4...v5.0.0|Compare Source> • Remove extend-expect typings (<https://togithub.com/testing-library/jest-dom/issues/182|#​182>) (<https://togithub.com/testing-library/jest-dom/commit/c76f8c548b3d99b8639aea05f76c111997c5bce5|c76f8c5>), closes <https://togithub.com/testing-library/jest-dom/issues/182|#​182> *BREAKING CHANGES* • moving typings to <https://togithub.com/types/testing-library|@​types/testing-library>__jest-dom • This version does not includes types. The next patch release v5.0.1 will. If you need the type definitions please do not update to v.5.0.0. testing-library/react-testing-library *<https://togithub.com/testing-library/react-testing-library/releases/v10.0.4|`v10.0.4`>* <https://togithub.com/testing-library/react-testing-library/compare/v10.0.3...v10.0.4|Compare Source> *Bug Fixes* • upgrade all dependencies (and fix UMD build) (<https://togithub.com/testing-library/react-testing-library/issues/653|#​653>) (<https://togithub.com/testing-library/react-testing-library/commit/a75fa350399857cd889ee0b878b08a79c2101206|a75fa35>) *<https://togithub.com/testing-library/react-testing-library/releases/v10.0.3|`v10.0.3`>* <https://togithub.com/testing-library/react-testing-library/compare/v10.0.2...v10.0.3|Compare Source> *Bug Fixes* • restore this when requiring timers (<https://togithub.com/testing-library/react-testing-library/issues/644|#​644>) (<https://togithub.com/testing-library/react-testing-library/commit/59a2de1e689be718f0931656b518509d43f5ac29|59a2de1>), closes <https://togithub.com/testing-library/react-testing-library/issues/614|#​614> *<https://togithub.com/testing-library/react-testing-library/releases/v10.0.2|`v10.0.2`>* <https://togithub.com/testing-library/react-testing-library/compare/v10.0.1...v10.0.2|Compare Source> *Bug Fixes* • Bump types dependency (<https://togithub.com/testing-library/react-testing-library/issues/625|#​625>) (<https://togithub.com/testing-library/react-testing-library/commit/afce94fec01d18f654d919e8e091a814afd63da1|afce94f>) *<https://togithub.com/testing-library/react-testing-library/releases/v10.0.1|`v10.0.1`>* <https://togithub.com/testing-library/react-testing-library/compare/v10.0.0...v10.0.1|Compare Source> *Bug Fixes* • support Node &gt;=10 (<https://togithub.com/testing-library/react-testing-library/issues/611|#​611>) (<https://togithub.com/testing-library/react-testing-library/commit/3bc13d94c05df06ae4cff5bf98ac1fd0cddb4783|3bc13d9>) *<https://togithub.com/testing-library/react-testing-library/releases/v10.0.0|`v10.0.0`>* <https://togithub.com/testing-library/react-testing-library/compare/v9…

mrorz 14:39:17
@lucien 目前搜尋頁面的 spec 還是寫「同 可疑訊息 頁」 https://g0v.hackmd.io/@NFi0czulSemxCM8RNSlz8Q/HJ8xT3QVU/%2FoWSar1t0SzWo150Dsbepxw

但是不按照「相關度」排序的搜尋頁面,根本無法使用囧

g0v.hackmd.io

[Spec] 可疑轉傳訊息 - HackMD

我來改改
mrorz 14:39:49
現在我跟比鄰要找 cofacts 的訊息,都是用 google 的 `site: cofacts.g0v.tw` 來找的囧
1
github 14:48:46

Review on #256 Feature/search page

Thanks for the PR! I think the PR's size is pretty easy to read :) Sorry that the review is postponed a bit because we are traveling to Tainan. I have made some comments so that the website can function more like the mockup suggests. Regarding the sort order in <https://g0v.hackmd.io/@NFi0czulSemxCM8RNSlz8Q/HJ8xT3QVU/%2FoWSar1t0SzWo150Dsbepxw|design spec>, I find that the sort order defined in spec &amp; mockup ("同 可疑訊息 頁") is very difficult to use, as the search result is barely relevant. Discussion here: <https://g0v-tw.slack.com/archives/C2PPMRQGP/p1590993557102800|https://g0v-tw.slack.com/archives/C2PPMRQGP/p1590993557102800> I am a bit concerned about `ReplySearchPageLayout` -- it looks pretty close to ArticlePageLayout and do shares a lot of common items. I can understand that the duplication is to mitigate the difference of its underlying data model (`ListArticle` query v.s. `ListReply` query). I think some of their items (such as `FilterGroup`) should be extracted to common components, and the difference in its data model / logic lives within each page. But this is too much for this PR, so I think we can leave it as-is.

github 14:48:46

Comment on #256 Feature/search page

We can set the component of this box to `form` so that • Instead of putting handler on submit button, we put `onSubmit` handler on the form • Browsers (especially soft keyboard of mobile browsers) _may_ adapt its input to smooth out the interaction of form submission • We don't need to implement `onChange` in the textarea; just put a `name` to the textarea, and we can get the value of textarea using `event.target.&lt;textarea name&gt;.value`. • As long as we implement form's `onSubmit`, we can just put `type="submit"` to the current `searchIcon` button and remove its `onClick` handler.

github 14:48:46

Comment on #256 Feature/search page

Please align `.view` to the center of `openModalButton` vertically <https://user-images.githubusercontent.com/108608/83379101-4ce7a100-a40d-11ea-9c8f-b6d9acc63280.png|image>

github 14:48:46

Comment on #256 Feature/search page

Please set the `defaultValue` to the currently searched item so that the textarea can be filled with the text in search box, as shown in mockup <https://user-images.githubusercontent.com/108608/83380244-0d6e8400-a410-11ea-9f6e-9106d4f943e4.png|image>

github 14:48:46

Comment on #256 Feature/search page

Since this button is supposed to show "other" messages, we should not repeat the article (first original article) shown outside of the dialog. Please filter out the article that is already shown above. <https://user-images.githubusercontent.com/108608/83380873-b36ebe00-a411-11ea-9aa1-080d0e5846f0.png|螢幕快照 2020-06-01 下午2 09 28>

github 14:48:47

Comment on #256 Feature/search page

This button should show only when `articleReplies.length` &gt; 1. If there is only one `articleReply`, it means that the reply is only used in one aritcle, and there is no "other messages" to show. The second item in the mockup shows the variant of `ReplySearchItem` with `articleReply.length` === 1. <https://user-images.githubusercontent.com/108608/83380674-0eec7c00-a411-11ea-83c2-5a3f9cf16966.png|image>

github 14:54:00

Comment on #256 Feature/search page

I forgot to mention that the search result page currently have a mysterious horizontal scroll. Please find what caused this scroll and eliminate it. <https://user-images.githubusercontent.com/108608/83383438-b4a2e980-a417-11ea-8577-f8666b353b87.gif|search-page-horizontal>

👌 1
github 16:52:14

Comment on #258 Enable react hook lint rules

<https://github.com/yanglin5689446|@yanglin5689446> This is causing lint error because of the use of `setAndUpdateValue`, which is updated every `render`. The logic in this hook is a bit complicated and its side effect (invoking `setAndUpdateValue`) is costly. Would you take a look at this and determine an appropriate dependency list here?

👌 1

2020-06-02

github 10:53:36

Comment on #258 Enable react hook lint rules

I think it's safe to include only `range` as dependency, because this effect should only run when props passed from parent update, only when this happen the effect should be run and bound to new closure, though I'm not pretty sure if it works as I expected :sweat_smile:

github 10:56:48

Comment on #258 Enable react hook lint rules

with `customValue` included in deps list, the state in component will always override the props passed from parent so the props update from parent never applied(correct me if I'm wrong)

2020-06-03

yanglin 12:29:15
@lucien @mrorz 不好意思這個我可能問得不夠清楚 XD
下面這些回應有辦法連到 Reply Detail 頁面嗎?
也就是獨立顯示 Reply 的頁面
或著 Reply Detail 的頁面現在要怎麼樣進入呢?
https://www.figma.com/file/zpD45j8nqDB2XfA6m2QskO?node-id=889:306#25793084

Figma

Cofacts website

Created with Figma

但那應該是有引用才會有原始回應的連結?
Hmm 你說得對
好像還是得請 @lucien 說明這種狀況怎麼點進 reply detail
另外,我在 figma 上也針對 reply detail 的細節提問囉
好喔,reply detail 目前是 search 進去的
這邊要整理 spec
github 17:48:27

Comment on #256 Feature/search page

&gt; I forgot to mention that the search result page currently have a mysterious horizontal scroll. Please find what caused this scroll and eliminate it. &gt; &gt; <https://user-images.githubusercontent.com/108608/83383438-b4a2e980-a417-11ea-8577-f8666b353b87.gif|search-page-horizontal> I can't reproduce this issue, can you provide more information about the platform or testcase?

github 19:00:33

#174 use parameter getter for createArticleCategory Mutation to avoid re-compilation

try to solve dynamic script compilation problem by using the same script in this mutation related discussion: <https://user-images.githubusercontent.com/4010549/83629327-77cc2380-a5cc-11ea-9724-2aeaccf42733.png|image> <https://user-images.githubusercontent.com/4010549/83629337-7d296e00-a5cc-11ea-98ce-04b0d7f0e9d3.png|image> reference: <https://stackoverflow.com/questions/60234600/too-many-dynamic-script-compilations-within-max-75-5m|https://stackoverflow.com/questions/60234600/too-many-dynamic-script-compilations-within-max-75-5m>

github 19:03:06

Comment on #174 use parameter getter for createArticleCategory Mutation to avoid re-compilation

<https://coveralls.io/builds/31209071|Coverage Status> Coverage remained the same at 86.578% when pulling *<https://github.com/cofacts/rumors-api/commit/7a66dcc805e8189e4ad4396a9dec533e3491bc54|7a66dcc> on create-categories-params* into *<https://github.com/cofacts/rumors-api/commit/1ef3790da93aec2ee26426d5561766ff1708ae13|1ef3790> on master*.

github 21:53:17

Comment on #162 Setup database on staging &amp; production

Done in <https://github.com/cofacts/rumors-line-bot/pull/182|#182> and is deployed

github 21:53:48

Comment on #145 Update article source wordings

Finished in <https://github.com/cofacts/rumors-line-bot/issues/121|#121>

2020-06-04

github 02:25:29

#193 line auth

因為 line-auth branch 太舊,就直接跟 dev compare 了 已知問題:IDToken 會過期(<https://developers.line.biz/en/reference/liff/#get-decoded-id-token|liff.getDecodedIDToken>),要在過期之前讓 user 重新登入 Setup : 1.set liff endpoint url for login callback 2.set channel token in .env file.

mglee 09:32:12
hello 關在家數個月後,我終於把論文中關於 Cofacts 的一章寫完了!熱騰騰的第一版草稿,請大家來查核
裡面提到不少次 @mrorz 如果有錯誤詮釋的地方請不要客氣提出!
https://beta.hackfoldr.org/mglee-dissertation/https%253A%252F%252Fdocs.google.com%252Fdocument%252Fd%252F1-_NCo6Su0jlbwHm9E6JjAoSACgCP3Jx47tAhap02DVQ%252Fedit%2523heading%253Dh.awfhjng7wwip
6
github 15:29:30

#175 Allow multiple origins for one appId

Currently, rumors-api is designed to lock browser apps to a certain origin. This PR allows multiple origins can be allowed for one browser app. • Currently we apply this to the only browser app, `RUMORS_SITE`, thus we handle `process.env.RUMORS_SITE_CORS_ORIGIN` exclusively. This is subject to change in future PRs when we introduce multiple apps, but the basic logic should be similar. • The CORS origin setting is also used in login redirects, restricting browser to only redirect back to allowed origins. We made the following changes to the login redirect mechanism to support multiple domains: 1. Support multiple `process.env.RUMORS_SITE_CORS_ORIGIN` 2. Store which origin the user is from when login process is initiated. When redirecting back, first check if the origin is valid, then redirect the user back to that specific origin. This PR makes the following setup possible: • `<http://en.cofacts.org|en.cofacts.org>`, `<http://zh.cofacts.org|zh.cofacts.org>`, `<http://www.cofacts.org|www.cofacts.org>` all connects to `<http://api.cofacts.org|api.cofacts.org>` without problem -- just set the above origins in `RUMORS_SITE_CORS_ORIGIN` • When logging in from `<http://zh.cofacts.org|zh.cofacts.org>`, the user will be redirect back to `<http://zh.cofacts.org|zh.cofacts.org>`, rather than other domains.

github 15:32:11

Comment on #175 Allow multiple origins for one appId

<https://coveralls.io/builds/31231067|Coverage Status> Coverage decreased (-0.2%) to 86.424% when pulling *<https://github.com/cofacts/rumors-api/commit/0d149775568ffbfb446a53f484b0144ed9d12a5b|0d14977> on allow-multiple-origin* into *<https://github.com/cofacts/rumors-api/commit/beddaeda9d353120149e208617967126b6b5e1ec|beddaed> on master*.

stbb1025 15:54:00
https://www.dropbox.com/sh/c95mhl97vq4kynj/AABtS1sl2P41AMtyGUl9shMra?dl=0
favicons 在這~ @lucien @yanglin5689446 @mrorz

Dropbox

cofacts favicon

Shared with Dropbox

👍 2
github 17:44:09

Comment on #256 Feature/search page

&gt; &gt; I forgot to mention that the search result page currently have a mysterious horizontal scroll. Please find what caused this scroll and eliminate it. &gt; &gt; <https://user-images.githubusercontent.com/108608/83383438-b4a2e980-a417-11ea-8577-f8666b353b87.gif|search-page-horizontal> &gt; &gt; I can't reproduce this issue, can you provide more information about the platform or testcase? It's visible if the user has "always show scroll" turned on. <https://user-images.githubusercontent.com/108608/83740620-aeb43f00-a689-11ea-8b45-89b40ba9d67a.png|image> On environments that always has scroll bars (such as Google Chrome 83 under Windows 10), the horizontal bar also exists: <https://user-images.githubusercontent.com/108608/83740930-1a96a780-a68a-11ea-98d8-9788f489a2e7.png|image> I have located the root cause -- it's due to `width: 100vw` and `min-width: 100vw` set on jumbotron. On environments that scroll bars do take space, • `100vw` measures the viewport size with scroll bar included. • Whenever there is something that goes under the right / bottom scrollbars, scrollbars on the bottom / right are generated. Replacing width setups with `right: 0` fixes the issue. <https://user-images.githubusercontent.com/108608/83741183-76f9c700-a68a-11ea-838d-d2450fd48140.png|image>

既然都找到原因了,我就順手修掉 push 囉
小小的 css 而已~
github 17:54:04

Review on #256 Feature/search page

This batch of improvements to search page is ready now, let's merge this first :muscle:

❤️ 1
github 18:11:22

Review on #259 Fix flexbox width

Confirmed that it works on • <https://cofacts.g0v.tw/article/33y6c0kmucpjq|https://cofacts.g0v.tw/article/33y6c0kmucpjq> (`.main` content too wide) • <https://cofacts.hacktabl.org/article/x1265bzf4voa|https://cofacts.hacktabl.org/article/x1265bzf4voa> (`.aside` content too wide) • <https://cofacts.g0v.tw/article/2unpagfl6e9hn|https://cofacts.g0v.tw/article/2unpagfl6e9hn> (`.main` and `.aside` both too wide!) LGTM. Thanks for the accurate fix!

🎉 1
github 19:41:42

Comment on #258 Enable react hook lint rules

Got it. In the latest change, I did not put `customValue` in the dep list. However, the use of `setAndUpdateValue` still leaves opportunity that this `useEffect` function can invoke old `onChange` prop from some very old closure. According to react doc, it is <https://reactjs.org/docs/hooks-faq.html#is-it-safe-to-omit-functions-from-the-list-of-dependencies|not safe to omit functions from the list of dependencies>. I have re-written all logic in `useEffect` using functional updates of states, as suggested in <https://reactjs.org/docs/hooks-faq.html#what-can-i-do-if-my-effect-dependencies-change-too-often|React documentation>. Hopefully it works all the same.

mrorz 19:59:13
我想說明一下這個 commit 針對 `TimeRange` 的變更:
https://github.com/cofacts/rumors-site/pull/258/commits/7e8111e4ccafd844ee2a102816cf671df0f560ec

1. 現在 production 上其實有個 bug:點 https://cofacts.g0v.tw/articles?start=now-1d%2Fd 進去,TimeRange 會顯示為「時間不限」,但應該要顯示為「一天內」。這是 `TimeRange` 裡面還在用 `GT` 但外面給 `GTE` 的關係。由於 `GTE` 比較符合使用者觀感(選「6/4 開始」應該要包含 6/4 當天),所以我把 `TimeRange` 裡所有 `GT` 改為 `GTE`。這也與 `TimeRange` 的 state 有關係,因此也更新了 `selected` state 的初始值。
2. 隨著 `range` 變化,確實需要根據 `range` 來更新 `selected` 與 `customValue` 。但是,原本的邏輯有點太複雜,而且需要從 function scope 外面取用 state 值。我這裡按照文件建議,將 `useEffect` 內的邏輯改成兩個 functional update,兩個 state 分開處理自己的更新,應該會比原本的好懂。
不過這其實改到滿多邏輯的,所以再請 @yanglin5689446 過目了。
👌 1

2020-06-05

github 00:04:13

#260 Storybook for TimeRange

Adds storybook &amp; storyshot for `&lt;TimeRange&gt;` component. <https://user-images.githubusercontent.com/108608/83779838-05883b80-a6bf-11ea-90d5-ebc1f7d76241.png|image> <https://user-images.githubusercontent.com/108608/83780071-454f2300-a6bf-11ea-8514-72162db2b211.gif|timerange-story> • Enzyme is required because `react-test-renderer` storyshot built-in cannot handle `Material-UI`'s portal (used in Material UI Modal that comprised of Material UI dropdown lists). Ref: <https://github.com/storybookjs/storybook/tree/master/addons/storyshots/storyshots-core#renderer|https://github.com/storybookjs/storybook/tree/master/addons/storyshots/storyshots-core#renderer> • Adds `@storybook/addon-knobs` to demonstrate how `&lt;TimeRange /&gt;` reacts to `range` prop change • Removes brittle snapshot made by Material-UI internals by implementing enzyme-to-json `map` function • Splits snapshot files into one snapshot per story file (but currently there is only 1 story so far...) using `multiSnapshotWithOptions` and <https://github.com/storybookjs/storybook/tree/master/addons/storyshots/storyshots-core#multisnapshotwithoptionsoptions|corresponding setup>

github 00:14:28

Comment on #193 line auth

*Pull Request Test Coverage Report for <https://coveralls.io/builds/31242002|Build 843>* • *12* of *25* *(48.0%)* changed or added relevant lines in *2* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage decreased (*-4.1%*) to *94.291%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*

github 02:08:15

Comment on #193 line auth

`getContext` is used by GraphQL APIs that does not require authentication as well, such as `Query.insights`. APIs that requires authentication are guarded by `@auth` directive, which detects empty context and throws `AuthenticationError`. `getContext`, on the other hand, should support anonymous requests (i.e. no `authorization` header at all in requests)

mrorz 11:29:03
On staging now:
• 新 API 對 CORS 有比較嚴格的限制(僅允許 whitelist 的 domain 進行 CORS)
• 新 API 在登入時會把使用者導回到原本的網域。因此 localhost:3000 登入後,會回到 localhost:3000 而不是會被導向到 cofacts.hacktabl.org
• Site 更新到目前的版本,修正文章頁面過長破版的問題
• 網頁上方搜尋框 (`<GlobalSearch>` )好像不能打字,似乎不小心弄壞了囧
mrorz 11:40:54
新網站的流量圖好像永遠是無流量
article id 似乎沒有給進去唷
螢幕快照 2020-06-05 上午11.36.06.png
github 11:51:19

Comment on #166 Implement Google analytics stats field in Article

Alternative: we can deploy a super-proxy in Google app engine instead. <https://github.com/googleanalytics/google-analytics-super-proxy#readme|https://github.com/googleanalytics/google-analytics-super-proxy#readme> *Pros* • It has cache that helps keep usage <https://developers.google.com/analytics/devguides/reporting/core/v4/limits-quotas|below quota> • Allows rumors-site to fetch data directly, don't put burden on API server *Cons* • May be less flexible than directly calling API (?) • GAE may incur additional cost (needs testing) • Super proxy is no longer maintained, may need to fork to get <https://github.com/googleanalytics/google-analytics-super-proxy/pull/29|timezone / CORS> right

2020-06-06

github 11:45:10

Comment on #193 line auth

If we allow anonymous user and reject unsupported authentication method or just return `EMPTY_CONTEXT` here?

github 12:19:06

Comment on #193 line auth

I think we should return `EMPTY_CONTEXT` here. `getContext` is invoked by all GraphQL calls, providing `context` in resolvers. For GraphQL APIs that don't need authentication, `getContext` is also called. We should only throw exception within `auth` directive (`directives/auth.js`), because that directive is the one that is responsible for guarding authenticated endpoints. `getContext` should be only responsible for providing GraphQL contexts, as its name suggests.

github 18:25:28

#16 Export articles.hyperlinks and replies.hyperlinks as open data

• Adds `article_hyperlinks.csv` and `reply_hyperkinks.csv` • Removes `hyperlinks[]` in `articles.csv`, which was always `[Object object]`

2020-06-07

AmigoCool 01:15:57
@alex8881012 has joined the channel
yanglin 01:46:16
在做 category UI 時發現一個神奇的小狀況
我新增了某個標籤之後我的 `ownVote` 是 `UPVOTE`
但 positiveFeedbackCount 卻仍然是 0

另外在 `AddCategoryToArticle` 時
不知道可不可以直接讓新增該 category 的 user 的 ownVote 變成 `UPVOTE` ?
因為現在 user 新增完 category 會新增一個 category 但不知道是誰新增的
沒辦法跟 AI 判斷的作曲別
截圖 2020-06-07 上午1.41.09(2).png
Hmm 目前使用者在 article 與 category 的關係,跟 article 與 reply 的關係是一樣的

因為送一個 articleReply 不會 upvote 自己(後來發現其實 API 沒擋,我們是在 UI 這裏擋住說不能 upvote 自己的 articleReply),所以原本 API 實作是新增 articleCategory 之後也不會 upvote 自己。

不過 @lucien 原本對 category 的 mind model 是加減分的概念,不分「是否有 create」的狀況;Lucien 的設計是,只要是正分,該文就有這個 category。不過目前 API 確實是用「是否有 articleCategory 存在」來做的。

最後,關於分類是 AI 還是人加的,`articleCategory` 應該有 expose `aiModel` 與 `aiConfidience`,如果是人加的也有 `user` 欄位可以使用,技術上做得到,只是設計上是否要呈現這樣。
這邊有當初架構設計歷史問題,我認為用加減分比較直觀,但暫時改不了。
分類要不要展示,我其實想做個實驗,在不展示是誰標記的狀況,到底 ai 標註跟人為標註的贊同跟反對狀況是什麼
也有可能有羊群效應,ai 或是人先標了,就固定住了
mrorz 11:54:21
Hmm 目前使用者在 article 與 category 的關係,跟 article 與 reply 的關係是一樣的

因為送一個 articleReply 不會 upvote 自己(後來發現其實 API 沒擋,我們是在 UI 這裏擋住說不能 upvote 自己的 articleReply),所以原本 API 實作是新增 articleCategory 之後也不會 upvote 自己。

不過 @lucien 原本對 category 的 mind model 是加減分的概念,不分「是否有 create」的狀況;Lucien 的設計是,只要是正分,該文就有這個 category。不過目前 API 確實是用「是否有 articleCategory 存在」來做的。

最後,關於分類是 AI 還是人加的,`articleCategory` 應該有 expose `aiModel` 與 `aiConfidience`,如果是人加的也有 `user` 欄位可以使用,技術上做得到,只是設計上是否要呈現這樣。
stbb1025 20:12:27
https://docs.google.com/presentation/d/18VnEBMr9m-t81ppRwHcjbA1keltg-CIn7wUF9pu1oLo/edit#slide=id.p

@yanglin5689446 這裡列出一些要微調的部份,請過目~謝謝!

@mrorz @lucien 有我遺漏的地方也麻煩補充唷,感恩
補充一下,我是用firefox瀏覽的
搜尋的部分在 staging 有更新版
不過右上角搜尋功能本身點按沒有反應囧
@stbb1025 如果設計想要微調,我可以在 figma 上調你設計嗎?還是你建議我複製一份
幫我備份一份好了~
感恩
github 22:14:08

Review on #15 Fix Typo

Great, thanks a lot!

2020-06-08

github 13:28:52

Comment on #193 line auth

I think we can go for verb + lower cased charactors, like `assertInClient`. Additional descriptions can also be added: ``` /** * Prevent users from proceeding with external browsers. * Useful when the following process involves functions only available within LINE client, * such as invoking `liff.sendMessage()`. */ ```

github 13:28:52

Review on #193 line auth

Thanks for providing LINE login functionality! I have made some suggestion on the naming and comments. LGTM!

github 18:07:23

#261 Improve article category UI

New design for article page category system, [mockup].(<https://www.figma.com/file/zpD45j8nqDB2XfA6m2QskO/Cofacts-website?node-id=912%3A303|https://www.figma.com/file/zpD45j8nqDB2XfA6m2QskO/Cofacts-website?node-id=912%3A303>) some behaviors are still weird, just pop this version out to collect more feedbacks.

2020-06-09

github 00:10:44

#70 Replace youtube API with meta tags parser

• Removes Youtube API client (`googleapis`) completely • Uses <https://github.com/jacktuck/unfurl|unfurl> to fetch result whenever possible • Invokes headless-browser based `scrap()` only when data from metadata is incomplete • Make `ScrapResult` a class for better documentation and readablilty

github 01:54:30

Comment on #70 Replace youtube API with meta tags parser

*Pull Request Test Coverage Report for <https://coveralls.io/builds/31317128|Build 155>* • *29* of *36* *(80.56%)* changed or added relevant lines in *4* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage decreased (*-17.2%*) to *82.813%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*

yanglin 10:57:57
意外發現搜尋很長很長的字串會破版
大家有什麼想法嗎?
截圖 2020-06-09 上午10.57.22.png
input 本身因為會隨著輸入游標捲來捲去所以沒關係
下面的 dropdown option 可以 ellipsis,露出右邊的「在 回報訊息 」/「在 查核回應」

畢竟是使用者自己寫的,他可以不用看全文
話說我在桌機上 staging ˙ GlobalSearch 不會動
https://dev.cofacts.org/articles
我剛剛找到問題了
是 eslint 那支改到的
我跟上面 UI 微調一起修
原來如此
感謝感謝
其實我越來越覺得 hooks 並不是很好寫,反而會讓人很想 ignore exhausive deps

但偏偏在 dep array 不是 `[]` (只會觸發一次) 的狀況下 ignore exhausive deps,很容易會抓到到某不知名 closure 裡的舊版資料,但目前並沒有能 visualize function closure 的工具⋯⋯
真的
我之前 react 小聚才想分享踩雷心得 QQ
最後變成只有特定的 pattern 才能比較安全,開發者需要把這些文件好好讀進去才能安全寫 code ._.
https://reactjs.org/docs/hooks-faq.html#is-it-safe-to-omit-functions-from-the-list-of-dependencies
導致要寫好 hook 不只個別開發者的 cognitive load 有點高,開發者之間也會需要更多時間溝通 ._.
(文件需要這麼多篇幅,也是一種溝通)
yanglin 11:55:17
要拿掉 google translate 嗎?
截圖 2020-06-09 上午11.54.46.png
Nick 的意思應該是拿掉半透明底
白色底是我們用 CSS 加的

至於下面那排技術提供,我不確定拿掉是否符合 terms of use (雖然有點找不到) XD
其實現在有 footer 的話,好像塞進 footer 不要讓他浮浮好像也是一個選項? @stbb1025
可以塞進footer!
不過印象中手機版沒 footer ?
手機版側欄有空間ㄇ
手機側欄可以!
ping 一下
請問要改到側欄 & footer 的話要怎麼改~
稍後更新!
@yanglin5689446 已更新囉,希望把其他多餘資訊遮掉,然後在中文版介面的翻譯選單顯示英文,在英文版介面的翻譯選單顯示中文「請選取語言」
ok 晚點看
3Q
ya
由 google 提供的字樣好像滿難移掉的
而且如 @mrorz 說的可能會違反 term of use
所以我就保留著了喔
結果
https://www.w3schools.com/HOWTO/howto_google_translate.asp

其實 `google.translate.TranslateElement` 可以指定 layout
其中一個 layout 好像就不會有 `powered by Google Translate`⋯⋯ lol
這裡有服務開放時的捷圖
看起來 `google.translate.TranslateElement` constructor 有很多選項
https://support.pinnaclecart.com/support/solutions/articles/44000320675-how-to-add-google-translate-to-your-store
yanglin