cofacts

#42 Update all dependencies

This PR contains the following updates: * * * *Release Notes* elastic/elasticsearch-js *<https://togithub.com/elastic/elasticsearch-js/releases/v7.7.1|`v7.7.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.7.0...v7.7.1|Compare Source> <https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/current/changelog-client.html|Changelog> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.7.0|`v7.7.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.6.1...v7.7.0|Compare Source> Support for Elasticsearch `v7.7` <https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/7.x/changelog-client.html|Changelog> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.6.1|`v7.6.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.6.0...v7.6.1|Compare Source> *Fixes:* • Secure json parsing - <https://togithub.com/elastic/elasticsearch-js/issues/1110|#​1110> • ApiKey should take precedence over basic auth - <https://togithub.com/elastic/elasticsearch-js/issues/1115|#​1115> *Documentation:* • Fix typo in api reference - <https://togithub.com/elastic/elasticsearch-js/issues/1109|#​1109> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.6.0|`v7.6.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.5.1...v7.6.0|Compare Source> Support for Elasticsearch `v7.6`. *<https://togithub.com/elastic/elasticsearch-js/releases/v7.5.1|`v7.5.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.5.0...v7.5.1|Compare Source> *Fixes:* • Skip compression in case of empty string body - <https://togithub.com/elastic/elasticsearch-js/issues/1080|#​1080> • Fix typo in NoLivingConnectionsError - <https://togithub.com/elastic/elasticsearch-js/issues/1045|#​1045> • Change TransportRequestOptions.ignore to number[] - <https://togithub.com/elastic/elasticsearch-js/issues/1053|#​1053> • ClientOptions["cloud"] should have optional auth fields - <https://togithub.com/elastic/elasticsearch-js/issues/1032|#​1032> *Documentation:* • Docs: Return super in example Transport subclass - <https://togithub.com/elastic/elasticsearch-js/issues/980|#​980> • Add examples to reference - <https://togithub.com/elastic/elasticsearch-js/issues/1076|#​1076> • Added new examples - <https://togithub.com/elastic/elasticsearch-js/issues/1031|#​1031> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.5.0|`v7.5.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.4.0...v7.5.0|Compare Source> Support for Elasticsearch `v7.5`. *Features* • X-Opaque-Id support <https://togithub.com/elastic/elasticsearch-js/issues/997|#​997> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.4.0|`v7.4.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.3.0...v7.4.0|Compare Source> Support for Elasticsearch `v7.4`. *Fixes:* • Fix issue; node roles are defaulting to true when undefined is breaking usage of nodeFilter option - <https://togithub.com/elastic/elasticsearch-js/issues/967|#​967> *Documentation:* • Updated API reference doc - <https://togithub.com/elastic/elasticsearch-js/issues/945|#​945> <https://togithub.com/elastic/elasticsearch-js/issues/969|#​969> • Fix inaccurate description sniffEndpoint - <https://togithub.com/elastic/elasticsearch-js/issues/959|#​959> *Internals:* • Update code generation <https://togithub.com/elastic/elasticsearch-js/issues/969|#​969> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.3.0|`v7.3.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.2.0...v7.3.0|Compare Source> Support for Elasticsearch `v7.3`. *Features:* • Added `auth` option - <https://togithub.com/elastic/elasticsearch-js/issues/908|#​908> • Added support for `ApiKey` authentication - <https://togithub.com/elastic/elasticsearch-js/issues/908|#​908> *Fixes:* • fix(Typings): sniffInterval can also be boolean - <https://togithub.com/elastic/elasticsearch-js/issues/914|#​914> *Internals:* • Refactored connection pool - <https://togithub.com/elastic/elasticsearch-js/issues/913|#​913> *Documentation:* • Better reference code examples - <https://togithub.com/elastic/elasticsearch-js/issues/920|#​920> • Improve README - <https://togithub.com/elastic/elasticsearch-js/issues/909|#​909> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.2.0|`v7.2.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.1.0...v7.2.0|Compare Source> Support for Elasticsearch `v7.2` *Fixes:* • Remove auth data from inspect and toJSON in connection class - <https://togithub.com/elastic/elasticsearch-js/issues/887|#​887> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.1.0|`v7.1.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.0.1...v7.1.0|Compare Source> Support for Elasticsearch `v7.1` *Fixes:* • Support for non-friendly chars in url username and password - <https://togithub.com/elastic/elasticsearch-js/issues/858|#​858> • Patch deprecated parameters - <https://togithub.com/elastic/elasticsearch-js/issues/851|#​851> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.0.1|`v7.0.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.0.0...v7.0.1|Compare Source> *Fixes:* • Fix TypeScript export _(issue <https://togithub.com/elastic/elasticsearch-js/issues/841|#​841>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/842|#​842> • Fix http and https port handling _(issue <https://togithub.com/elastic/elasticsearch-js/issues/843|#​843>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/845|#​845> • Fix TypeScript definiton _(issue <https://togithub.com/elastic/elasticsearch-js/issues/803|#​803>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/846|#​846> • Added toJSON method to Connection class _(issue <https://togithub.com/elastic/elasticsearch-js/issues/848|#​848>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/849|#​849> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.0.0|`v7.0.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v6.8.7...v7.0.0|Compare Source> • Stable release. eslint/eslint *<https://togithub.com/eslint/eslint/releases/v7.1.0|`v7.1.0`>* <https://togithub.com/eslint/eslint/compare/v7.0.0...v7.1.0|Compare Source> • <https://togithub.com/eslint/eslint/commit/a93083af89c6f9714dcdd4a7f27c8655a0b0dba6|`a93083a`> Fix: astUtils.getNextLocation returns invalid location after CRLF (<https://togithub.com/eslint/eslint/issues/13275|#​13275>) (Milos Djermanovic) • <https://togithub.com/eslint/eslint/commit/df01af184d93b3d64b37cee786cad59bd0d7aacb|`df01af1`> Update: padded-blocks loc position changes (refs <https://togithub.com/eslint/eslint/issues/12334|#​12334>) (<https://togithub.com/eslint/eslint/issues/13328|#​13328>) (Anix) • <https://togithub.com/eslint/eslint/commit/bd3f092efa579944f75bfbc277b35f85e6d966ed|`bd3f092`> Fix: max-lines-per-function flagging arrow IIFEs (fixes <https://togithub.com/eslint/eslint/issues/13332|#​13332>) (<https://togithub.com/eslint/eslint/issues/13336|#​13336>) (cherryblossom000) • <https://togithub.com/eslint/eslint/commit/25462b23eac4ed1ded97eeae6187b5d8baa58e78|`25462b2`> Update: block-spacing changed loc for extra (refs <https://togithub.com/eslint/eslint/issues/12334|#​12334>) (<https://togithub.com/eslint/eslint/issues/13314|#​13314>) (Anix) • <https://togithub.com/eslint/eslint/commit/de0aab95005f172db72196fc3fd18e91ee9a5880|`de0aab9`> Fix: report end loc in one-var-declaration-per-line (refs <https://togithub.com/eslint/eslint/issues/12334|#​12334>) (<https://togithub.com/eslint/eslint/issues/13326|#​13326>) (YeonJuan) • <https://togithub.com/eslint/eslint/commit/1710296082083602a904b080908657bb431fb56c|`1710296`> Fix: no-new-symbol false positive with Symbol as an argument (<https://togithub.com/eslint/eslint/issues/13337|#​13337>) (Milos Djermanovic) • <https://togithub.com/eslint/eslint/commit/cc014514c29626e556acb0a528e3478b3725e284|`cc01451`> Fix: arrow-parens no reporting for comments inside (…

#173 Update all dependencies

This PR contains the following updates: * * * *Release Notes* elastic/elasticsearch-js *<https://togithub.com/elastic/elasticsearch-js/releases/v7.7.1|`v7.7.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.7.0...v7.7.1|Compare Source> <https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/current/changelog-client.html|Changelog> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.7.0|`v7.7.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.6.1...v7.7.0|Compare Source> Support for Elasticsearch `v7.7` <https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/7.x/changelog-client.html|Changelog> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.6.1|`v7.6.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.6.0...v7.6.1|Compare Source> *Fixes:* • Secure json parsing - <https://togithub.com/elastic/elasticsearch-js/issues/1110|#​1110> • ApiKey should take precedence over basic auth - <https://togithub.com/elastic/elasticsearch-js/issues/1115|#​1115> *Documentation:* • Fix typo in api reference - <https://togithub.com/elastic/elasticsearch-js/issues/1109|#​1109> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.6.0|`v7.6.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.5.1...v7.6.0|Compare Source> Support for Elasticsearch `v7.6`. *<https://togithub.com/elastic/elasticsearch-js/releases/v7.5.1|`v7.5.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.5.0...v7.5.1|Compare Source> *Fixes:* • Skip compression in case of empty string body - <https://togithub.com/elastic/elasticsearch-js/issues/1080|#​1080> • Fix typo in NoLivingConnectionsError - <https://togithub.com/elastic/elasticsearch-js/issues/1045|#​1045> • Change TransportRequestOptions.ignore to number[] - <https://togithub.com/elastic/elasticsearch-js/issues/1053|#​1053> • ClientOptions["cloud"] should have optional auth fields - <https://togithub.com/elastic/elasticsearch-js/issues/1032|#​1032> *Documentation:* • Docs: Return super in example Transport subclass - <https://togithub.com/elastic/elasticsearch-js/issues/980|#​980> • Add examples to reference - <https://togithub.com/elastic/elasticsearch-js/issues/1076|#​1076> • Added new examples - <https://togithub.com/elastic/elasticsearch-js/issues/1031|#​1031> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.5.0|`v7.5.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.4.0...v7.5.0|Compare Source> Support for Elasticsearch `v7.5`. *Features* • X-Opaque-Id support <https://togithub.com/elastic/elasticsearch-js/issues/997|#​997> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.4.0|`v7.4.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.3.0...v7.4.0|Compare Source> Support for Elasticsearch `v7.4`. *Fixes:* • Fix issue; node roles are defaulting to true when undefined is breaking usage of nodeFilter option - <https://togithub.com/elastic/elasticsearch-js/issues/967|#​967> *Documentation:* • Updated API reference doc - <https://togithub.com/elastic/elasticsearch-js/issues/945|#​945> <https://togithub.com/elastic/elasticsearch-js/issues/969|#​969> • Fix inaccurate description sniffEndpoint - <https://togithub.com/elastic/elasticsearch-js/issues/959|#​959> *Internals:* • Update code generation <https://togithub.com/elastic/elasticsearch-js/issues/969|#​969> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.3.0|`v7.3.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.2.0...v7.3.0|Compare Source> Support for Elasticsearch `v7.3`. *Features:* • Added `auth` option - <https://togithub.com/elastic/elasticsearch-js/issues/908|#​908> • Added support for `ApiKey` authentication - <https://togithub.com/elastic/elasticsearch-js/issues/908|#​908> *Fixes:* • fix(Typings): sniffInterval can also be boolean - <https://togithub.com/elastic/elasticsearch-js/issues/914|#​914> *Internals:* • Refactored connection pool - <https://togithub.com/elastic/elasticsearch-js/issues/913|#​913> *Documentation:* • Better reference code examples - <https://togithub.com/elastic/elasticsearch-js/issues/920|#​920> • Improve README - <https://togithub.com/elastic/elasticsearch-js/issues/909|#​909> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.2.0|`v7.2.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.1.0...v7.2.0|Compare Source> Support for Elasticsearch `v7.2` *Fixes:* • Remove auth data from inspect and toJSON in connection class - <https://togithub.com/elastic/elasticsearch-js/issues/887|#​887> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.1.0|`v7.1.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.0.1...v7.1.0|Compare Source> Support for Elasticsearch `v7.1` *Fixes:* • Support for non-friendly chars in url username and password - <https://togithub.com/elastic/elasticsearch-js/issues/858|#​858> • Patch deprecated parameters - <https://togithub.com/elastic/elasticsearch-js/issues/851|#​851> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.0.1|`v7.0.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.0.0...v7.0.1|Compare Source> *Fixes:* • Fix TypeScript export _(issue <https://togithub.com/elastic/elasticsearch-js/issues/841|#​841>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/842|#​842> • Fix http and https port handling _(issue <https://togithub.com/elastic/elasticsearch-js/issues/843|#​843>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/845|#​845> • Fix TypeScript definiton _(issue <https://togithub.com/elastic/elasticsearch-js/issues/803|#​803>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/846|#​846> • Added toJSON method to Connection class _(issue <https://togithub.com/elastic/elasticsearch-js/issues/848|#​848>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/849|#​849> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.0.0|`v7.0.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v6.8.7...v7.0.0|Compare Source> • Stable release. facebook/jest *<https://togithub.com/facebook/jest/blob/master/CHANGELOG.md#%E2%80%8B2601|`v26.0.1`>* <https://togithub.com/facebook/jest/compare/v26.0.0...v26.0.1|Compare Source> *Fixes* • `[jest-circus]` Backward compatibility for deprecated `DescribeBlock.tests` to not break e.g. Detox reporter *<https://togithub.com/facebook/jest/blob/master/CHANGELOG.md#%E2%80%8B2600|`v26.0.0`>* <https://togithub.com/facebook/jest/compare/v25.5.1...v26.0.0|Compare Source> *Features* • `[jest-environment-jsdom]` [*BREAKING*] Upgrade `jsdom` to v16 (<https://togithub.com/facebook/jest/pull/9606|#​9606>) • `[@jest/fake-timers]` Add possibility to use a modern implementation of fake timers, backed by `@sinonjs/fake-timers` (<https://togithub.com/facebook/jest/pull/7776|#​7776>) • `[jest-runtime]` Add `createMockFromModule` as an alias for `genMockFromModule` (<https://togithub.com/facebook/jest/pull/9962|#​9962>) *Fixes* • `[babel-jest]` Handle `null` being passed to `createTransformer` (<https://togithub.com/facebook/jest/pull/9955|#​9955>) • `[jest-circus, jest-console, jest-jasmine2, jest-reporters, jest-util, pretty-format]` Fix time durating formatting and consolidate time formatting code (<https://togithub.com/facebook/jest/pull/9765|#​9765>) • `[jest-circus]` [*BREAKING*] Fail tests if a test takes a done callback and have return values (<https://togithub.com/facebook/jest/pull/9129|#​9129>) • `[jest-circus]` [*BREAKING*] Throw a proper error if a test / hook is defined asynchronously (<https://togithub.com/facebook/jest/pull/8096|#​8096>) • `[jest-circus]` Throw more descriptive error if hook is defined inside test (<https://togithub.com/facebook/jest/pull/9957|#​9957>) • `[jest-circus]` [*BREAKING*] Align execution order of tests to match `jasmine`'s top to bottom order (<https://togithub.com/facebook/jest/pull/9965|#​9965>) • `[jest-config, jest-resolve]` [*BREAKING*] Rem…

Comment on #173 Update all dependencies

<https://coveralls.io/builds/31149862|Coverage Status> Coverage remained the same at 86.578% when pulling *<https://github.com/cofacts/rumors-api/commit/0e5bceddae3f11ff621f96737844962c031db52d|0e5bced> on renovate/all* into *<https://github.com/cofacts/rumors-api/commit/1ef3790da93aec2ee26426d5561766ff1708ae13|1ef3790> on master*.

#2 Update all dependencies

This PR contains the following updates: * * * *Release Notes* testing-library/jest-dom *<https://togithub.com/testing-library/jest-dom/releases/v5.9.0|`v5.9.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.8.0...v5.9.0|Compare Source> *Features* • Deprecate toBeEmpty in favour of toBeEmptyDomElement (<https://togithub.com/testing-library/jest-dom/issues/216|#​216>) (<https://togithub.com/testing-library/jest-dom/issues/254|#​254>) (<https://togithub.com/testing-library/jest-dom/commit/927c5a4f898369524ab6e96d67f2e1004f1714d5|927c5a4>) *<https://togithub.com/testing-library/jest-dom/releases/v5.8.0|`v5.8.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.7.0...v5.8.0|Compare Source> *Features* • add toBePartiallyChecked matcher (<https://togithub.com/testing-library/jest-dom/issues/249|#​249>) (<https://togithub.com/testing-library/jest-dom/commit/e46299b8fe4d57b6fbfc5ae8e312eacc8419ee34|e46299b>) *<https://togithub.com/testing-library/jest-dom/releases/v5.7.0|`v5.7.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.6.0...v5.7.0|Compare Source> *Features* • Allow to use regex on toHaveDisplayValue (<https://togithub.com/testing-library/jest-dom/issues/242|#​242>) (<https://togithub.com/testing-library/jest-dom/commit/5c9e8e5a1a18e58c0bf8147baaf568259c3c2a13|5c9e8e5>) *<https://togithub.com/testing-library/jest-dom/releases/v5.6.0|`v5.6.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.5.0...v5.6.0|Compare Source> *Features* • Add new custom matcher toHaveDescription (<https://togithub.com/testing-library/jest-dom/issues/244|#​244>) (<https://togithub.com/testing-library/jest-dom/commit/943a0c9783de6acc83a397b5dab22570f2611c3c|943a0c9>) *<https://togithub.com/testing-library/jest-dom/releases/v5.5.0|`v5.5.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.4.0...v5.5.0|Compare Source> *Features* • Add `toHaveDisplayValue()` matcher (<https://togithub.com/testing-library/jest-dom/issues/223|#​223>) (<https://togithub.com/testing-library/jest-dom/commit/840414f73864226852199b5f0c9cb591d7cfc140|840414f>) *<https://togithub.com/testing-library/jest-dom/releases/v5.4.0|`v5.4.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.3.0...v5.4.0|Compare Source> *Features* • add switch role to toBeChecked (<https://togithub.com/testing-library/jest-dom/issues/228|#​228>) (<https://togithub.com/testing-library/jest-dom/commit/144c647fcf5586312ae7e1a16ff4654713097209|144c647>) *<https://togithub.com/testing-library/jest-dom/releases/v5.3.0|`v5.3.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.2.0...v5.3.0|Compare Source> *Features* • add exact mode option for toHaveClass (<https://togithub.com/testing-library/jest-dom/issues/176|#​176>) (<https://togithub.com/testing-library/jest-dom/issues/217|#​217>) (<https://togithub.com/testing-library/jest-dom/commit/cc8721e10637137ec15e731db2aa8af4b13bf21e|cc8721e>) *<https://togithub.com/testing-library/jest-dom/releases/v5.2.0|`v5.2.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.1.1...v5.2.0|Compare Source> *Features* • *toHaveValue:* Enhanced error message with type information… (<https://togithub.com/testing-library/jest-dom/issues/219|#​219>) (<https://togithub.com/testing-library/jest-dom/commit/eb51c17438a6fbdaa027bc35cdd07a031a167338|eb51c17>) *<https://togithub.com/testing-library/jest-dom/releases/v5.1.1|`v5.1.1`>* <https://togithub.com/testing-library/jest-dom/compare/v5.1.0...v5.1.1|Compare Source> *Bug Fixes* • root matchers module (closes <https://togithub.com/testing-library/jest-dom/issues/197|#​197>) (<https://togithub.com/testing-library/jest-dom/issues/200|#​200>) (<https://togithub.com/testing-library/jest-dom/commit/3b98d4d16b51b7b8d9d9ca77172b5367503f203f|3b98d4d>) *<https://togithub.com/testing-library/jest-dom/releases/v5.1.0|`v5.1.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.0.2...v5.1.0|Compare Source> *Features* • Enhance toHaveStyle to accept JS as css (<https://togithub.com/testing-library/jest-dom/issues/196|#​196>) (<https://togithub.com/testing-library/jest-dom/commit/7921e4a0a9e21e419122951eb28ed270c13209c5|7921e4a>) *<https://togithub.com/testing-library/jest-dom/releases/v5.0.2|`v5.0.2`>* <https://togithub.com/testing-library/jest-dom/compare/v5.0.1...v5.0.2|Compare Source> *Bug Fixes* • toBeVisible ignoring Details element (<https://togithub.com/testing-library/jest-dom/issues/184|#​184>) (<https://togithub.com/testing-library/jest-dom/commit/e4d61c2ef16018197c316135f57f905bf5b2ca2a|e4d61c2>) *<https://togithub.com/testing-library/jest-dom/releases/v5.0.1|`v5.0.1`>* <https://togithub.com/testing-library/jest-dom/compare/v5.0.0...v5.0.1|Compare Source> *Bug Fixes* • Add <https://togithub.com/types/testing-library|@​types/testing-library>__jest-dom dependency (<https://togithub.com/testing-library/jest-dom/issues/189|#​189>) (<https://togithub.com/testing-library/jest-dom/commit/030da6207a2e4862035b7b9d9f915328c5ff4e2f|030da62>), closes <https://togithub.com/testing-library/jest-dom/issues/123|#​123> <https://togithub.com/testing-library/jest-dom/issues/160|#​160> <https://togithub.com/testing-library/jest-dom/issues/185|#​185> *<https://togithub.com/testing-library/jest-dom/releases/v5.0.0|`v5.0.0`>* <https://togithub.com/testing-library/jest-dom/compare/v4.2.4...v5.0.0|Compare Source> • Remove extend-expect typings (<https://togithub.com/testing-library/jest-dom/issues/182|#​182>) (<https://togithub.com/testing-library/jest-dom/commit/c76f8c548b3d99b8639aea05f76c111997c5bce5|c76f8c5>), closes <https://togithub.com/testing-library/jest-dom/issues/182|#​182> *BREAKING CHANGES* • moving typings to <https://togithub.com/types/testing-library|@​types/testing-library>__jest-dom • This version does not includes types. The next patch release v5.0.1 will. If you need the type definitions please do not update to v.5.0.0. testing-library/react-testing-library *<https://togithub.com/testing-library/react-testing-library/releases/v10.0.4|`v10.0.4`>* <https://togithub.com/testing-library/react-testing-library/compare/v10.0.3...v10.0.4|Compare Source> *Bug Fixes* • upgrade all dependencies (and fix UMD build) (<https://togithub.com/testing-library/react-testing-library/issues/653|#​653>) (<https://togithub.com/testing-library/react-testing-library/commit/a75fa350399857cd889ee0b878b08a79c2101206|a75fa35>) *<https://togithub.com/testing-library/react-testing-library/releases/v10.0.3|`v10.0.3`>* <https://togithub.com/testing-library/react-testing-library/compare/v10.0.2...v10.0.3|Compare Source> *Bug Fixes* • restore this when requiring timers (<https://togithub.com/testing-library/react-testing-library/issues/644|#​644>) (<https://togithub.com/testing-library/react-testing-library/commit/59a2de1e689be718f0931656b518509d43f5ac29|59a2de1>), closes <https://togithub.com/testing-library/react-testing-library/issues/614|#​614> *<https://togithub.com/testing-library/react-testing-library/releases/v10.0.2|`v10.0.2`>* <https://togithub.com/testing-library/react-testing-library/compare/v10.0.1...v10.0.2|Compare Source> *Bug Fixes* • Bump types dependency (<https://togithub.com/testing-library/react-testing-library/issues/625|#​625>) (<https://togithub.com/testing-library/react-testing-library/commit/afce94fec01d18f654d919e8e091a814afd63da1|afce94f>) *<https://togithub.com/testing-library/react-testing-library/releases/v10.0.1|`v10.0.1`>* <https://togithub.com/testing-library/react-testing-library/compare/v10.0.0...v10.0.1|Compare Source> *Bug Fixes* • support Node &gt;=10 (<https://togithub.com/testing-library/react-testing-library/issues/611|#​611>) (<https://togithub.com/testing-library/react-testing-library/commit/3bc13d94c05df06ae4cff5bf98ac1fd0cddb4783|3bc13d9>) *<https://togithub.com/testing-library/react-testing-library/releases/v10.0.0|`v10.0.0`>* <https://togithub.com/testing-library/react-testing-library/compare/v9…

g0v.hackmd.io

[Spec] 可疑轉傳訊息 - HackMD

Review on #256 Feature/search page

Thanks for the PR! I think the PR's size is pretty easy to read :) Sorry that the review is postponed a bit because we are traveling to Tainan. I have made some comments so that the website can function more like the mockup suggests. Regarding the sort order in <https://g0v.hackmd.io/@NFi0czulSemxCM8RNSlz8Q/HJ8xT3QVU/%2FoWSar1t0SzWo150Dsbepxw|design spec>, I find that the sort order defined in spec &amp; mockup ("同 可疑訊息 頁") is very difficult to use, as the search result is barely relevant. Discussion here: <https://g0v-tw.slack.com/archives/C2PPMRQGP/p1590993557102800|https://g0v-tw.slack.com/archives/C2PPMRQGP/p1590993557102800> I am a bit concerned about `ReplySearchPageLayout` -- it looks pretty close to ArticlePageLayout and do shares a lot of common items. I can understand that the duplication is to mitigate the difference of its underlying data model (`ListArticle` query v.s. `ListReply` query). I think some of their items (such as `FilterGroup`) should be extracted to common components, and the difference in its data model / logic lives within each page. But this is too much for this PR, so I think we can leave it as-is.

Comment on #256 Feature/search page

We can set the component of this box to `form` so that • Instead of putting handler on submit button, we put `onSubmit` handler on the form • Browsers (especially soft keyboard of mobile browsers) _may_ adapt its input to smooth out the interaction of form submission • We don't need to implement `onChange` in the textarea; just put a `name` to the textarea, and we can get the value of textarea using `event.target.&lt;textarea name&gt;.value`. • As long as we implement form's `onSubmit`, we can just put `type="submit"` to the current `searchIcon` button and remove its `onClick` handler.

Comment on #256 Feature/search page

Please align `.view` to the center of `openModalButton` vertically <https://user-images.githubusercontent.com/108608/83379101-4ce7a100-a40d-11ea-9c8f-b6d9acc63280.png|image>

Comment on #256 Feature/search page

Please set the `defaultValue` to the currently searched item so that the textarea can be filled with the text in search box, as shown in mockup <https://user-images.githubusercontent.com/108608/83380244-0d6e8400-a410-11ea-9f6e-9106d4f943e4.png|image>

Comment on #256 Feature/search page

Since this button is supposed to show "other" messages, we should not repeat the article (first original article) shown outside of the dialog. Please filter out the article that is already shown above. <https://user-images.githubusercontent.com/108608/83380873-b36ebe00-a411-11ea-9aa1-080d0e5846f0.png|螢幕快照 2020-06-01 下午2 09 28>

Comment on #256 Feature/search page

This button should show only when `articleReplies.length` &gt; 1. If there is only one `articleReply`, it means that the reply is only used in one aritcle, and there is no "other messages" to show. The second item in the mockup shows the variant of `ReplySearchItem` with `articleReply.length` === 1. <https://user-images.githubusercontent.com/108608/83380674-0eec7c00-a411-11ea-83c2-5a3f9cf16966.png|image>

Comment on #256 Feature/search page

I forgot to mention that the search result page currently have a mysterious horizontal scroll. Please find what caused this scroll and eliminate it. <https://user-images.githubusercontent.com/108608/83383438-b4a2e980-a417-11ea-8577-f8666b353b87.gif|search-page-horizontal>

Comment on #258 Enable react hook lint rules

<https://github.com/yanglin5689446|@yanglin5689446> This is causing lint error because of the use of `setAndUpdateValue`, which is updated every `render`. The logic in this hook is a bit complicated and its side effect (invoking `setAndUpdateValue`) is costly. Would you take a look at this and determine an appropriate dependency list here?

Comment on #258 Enable react hook lint rules

I think it's safe to include only `range` as dependency, because this effect should only run when props passed from parent update, only when this happen the effect should be run and bound to new closure, though I'm not pretty sure if it works as I expected :sweat_smile:

Review on #258 Enable react hook lint rules

Comment on #258 Enable react hook lint rules

with `customValue` included in deps list, the state in component will always override the props passed from parent so the props update from parent never applied(correct me if I'm wrong)

g0v.hackmd.io

20200603 會議紀錄 - HackMD

Figma

Cofacts website

Created with Figma

Comment on #256 Feature/search page

&gt; I forgot to mention that the search result page currently have a mysterious horizontal scroll. Please find what caused this scroll and eliminate it. &gt; &gt; <https://user-images.githubusercontent.com/108608/83383438-b4a2e980-a417-11ea-8577-f8666b353b87.gif|search-page-horizontal> I can't reproduce this issue, can you provide more information about the platform or testcase?

#174 use parameter getter for createArticleCategory Mutation to avoid re-compilation

try to solve dynamic script compilation problem by using the same script in this mutation related discussion: <https://user-images.githubusercontent.com/4010549/83629327-77cc2380-a5cc-11ea-9724-2aeaccf42733.png|image> <https://user-images.githubusercontent.com/4010549/83629337-7d296e00-a5cc-11ea-98ce-04b0d7f0e9d3.png|image> reference: <https://stackoverflow.com/questions/60234600/too-many-dynamic-script-compilations-within-max-75-5m|https://stackoverflow.com/questions/60234600/too-many-dynamic-script-compilations-within-max-75-5m>

Comment on #174 use parameter getter for createArticleCategory Mutation to avoid re-compilation

<https://coveralls.io/builds/31209071|Coverage Status> Coverage remained the same at 86.578% when pulling *<https://github.com/cofacts/rumors-api/commit/7a66dcc805e8189e4ad4396a9dec533e3491bc54|7a66dcc> on create-categories-params* into *<https://github.com/cofacts/rumors-api/commit/1ef3790da93aec2ee26426d5561766ff1708ae13|1ef3790> on master*.

Review on #174 use parameter getter for createArticleCategory Mutation to avoid re-compilation

#162 Setup database on staging &amp; production

Comment on #162 Setup database on staging &amp; production

Done in <https://github.com/cofacts/rumors-line-bot/pull/182|#182> and is deployed

#145 Update article source wordings

Comment on #145 Update article source wordings

Finished in <https://github.com/cofacts/rumors-line-bot/issues/121|#121>

#213 Category labeling mechanism UI

g0v.hackmd.io

[Spec] 搜尋結果 - HackMD

Review on #171 Multiple ArticleReplyFeedback filters should narrow down selection

LGTM!

#171 Multiple ArticleReplyFeedback filters should narrow down selection

#174 use parameter getter for createArticleCategory Mutation to avoid re-compilation

#193 line auth

因為 line-auth branch 太舊，就直接跟 dev compare 了 已知問題：IDToken 會過期(<https://developers.line.biz/en/reference/liff/#get-decoded-id-token|liff.getDecodedIDToken>)，要在過期之前讓 user 重新登入 Setup : 1.set liff endpoint url for login callback 2.set channel token in .env file.

#175 Allow multiple origins for one appId

Currently, rumors-api is designed to lock browser apps to a certain origin. This PR allows multiple origins can be allowed for one browser app. • Currently we apply this to the only browser app, `RUMORS_SITE`, thus we handle `process.env.RUMORS_SITE_CORS_ORIGIN` exclusively. This is subject to change in future PRs when we introduce multiple apps, but the basic logic should be similar. • The CORS origin setting is also used in login redirects, restricting browser to only redirect back to allowed origins. We made the following changes to the login redirect mechanism to support multiple domains: 1. Support multiple `process.env.RUMORS_SITE_CORS_ORIGIN` 2. Store which origin the user is from when login process is initiated. When redirecting back, first check if the origin is valid, then redirect the user back to that specific origin. This PR makes the following setup possible: • `<http://en.cofacts.org|en.cofacts.org>`, `<http://zh.cofacts.org|zh.cofacts.org>`, `<http://www.cofacts.org|www.cofacts.org>` all connects to `<http://api.cofacts.org|api.cofacts.org>` without problem -- just set the above origins in `RUMORS_SITE_CORS_ORIGIN` • When logging in from `<http://zh.cofacts.org|zh.cofacts.org>`, the user will be redirect back to `<http://zh.cofacts.org|zh.cofacts.org>`, rather than other domains.

Comment on #175 Allow multiple origins for one appId

<https://coveralls.io/builds/31231067|Coverage Status> Coverage decreased (-0.2%) to 86.424% when pulling *<https://github.com/cofacts/rumors-api/commit/0d149775568ffbfb446a53f484b0144ed9d12a5b|0d14977> on allow-multiple-origin* into *<https://github.com/cofacts/rumors-api/commit/beddaeda9d353120149e208617967126b6b5e1ec|beddaed> on master*.

Dropbox

cofacts favicon

Shared with Dropbox

#259 Fix flexbox width

Comment on #256 Feature/search page

&gt; &gt; I forgot to mention that the search result page currently have a mysterious horizontal scroll. Please find what caused this scroll and eliminate it. &gt; &gt; <https://user-images.githubusercontent.com/108608/83383438-b4a2e980-a417-11ea-8577-f8666b353b87.gif|search-page-horizontal> &gt; &gt; I can't reproduce this issue, can you provide more information about the platform or testcase? It's visible if the user has "always show scroll" turned on. <https://user-images.githubusercontent.com/108608/83740620-aeb43f00-a689-11ea-8b45-89b40ba9d67a.png|image> On environments that always has scroll bars (such as Google Chrome 83 under Windows 10), the horizontal bar also exists: <https://user-images.githubusercontent.com/108608/83740930-1a96a780-a68a-11ea-98d8-9788f489a2e7.png|image> I have located the root cause -- it's due to `width: 100vw` and `min-width: 100vw` set on jumbotron. On environments that scroll bars do take space, • `100vw` measures the viewport size with scroll bar included. • Whenever there is something that goes under the right / bottom scrollbars, scrollbars on the bottom / right are generated. Replacing width setups with `right: 0` fixes the issue. <https://user-images.githubusercontent.com/108608/83741183-76f9c700-a68a-11ea-838d-d2450fd48140.png|image>

Review on #256 Feature/search page

This batch of improvements to search page is ready now, let's merge this first :muscle:

#256 Feature/search page

Review on #259 Fix flexbox width

Confirmed that it works on • <https://cofacts.g0v.tw/article/33y6c0kmucpjq|https://cofacts.g0v.tw/article/33y6c0kmucpjq> (`.main` content too wide) • <https://cofacts.hacktabl.org/article/x1265bzf4voa|https://cofacts.hacktabl.org/article/x1265bzf4voa> (`.aside` content too wide) • <https://cofacts.g0v.tw/article/2unpagfl6e9hn|https://cofacts.g0v.tw/article/2unpagfl6e9hn> (`.main` and `.aside` both too wide!) LGTM. Thanks for the accurate fix!

#259 Fix flexbox width

Comment on #258 Enable react hook lint rules

Got it. In the latest change, I did not put `customValue` in the dep list. However, the use of `setAndUpdateValue` still leaves opportunity that this `useEffect` function can invoke old `onChange` prop from some very old closure. According to react doc, it is <https://reactjs.org/docs/hooks-faq.html#is-it-safe-to-omit-functions-from-the-list-of-dependencies|not safe to omit functions from the list of dependencies>. I have re-written all logic in `useEffect` using functional updates of states, as suggested in <https://reactjs.org/docs/hooks-faq.html#what-can-i-do-if-my-effect-dependencies-change-too-often|React documentation>. Hopefully it works all the same.

#260 Storybook for TimeRange

Adds storybook &amp; storyshot for `&lt;TimeRange&gt;` component. <https://user-images.githubusercontent.com/108608/83779838-05883b80-a6bf-11ea-90d5-ebc1f7d76241.png|image> <https://user-images.githubusercontent.com/108608/83780071-454f2300-a6bf-11ea-8514-72162db2b211.gif|timerange-story> • Enzyme is required because `react-test-renderer` storyshot built-in cannot handle `Material-UI`'s portal (used in Material UI Modal that comprised of Material UI dropdown lists). Ref: <https://github.com/storybookjs/storybook/tree/master/addons/storyshots/storyshots-core#renderer|https://github.com/storybookjs/storybook/tree/master/addons/storyshots/storyshots-core#renderer> • Adds `@storybook/addon-knobs` to demonstrate how `&lt;TimeRange /&gt;` reacts to `range` prop change • Removes brittle snapshot made by Material-UI internals by implementing enzyme-to-json `map` function • Splits snapshot files into one snapshot per story file (but currently there is only 1 story so far...) using `multiSnapshotWithOptions` and <https://github.com/storybookjs/storybook/tree/master/addons/storyshots/storyshots-core#multisnapshotwithoptionsoptions|corresponding setup>

Comment on #193 line auth

*Pull Request Test Coverage Report for <https://coveralls.io/builds/31242002|Build 843>* • *12* of *25* *(48.0%)* changed or added relevant lines in *2* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage decreased (*-4.1%*) to *94.291%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*

Review on #258 Enable react hook lint rules

#258 Enable react hook lint rules

Comment on #193 line auth

`getContext` is used by GraphQL APIs that does not require authentication as well, such as `Query.insights`. APIs that requires authentication are guarded by `@auth` directive, which detects empty context and throws `AuthenticationError`. `getContext`, on the other hand, should support anonymous requests (i.e. no `authorization` header at all in requests)

Review on #175 Allow multiple origins for one appId

#175 Allow multiple origins for one appId

螢幕快照 2020-06-05 上午11.36.06.png

Comment on #166 Implement Google analytics stats field in Article

Alternative: we can deploy a super-proxy in Google app engine instead. <https://github.com/googleanalytics/google-analytics-super-proxy#readme|https://github.com/googleanalytics/google-analytics-super-proxy#readme> *Pros* • It has cache that helps keep usage <https://developers.google.com/analytics/devguides/reporting/core/v4/limits-quotas|below quota> • Allows rumors-site to fetch data directly, don't put burden on API server *Cons* • May be less flexible than directly calling API (?) • GAE may incur additional cost (needs testing) • Super proxy is no longer maintained, may need to fork to get <https://github.com/googleanalytics/google-analytics-super-proxy/pull/29|timezone / CORS> right

Comment on #193 line auth

If we allow anonymous user and reject unsupported authentication method or just return `EMPTY_CONTEXT` here?

Comment on #193 line auth

I think we should return `EMPTY_CONTEXT` here. `getContext` is invoked by all GraphQL calls, providing `context` in resolvers. For GraphQL APIs that don't need authentication, `getContext` is also called. We should only throw exception within `auth` directive (`directives/auth.js`), because that directive is the one that is responsible for guarding authenticated endpoints. `getContext` should be only responsible for providing GraphQL contexts, as its name suggests.

#16 Export articles.hyperlinks and replies.hyperlinks as open data

• Adds `article_hyperlinks.csv` and `reply_hyperkinks.csv` • Removes `hyperlinks[]` in `articles.csv`, which was always `[Object object]`

截圖 2020-06-07 上午1.41.09（2）.png

Review on #16 Export articles.hyperlinks and replies.hyperlinks as open data

Review on #15 Fix Typo

Great, thanks a lot!

#15 Fix Typo

#16 Export articles.hyperlinks and replies.hyperlinks as open data

Comment on #193 line auth

I think we can go for verb + lower cased charactors, like `assertInClient`. Additional descriptions can also be added: ``` /** * Prevent users from proceeding with external browsers. * Useful when the following process involves functions only available within LINE client, * such as invoking `liff.sendMessage()`. */ ```

Review on #193 line auth

Thanks for providing LINE login functionality! I have made some suggestion on the naming and comments. LGTM!

#261 Improve article category UI

New design for article page category system, [mockup].(<https://www.figma.com/file/zpD45j8nqDB2XfA6m2QskO/Cofacts-website?node-id=912%3A303|https://www.figma.com/file/zpD45j8nqDB2XfA6m2QskO/Cofacts-website?node-id=912%3A303>) some behaviors are still weird, just pop this version out to collect more feedbacks.

Review on #260 Storybook for TimeRange

#260 Storybook for TimeRange

#70 Replace youtube API with meta tags parser

• Removes Youtube API client (`googleapis`) completely • Uses <https://github.com/jacktuck/unfurl|unfurl> to fetch result whenever possible • Invokes headless-browser based `scrap()` only when data from metadata is incomplete • Make `ScrapResult` a class for better documentation and readablilty

Comment on #70 Replace youtube API with meta tags parser

*Pull Request Test Coverage Report for <https://coveralls.io/builds/31317128|Build 155>* • *29* of *36* *(80.56%)* changed or added relevant lines in *4* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage decreased (*-17.2%*) to *82.813%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*

截圖 2020-06-09 上午10.57.22.png

截圖 2020-06-09 上午11.54.46.png

截圖 2020-06-09 下午3.39.55.png

#70 Replace youtube API with meta tags parser

jacktuck/unfurl

Scraper for oEmbed, Twitter Cards and Open Graph metadata - fast and Promise-based :zap:

#172 Implement articleRepliesFrom filter for ListArticles

Fixes <https://github.com/cofacts/rumors-api/issues/165|#165> • Implements `articleRepliesFrom` in <https://github.com/cofacts/rumors-api/issues/165|#165> • Drops `appId` because `userId` should be sufficient according to <https://g0v.hackmd.io/ZcoUOX_-RQSkJyl5xz4_Zg#%E6%96%B9%E5%90%91-2-%E9%87%9D%E5%B0%8D%E6%AF%8F%E5%80%8B-backend-user-%E9%83%BD%E7%94%A2%E7%94%9F%E4%B8%80%E5%80%8B-user-document|`userId` / `appId` management proposal> • I cannot think of any useful use case filtering article-reply's `appId` yet • Removes the limitation that requires `userId` and `appId` must be specified together in `ListArticles` filter • Previously we use `userId`-`appId` pair to identify users. However in the future <https://g0v.hackmd.io/ZcoUOX_-RQSkJyl5xz4_Zg#%E6%96%B9%E5%90%91-2-%E9%87%9D%E5%B0%8D%E6%AF%8F%E5%80%8B-backend-user-%E9%83%BD%E7%94%A2%E7%94%9F%E4%B8%80%E5%80%8B-user-document|using only `userId` should be sufficient>, thus removing the restriction here. • Adds `userId` and `appId` to `ListReplies` filter, so that `ListArticles`, `ListReplies` filters work the same as `ListArticleReplyFeedbacks`'s. • Fixes `categoryIds` and `hasArticleReplyWithMorePositiveFeedback`, which unions its results when used with other filters and is incorrect • Similar to <https://github.com/cofacts/rumors-api/pull/171|#171>, please see <https://github.com/cofacts/rumors-api/pull/171|#171> for explanation.

#176 Sync proto file with url-resolver

Reflect changes in <https://github.com/cofacts/url-resolver/pull/70/files#diff-64ff70ff651c3a5a54fda110aa5fb88c|https://github.com/cofacts/url-resolver/pull/70/files#diff-64ff70ff651c3a5a54fda110aa5fb88c>

Comment on #176 [Trivial] Sync proto file with url-resolver

<https://coveralls.io/builds/31355740|Coverage Status> Coverage remained the same at 86.424% when pulling *<https://github.com/cofacts/rumors-api/commit/f774127e160217b50741207ec68c4d83229b9fb2|f774127> on sync-with-resolver* into *<https://github.com/cofacts/rumors-api/commit/11ea79df018a9a06fa8e90a314e98ecc90b28eef|11ea79d> on master*.

Review on #176 [Trivial] Sync proto file with url-resolver

Review on #70 Replace youtube API with meta tags parser

Looks okay to me

#69 Throughput issue

#70 Replace youtube API with meta tags parser

#176 [Trivial] Sync proto file with url-resolver

#1 Create 0610-privacy.md

Review on #1 Create 0610-privacy.md

#262 Fix RSS function

Currently whenever RSS is invoked by any RSS tracker, rumors-site would print the following to log: ``` site-en_1 | 2020-06-10 08:59 +00:00: Error while running `getDataFromTree` ApolloError: GraphQL error: Variable "$filter" got invalid value "1" at "filter.replyRequestCount.GTE"; Int cannot represent non-integer value: "1" site-en_1 | at new ApolloError (/srv/www/node_modules/apollo-client/bundle.umd.js:92:26) site-en_1 | at /srv/www/node_modules/apollo-client/bundle.umd.js:1587:34 site-en_1 | at /srv/www/node_modules/apollo-client/bundle.umd.js:2007:15 site-en_1 | at Set.forEach (&lt;anonymous&gt;) site-en_1 | at /srv/www/node_modules/apollo-client/bundle.umd.js:2005:26 site-en_1 | at Map.forEach (&lt;anonymous&gt;) site-en_1 | at QueryManager.broadcastQueries (/srv/www/node_modules/apollo-client/bundle.umd.js:2003:20) site-en_1 | at /srv/www/node_modules/apollo-client/bundle.umd.js:2130:19 site-en_1 | at Object.next (/srv/www/node_modules/zen-observable/lib/Observable.js:308:23) site-en_1 | at notifySubscription (/srv/www/node_modules/zen-observable/lib/Observable.js:130:18) { site-en_1 | graphQLErrors: [ site-en_1 | { site-en_1 | message: 'Variable "$filter" got invalid value "1" at "filter.replyRequestCount.GTE"; Int cannot represent non-integer value: "1"', site-en_1 | locations: [Array], site-en_1 | extensions: [Object], site-en_1 | authError: false site-en_1 | } site-en_1 | ], site-en_1 | networkError: null, site-en_1 | extraInfo: undefined site-en_1 | } site-en_1 | 2020-06-10 08:59 +00:00: [apollo-link-error] { site-en_1 | graphQLErrors: [ site-en_1 | { site-en_1 | message: 'Variable "$filter" got invalid value "1" at "filter.replyRequestCount.GTE"; Int cannot represent non-integer value: "1"', site-en_1 | locations: [Array], site-en_1 | extensions: [Object], site-en_1 | authError: false site-en_1 | } site-en_1 | ], site-en_1 | response: { errors: [ [Object] ] }, site-en_1 | operation: { site-en_1 | variables: { filter: [Object], orderBy: [Array] }, site-en_1 | extensions: {}, site-en_1 | operationName: 'ListArticles', site-en_1 | query: { kind: 'Document', definitions: [Array], loc: [Object] } site-en_1 | }, site-en_1 | forward: [Function] site-en_1 | } site-en_1 | 2020-06-10 08:59 +00:00: [apollo-link-error] { site-en_1 | graphQLErrors: [ site-en_1 | { site-en_1 | message: 'Variable "$filter" got invalid value "1" at "filter.replyRequestCount.GTE"; Int cannot represent non-integer value: "1"', site-en_1 | locations: [Array], site-en_1 | extensions: [Object], site-en_1 | authError: false site-en_1 | } site-en_1 | ], site-en_1 | response: { errors: [ [Object] ] }, site-en_1 | operation: { site-en_1 | variables: { filter: [Object], orderBy: [Array] }, site-en_1 | extensions: {}, site-en_1 | operationName: 'ListArticlesStat', site-en_1 | query: { kind: 'Document', definitions: [Array], loc: [Object] } site-en_1 | }, site-en_1 | forward: [Function] site-en_1 | } site-en_1 | 2020-06-10 09:02 +00:00: ApolloError: GraphQL error: Variable "$orderBy" got invalid value { undefined: "DESC" } at "orderBy[0]"; Field "undefined" is not defined by type "ListArticleOrderBy". site-en_1 | at new ApolloError (/srv/www/node_modules/apollo-client/bundle.umd.js:92:26) site-en_1 | at /srv/www/node_modules/apollo-client/bundle.umd.js:1587:34 site-en_1 | at /srv/www/node_modules/apollo-client/bundle.umd.js:2007:15 site-en_1 | at Set.forEach (&lt;anonymous&gt;) site-en_1 | at /srv/www/node_modules/apollo-client/bundle.umd.js:2005:26 site-en_1 | at Map.forEach (&lt;anonymous&gt;) site-en_1 | at QueryManager.broadcastQueries (/srv/www/node_modules/apollo-client/bundle.umd.js:2003:20) site-en_1 | at /srv/www/node_modules/apollo-client/bundle.umd.js:2130:19 site-en_1 | at Object.next (/srv/www/node_modules/zen-observable/lib/Observable.js:308:23) site-en_1 | at notifySubscription (/srv/www/node_modules/zen-observable/lib/Observable.js:130:18) { site-en_1 | graphQLErrors: [ site-en_1 | { site-en_1 | message: 'Variable "$orderBy" got invalid value { undefined: "DESC" } at "orderBy[0]"; Field "undefined" is not defined by type "ListArticleOrderBy".', site-en_1 | locations: [Array], site-en_1 | extensions: [Object], site-en_1 | authError: false site-en_1 | } site-en_1 | ], site-en_1 | networkError: null, site-en_1 | extraInfo: undefined site-en_1 | } ```

#1 Create 0610-privacy.md

Review on #193 line auth

#193 line auth

Comment on #261 Improve article category UI

`c` is the old query param. Using `categoryIds` should work.

Comment on #261 Improve article category UI

Since addition, deletion, upvote and downvote all happens within the option, I think it is more logical if we handle these logic together -- we should handle all these actions either within `&lt;CategoryOption&gt;`, or handling them all in `&lt;AddCategoryDialog&gt;` and put these callback prop on `&lt;CategoryOption&gt;`. As we pass `articleId` down to `CategoryOption` to handle its deletion, upvote and downvote, I think its good to move addition logic down to `CategoryOption` as well.

Review on #261 Improve article category UI

The initial look on category UI looks in a good shape! I have some suggestions on where to place the event callbacks. I have also added some comments on Figma to ask for clarification on the interactions. Since we have not received feedback from the designers, we can leave those for another PR in the future :)

#194 Enable URL token related check only in search session related pages

Previously, `App.svelte` performs URL token expire check and tries getting context from API. However, this check does not make sense in "user setting" page and "previous searched article" page. This PR moves the check `assertSameSearchSession` function and only invokes them in search related LIFF pages. Note: It may seem tempting to merge `assertSameSession()` with `assertInClient()`. However, in "previous searched article" page that I am going to implement next, it requires `assertInClinet()` but not `assertSameSession()`. Thus I decided to separate the session check in a separate method. *Refactor* • Moves URL token checking logic to `assertSameSession()`. • No need to expose token in `liff/lib` now. • App.svelte now just serves as a simple router page. Other fixes include: • Move `new App` initialization to before `liff.login` so that LINE login don't interrupt assertion checks, which may close down the LIFF. • Fix LINE login redirect URI: `location.href` already includes `location.search`. Repeating `location.search` will result in incorrect url token.

Comment on #194 Enable URL token related check only in search session related pages

*Pull Request Test Coverage Report for <https://coveralls.io/builds/31385827|Build 857>* • *0* of *0* changed or added relevant lines in *0* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage remained the same at *98.521%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*

Review on #194 Enable URL token related check only in search session related pages

LGTM!

Comment on #194 Enable URL token related check only in search session related pages

Should we use `async` `await` here?

Comment on #194 Enable URL token related check only in search session related pages

I added a new env var `DEBUG_LIFF` that disables `isInClient` check. If there is other function that we want to disable when developing LIFF, we can reuse this flag as well

Comment on #194 Enable URL token related check only in search session related pages

It's not required because there is no action that follows the assertion. However I think it's good to do `await` here just in case we want to add more data loading in the future. I all change it.

Comment on #185 Feature/164 user setting

*Pull Request Test Coverage Report for <https://coveralls.io/builds/31386064|Build 859>* • *3* of *8* *(37.5%)* changed or added relevant lines in *3* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage decreased (*-0.9%*) to *97.632%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*

#194 Enable URL token related check only in search session related pages

#195 Add *.svelte support for ESLint

Previously .svelte files are not covered by eslint. This PR upgrades eslint and add <https://github.com/sveltejs/eslint-plugin-svelte3|eslint-plugin-svelte3> (<https://github.com/sveltejs/eslint-plugin-svelte3/pull/17#issuecomment-510897217|requires eslint &gt; 6>) so that eslint can help us find out undefined variables and other issue. TODO: For unknown reasons, eslint error seems not showing in VSCode. Needs running `npm run lint` manually, or catching such error in Travis.

Comment on #195 Lint check on *.svelte files

*Pull Request Test Coverage Report for <https://coveralls.io/builds/31386392|Build 862>* • *0* of *0* changed or added relevant lines in *0* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage remained the same at *98.521%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*

Digital Future Society

Dealing with disinformation | Digital Future Society

In the interest of promoting citizen empowerment in the age of disinformation, this report seeks to understand what disinformation is, why its effects are so damaging, and how policymakers can tackle…

image.png

Review on #195 Lint check on *.svelte files

LGTM!

#195 Lint check on *.svelte files

#196 Unit test for src/liff/lib

This PR adds unit tests for things in `src/liff/lib`, including: • `isDuringLiffRedirect` const • `gql` • `assertInClient` • `assertSameSearchSession`

Comment on #196 Unit test for src/liff/lib

*Pull Request Test Coverage Report for <https://coveralls.io/builds/31421648|Build 876>* • *1* of *1* *(100.0%)* changed or added relevant line in *1* file are covered. • No unchanged relevant lines lost coverage. • Overall coverage decreased (*-0.1%*) to *98.39%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*

Review on #172 Implement articleRepliesFrom filter for ListArticles

#263 Doc/storybook components

Add stories to some components. also remove unused stylesheet file in <https://github.com/cofacts/rumors-site/commit/220be59329b6f9438175ec247e85716547650947|220be59>

Comment on #261 Improve article category UI

Hmm I missed this in last review? XD

Review on #261 Improve article category UI

LGTM! Thanks for the fix!

#261 Improve article category UI

Review on #263 Doc/storybook components

Thank you for documenting these components! I have setup storyshot so that when unit test runs, it will create DOM snapshot. Please include the snapshot in the commit to make the unit test pass.

#159 "不好意思！系統可能在忙線中" has no reply token

#197 User model and API for listing userArticleLink

Comment on #197 User model and API for listing userArticleLink

*Pull Request Test Coverage Report for <https://coveralls.io/builds/31438492|Build 880>* • *7* of *7* *(100.0%)* changed or added relevant lines in *4* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage decreased (*-0.4%*) to *98.083%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*

#197 User model and API for listing userArticleLink

#165 Implement `articleReplyFrom` filter in ListArticle

#172 Implement articleRepliesFrom filter for ListArticles

#177 Add CORS origin for LINE bot LIFF

This is the temp solution for adding more app id (rumors-line-bot's LIFF). Real solution will come in branch `create-user`.

Comment on #177 Add CORS origin for LINE bot LIFF

<https://coveralls.io/builds/31453136|Coverage Status> Coverage remained the same at 86.779% when pulling *<https://github.com/cofacts/rumors-api/commit/5e7d1f1258270ac6eb38de39a49f9bb3332c0554|5e7d1f1> on line-bot-cors* into *<https://github.com/cofacts/rumors-api/commit/b0aaf7f6b03a1b8df26ede5a344e39e0e1291212|b0aaf7f> on master*.

#198 Loads previously viewed articles and display in LIFF

Initial implementation articles list page in LIFF, with not paginations &amp; interactions yet. <https://user-images.githubusercontent.com/108608/84641112-307b5680-af2d-11ea-99ae-47002fe4eb0b.gif|liff-loading> Data shown in the recording is from mock data manually inserted into staging MongoDB. *Features* • Loads user-article links using chatbot GraphQL function `userArticleLink` • Loads article data from Cofacts using new util function `getArticlesFromCofacts ()` that is run in client side (within LIFF) • Displays link and article data in LIFF

#177 Add CORS origin for LINE bot LIFF

Comment on #198 Loads previously viewed articles and display in LIFF

*Pull Request Test Coverage Report for <https://coveralls.io/builds/31454401|Build 894>* • *19* of *19* *(100.0%)* changed or added relevant lines in *1* file are covered. • No unchanged relevant lines lost coverage. • Overall coverage decreased (*-0.09%*) to *98.308%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*

#199 Article Item UI

Basic list UI for viewed article items. • `&lt;ViewedArticle&gt;` • Add date-fns and locale-based helper function • Adjust global background color to match Cofacts website • Translate

Comment on #199 Article Item UI

*Pull Request Test Coverage Report for <https://coveralls.io/builds/31466532|Build 906>* • *6* of *6* *(100.0%)* changed or added relevant lines in *2* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage decreased (*-0.1%*) to *98.187%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*

#200 Article prefix handling

Comment on #200 Article prefix handling

*Pull Request Test Coverage Report for <https://coveralls.io/builds/31466599|Build 908>* • *8* of *8* *(100.0%)* changed or added relevant lines in *1* file are covered. • No unchanged relevant lines lost coverage. • Overall coverage decreased (*-1.6%*) to *96.626%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*

Review on #196 Unit test for src/liff/lib

LGTM!

#196 Unit test for src/liff/lib

#199 Article Item UI

#200 Listing replies after selecting viewed article

Comment on #244 Cannot login to local dev server

<https://www.chromium.org/updates/same-site|https://www.chromium.org/updates/same-site> 1. `rumors-api` has not add `SameSite: none; secure` to its cookie 2. Google says "We have begun enforcing the new behavior for Chrome 80 stable, just not for 100% of users. ". This means that _some_ users are *already blocked* from Cofacts due to this issue, while others can still proceed with a warning message: &gt; A cookie associated with a cross-site resource at <http://cofacts-api.g0v.tw/|http://cofacts-api.g0v.tw/> was set without the `SameSite` attribute. _A future release of Chrome will only deliver cookies with cross-site requests if they are set with `SameSite=None` and `Secure`_. You can review cookies in developer tools under Application&gt;Storage&gt;Cookies and see more details at <https://www.chromestatus.com/feature/5088147346030592|https://www.chromestatus.com/feature/5088147346030592> and <https://www.chromestatus.com/feature/5633521622188032|https://www.chromestatus.com/feature/5633521622188032>. The message is different from the one <https://github.com/Stimim|@Stimim> received. The difference is marked italic, stating that the browser has not blocked the cookie yet; while Stimim's browser is _chosen_ by Google and blocked cookies according to SameSite rules. *Mitigation* Since rumors-api acts as a authentication service, its cookie must be sent in third party context (ex: `<http://cofacts.org|cofacts.org>` and `<http://cofacts-api.g0v.tw|cofacts-api.g0v.tw>` are cross-site ). We should set `SameSite: none; secure` on the login cookies set by `rumors-api`. *References* • <https://auth0.com/docs/sessions/concepts/cookie-attributes|Auth0's mitigation> • <https://docs.microsoft.com/en-us/azure/active-directory/develop/howto-handle-samesite-cookie-changes-chrome-browser?tabs=python#mitigation-and-samples|Microsoft's mitigation> • <https://blog.heroku.com/chrome-changes-samesite-cookie|Heroku's post> • <https://www.chromium.org/updates/same-site|Chromium SameSite latest updates> *Impact* After enforcing samesite on rumors-api, we may encounter issue developing using `<http://localhost:3000>`. Need to investigate workarounds, or provide documentation for devs to setup https on localhost.

Review on #177 Add CORS origin for LINE bot LIFF

#177 Add CORS origin for LINE bot LIFF

Review on #200 Listing replies after selecting viewed article

Review on #199 Article Item UI

old.cofacts.org

Cofacts 真的假的 - 協作型事實查核系統

「Cofacts 真的假的」是一套連結網路訊息與事實查核的協作型系統。

#200 Listing replies after selecting viewed article

20200617_104320.mp4

#200 Listing replies after selecting viewed article

#2 Feature/backtrack user

Review on #263 Doc/storybook components

LGTM! IMO some adjustments can be made on `ExpandableText`. Currently the "閱讀全文" does not align with the text line: <https://user-images.githubusercontent.com/108608/84858710-42c8d200-b09e-11ea-8d29-3e524899db75.png|image> We can do the following to fix that: • set `button`'s `padding` to 0, `vertical-align` to `bottom` • This removes padding around native `&lt;button&gt;` and makes sure surrounding `&lt;div&gt;` have the same height with `&lt;button&gt;` • set the `button` element's `font-size` and `line-height` to `inherit` • Ensures the height of the button will be the same height as its surroundings, so that the gradient color can cover exactly 1 line. • <https://developer.mozilla.org/en-US/docs/Web/CSS/Replaced_element|Replaced elements> like `button` don't automatically inherit styles from document. After adjustment: <https://user-images.githubusercontent.com/108608/84858668-304e9880-b09e-11ea-8727-3e4a0ddde682.png|image>

Comment on #2 Feature/backtrack user

我想確認一下，這個 PR 主要是把原本的 parser 改寫成可以 require 到其他 script 的版本，尚未包含生成 `userArticleLink` 的邏輯這樣嗎 畢竟 PR 沒有 description ._.

Comment on #263 Doc/storybook components

&gt; LGTM! &gt; &gt; IMO some adjustments can be made on `ExpandableText`. Currently the "閱讀全文" does not align with the text line: &gt; <https://user-images.githubusercontent.com/108608/84858710-42c8d200-b09e-11ea-8d29-3e524899db75.png|image> &gt; &gt; We can do the following to fix that: &gt; &gt; • set `button`'s `padding` to 0, `vertical-align` to `bottom` &gt; &gt; • This removes padding around native `&lt;button&gt;` and makes sure surrounding `&lt;div&gt;` have the same height with `&lt;button&gt;` &gt; • set the `button` element's `font-size` and `line-height` to `inherit` &gt; &gt; • Ensures the height of the button will be the same height as its surroundings, so that the gradient color can cover exactly 1 line. &gt; • <https://developer.mozilla.org/en-US/docs/Web/CSS/Replaced_element|Replaced elements> like `button` don't automatically inherit styles from document. &gt; &gt; After adjustment: &gt; <https://user-images.githubusercontent.com/108608/84858668-304e9880-b09e-11ea-8727-3e4a0ddde682.png|image> make sense. will fix it in fine tuning branch.

#263 Doc/storybook components

#201 Feature/163 insert data

<https://github.com/cofacts/rumors-line-bot/issues/163|#163>

6/18 slack free trial 到期喔

Comment on #2 Feature/backtrack user

阿是的，生成 `userArticleLink` 的 PR 預計長在這 <https://github.com/cofacts/rumors-line-bot/pull/201|cofacts/rumors-line-bot#201>

#18 Implement ClaimReview structured data

Comment on #18 Implement ClaimReview structured data

`ClaimReview` spec is more mature now in 2020, supporting multiple author making claim review to a same claim in a page. Therefore, we can re-implement this into Cofacts. Brief story of Cofacts' ClaimReview implementation: • 2017/Aug initial implementation <https://github.com/cofacts/rumors-site/pull/25|#25> • 2018/Feb Google search console reports "Spammy markup", we removed the markup <https://github.com/cofacts/rumors-site/pull/81|#81>; but in the end we found that what caused "Spammy markup" is actually the 'website' <https://github.com/cofacts/rumors-site/issues/128|#128> • 2020/06/17 in the <https://g0v.hackmd.io/ma_IUiRqToO_WJMwPfBpYw?view#ClaimReview-search|meeting> we found that Google provides nice search tool &amp; API for web pages with ClaimReview tag. We can consider re-implement the ClaimReview micro-format now.

Review on #197 User model and API for listing userArticleLink

Review on #2 Feature/backtrack user

LGTM! `sequential` option design is interesting.

#2 Feature/backtrack user

Comment on #201 Feature/163 insert data

這個可以 review 了嗎？ （unit test 好像是壞的） 還沒好的話要不要先 convert to draft？ <https://user-images.githubusercontent.com/108608/84939691-49446180-b111-11ea-98d5-f4c68bbd5c88.png|image> 直接引入 supertest 來測 webhook handler 感覺 coverage 會掉很多，但就先這樣吧 XD

#197 User model and API for listing userArticleLink

#264 Enhance/fine tuning

• Some UI tuning • User avatar with label • Add float edit button to article details page

#202 Convert GraphQL userArticleLinks to cursor-based pagination

Comment on #202 Convert GraphQL userArticleLinks to cursor-based pagination

*Pull Request Test Coverage Report for <https://coveralls.io/builds/31535800|Build 931>* • *32* of *32* *(100.0%)* changed or added relevant lines in *3* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage decreased (*-0.2%*) to *98.338%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*

#202 Convert GraphQL userArticleLinks to cursor-based pagination

#203 Viewed message pagination mechanism

<https://user-images.githubusercontent.com/108608/85028810-21efa200-b1ae-11ea-9e85-781489e72543.gif|pagination> Note: the page size should be 25. On the screencast above the page size was set to 2 for the purpose of demonstration. *Feature* • Connects "Viewed message" LIFF to paginated `userArticleLinks` API • Total message count display • Working Prev / Next buttons

#203 Viewed message pagination mechanism

Comment on #203 Viewed message pagination mechanism

*Pull Request Test Coverage Report for <https://coveralls.io/builds/31538182|Build 939>* • *0* of *0* changed or added relevant lines in *0* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage remained the same at *98.335%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*

Review on #203 Viewed message pagination mechanism

Comment on #199 Article Item UI

Forgot to add `LOCALE` to `.env.sample` in this <https://github.com/cofacts/rumors-line-bot/pull/146|PR>.

Review on #198 Loads previously viewed articles and display in LIFF

LGTM!

#198 Loads previously viewed articles and display in LIFF

Comment on #264 Enhance/fine tuning

How about using <https://reactjs.org/docs/hooks-reference.html#functional-updates|functional update> to avoid state value in deps array? In this way we should not need to disable eslint: ``` useEffect(() =&gt; void(setValue(value =&gt; query.q !== value ? (query.q || '') : value )), [query.q]); ```

Comment on #264 Enhance/fine tuning

Removing `iconWithText` div and just use `resultEntry` as flex container should yield same result with simpler DOM structure. <https://user-images.githubusercontent.com/108608/85193402-c979eb00-b2fa-11ea-95b5-06fddd8c09b6.png|image> Also, we may need to add `flex-shrink: 0` to `.right`, so that it doesn't get squeezed.

Comment on #264 Enhance/fine tuning

1. Seems that ellipsis is also needed on desktop <https://user-images.githubusercontent.com/108608/85193429-0a71ff80-b2fb-11ea-9480-ed215110ee79.png|image> 2. In order to trigger overflow, we should set `min-width: 0` to override the box's <https://css-tricks.com/flexbox-truncated-text/|default min-sizing behavior> (which enforces the flex children to have same width as content, thus no overflow could happen). In this case, we won't need to set a fixed `max-width`, and the style should work on different screen widths. <https://user-images.githubusercontent.com/108608/85193465-5c1a8a00-b2fb-11ea-8ab1-4f8ff86c5167.png|image>

Review on #264 Enhance/fine tuning

Some comments on `GlobalSearch`

Comment on #264 Enhance/fine tuning

Kudos, SonarCloud Quality Gate passed! <https://sonarcloud.io/project/issues?id=cofacts_rumors-site&amp;pullRequest=264&amp;resolved=false&amp;types=BUG|Bug> <https://sonarcloud.io/project/issues?id=cofacts_rumors-site&amp;pullRequest=264&amp;resolved=false&amp;types=BUG|A> <https://sonarcloud.io/project/issues?id=cofacts_rumors-site&amp;pullRequest=264&amp;resolved=false&amp;types=BUG|0 Bugs> <https://sonarcloud.io/project/issues?id=cofacts_rumors-site&amp;pullRequest=264&amp;resolved=false&amp;types=VULNERABILITY|Vulnerability> <https://sonarcloud.io/project/issues?id=cofacts_rumors-site&amp;pullRequest=264&amp;resolved=false&amp;types=VULNERABILITY|A> <https://sonarcloud.io/project/issues?id=cofacts_rumors-site&amp;pullRequest=264&amp;resolved=false&amp;types=VULNERABILITY|0 Vulnerabilities> (and <https://sonarcloud.io/project/issues?id=cofacts_rumors-site&amp;pullRequest=264&amp;resolved=false&amp;types=SECURITY_HOTSPOT|Security Hotspot> <https://sonarcloud.io/project/issues?id=cofacts_rumors-site&amp;pullRequest=264&amp;resolved=false&amp;types=SECURITY_HOTSPOT|0 Security Hotspots> to review) <https://sonarcloud.io/project/issues?id=cofacts_rumors-site&amp;pullRequest=264&amp;resolved=false&amp;types=CODE_SMELL|Code Smell> <https://sonarcloud.io/project/issues?id=cofacts_rumors-site&amp;pullRequest=264&amp;resolved=false&amp;types=CODE_SMELL|A> <https://sonarcloud.io/project/issues?id=cofacts_rumors-site&amp;pullRequest=264&amp;resolved=false&amp;types=CODE_SMELL|3 Code Smells> <https://sonarcloud.io/component_measures?id=cofacts_rumors-site&amp;pullRequest=264|No Coverage information> No Coverage information <https://sonarcloud.io/component_measures?id=cofacts_rumors-site&amp;pullRequest=264&amp;metric=new_duplicated_lines_density&amp;view=list|0.9%> <https://sonarcloud.io/component_measures?id=cofacts_rumors-site&amp;pullRequest=264&amp;metric=new_duplicated_lines_density&amp;view=list|0.9% Duplication>

Figma

Cofacts website

Created with Figma

Comment on #199 Article Item UI

Fixed, thanks

#204 Feature/backtrack user

Comment on #201 Feature/163 insert data

*Pull Request Test Coverage Report for <https://coveralls.io/builds/31584166|Build 950>* • *5* of *5* *(100.0%)* changed or added relevant lines in *5* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage decreased (*-26.5%*) to *71.789%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*

Comment on #201 Feature/163 insert data

<https://github.com/MrOrz|@MrOrz> 好了，可 review 了

Comment on #204 Feature/backtrack user

*Pull Request Test Coverage Report for <https://coveralls.io/builds/31584280|Build 954>* • *5* of *5* *(100.0%)* changed or added relevant lines in *5* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage decreased (*-26.5%*) to *71.789%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*

Review on #264 Enhance/fine tuning

50% reviewed

Comment on #264 Enhance/fine tuning

Unfortunately the tails are not aligned in narrower screen: <https://user-images.githubusercontent.com/108608/85220902-e3422d80-b3e1-11ea-8c1f-719c6cd6f15a.png|image> (Actually the one in the menu is not aligned either.) Since it's difficult calculating border-size to place these triangles, I would suggest using svg instead. It's shape is so simple that we can write the svg <https://www.oxxostudio.tw/articles/201406/svg-04-path-1.html|by hand>: ``` &lt;svg viewBox="0 0 1 2"&gt; &lt;path d="M0 0 H1 L0 1 L1 2 H0 Z" /&gt; &lt;/svg&gt; ``` And we get a ribbon tail that we can resize and recolor using CSS.

Comment on #264 Enhance/fine tuning

Mysterious misalignment <https://user-images.githubusercontent.com/108608/85221036-349eec80-b3e3-11ea-86d4-49739d7ebb31.png|螢幕快照 2020-06-21 下午5 17 43>

Comment on #264 Enhance/fine tuning

Let's remove `nl2br` for all screen sizes. First 3 lines show too little info for desktop users as well, and desktop users are editors that really more info.

Comment on #264 Enhance/fine tuning

Hmm, why disable prettier in this file?

Comment on #264 Enhance/fine tuning

I think it's accidentally lol

Comment on #264 Enhance/fine tuning

The height of the buttons are not even. <https://user-images.githubusercontent.com/108608/85226443-0ed90e00-b40a-11ea-94ff-9ac274f2f5bf.png|image> When hovering on the button, the border highlight is scattered: <https://user-images.githubusercontent.com/108608/85226612-f9181880-b40a-11ea-999d-b5cafabf52fb.png|image> The same goes to the button groups in `CreateReplyRequestForm`. They have different heights (36px vs 38px). <https://user-images.githubusercontent.com/108608/85226538-9aeb3580-b40a-11ea-96d9-9167d5db21fb.gif|imba-buttons> I would suggest we use <https://material-ui.com/components/button-group/#sizes-and-colors|outlined button groups> for all the connected buttons buttons, and &lt;<https://material-ui.com/components/buttons/#contained-buttons%7C`&lt;Button> variant="contained" color="primary" disableElevation&gt;`&gt; for "Reply to this message" button. In this way we get even-height buttons, more sensible border highlight when hovering on the button, and a consistent feedback when clicking on the buttons.

Comment on #264 Enhance/fine tuning

Since we block users from upvoting / downvoting their own reply, I think we should directly disable upvote / downvote button here, instead of displaying a popover that cannot submit.

Review on #264 Enhance/fine tuning

Review finished. Thanks for the work! Please find my suggestions below.

Comment on #264 Enhance/fine tuning

We should also <https://developer.mozilla.org/zh-CN/docs/Web/API/Element/scrollIntoView|scroll the `newReplyContainer` into view> using `scrollIntoView({behavior: "smooth"})`, otherwise desktop users will not know what happened after clicking the floating button.

Comment on #264 Enhance/fine tuning

Selected categories should also have borders Figma: <https://user-images.githubusercontent.com/108608/85227090-aee46680-b40d-11ea-9130-8aa5036b3514.png|image> Now: <https://user-images.githubusercontent.com/108608/85227083-9ffdb400-b40d-11ea-87d5-e84e83cca4c2.png|image>

Comment on #264 Enhance/fine tuning

Instead of scroll handler, I think we can use <https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API|`IntersectionObserver`> instead. Its callback is only invoked when intersection changes, thus it should be more efficient for scroll callbacks, which is invoked on every scroll event. With `IntersectionObserver`, we can directly use `intersectionRatio` to see if the button is in screen, thus we won't need to implement `inViewport()` at all.

Comment on #264 Enhance/fine tuning

According to <https://material-ui.com/customization/breakpoints/#theme-breakpoints-down-key-media-query|doc>, `down('md')` actually matches `[0, lg)`. Therefore between `md` and `lg` the button would look like this: <https://user-images.githubusercontent.com/108608/85225971-57db9300-b407-11ea-85eb-49e62c1a8553.png|image> I think we should try `down('sm')` instead.

Comment on #264 Enhance/fine tuning

I do found this API, but the browser support is <https://caniuse.com/#search=intersection%20observer|fairly poor> as for now

Comment on #264 Enhance/fine tuning

I add the scrollIntoView feature in `useEffect` on Desktop editor so that when either float or regular button is clicked the editor scroll into view, and avoid deep ref pass-down issue.

Comment on #264 Enhance/fine tuning

There are 2 versions of `IntersectionObserver`. The one that calculates intersection with viewport is the first version, which has pretty decent support: <https://caniuse.com/#feat=intersectionobserver|https://caniuse.com/#feat=intersectionobserver>

Comment on #201 Feature/163 insert data

I think we should only put test files under `__tests__`. In the project root directory there is `setup-jest.js` and `authGoogleDrive.js`. We may collect these scripts along with `setup-docker.sh` into a directory named something like `scripts/`.

Review on #201 Feature/163 insert data

I think we should remove the update of `lastRepliedAt` since it should not be updated on `choosingReply`. Also have other suggestions.

Comment on #201 Feature/163 insert data

Actually `lastRepliedAt` is not defined as "last reply view date". It is the `createdAt` of latest reply of the article *in the Cofacts database*. It should be updated by cron jobs, choosing a reply should not update the timestamp. Ref: <https://g0v.hackmd.io/eIeU2g86Tfu5VnLazNfUvQ|https://g0v.hackmd.io/eIeU2g86Tfu5VnLazNfUvQ>

Comment on #201 Feature/163 insert data

Since you invoke `UserSettings.findOrInsertByUserId` directly in the test script (L52), this test will pass even if you comment out L47-L50. In this test, I suggest we read from DB using MongoDb commands, instead of invoking `UserSettings.findOrInsertByUserId`.

#185 Feature/164 user setting

#199 Article Item UI

#264 Enhance/fine tuning

• Some UI tuning • User avatar with label • Add float edit button to article details page

Review on #264 Enhance/fine tuning

Great! Let's ship it <https://github.githubassets.com/images/icons/emoji/shipit.png|:shipit:> Looking forward to future fixes and features :+1:

#264 Enhance/fine tuning

#265 Reply search result's time is not correct

Reproduced on staging: All replies are displayed as "replied less than 1 mins ago", but these replies should be created long time ago. <https://user-images.githubusercontent.com/108608/85412519-3c55c100-b59c-11ea-9ff0-93ef85c4defd.png|螢幕快照 2020-06-23 下午9 51 23>

Screenshot_20200624-133912.png

Comment on #185 Feature/164 user setting

toekn -&gt; token

Comment on #185 Feature/164 user setting

Let's remove user context from unit test to test the case when user sets notification without searching anything. `__tests__/setting.js`'s unit test should also apply.

Review on #185 Feature/164 user setting

LGTM overall! Thanks a million. I have some comments on `@auth` setup, and also found a bit of typos. Also, travis complains about lint error, we need to make it happy.

Comment on #185 Feature/164 user setting

We can check `userId` only using `@auth(check: ["userId"])` The same goes for `allowNotification` mutation

Comment on #185 Feature/164 user setting

toekn -&gt; token

#266 20200624 release

Comment on #185 Feature/164 user setting

Actually we don't need to store "user" in session. We are not authenticating user anyway, we just get a token in a one-time OAuth2 process and then store it to database. `passport.session()`, `passport.serializeUser` and `passport.deserializeUser` are used to store "user" in session. I think after removing these together, LINE notify would still work?

Review on #185 Feature/164 user setting

LGTM! I think we can test it on staging after merge. We can test if we can remove `passport.session` safely in future PRs.

#185 Feature/164 user setting

#205 Try removing passport.session in LINE notify OAuth2 process

Actually we don't need to store "user" in session. We are not authenticating user anyway, we just get a token in a one-time OAuth2 process and then store it to database. `passport.session()`, `passport.serializeUser` and `passport.deserializeUser` are used to store "user" in session. I think after removing these together, LINE notify would still work? _Originally posted by <https://github.com/MrOrz|@MrOrz> in <https://github.com/cofacts/rumors-line-bot/pull/185|#185>_

Comment on #185 Feature/164 user setting

According to <https://notify-bot.line.me/doc/en/|doc>, session is used to avoid CSRF. ``` Assigns a token that can be used for responding to CSRF attacksCSRF attacks are typically countered by assigning a hash value generated from a user's session ID, and then verifying the state parameter variable when it attempts to access redirect_uri. ``` I've tried removing `passport.serializeUser` and `passport.deserializeUser`, there would be errors occur. But I didn't investigate deeper.

Comment on #185 Feature/164 user setting

Interesting aspect from LINE notify doc. The doc is saying that we can pass a `state` in URL param when requesting for tokens. OAuth2 service will return the `state` URL param intact, so that our callback can verify the `state`. It's a security measure commonly provided by authentication services: <https://auth0.com/docs/protocols/oauth2/oauth-state|https://auth0.com/docs/protocols/oauth2/oauth-state> It seems that it can be achieved by passing `state: true` to the strategy constructor: <https://github.com/jaredhanson/passport-oauth2/pull/93/files|https://github.com/jaredhanson/passport-oauth2/pull/93/files> As far as I know, What `passport.session()` does should be serializing user from session to `ctx.state.user`, and vice versa. It's probably not related to the anti-CSRF measure with `state` param mentioned in LINE Notify doc.

截圖 2020-06-26 下午11.50.29.png

截圖 2020-06-26 下午11.50.36.png

截圖 2020-06-26 下午11.52.12.png

g0v.hackmd.io

Cofacts list page refactor - HackMD

#267 Global style &amp; storybook adjustments

*Refactors* • Remove unused files `ListPage.js`, `SearchInput.js`, `AppLayout.css` • Move inline CSS style from `_document` to `app.css` and include in `_app.js`, as instructed in <https://nextjs.org/docs/basic-features/built-in-css-support|Next.js doc>. • Properly load fonts into website • Storybook config • Add Material UI theme to Storybook • Setup Storybook global font to align with websites' • Include subdirectories of `src/components` when searching for story files *Screenshots* • No visual change to website (probably...) • Storybook: <https://user-images.githubusercontent.com/108608/85920132-c30fe400-b8a3-11ea-9e0c-d194271d0455.png|image>

propose.summit2020.g0v.tw

g0v 雙年會 2020 議程徵集

<http://g0v.tw|g0v.tw> 是一個推動資訊透明化的社群，致力於開發公民參與社會的資訊平台與工具。2012 年底開始成形，截至2014年初已有 26 場工作坊、受邀演講 30+ 場、媒體報導 20+ 次、500+ 遍佈三大洲的貢獻者，成果皆以自由軟體模式釋出。將 gov 以「零」替代成為 g0v，從零重新思考政府的角色，也是代表數位原生世代從 0 與 1 世界的視野。<http://g0v.tw|g0v.tw> 以開放原始碼的精神為基底，關心言論自由、資訊開放，寫程式提供公民容易使用的資訊服務。資訊的透明化能幫助公民更確實了解政府運作、更快速了解議題，不被媒體壟斷，也才可有效監督政府，化為參與行動最終深化民主體質。

#4 Model API v1

*Create (register) a model* `POST /v1/models/` *Request* ``` { "name": "my ai model", "realTime": false } ``` *Response* ``` { "id": "this-is-mongo-object-id", "name": "my ai model", "apiKey": "zzzzzz", "realTime": false, "approved": false, "createdAt": "2020-06-28T12:26:55.162Z" } ``` `GET /v1/models/` *Get current models* ``` { "result":[ { "id":"this-is-mongo-object-id-1", "name":"cofacts bert model", "realTime":false, "approved":true }, { "id":"this-is-mongo-object-id-2", "name":"cofacts bow model", "realTime":true, "approved":true }, { "id":"this-is-mongo-object-id-3", "name":"my ai model", "realTime":false, "approved":false } ] } ```

#178 [ListArticles] add reply type filter

This PR adds `replyTypes` filter to `ListArticles` so that users can list articles with specified reply types.

Comment on #178 [ListArticles] add reply type filter

<https://coveralls.io/builds/31732499|Coverage Status> Coverage increased (+0.05%) to 86.826% when pulling *<https://github.com/cofacts/rumors-api/commit/d4246f2bc064dbd1fae5c91a93a3faadfca60ff0|d4246f2> on ListArticle-types* into *<https://github.com/cofacts/rumors-api/commit/3ef73e43b26c413c6b67dd4f31f36058bc9e6e1f|3ef73e4> on master*.

#178 [ListArticles] add reply type filter

Review on #178 [ListArticles] add reply type filter

LGTM!

#268 Moves article / reply list controls to components/ListPages

#178 [ListArticles] add reply type filter

#269 Feature/reply editor toobar

Add some features to reply editor • list style support • emoji picker • extend from other reply

#268 Moves article / reply list controls to components/ListPages

#270 Hotfix/minor bugs

fix some bugs according to the <https://g0v.hackmd.io/W16H4cLoSQ66SPQNYpmvRQ|feebacks> • search replies can't vote • replies link to reply detail page • reply author mismatch (now use articleReply.user only) • category logic (only user that marks the category can remove, user that marks the category can't vote)

Review on #268 Moves article / reply list controls to components/ListPages

Comment on #270 Hotfix/minor bugs

I think it's legit that `CategoryOption` owns its own fragment that records needed fields in within this component, in order to achieve <https://www.apollographql.com/docs/react/data/fragments/#colocating-fragments|fragment colocation>. • `CategoryOption` does not use `&lt;ArticleCategory&gt;`, thus we should not include its fragments in `CategoryOption`. • Since `CategoryOption` only uses `category`, it should declare a fragment on `Category` object type instead. • After we pass `user` (author of `CategoryOption`) to `CategoryOption`, we only used its ID. I think it would be simpler if we directly add something like `disableVote` prop to `CategoryOption` and determine if we should disable upvotes / downvotes in `AddCategoryDialog` instead. • Actually most of the fields in `ArticleCategory.fragments` are no longer needed in `ArticleCategory`, and should be removed accordingly. Each component should only declare fields it really needs. • `AddCategoryDialog` is the component that uses `&lt;CategoryOption&gt;`, thus it should include `CategoryOption.fragments` in its exposed fragments. • `ArticleCategories` uses both `&lt;ArticleCategory&gt;` and `&lt;AddCategoryDialog&gt;`, thus it should include fragments from both components. since it's passed down in a prop (`articleCategories`), it makes sense we create a new fragment in `ArticleCategories` that uses the fields from `&lt;ArticleCategory&gt;` and `&lt;AddCategoryDialog&gt;`. However, when it comes to mutation, things become very complicated and there is no official guideline on how to deal with it. <https://stackoverflow.com/questions/48017187/organization-structure-for-fragment-composition-in-large-react-apollo-apps|An answer from stackoverflow> mentions global mutations (the Relay approach) -- moving mutation field outside of `CategoryOption` may be a good idea avoiding circular dependency on fragments, but the use of fragments in `update()` is still an issue. Maybe we should move `update()` outside as well?

Comment on #270 Hotfix/minor bugs

We may need to add `ReplyInfo.fragments.replyInfo` in `ReplyItem.fragments.ReplyItem`, since `ReplyInfo` actually uses `ReplyInfo`.

Review on #270 Hotfix/minor bugs

Thanks for the fix! Managing all these GraphQL fragments is really difficult, thanks for the hard work :muscle: Found a possibly missing fragment, and added some advice on managing fragments within `ArticleCategories`. The latter may not have a standard solution, discussions are welcomed.

Comment on #166 Implement Google analytics stats field in Article

Spec: <https://g0v.hackmd.io/0kjaVlFASSyddkltqGR6Nw|https://g0v.hackmd.io/0kjaVlFASSyddkltqGR6Nw>

developers.line.biz

Opening a LIFF app

The LINE Developers site is a portal site for developers. It contains documents and tools that will help you use our various developer products. Creating LINE Login and Messaging API applications and services has never been easier!

#266 20200624 release