Review on #263 Mutation adds status
LGTM!
Review on #263 Mutation adds status
LGTM!
HackMD
# Cofacts 會議記錄 ## 2021 - [20211110 會議記錄](/hEaUz91PR0mFftzDfydg8A) - [20211103 會議記錄](/1WADYBY0TH27
<https://github.com/cofacts/rumors-api/pull/266|#266 Update rumors-db version>
Update test/rumors-db after rumors-db's release <https://github.com/cofacts/rumors-db/releases/tag/release%2F20211105|https://github.com/cofacts/rumors-db/releases/tag/release%2F20211105> Will merge after build pass.
:white_check_mark: All checks have passed
<https://coveralls.io/builds/44160070|Coverage Status> Coverage decreased (-0.1%) to 86.193% when pulling *<https://github.com/cofacts/rumors-api/commit/c7aa10fbf133a55899faf8cdcc9363a1d3ba8a37|c7aa10f> on update-rumors-db* into *<https://github.com/cofacts/rumors-api/commit/a01c249da506bef52cb909d24759918b9a01ebfe|a01c249> on master*.
<https://github.com/cofacts/takedowns/pull/22|#22 Add people to spammer list>
<https://g0v.hackmd.io/hEaUz91PR0mFftzDfydg8A#Spammers|https://g0v.hackmd.io/hEaUz91PR0mFftzDfydg8A#Spammers>
g0v.hackmd.io
Discussion in slack: <https://user-images.githubusercontent.com/108608/142204449-94fbb4c1-cd72-4a79-8546-66f4a5c80351.png|圖片> "Use existing reply" will now list out deleted replies. Although we cannot filter out replies from API (because `articleReplies` are not stored in reply), we can remove replies with no normal article replies when listing them out in UI.
HackMD
# Cofacts 會議記錄 ## 2021 - [20211124 會議記錄](/YaQbzua8SWmkm2DNSGD-eQ) - [20211117 會議記錄](/lYTN-n1xQyql
<https://github.com/cofacts/takedowns/pull/24|#24 Announce blockage of the spammers>
<https://github.com/cofacts/takedowns/pull/24|#24 Announce blockage of the spammers>
<https://github.com/cofacts/rumors-api/pull/269|#269 Expose user blockage information>
Corresponds to <https://g0v.hackmd.io/rf0A7MRfTOC613QZmFehQA#2nd-milestone-blocking-mechanism|2nd milestone> in user blocking mechanism • Adds `blockedReason` field to `User` object type • Necessary for website to determine if we should block an user • `ListBlockedUsers` API • So that we can list all blocked user & their blocked contents in milestone 3
:white_check_mark: All checks have passed
<https://coveralls.io/builds/44589306|Coverage Status> Coverage increased (+0.06%) to 86.19% when pulling *<https://github.com/cofacts/rumors-api/commit/6a82a9d4329d38de2ba89782d274016d9ea12b34|6a82a9d> on blocked-user* into *<https://github.com/cofacts/rumors-api/commit/4719a8afebe0b846876b8deabe44dd50916f8afa|4719a8a> on master*.
<https://github.com/cofacts/rumors-site/pull/457|#457 Blocked user's cookie setup>
This is part of <https://g0v.hackmd.io/@mrorz/cofacts-meeting-notes/%2Frf0A7MRfTOC613QZmFehQA|the 2nd milestone> of user blocking mechanism. • Loads `blockedReason` in `AppLayout` and set cookie `isUserBlocked` if blockedReason persists • Once the cookie is set, there is no way to clear the cookie, unless they use devtools. • `useIsUserBlocked()` hook can read if the current browser is owned by blocked user both on browser & during server-side render • Logging out does not clear `isUserBlocked` cookie, thus the value is persisted
:white_check_mark: All checks have passed
<https://coveralls.io/builds/44605203|Coverage Status> Coverage remained the same at 75.363% when pulling *<https://github.com/cofacts/rumors-site/commit/abba9a8d1d01099c6c2ed604acf2e6f0c3f68a6e|abba9a8> on block-user-cookie* into *<https://github.com/cofacts/rumors-site/commit/9a68c273d1fa0199fc8c39f6426117b3ad3fce2e|9a68c27> on master*.