g0v.hackmd.io
![]()
Updated according to <https://g0v.hackmd.io/@mrorz/cofacts-meeting-notes/%2F6gLsmuTUQia3sjyYPPcFvQ|meeting discussion> <https://user-images.githubusercontent.com/108608/182918507-60654179-2925-4a2b-b327-51f9f4a83a91.png|image> <https://user-images.githubusercontent.com/108608/182918534-4dfccae9-45fd-49f3-a5fa-752f2883a845.png|image> <https://user-images.githubusercontent.com/108608/182918681-8a863e10-3541-4ca3-8c50-dc446618eadb.png|image> <https://user-images.githubusercontent.com/108608/182918712-7a231ec1-b654-4871-b803-4f3f312171e6.png|image>
![]()
Updated according to <https://g0v.hackmd.io/@mrorz/cofacts-meeting-notes/%2F6gLsmuTUQia3sjyYPPcFvQ|meeting discussion> <https://user-images.githubusercontent.com/108608/182918507-60654179-2925-4a2b-b327-51f9f4a83a91.png|image> <https://user-images.githubusercontent.com/108608/182918534-4dfccae9-45fd-49f3-a5fa-752f2883a845.png|image> <https://user-images.githubusercontent.com/108608/182918681-8a863e10-3541-4ca3-8c50-dc446618eadb.png|image> <https://user-images.githubusercontent.com/108608/182918712-7a231ec1-b654-4871-b803-4f3f312171e6.png|image>
![]()
cofacts.github.io
Web site created using create-react-app
arXiv.org
Ask to Know More: Generating Counterfactual Explanations for Fake Claims
Automated fact checking systems have been proposed that quickly provide veracity prediction at scale to mitigate the negative influence of fake news on people and on public opinion. However, most...
Ask to Know More: Counterfactual Explanations for Fake Claims source code
<https://github.com/cofacts/rumors-line-bot/pull/316|#316 Feature/image search>
1. Implement processImage 2. Remove old image related code: tesseract-ocr, GDrive 3. Extract postback event function as a standalone handler 4. Remove isSkipUser paramater by directly calling `handlePostback`
<https://github.com/cofacts/rumors-line-bot/pull/316|#316 Feature/image search>
*Changes* 1. Implement processImage, fixes <https://github.com/cofacts/rumors-line-bot/issues/304|#304> 2. Remove old image related code: tesseract-ocr, GDrive 3. Extract postback event function as a standalone handler • Input(text) -> `handleInput` -> return buttons that will trigger `handlePostback` • Input(image) -> `processImage` -> return buttons that will trigger `handlePostback` • Input(postback) -> `handlePostback` 4. Remove isSkipUser (only used in `initState`) parameter by directly calling `handlePostback` *Snapshots* <https://user-images.githubusercontent.com/6376572/183279240-d72dce87-c366-4050-b989-c3927a7bb100.png|https://user-images.githubusercontent.com/6376572/183279240-d72dce87-c366-4050-b989-c3927a7bb100.png> <https://user-images.githubusercontent.com/6376572/183279242-7a99b590-d773-4e0d-b764-479262af57ca.png|https://user-images.githubusercontent.com/6376572/183279242-7a99b590-d773-4e0d-b764-479262af57ca.png> <https://user-images.githubusercontent.com/6376572/183279246-e642c1ce-a2bd-4d5d-b29b-730bf6f41ea2.png|https://user-images.githubusercontent.com/6376572/183279246-e642c1ce-a2bd-4d5d-b29b-730bf6f41ea2.png>
![]()
:white_check_mark: All checks have passed
*Pull Request Test Coverage Report for <https://coveralls.io/builds/51470788|Build 2811714669>* • *83* of *106* *(78.3%)* changed or added relevant lines in *11* files are covered. • *4* unchanged lines in *2* files lost coverage. • Overall coverage increased (+*5.8%*) to *91.292%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*
*Pull Request Test Coverage Report for <https://coveralls.io/builds/51470788|Build 2811714669>* • *83* of *106* *(78.3%)* changed or added relevant lines in *11* files are covered. • *4* unchanged lines in *2* files lost coverage. • Overall coverage increased (+*5.8%*) to *91.292%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*
When back filling old analytics data, we found that the fetched LIFF stats are inconsistent with the numbers on Google Analytics. We can reproduce this on local machine, and found that the inaccuracy only happens when the data is sampled: <https://developers.google.com/analytics/devguides/reporting/core/v4/basics#sampling|https://developers.google.com/analytics/devguides/reporting/core/v4/basics#sampling> If we specify a shorter date range when running the script, the inconsistency will be gone. This PR adds a warning message when sampled data is detected from the Google Analytics Reporting API response. <https://user-images.githubusercontent.com/108608/183285758-e32e57a5-6533-48d3-96ad-c0e4e5b6bfbf.png|圖片>
![]()
When back filling old analytics data, we found that the fetched LIFF stats are inconsistent with the numbers on Google Analytics. We can reproduce this on local machine, and found that the inaccuracy only happens when the data is sampled: <https://developers.google.com/analytics/devguides/reporting/core/v4/basics#sampling|https://developers.google.com/analytics/devguides/reporting/core/v4/basics#sampling> If we specify a shorter date range when running the script, the inconsistency will be gone. This PR adds a warning message when sampled data is detected from the Google Analytics Reporting API response. <https://user-images.githubusercontent.com/108608/183285758-e32e57a5-6533-48d3-96ad-c0e4e5b6bfbf.png|圖片> Sampling should only happens when we manually back-fill the data. The hourly cron job should not have that much of data that triggers Google Analytics samplng.
![]()
:white_check_mark: All checks have passed
<https://coveralls.io/builds/51471855|Coverage Status> Coverage increased (+0.01%) to 87.768% when pulling *<https://github.com/cofacts/rumors-api/commit/4aac44c901ef46b5e512909c22b5a492b74bca76|4aac44c> on warn-about-sampled* into *<https://github.com/cofacts/rumors-api/commit/985911c62e94f6d15e330f61d9bc1d05d9263480|985911c> on master*.
<https://coveralls.io/builds/51471855|Coverage Status> Coverage increased (+0.01%) to 87.768% when pulling *<https://github.com/cofacts/rumors-api/commit/4aac44c901ef46b5e512909c22b5a492b74bca76|4aac44c> on warn-about-sampled* into *<https://github.com/cofacts/rumors-api/commit/985911c62e94f6d15e330f61d9bc1d05d9263480|985911c> on master*.
:+1::+1::+1:
:+1::+1::+1:
<https://github.com/cofacts/takedowns/pull/84|#84 Create 0810-love-scam.md>
<https://github.com/cofacts/takedowns/pull/84|#84 Create 0810-love-scam.md>
HackMD
# Cofacts 會議記錄 ## 2022 - [20220810 會議記錄](/uZ3gouRWRamtrCFzKFrgnw) - [20220803 會議記錄](/6gLsmuTUQia3
Q: seems that we should delete these text related search from `processImage` test ?
Q: seems that we should delete these text related search from `processImage` test ?
I think we should not show "None of these messages matches mine" if there is a 100% match. Because if the user chooses this option and tries to submit the image, `MediaManager` will find that the uploaded file has 100% match and does not perform upload anyway.
I think we should not show "None of these messages matches mine" if there is a 100% match. Because if the user chooses this option and tries to submit the image, `MediaManager` will find that the uploaded file has 100% match and does not perform upload anyway.
Review on #316 Feature/image search
Thanks for the contribution! Although the PR is big, it's still understandable. The PR description and the weekly sync helped a lot :+1: Please find my comments below.
Review on #316 Feature/image search
Thanks for the contribution! Although the PR is big, it's still understandable. The PR description and the weekly sync helped a lot :+1: Please find my comments below.
Unused, suggest remove Suggested change
Unused, suggest remove Suggested change
Let's add a comment denoting the reason why we -1: Suggested change
Let's add a comment denoting the reason why we -1: Suggested change
The height of thumbnail image always does not exceed 240px (set <https://github.com/cofacts/rumors-api/blob/8eb18c6202be8735e5d7fe31db4fee5acd7eee06/src/graphql/mutations/CreateMediaArticle.js#L67|in rumors-api>). Can we set the <https://developers.line.biz/en/docs/messaging-api/flex-message-layout/#box-max-height|maxHeight> of hero so that images don't get blurry?
The height of thumbnail image always does not exceed 240px (set <https://github.com/cofacts/rumors-api/blob/8eb18c6202be8735e5d7fe31db4fee5acd7eee06/src/graphql/mutations/CreateMediaArticle.js#L67|in rumors-api>). Can we set the <https://developers.line.biz/en/docs/messaging-api/flex-message-layout/#box-max-height|maxHeight> of hero so that images don't get blurry?
Outdated comment. Hope we can fix the comment along with this PR XD Suggested change
Outdated comment. Hope we can fix the comment along with this PR XD Suggested change
Review on #317 docs: fix hyperlink
Thanks for the update!
Review on #317 docs: fix hyperlink
Thanks for the update!
*Pull Request Test Coverage Report for <https://coveralls.io/builds/51586704|Build 2838255119>* • *0* of *0* changed or added relevant lines in *0* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage remained the same at *85.487%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*
*Pull Request Test Coverage Report for <https://coveralls.io/builds/51586704|Build 2838255119>* • *0* of *0* changed or added relevant lines in *0* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage remained the same at *85.487%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*
From 20220810 test result: <https://g0v.hackmd.io/uZ3gouRWRamtrCFzKFrgnw#%E6%9C%AA%E7%AB%9F%E9%A0%85%E7%9B%AE|https://g0v.hackmd.io/uZ3gouRWRamtrCFzKFrgnw#%E6%9C%AA%E7%AB%9F%E9%A0%85%E7%9B%AE> LIFF article list (articles) and article page should support displaying images
From 20220810 test result: <https://g0v.hackmd.io/uZ3gouRWRamtrCFzKFrgnw#%E6%9C%AA%E7%AB%9F%E9%A0%85%E7%9B%AE|https://g0v.hackmd.io/uZ3gouRWRamtrCFzKFrgnw#%E6%9C%AA%E7%AB%9F%E9%A0%85%E7%9B%AE> LIFF article list (articles) and article page should support displaying images
From 20220810 test result: <https://g0v.hackmd.io/uZ3gouRWRamtrCFzKFrgnw#%E6%9C%AA%E7%AB%9F%E9%A0%85%E7%9B%AE|https://g0v.hackmd.io/uZ3gouRWRamtrCFzKFrgnw#%E6%9C%AA%E7%AB%9F%E9%A0%85%E7%9B%AE> *As-is* <https://user-images.githubusercontent.com/108608/185045067-dfd5fdb5-4f7c-47d8-baad-3037bb1fe2d4.png|image> *To-be* If there is no other people submitting reply request / comments, we should not show the second sentence. Just use the first sentence (thank the user).
![]()
From 20220810 test result: <https://g0v.hackmd.io/uZ3gouRWRamtrCFzKFrgnw#%E6%9C%AA%E7%AB%9F%E9%A0%85%E7%9B%AE|https://g0v.hackmd.io/uZ3gouRWRamtrCFzKFrgnw#%E6%9C%AA%E7%AB%9F%E9%A0%85%E7%9B%AE> *As-is* <https://user-images.githubusercontent.com/108608/185045067-dfd5fdb5-4f7c-47d8-baad-3037bb1fe2d4.png|image> *To-be* If there is no other people submitting reply request / comments, we should not show the second sentence. Just use the first sentence (thank the user).
![]()