主要更新 category review 與 user blocking 的進度
https://g0v.hackmd.io/@mrorz/cofacts-meeting-notes/%2FTEbULkjbSE-3GDyk-Whj2A
<https://coveralls.io/builds/44697141|Coverage Status> Coverage remained the same at 75.363% when pulling *<https://github.com/cofacts/rumors-site/commit/9e80aafee22822c8a6d6b636ce013abb1efc01dd|9e80aaf> on dependabot/npm_and_yarn/lodash-4.17.21* into *<https://github.com/cofacts/rumors-site/commit/20c9b0b611e46a18453c9aefb928bf9307735fc9|20c9b0b> on master*.
<https://github.com/cofacts/rumors-site/pull/458|#458 Handle SSG case>
<https://github.com/cofacts/rumors-site/actions/runs/1529029608|Previous image build> fails due to the server-side cookie logic introduced in <https://github.com/cofacts/rumors-site/pull/457|#457> . This PR fixes the build by properly handle SSG case, which will have undefined ctx.req.
:white_check_mark: All checks have passed
<https://coveralls.io/builds/44758658|Coverage Status> Coverage remained the same at 75.363% when pulling *<https://github.com/cofacts/rumors-site/commit/7ef839a755b966fd49b5cdcd53a830f69a807a21|7ef839a> on fix-build* into *<https://github.com/cofacts/rumors-site/commit/20c9b0b611e46a18453c9aefb928bf9307735fc9|20c9b0b> on master*.
Build pass & works on staging, will directly merge
<https://github.com/cofacts/rumors-api/pull/271|#271 Flow tag import script>
Discussion: "若水 ground truth" in <https://g0v.hackmd.io/@mrorz/cofacts-meeting-notes/%2FlYTN-n1xQyqlHB9oeaPvuQ|https://g0v.hackmd.io/@mrorz/cofacts-meeting-notes/%2FlYTN-n1xQyqlHB9oeaPvuQ> This PR implements migration script, `importFlowAnnotation.js`, that imports ground truth data from Flow annotators (<https://github.com/cofacts/ground-truth/blob/main/20211204_14859.zip|https://github.com/cofacts/ground-truth/blob/main/20211204_14859.zip>) to database by: 0. Map 0~16 (Flow's annotation) to actual category ID used in database 1. Create (or update) app user ID=`category-reviewer` and user ID=`flow-annotator` in `users` index • `genCategoryReview` is also updated so that it will look for previous reviewer feedback using the ID in `users` index 2. add article category (using app `RUMORS_AI` and app user ID "flow-annotator") if the article category is not existed yet • If there exists a deleted matching article category, the article category status will become `NORMAL` and article category author will switch to `flow-annotator` -- this is the existing behavior of `createArticleCategory`. 3. add positive feedback (using app `RUMORS_AI` and app user ID `category-reviewer`) • so that the article-category will be selected by <https://g0v.hackmd.io/EcrdwfZrQOSTGX7yK6nn4w#Script-2-genBERTInputArticles-script-in-rumors-api|script 2> if no further downvotes exist This PR also does the following refactor: • Simplify `createArticleCategory()` argument: use article ID instead of article instance, since only ID is actually used • Extract `createOrUpdateArticleCategoryFeedback()` from the resolver so that migration script (and script 2 in the future) can call it
:white_check_mark: All checks have passed
<https://coveralls.io/builds/44767051|Coverage Status> Coverage increased (+0.5%) to 86.847% when pulling *<https://github.com/cofacts/rumors-api/commit/9c2f86c655fe1cad04ef9a7537d95b777b8a0bd6|9c2f86c> on flow-tag-importer* into *<https://github.com/cofacts/rumors-api/commit/3bfbac6a62c588e740e6aac52d23ff901f6e58e5|3bfbac6> on master*.
<https://github.com/cofacts/rumors-site/pull/459|#459 Bump next from 9.3.2 to 11.1.3>
Bumps <https://github.com/vercel/next.js|next> from 9.3.2 to 11.1.3. Release notes _Sourced from <https://github.com/vercel/next.js/releases|next's releases>._ > *v11.1.3* > > See <https://github.com/vercel/next.js/releases/v12.0.5|https://github.com/vercel/next.js/releases/v12.0.5> for details about this patch. > > *v11.1.3-canary.105* > *Core Changes* > > • Update swc-minify-enabled link: <https://github-redirect.dependabot.com/vercel/next.js/issues/30290|#30290> > • Fix middleware header propagation: <https://github-redirect.dependabot.com/vercel/next.js/issues/30288|#30288> > • Move outputFileTracing config up: <https://github-redirect.dependabot.com/vercel/next.js/issues/30295|#30295> > • Track usage of swc features: <https://github-redirect.dependabot.com/vercel/next.js/issues/30297|#30297> > • Ensure null bytes in resolved path are handled: <https://github-redirect.dependabot.com/vercel/next.js/issues/30313|#30313> > • Improve deprecation errors for new middleware API: <https://github-redirect.dependabot.com/vercel/next.js/issues/30316|#30316> > > *Documentation Changes* > > • Add more docs.: <https://github-redirect.dependabot.com/vercel/next.js/issues/30320|#30320> > > *Example Changes* > > • Update image component example to use AVIF: <https://github-redirect.dependabot.com/vercel/next.js/issues/30294|#30294> > > *Credits* > > Huge thanks to <https://github.com/ijjk|`@ijjk`>, <https://github.com/styfle|`@styfle`>, <https://github.com/padmaia|`@padmaia`>, <https://github.com/javivelasco|`@javivelasco`>, and <https://github.com/leerob|`@leerob`> for helping! > > *v11.1.3-canary.104* > *Misc Changes* > > • Add necessary workflow job dependencies: <https://github-redirect.dependabot.com/vercel/next.js/issues/30291|#30291> > > *v11.1.3-canary.103* > *Core Changes* > > • Warn when mutating res if not streaming: <https://github-redirect.dependabot.com/vercel/next.js/issues/30284|#30284> > • Chore/publish all swc: <https://github-redirect.dependabot.com/vercel/next.js/issues/30289|#30289> > > *Credits* > > Huge thanks to <https://github.com/kara|`@kara`> for helping! > > *v11.1.3-canary.102* > *Core Changes* > > • Add warning when LCP image is missing `priority` prop: <https://github-redirect.dependabot.com/vercel/next.js/issues/30221|#30221> > • New Middleware API signature: <https://github-redirect.dependabot.com/vercel/next.js/issues/30282|#30282> > • Fix trace case with tsconfig/jsconfig baseUrl: <https://github-redirect.dependabot.com/vercel/next.js/issues/30286|#30286> > > *Documentation Changes* ... (truncated) Commits • <https://github.com/vercel/next.js/commit/ec1a0f7643172e5beba96e7be7d000471813cf69|`ec1a0f7`> v11.1.3 • <https://github.com/vercel/next.js/commit/4dc9bba59b5c4f1d49d9a7b2662c21f225cbd38e|`4dc9bba`> Add no-verify-access for lerna • <https://github.com/vercel/next.js/commit/e314019e987e9bfcc7c8cf6cb7bf6c005521a3f6|`e314019`> use correct token • <https://github.com/vercel/next.js/commit/1a40e71a5ef6b906a5871c1deab6c79b5118189a|`1a40e71`> fix lint • <https://github.com/vercel/next.js/commit/b01acc1b1a5ede2840023bfc3aaedd7415cb8aec|`b01acc1`> Update branch name to next-11 • <https://github.com/vercel/next.js/commit/66de88d9dc2e8f58d392a694eb8833bce7d43c80|`66de88d`> Use next-11 tag • <https://github.com/vercel/next.js/commit/303bc0f94d8f3bb809a1eed14ddcaf15bc915a14|`303bc0f`> Allow publishing on v11-patch branch • <https://github.com/vercel/next.js/commit/f59c82b53fabfb3a07184816d3949f9553aaf44d|`f59c82b`> Enable GitHub actions for v11-patch branch • <https://github.com/vercel/next.js/commit/48887132d12075dc8a8b6ac7ad3658d1a5088e88|`4888713`> Ensure invalid URLs respond with 400 correctly • <https://github.com/vercel/next.js/commit/97456e81ce9860ce8b4bb58931b8d723d312d389|`97456e8`> v11.1.2 • Additional commits viewable in <https://github.com/vercel/next.js/compare/v9.3.2...v11.1.3|compare view> Maintainer changes This version was pushed to npm by <https://www.npmjs.com/~vercel-release-bot|vercel-release-bot>, a new releaser for next since your current version. <https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores|Dependabot compatibility score> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. * * * Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: • `@dependabot rebase` will rebase this PR • `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it • `@dependabot merge` will merge this PR after your CI passes on it • `@dependabot squash and merge` will squash and merge this PR after your CI passes on it • `@dependabot cancel merge` will cancel a previously requested merge and block automerging • `@dependabot reopen` will reopen this PR if it is closed • `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually • `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) • `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) • `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) • `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language • `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language • `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language • `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the <https://github.com/cofacts/rumors-site/network/alerts|Security Alerts page>.
:white_check_mark: All checks have passed
<https://coveralls.io/builds/44867865|Coverage Status> Coverage remained the same at 75.363% when pulling *<https://github.com/cofacts/rumors-site/commit/247941987441274172e2f60d667dcae4c74a321b|2479419> on dependabot/npm_and_yarn/next-11.1.3* into *<https://github.com/cofacts/rumors-site/commit/73063753bbf89b02cf8e58728a4213f156c3779b|7306375> on master*.
Production execution result > node_modules/.bin/babel-node -- src/scripts/genBERTInputArticles.js -s 1Y9FrI01in2hz5eiveGknH0HE081sr7gVuk0a7hqqKuc -o 20211128-production > Writing feedbacks to database > progress [========================================] 100% | ETA: 0s | 2989/2989 > 2211 positive feedbacks & 131 negative feedbacks have been written. > Scanning through 14910 matching articles > progress [========================================] 100% | ETA: 0s | 14910/14910
Run again on production DB & new review category to include Flow's ground truth labels added in 12/06. > $ node_modules/.bin/babel-node -- src/scripts/genBERTInputArticles.js -s 1E6S_wYkRIEgItKKnZyaXVBejiwYCS67qvtJ4u3YoFq8 -o ../groundtruth/20211209-production > Writing feedbacks to database > progress [========================================] 100% | ETA: 0s | 476/476 > 318 positive feedbacks & 61 negative feedbacks have been written. > Scanning through 17111 matching articles > progress [========================================] 100% | ETA: 0s | 17111/17111
facebook.com
See posts, photos and more on Facebook.
<https://github.com/cofacts/rumors-site/pull/460|#460 Fix editor RWD breakpoints #363>
edit breakpoints and css
:white_check_mark: All checks have passed
<https://coveralls.io/builds/44930739|Coverage Status> Coverage remained the same at 75.363% when pulling *<https://github.com/cofacts/rumors-site/commit/7e76c3bafe785e42a36f10ec93bf7ee3107d7340|7e76c3b> on Young-TW:master* into *<https://github.com/cofacts/rumors-site/commit/73063753bbf89b02cf8e58728a4213f156c3779b|7306375> on cofacts:master*.
Review on #460 Fix editor RWD breakpoints #363
Thanks a million for locating the root cause and fix the misaligned breakpoints! :tada: I found that the misaligned breakpoints also exist in `ReferenceInput` as well. *Desktop* <https://user-images.githubusercontent.com/108608/145664852-18e1f5ef-ed9a-4e9c-8de8-6f0d0dcfca48.png|圖片> *Tablet size (incorrect)* <https://user-images.githubusercontent.com/108608/145664922-61243f29-6706-44fc-932c-c9d6eab47310.png|圖片> Also the border of textarea is missing. With the information you give as you digging into this issue, I am able to fix the errors above real quick in a following PR. Kudos to <https://github.com/Young-TW|@Young-TW> for the analysis and the fix!
<https://github.com/cofacts/rumors-site/pull/461|#461 NewReplySection border & display fix>
Extends <https://github.com/cofacts/rumors-site/pull/460|#460> to fix reference input quirks & textarea borders on tablet size. *Screenshot* <https://user-images.githubusercontent.com/108608/145665707-de40ba4a-db13-45bf-8297-f6c27c8c3282.gif|fix-border>
:white_check_mark: All checks have passed
<https://coveralls.io/builds/44930924|Coverage Status> Coverage remained the same at 75.363% when pulling *<https://github.com/cofacts/rumors-site/commit/787bfb6c9cbab5bb3428e512ddd9524588f59b64|787bfb6> on fix-border* into *<https://github.com/cofacts/rumors-site/commit/0d67a1fddc1e1142ab70f30f0069a483b5c01a91|0d67a1f> on master*.
From: <https://g0v.hackmd.io/@mrorz/cofacts-meeting-notes/%2F-G9Md9IyQauRoalIXJgenQ|https://g0v.hackmd.io/@mrorz/cofacts-meeting-notes/%2F-G9Md9IyQauRoalIXJgenQ> Put this <https://www.youtube.com/watch?v=WfdfB7GyqMY|https://www.youtube.com/watch?v=WfdfB7GyqMY> in this <https://cofacts.tw/about|https://cofacts.tw/about> <https://user-images.githubusercontent.com/108608/145665971-0615598b-2c9b-4a47-9ec9-f367580a1a33.png|圖片> Width: align with container Height: make it proportional (Around 16:9) across all sizes
<https://github.com/cofacts/rumors-site/issues/463|#463 Tell editors to not reply other's reply>
From <https://g0v.hackmd.io/@mrorz/cofacts-meeting-notes/%2F-G9Md9IyQauRoalIXJgenQ|https://g0v.hackmd.io/@mrorz/cofacts-meeting-notes/%2F-G9Md9IyQauRoalIXJgenQ> In the the article page, when there are already replies to the article, add a sentence in editor's textarea placeholder text. <https://user-images.githubusercontent.com/108608/145666203-162e0ee4-7769-40fa-8a7b-43cace07df6b.png|圖片> > Note: Please write your reply in response to the reported message above, NOT to other editor's replies below! It is very likely that your audience will not read other's reply before reading yours. > 注意:這裏不是討論區!請針對上面的「可疑訊息」撰寫回覆,不要去回覆下面的查核回應。若現有查核回應不夠好,請使用該篇回應下方的「倒讚」按鈕 > (回應請附上可靠出處)
<https://github.com/MrOrz|@MrOrz> can close this issue?
> <https://github.com/MrOrz|@MrOrz> can close this issue? :ok_hand: :ok_hand: :ok_hand: <https://user-images.githubusercontent.com/108608/145667829-926bf7a6-8ae1-4061-b904-537d5e9baba3.png|圖片>
Discussion: <https://g0v.hackmd.io/@mrorz/cofacts-meeting-notes/%2F-G9Md9IyQauRoalIXJgenQ|https://g0v.hackmd.io/@mrorz/cofacts-meeting-notes/%2F-G9Md9IyQauRoalIXJgenQ> This PR replaces the original "Forum" link in app header & app sidebar to tutorial. • Landing page: "Forum" link changed to "Tutorial" and point to how-to-check-rumors tutorial (`/tutorial?tab=check-rumors`) • Inside application: "Forum link" in app header & sidebar changed to "Tutorial" pointing to fact-checking tutorial. • Add tutorial link to footer. (`/tutorial`) *Landing page* <https://user-images.githubusercontent.com/108608/145668429-86a822fb-0c76-4847-a66d-245e295be807.png|圖片> *Inside application* *Desktop header* <https://user-images.githubusercontent.com/108608/145668292-16afcbd7-8c28-405a-82f7-e8301e15f720.png|圖片> *Mobile sidebar* <https://user-images.githubusercontent.com/108608/145668306-d9789406-e961-4823-8d68-b61345305706.png|圖片> *Footer* <https://user-images.githubusercontent.com/108608/145668347-57910c8a-e4c6-4d2d-8222-da855c1f222e.png|圖片>
:white_check_mark: No checks have passed
<https://coveralls.io/builds/44931563|Coverage Status> Coverage remained the same at 75.363% when pulling *<https://github.com/cofacts/rumors-site/commit/0c0aeba0add7f87daf009033feed86bfcb8c7220|0c0aeba> on tutorial-link* into *<https://github.com/cofacts/rumors-site/commit/0d67a1fddc1e1142ab70f30f0069a483b5c01a91|0d67a1f> on master*.
<https://github.com/cofacts/rumors-site/pull/465|#465 Tell editors to not reply other's reply>
Fixes <https://github.com/cofacts/rumors-site/issues/463|#463> . *0 replies* No extra hint when there is no reply <https://user-images.githubusercontent.com/108608/145718428-93e6cc6d-252a-4382-a318-840cfef794b2.png|image> *Have existing reply* Hint user to not reply other's reply when there is another reply <https://user-images.githubusercontent.com/108608/145718442-8340fc69-e896-4ada-81a5-6172ad0c863d.png|image> This PR also translates the header text of comment section <https://user-images.githubusercontent.com/108608/145718626-6100caaa-55f7-4088-a36e-8979f297e5ae.png|image>
:white_check_mark: All checks have passed
<https://coveralls.io/builds/44939010|Coverage Status> Coverage remained the same at 75.363% when pulling *<https://github.com/cofacts/rumors-site/commit/7abaf1ceddc19a54246e81d622528324f7d33de6|7abaf1c> on multi-reason-hint* into *<https://github.com/cofacts/rumors-site/commit/e4f24b2c3c9d22a85ff27a67e5f7d40aa78d5413|e4f24b2> on master*.
ithelp.ithome.com.tw
iT 邦幫忙是 IT 領域的技術問答與分享社群,透過 IT 人互相幫忙,一起解決每天面臨的靠北時刻。一起來當 IT 人的超級英雄吧,拯救下一個卡關的 IT 人
Tested in <https://g0v.hackmd.io/@mrorz/cofacts-meeting-notes/%2FWEqAcqHwRAeiQywjdOu1Jw|meeting>, let's merge
g0v.hackmd.io
YouTube
Discussion: <https://g0v.hackmd.io/Syl8le5xS22nLo8Vc56gmw?both#Cofacts-search-snippet-%E4%BF%AE%E6%94%B9|https://g0v.hackmd.io/Syl8le5xS22nLo8Vc56gmw?both#Cofacts-search-snippet-%E4%BF%AE%E6%94%B9> <https://user-images.githubusercontent.com/108608/147668806-d9b5e50d-5e6a-4318-8dd4-43b11a0f8a6b.png|圖片>
:white_check_mark: All checks have passed
<https://coveralls.io/builds/45280269|Coverage Status> Coverage remained the same at 75.363% when pulling *<https://github.com/cofacts/rumors-site/commit/221781469f124ef1580b6805feed254aaf03569a|2217814> on update-landing-description* into *<https://github.com/cofacts/rumors-site/commit/7bfd6b73000532614da6e3588f79ce0210a293ca|7bfd6b7> on master*.
YouTube