<https://github.com/cofacts/rumors-line-bot/pull/271|#271 [Trivial] Update default dev url>
<http://cofacts.hacktabl.org|cofacts.hacktabl.org> is no longer maintained -- this domain is removed from CORS whitelist. We should change to <http://dev.cofacts.tw|dev.cofacts.tw>.
:white_check_mark: All checks have passed
*Pull Request Test Coverage Report for <https://coveralls.io/builds/41012566|Build 987062434>* • *0* of *0* changed or added relevant lines in *0* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage remained the same at *87.107%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*
*Pull Request Test Coverage Report for <https://coveralls.io/builds/41013280|Build 987114643>* • *0* of *0* changed or added relevant lines in *0* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage remained the same at *87.107%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*
*Problem* dotenv in babel.config.js it will load .env on unit tests, thus contents in `.env` file can affect `npm test` results and snapshots. *Expected* Unit test should always use `.env.sample`, as set in `setup-jest.js`. Changing any env in `.env` file should have no affect on test snapshots and test results. *Solution* Remove dotenv in `babel.config.js`, which was newly added during <https://github.com/cofacts/rumors-line-bot/pull/253|dockerization> • babel.config.js only requires LOCALE and is only relevent on docker build, thus set LOCALE in Dockerfile instead. • LOCALE in `.env` file is overridden by Dockerfile args. • also enables matrix build of diffrerent languages in the future.
:white_check_mark: All checks have passed
*Pull Request Test Coverage Report for <https://coveralls.io/builds/41016501|Build 987388143>* • *0* of *0* changed or added relevant lines in *0* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage remained the same at *87.107%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*
g0v.hackmd.io
g0v「沒有人」的線上簽書會：真相製造 by 劉致昕 JS Liu - HackMD
3
twitter.com
Birdwatch (@birdwatch) | Twitter
The latest Tweets from Birdwatch (@birdwatch). Empowering the Twitter community to create a better-informed world. Questions? Tweet/DM us
Hi <https://github.com/MrOrz|@MrOrz> I just fixed this issue, and wondering which branch should I PR to ? thx:pray:
Hi <https://github.com/ulayab|@ulayab> , Please open a PR to `master` branch. Thanks!
<https://github.com/cofacts/rumors-site/pull/438|#438 fix: #417 landing page avatar displaying bug>
Review on #438 fix: #417 landing page avatar displaying bug
Thanks a lot for finding the missing data! I think it would be great if we can do the following to <https://www.apollographql.com/docs/react/data/fragments/#colocating-fragments|achieve fragment colocation>: 1. move `USER_QUERY` and `useQuery` to within `LandingPage/Header`, as its data is only used there 2. use <https://github.com/cofacts/rumors-site/blob/9bece90df7d61e8fa298f3b3e99868e56bec698f/lib/useCurrentUser.js#L13|`Avatar.fragment.AvatarData`> in query so that we don't need to enumerate all fields that is used by `Avatar` component <https://github.com/ulayab|@ulayab> are you interested in changing the code above? I can do it after merge as well.
LGTM!
Review on #272 Remove babel.config.js dotenv and set env in Dockerfile instead
LGTM!
<https://github.com/cofacts/rumors-line-bot/pull/270|#270 Fix textarea>
<https://github.com/cofacts/rumors-line-bot/pull/271|#271 [Trivial] Update default dev url>
Sure! I'll try to deal with it.
Hi <https://github.com/MrOrz|@MrOrz> I just update the branch. BTW, it's my first time using Apollo, so I'm not really sure if it's an expected practice.:sneezing_face: Please advise as necessary, thank you!
Review on #438 fix: #417 landing page avatar displaying bug
LGTM, thanks for the fix!
<https://github.com/cofacts/rumors-site/pull/438|#438 fix: #417 landing page avatar displaying bug>
In order to fix <https://g0v.hackmd.io/giYWfM8yRkKghtPOG1EBig#Notification-count-issue|missing `lastScannedAt` issue> which causes notifications to send in bulk, we move `lastScannedAt` from Redis to MongoDB instead. This PR: • Introduces new model `AppVariable` with `set()` and `get()` • The value is persisted in MongoDB • Uses `AppVariable` to replace `redis` in notification scanning code
:white_check_mark: All checks have passed
*Pull Request Test Coverage Report for <https://coveralls.io/builds/41102252|Build 998777928>* • *9* of *9* *(100.0%)* changed or added relevant lines in *2* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage increased (+*0.4%*) to *87.492%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*
This PR handles the case when postback actions are called after the search session is removed from Redis. This should fix <https://rollbar.com/mrorz/rumors-line-bot/items/220/|https://rollbar.com/mrorz/rumors-line-bot/items/220/> .
:white_check_mark: All checks have passed
*Pull Request Test Coverage Report for <https://coveralls.io/builds/41102380|Build 998824566>* • *0* of *4* *(0.0%)* changed or added relevant lines in *1* file are covered. • No unchanged relevant lines lost coverage. • Overall coverage decreased (*-0.3%*) to *87.17%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*
3
Review on #273 Implement AppVariable for persistent app-wide variable
Review on #274 Tell the user the postback button no longer works if their user session is expired
LGTM!
2
1
This PR implements `FeedbackForm` and updates LIFF feedback pages. Figma: <https://www.figma.com/file/DvmAQjMJCncuPORWKnljM1/Cofacts-website-MrOrz?node-id=3042%3A2|https://www.figma.com/file/DvmAQjMJCncuPORWKnljM1/Cofacts-website-MrOrz?node-id=3042%3A2> This PR also refactors the following components: 1. `Button` • applies `color` set outside `Button` • use transparent version of text color for button background when hovering on a "outline" Button. 2. app.css • apply column flexbox to `body` • make `body` at least screen size *`FeedbackForm` component* *No score given* <https://user-images.githubusercontent.com/108608/125168082-39913280-e1d6-11eb-8c2e-58b7a0f55357.gif|positive-negative> *`score === 1`* User can hit "close" directly, or fill in their reasons. <https://user-images.githubusercontent.com/108608/125168163-9c82c980-e1d6-11eb-99aa-664ed24d14f6.gif|positive> *`score === -1`* Stops user from submitting negative feedback without reasons. <https://user-images.githubusercontent.com/108608/125168198-d0f68580-e1d6-11eb-9393-c85aa4a69bb2.gif|cannot-submit> *Sending positive feedback flow* TBA *Sending negative feedback flow* TBA *Switching between positive and negative feedback flow* TBA
:white_check_mark: No checks have passed
*Pull Request Test Coverage Report for <https://coveralls.io/builds/41268398|Build 1018347708>* • *0* of *0* changed or added relevant lines in *0* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage remained the same at *87.17%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*
Review on #275 LIFF FeedbackForm and positive / negative feedback page
<https://github.com/cofacts/need-to-check-list-generator/pull/7|#7 Add Xlsx option>
*Description* Update script for Cofacts meetup, details see <https://g0v.hackmd.io/P3-iDyfYRNiW1kxe4r2ROQ#25th-%E5%B0%8F%E8%81%9A|discussion>. • Rename tabs name as attendees' `nickname`. • Use `name` as tab name when `nickname` is empty. • Filter out the people whose `Ticket Status` are `cancelled`. *Snapshots* <https://user-images.githubusercontent.com/6376572/126064479-469686b0-9875-4869-bf4b-9c51f251be56.png|console> <https://user-images.githubusercontent.com/6376572/126064497-18a1533e-920e-45d1-9e21-dfcbaff6ca3b.png|output>
LGTM!
Superseded by <https://github.com/cofacts/rumors-fb-bot/pull/25|#25>.
<https://github.com/cofacts/rumors-fb-bot/pull/25|#25 Bump urijs from 1.19.1 to 1.19.7>
Bumps <https://github.com/medialize/URI.js|urijs> from 1.19.1 to 1.19.7. Release notes _Sourced from <https://github.com/medialize/URI.js/releases|urijs's releases>._ > *1.19.7 (July 14th 2021)* > > • *SECURITY* fixing <http://medialize.github.io/URI.js/docs.html#static-parseQuery|`URI.parseQuery()`> to prevent overwriting `__proto__` in parseQuery() - disclosed privately by <https://github.com/NewEraCracker|`@NewEraCracker`> > • *SECURITY* fixing <http://medialize.github.io/URI.js/docs.html#static-parse|`URI.parse()`> to handle variable amounts of `\` and `/` in scheme delimiter as Node and Browsers do - disclosed privately by <https://github.com/ready-research|ready-research> via <https://huntr.dev/|https://huntr.dev/> > • removed obsolete build tools > • updated jQuery versions (verifying compatibility with 1.12.4, 2.2.4, 3.6.0) > > *1.19.6 (February 13th 2021)* > > • *SECURITY* fixing <http://medialize.github.io/URI.js/docs.html#static-parse|`URI.parse()`> to rewrite `\` in scheme delimiter to `/` as Node and Browsers do - disclosed privately by <https://twitter.com/ynizry|Yaniv Nizry> from the CxSCA AppSec team at Checkmarx > > *1.19.5 (December 30th 2020)* > > • dropping jquery.URI.js from minified bundle accidentally added since v1.19.3 - [Issue <https://github-redirect.dependabot.com/medialize/URI.js/issues/404|#404>](<https://github-redirect.dependabot.com/medialize/URI.js/issues/404|medialize/URI.js#404>) > > *1.19.4 (December 23rd 2020)* > > • *SECURITY* fixing <http://medialize.github.io/URI.js/docs.html#static-parseAuthority|`URI.parseAuthority()`> to rewrite `\` to `/` as Node and Browsers do - followed up to by <https://github.com/alesandroortiz|alesandroortiz> in [PR <https://github-redirect.dependabot.com/medialize/URI.js/issues/403|#403>](<https://github-redirect.dependabot.com/medialize/URI.js/issues/403|medialize/URI.js#403>), relates to [Issue <https://github-redirect.dependabot.com/medialize/URI.js/issues/233|#233>](<https://github-redirect.dependabot.com/medialize/URI.js/pull/233|medialize/URI.js#233>) > > *1.19.3 (December 20th 2020)* > > • *SECURITY* fixing <http://medialize.github.io/URI.js/docs.html#static-parseAuthority|`URI.parseAuthority()`> to rewrite `\` to `/` as Node and Browsers do - disclosed privately by <https://github.com/alesandroortiz|alesandroortiz>, relates to [Issue <https://github-redirect.dependabot.com/medialize/URI.js/issues/233|#233>](<https://github-redirect.dependabot.com/medialize/URI.js/pull/233|medialize/URI.js#233>) > > *1.19.2 (October 20th 2019)* > > • fixing <http://medialize.github.io/URI.js/docs.html#static-build|`URI.build()`> to properly handle relative paths when a scheme is given - [Issue <https://github-redirect.dependabot.com/medialize/URI.js/issues/387|#387>](<https://github-redirect.dependabot.com/medialize/URI.js/issues/387|medialize/URI.js#387>) > • fixing <http://medialize.github.io/URI.js/docs.html#static-buildQuery|`URI.buildQuery()`> to properly handle empty param name - [Issue <https://github-redirect.dependabot.com/medialize/URI.js/issues/243|#243>](<https://github-redirect.dependabot.com/medialize/URI.js/issues/243|medialize/URI.js#243>), [PR <https://github-redirect.dependabot.com/medialize/URI.js/issues/383|#383>](<https://github-redirect.dependabot.com/medialize/URI.js/issues/383|medialize/URI.js#383>) > • support Composer [PR <https://github-redirect.dependabot.com/medialize/URI.js/issues/386|#386>](<https://github-redirect.dependabot.com/medialize/URI.js/issues/386|medialize/URI.js#386>) Changelog _Sourced from <https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md|urijs's changelog>._ > *1.19.7 (July 14th 2021)* > > • *SECURITY* fixing <http://medialize.github.io/URI.js/docs.html#static-parseQuery|`URI.parseQuery()`> to prevent overwriting `__proto__` in parseQuery() - disclosed privately by <https://github.com/NewEraCracker|`@NewEraCracker`> > • *SECURITY* fixing <http://medialize.github.io/URI.js/docs.html#static-parse|`URI.parse()`> to handle variable amounts of `\` and `/` in scheme delimiter as Node and Browsers do - disclosed privately by <https://github.com/ready-research|ready-research> via <https://huntr.dev/|https://huntr.dev/> > • removed obsolete build tools > • updated jQuery versions (verifying compatibility with 1.12.4, 2.2.4, 3.6.0) > > *1.19.6 (February 13th 2021)* > > • *SECURITY* fixing <http://medialize.github.io/URI.js/docs.html#static-parse|`URI.parse()`> to rewrite `\` in scheme delimiter to `/` as Node and Browsers do - disclosed privately by <https://twitter.com/ynizry|Yaniv Nizry> from the CxSCA AppSec team at Checkmarx > > *1.19.5 (December 30th 2020)* > > • dropping jquery.URI.js from minified bundle accidentally added since v1.19.3 - [Issue <https://github-redirect.dependabot.com/medialize/URI.js/issues/404|#404>](<https://github-redirect.dependabot.com/medialize/URI.js/issues/404|medialize/URI.js#404>) > > *1.19.4 (December 23rd 2020)* > > • *SECURITY* fixing <http://medialize.github.io/URI.js/docs.html#static-parseAuthority|`URI.parseAuthority()`> to rewrite `\` to `/` as Node and Browsers do - followed up to by <https://github.com/alesandroortiz|alesandroortiz> in [PR <https://github-redirect.dependabot.com/medialize/URI.js/issues/403|#403>](<https://github-redirect.dependabot.com/medialize/URI.js/issues/403|medialize/URI.js#403>), relates to [Issue <https://github-redirect.dependabot.com/medialize/URI.js/issues/233|#233>](<https://github-redirect.dependabot.com/medialize/URI.js/pull/233|medialize/URI.js#233>) > > *1.19.3 (December 20th 2020)* > > • *SECURITY* fixing <http://medialize.github.io/URI.js/docs.html#static-parseAuthority|`URI.parseAuthority()`> to rewrite `\` to `/` as Node and Browsers do - disclosed privately by <https://github.com/alesandroortiz|alesandroortiz>, relates to [Issue <https://github-redirect.dependabot.com/medialize/URI.js/issues/233|#233>](<https://github-redirect.dependabot.com/medialize/URI.js/pull/233|medialize/URI.js#233>) > > *1.19.2 (October 20th 2019)* > > • fixing <http://medialize.github.io/URI.js/docs.html#static-build|`URI.build()`> to properly handle relative paths when a scheme is given - [Issue <https://github-redirect.dependabot.com/medialize/URI.js/issues/387|#387>](<https://github-redirect.dependabot.com/medialize/URI.js/issues/387|medialize/URI.js#387>) > • fixing <http://medialize.github.io/URI.js/docs.html#static-buildQuery|`URI.buildQuery()`> to properly handle empty param name - [Issue <https://github-redirect.dependabot.com/medialize/URI.js/issues/243|#243>](<https://github-redirect.dependabot.com/medialize/URI.js/issues/243|medialize/URI.js#243>), [PR <https://github-redirect.dependabot.com/medialize/URI.js/issues/383|#383>](<https://github-redirect.dependabot.com/medialize/URI.js/issues/383|medialize/URI.js#383>) > • support Composer [PR <https://github-redirect.dependabot.com/medialize/URI.js/issues/386|#386>](<https://github-redirect.dependabot.com/medialize/URI.js/issues/386|medialize/URI.js#386>) Commits • <https://github.com/medialize/URI.js/commit/19e54c78d5864aec43986e8f96be8d15998daa80|`19e54c7`> chore(build): bumping to version 1.19.7 • <https://github.com/medialize/URI.js/commit/547d4b69d45d435eed88b04ec0a74cc8080c8694|`547d4b6`> build: update jquery • <https://github.com/medialize/URI.js/commit/aab4a43e0c0cab5bde140edcb73d29f77365ad02|`aab4a43`> build: remove obsolete build tools • <https://github.com/medialize/URI.js/commit/ac43ca8f80c042f0256fb551ea5203863dec4481|`ac43ca8`> fix(parse): more backslash galore <https://github-redirect.dependabot.com/medialize/URI.js/issues/410|#410> • <https://github.com/medialize/URI.js/commit/622db6d8d6e650d6de4300c97779de50e3331095|`622db6d`> docs: add security policy • <https://github.com/medialize/URI.js/commit/8e51b00911ba0f6e90…
<https://github.com/cofacts/rumors-fb-bot/pull/19|#19 Bump urijs from 1.19.1 to 1.19.6>
<https://github.com/cofacts/rumors-site/pull/439|#439 Bump urijs from 1.19.6 to 1.19.7>
Bumps <https://github.com/medialize/URI.js|urijs> from 1.19.6 to 1.19.7. Release notes _Sourced from <https://github.com/medialize/URI.js/releases|urijs's releases>._ > *1.19.7 (July 14th 2021)* > > • *SECURITY* fixing <http://medialize.github.io/URI.js/docs.html#static-parseQuery|`URI.parseQuery()`> to prevent overwriting `__proto__` in parseQuery() - disclosed privately by <https://github.com/NewEraCracker|`@NewEraCracker`> > • *SECURITY* fixing <http://medialize.github.io/URI.js/docs.html#static-parse|`URI.parse()`> to handle variable amounts of `\` and `/` in scheme delimiter as Node and Browsers do - disclosed privately by <https://github.com/ready-research|ready-research> via <https://huntr.dev/|https://huntr.dev/> > • removed obsolete build tools > • updated jQuery versions (verifying compatibility with 1.12.4, 2.2.4, 3.6.0) Changelog _Sourced from <https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md|urijs's changelog>._ > *1.19.7 (July 14th 2021)* > > • *SECURITY* fixing <http://medialize.github.io/URI.js/docs.html#static-parseQuery|`URI.parseQuery()`> to prevent overwriting `__proto__` in parseQuery() - disclosed privately by <https://github.com/NewEraCracker|`@NewEraCracker`> > • *SECURITY* fixing <http://medialize.github.io/URI.js/docs.html#static-parse|`URI.parse()`> to handle variable amounts of `\` and `/` in scheme delimiter as Node and Browsers do - disclosed privately by <https://github.com/ready-research|ready-research> via <https://huntr.dev/|https://huntr.dev/> > • removed obsolete build tools > • updated jQuery versions (verifying compatibility with 1.12.4, 2.2.4, 3.6.0) Commits • <https://github.com/medialize/URI.js/commit/19e54c78d5864aec43986e8f96be8d15998daa80|`19e54c7`> chore(build): bumping to version 1.19.7 • <https://github.com/medialize/URI.js/commit/547d4b69d45d435eed88b04ec0a74cc8080c8694|`547d4b6`> build: update jquery • <https://github.com/medialize/URI.js/commit/aab4a43e0c0cab5bde140edcb73d29f77365ad02|`aab4a43`> build: remove obsolete build tools • <https://github.com/medialize/URI.js/commit/ac43ca8f80c042f0256fb551ea5203863dec4481|`ac43ca8`> fix(parse): more backslash galore <https://github-redirect.dependabot.com/medialize/URI.js/issues/410|#410> • <https://github.com/medialize/URI.js/commit/622db6d8d6e650d6de4300c97779de50e3331095|`622db6d`> docs: add security policy • <https://github.com/medialize/URI.js/commit/8e51b00911ba0f6e90949e2c4516b945c35021f7|`8e51b00`> fix(parse): prevent overwriting *proto* in parseQuery() • See full diff in <https://github.com/medialize/URI.js/compare/v1.19.6...v1.19.7|compare view> <https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores|Dependabot compatibility score> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. * * * Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: • `@dependabot rebase` will rebase this PR • `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it • `@dependabot merge` will merge this PR after your CI passes on it • `@dependabot squash and merge` will squash and merge this PR after your CI passes on it • `@dependabot cancel merge` will cancel a previously requested merge and block automerging • `@dependabot reopen` will reopen this PR if it is closed • `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually • `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) • `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) • `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) • `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language • `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language • `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language • `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the <https://github.com/cofacts/rumors-site/network/alerts|Security Alerts page>.
