TikTok
@leader_10011010 抱歉原諒我的笑聲 #國文老師 #罵髒話 ♬ 原聲 - 牛奶領袖 - 領袖
g0v.hackmd.io
Just `if (!contentTypeBeforeSlash)` ?
Just `if (!contentTypeBeforeSlash)` ?
Nice catch! Removed `!contentType`
Nice catch! Removed `!contentType`
<https://github.com/cofacts/media-manager/pull/3|#3 Publish to npm>
<https://github.com/cofacts/media-manager/pull/3|#3 Publish to npm>
GitHub Community
Workflow_dispatch workflow not showing in actions tab
As of today if you create a workflow file manually on your machine or through GitHub interface it doesn’t matter. If you want to use the workflow_dispatch trigger it will only work on the main branch if you commit it to a separate branch (any non default branch) it will not show.
<https://coveralls.io/builds/49975159|Coverage Status> Coverage decreased (-0.1%) to 87.355% when pulling *<https://github.com/cofacts/rumors-api/commit/8dae1a06381ac702897c5f0d814c6c57c8facf11|8dae1a0> on apply-media-manager* into *<https://github.com/cofacts/rumors-api/commit/319b9d3cef5efa151c82f1d9c73f1e35903cef22|319b9d3> on master*.
<https://coveralls.io/builds/49975159|Coverage Status> Coverage decreased (-0.1%) to 87.355% when pulling *<https://github.com/cofacts/rumors-api/commit/8dae1a06381ac702897c5f0d814c6c57c8facf11|8dae1a0> on apply-media-manager* into *<https://github.com/cofacts/rumors-api/commit/319b9d3cef5efa151c82f1d9c73f1e35903cef22|319b9d3> on master*.
cofacts.github.io
Web site created using create-react-app
We should show author of reply requests, as depicted in <https://www.figma.com/file/zpD45j8nqDB2XfA6m2QskO/Cofacts-website?node-id=681%3A0|figma>. *Mobile* <https://user-images.githubusercontent.com/108608/113914992-c4961180-9810-11eb-89cf-31b78f363609.png|image> *Desktop* <https://user-images.githubusercontent.com/108608/113914962-bba54000-9810-11eb-9568-4c47bab8117d.png|image>
Review on #284 Apply media manager
LGTM!
Review on #284 Apply media manager
LGTM!
<https://github.com/cofacts/takedowns/pull/72|#72 Create 0617-coordinated-feedback.md>
<https://github.com/cofacts/takedowns/pull/72|#72 Create 0617-coordinated-feedback.md>
Also do the same to article reply feedbacks
Also do the same to article reply feedbacks
Related: <https://github.com/cofacts/rumors-site/issues/277|#277>
Related: <https://github.com/cofacts/rumors-site/issues/277|#277>
When user scrolls back and gives feedback, the feedback will be given to the latest article / reply. For instance, in the conversation below, when user clicks "yes" circled in red, the feedback will be sent to the circled out reply further below: <https://user-images.githubusercontent.com/108608/174947370-44cf2a68-07e8-422a-8c8d-0eeadead2b9b.png|image> If the second selected article have multiple replies, the `selectedReplyId` will stay in the previous selection, while the `selectedArticleId` in context being updated. This will create an article-reply-feedback to wrong combination of `articleId` and `replyId`, and chatbot will return "Cannot record your feedback" error. We now have hundreds of such feedback in the database. Since the buttons comes from the same search session, the old buttons are not blocked. *Suggested fix* In <https://github.com/cofacts/rumors-line-bot/issues/176|#176> we have addressed that this is an issue. But instead of using JWT (which we want to deprecate), passing `articleId` and `replyId` right inside the LIFF URL should be enough. We should also remove the need to use `sendMessage` in feedback LIFFs, similar to what we have done in comment LIFFs (<https://g0v.hackmd.io/dOAOGDNzTGCWEsXW8weIgg#%E9%80%81%E5%87%BA%E8%A8%8A%E6%81%AF-state-diagram|discussion>)
When user scrolls back and gives feedback, the feedback will be given to the latest article / reply. For instance, in the conversation below, when user clicks "yes" circled in red, the feedback will be sent to the circled out reply further below: <https://user-images.githubusercontent.com/108608/174947370-44cf2a68-07e8-422a-8c8d-0eeadead2b9b.png|image> If the second selected article have multiple replies, the `selectedReplyId` will stay in the previous selection, while the `selectedArticleId` in context being updated. This will create an article-reply-feedback to wrong combination of `articleId` and `replyId`, and chatbot will return "Cannot record your feedback" error. We now have hundreds of such feedback in the database. Since the buttons comes from the same search session, the old buttons are not blocked. *Suggested fix* In <https://github.com/cofacts/rumors-line-bot/issues/176|#176> we have addressed that this is an issue. But instead of using JWT (which we want to deprecate), passing `articleId` and `replyId` right inside the LIFF URL should be enough. We should also remove the need to use `sendMessage` in feedback LIFFs, similar to what we have done in comment LIFFs (<https://g0v.hackmd.io/dOAOGDNzTGCWEsXW8weIgg#%E9%80%81%E5%87%BA%E8%A8%8A%E6%81%AF-state-diagram|discussion>)
Will address in <https://github.com/cofacts/rumors-line-bot/issues/310|#310>
Will address in <https://github.com/cofacts/rumors-line-bot/issues/310|#310>
<https://github.com/cofacts/rumors-line-bot/pull/311|#311 Implement line content proxy>
usage `/getcontent?token={jwt}` • use a 5min-expired jwt to avoid others accessing it
<https://github.com/cofacts/rumors-line-bot/pull/311|#311 Implement line content proxy>
usage `/getcontent?token={jwt}` • use a 5min-expired jwt to avoid others accessing it
:white_check_mark: No checks have passed
Review on #311 Implement line content proxy
Using signed JWT to avoid arbitrary access is elegant! It ensures that only rumors-line-bot can generate valid URLs for the endpoint, and the URL it gives out has limited access in time. <https://user-images.githubusercontent.com/108608/175222413-ba8a878f-ac53-4372-9d88-9751590baed2.png|image>
Review on #311 Implement line content proxy
Using signed JWT to avoid arbitrary access is elegant! It ensures that only rumors-line-bot can generate valid URLs for the endpoint, and the URL it gives out has limited access in time. <https://user-images.githubusercontent.com/108608/175222413-ba8a878f-ac53-4372-9d88-9751590baed2.png|image>
This will download the whole file from LINE to chatbot before sending to response. Could we directly pipe body to response instead? In this way the file will not fill up the memory of chatbot. Also, it would be great if this proxy can forward `Content-Type` and `Content-Length` from LINE `getContent` endpoint, as media-manager would rely on these two headers to determine file type and process files.
This will download the whole file from LINE to chatbot before sending to response. Could we directly pipe body to response instead? In this way the file will not fill up the memory of chatbot. Also, it would be great if this proxy can forward `Content-Type` and `Content-Length` from LINE `getContent` endpoint, as media-manager would rely on these two headers to determine file type and process files.
so that its version resolution matches the new npm behavior used on Github action. *Before* <https://github.com/cofacts/rumors-line-bot/runs/7038118527?check_suite_focus=true|https://github.com/cofacts/rumors-line-bot/runs/7038118527?check_suite_focus=true> (on master branch) <https://user-images.githubusercontent.com/108608/175497728-9ddd2ee1-6907-4c82-9d9a-a865a68930c2.png|image> *After* <https://github.com/cofacts/rumors-line-bot/actions/runs/2554485738|https://github.com/cofacts/rumors-line-bot/actions/runs/2554485738> (on this branch) <https://user-images.githubusercontent.com/108608/175497790-501281a7-b26c-4cd9-852d-923ac41b338b.png|image>
so that its version resolution matches the new npm behavior used on Github action. Reference: <https://github.com/npm/cli/issues/4684|npm/cli#4684> *Before* <https://github.com/cofacts/rumors-line-bot/runs/7038118527?check_suite_focus=true|https://github.com/cofacts/rumors-line-bot/runs/7038118527?check_suite_focus=true> (on master branch) <https://user-images.githubusercontent.com/108608/175497728-9ddd2ee1-6907-4c82-9d9a-a865a68930c2.png|image> *After* <https://github.com/cofacts/rumors-line-bot/actions/runs/2554485738|https://github.com/cofacts/rumors-line-bot/actions/runs/2554485738> (on this branch) <https://user-images.githubusercontent.com/108608/175497790-501281a7-b26c-4cd9-852d-923ac41b338b.png|image>
:white_check_mark: All checks have passed
*Pull Request Test Coverage Report for <https://coveralls.io/builds/50328003|Build 2554559934>* • *0* of *0* changed or added relevant lines in *0* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage remained the same at *86.946%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*
*Pull Request Test Coverage Report for <https://coveralls.io/builds/50328003|Build 2554559934>* • *0* of *0* changed or added relevant lines in *0* files are covered. • No unchanged relevant lines lost coverage. • Overall coverage remained the same at *86.946%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*
Review on #314 Upgrade npm to 8.13.1 (8.5+) and regenerate package-lock.json
LGTM! Thanks <@U039CG5S7> for the fix!
Review on #314 Upgrade npm to 8.13.1 (8.5+) and regenerate package-lock.json
LGTM! Thanks <@U039CG5S7> for the fix!
<https://github.com/cofacts/rumors-fb-bot/pull/36|#36 Bump node-fetch from 2.2.0 to 2.6.7>
Bumps <https://github.com/node-fetch/node-fetch|node-fetch> from 2.2.0 to 2.6.7. Release notes _Sourced from <https://github.com/node-fetch/node-fetch/releases|node-fetch's releases>._ > *v2.6.7* > *Security patch release* > > Recommended to upgrade, to not leak sensitive cookie and authentication header information to 3th party host while a redirect occurred > > *What's Changed* > > • fix: don't forward secure headers to 3th party by <https://github.com/jimmywarting|`@jimmywarting`> in <https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1453|node-fetch/node-fetch#1453> > > *Full Changelog*: <https://github.com/node-fetch/node-fetch/compare/v2.6.6...v2.6.7|node-fetch/node-fetch@v2.6.6...v2.6.7> > > *v2.6.6* > *What's Changed* > > • fix(URL): prefer built in URL version when available and fallback to whatwg by <https://github.com/jimmywarting|`@jimmywarting`> in <https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1352|node-fetch/node-fetch#1352> > > *Full Changelog*: <https://github.com/node-fetch/node-fetch/compare/v2.6.5...v2.6.6|node-fetch/node-fetch@v2.6.5...v2.6.6> > > *v2.6.2* > > fixed main path in package.json > > *v2.6.1* > > *This is an important security release. It is strongly recommended to update as soon as possible.* > > See <https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md#v261|CHANGELOG> for details. > > *v2.6.0* > > See <https://github.com/bitinn/node-fetch/blob/v2.6.0/CHANGELOG.md#v260|CHANGELOG>. > > *v2.5.0* > > See <https://github.com/bitinn/node-fetch/blob/v2.5.0/CHANGELOG.md#v250|CHANGELOG>. > > *v2.4.1* > > See <https://github.com/bitinn/node-fetch/blob/v2.4.1/CHANGELOG.md#v241|CHANGELOG>. > > *v2.4.0* > > See <https://github.com/bitinn/node-fetch/blob/v2.4.0/CHANGELOG.md#v240|CHANGELOG>. > > *v2.3.0* > > See <https://github.com/bitinn/node-fetch/blob/v2.3.0/CHANGELOG.md#v230|CHANGELOG>. > > *v2.2.1* > > See <https://github.com/bitinn/node-fetch/blob/v2.2.1/CHANGELOG.md#v221|CHANGELOG>. Commits • <https://github.com/node-fetch/node-fetch/commit/1ef4b560a17e644a02a3bfdea7631ffeee578b35|`1ef4b56`> backport of <https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1449|#1449> (<https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1453|#1453>) • <https://github.com/node-fetch/node-fetch/commit/8fe5c4ea66b9b8187600e6d5ec9b1b6781f44009|`8fe5c4e`> 2.x: Specify encoding as an optional peer dependency in package.json (<https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1310|#1310>) • <https://github.com/node-fetch/node-fetch/commit/f56b0c66d3dd2ef185436de1f2fd40f66bfea8f4|`f56b0c6`> fix(URL): prefer built in URL version when available and fallback to whatwg (... • <https://github.com/node-fetch/node-fetch/commit/b5417aea6a3275932283a200214522e6ab53f1ea|`b5417ae`> fix: import whatwg-url in a way compatible with ESM Node (<https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1303|#1303>) • <https://github.com/node-fetch/node-fetch/commit/18193c5922c64046b922e18faf41821290535f06|`18193c5`> fix v2.6.3 that did not sending query params (<https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1301|#1301>) • <https://github.com/node-fetch/node-fetch/commit/ace7536c955556be742d9910566738630cc3c2a6|`ace7536`> fix: properly encode url with unicode characters (<https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1291|#1291>) • <https://github.com/node-fetch/node-fetch/commit/152214ca2f6e2a5a17d71e4638114625d3be30c6|`152214c`> Fix(package.json): Corrected main file path in package.json (<https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1274|#1274>) • <https://github.com/node-fetch/node-fetch/commit/b5e2e41b2b50bf2997720d6125accaf0dd68c0ab|`b5e2e41`> update version number • <https://github.com/node-fetch/node-fetch/commit/2358a6c2563d1730a0cdaccc197c611949f6a334|`2358a6c`> Honor the `size` option after following a redirect and revert data uri support • <https://github.com/node-fetch/node-fetch/commit/8c197f8982a238b3c345c64b17bfa92e16b4f7c4|`8c197f8`> docs: Fix typos and grammatical errors in README.md (<https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/686|#686>) • Additional commits viewable in <https://github.com/node-fetch/node-fetch/compare/v2.2.0...v2.6.7|compare view> Maintainer changes This version was pushed to npm by <https://www.npmjs.com/~endless|endless>, a new releaser for node-fetch since your current version. <https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores|Dependabot compatibility score> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. * * * Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: • `@dependabot rebase` will rebase this PR • `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it • `@dependabot merge` will merge this PR after your CI passes on it • `@dependabot squash and merge` will squash and merge this PR after your CI passes on it • `@dependabot cancel merge` will cancel a previously requested merge and block automerging • `@dependabot reopen` will reopen this PR if it is closed • `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually • `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) • `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) • `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) • `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language • `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language • `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language • `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the <https://github.com/cofacts/rumors-fb-bot/network/alerts|Security Alerts page>.
<https://github.com/cofacts/rumors-fb-bot/pull/36|#36 Bump node-fetch from 2.2.0 to 2.6.7>
Bumps <https://github.com/node-fetch/node-fetch|node-fetch> from 2.2.0 to 2.6.7. Release notes _Sourced from <https://github.com/node-fetch/node-fetch/releases|node-fetch's releases>._ > *v2.6.7* > *Security patch release* > > Recommended to upgrade, to not leak sensitive cookie and authentication header information to 3th party host while a redirect occurred > > *What's Changed* > > • fix: don't forward secure headers to 3th party by <https://github.com/jimmywarting|`@jimmywarting`> in <https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1453|node-fetch/node-fetch#1453> > > *Full Changelog*: <https://github.com/node-fetch/node-fetch/compare/v2.6.6...v2.6.7|node-fetch/node-fetch@v2.6.6...v2.6.7> > > *v2.6.6* > *What's Changed* > > • fix(URL): prefer built in URL version when available and fallback to whatwg by <https://github.com/jimmywarting|`@jimmywarting`> in <https://github-redirect.dependabot.com/node-fetch/node-fetch/pull/1352|node-fetch/node-fetch#1352> > > *Full Changelog*: <https://github.com/node-fetch/node-fetch/compare/v2.6.5...v2.6.6|node-fetch/node-fetch@v2.6.5...v2.6.6> > > *v2.6.2* > > fixed main path in package.json > > *v2.6.1* > > *This is an important security release. It is strongly recommended to update as soon as possible.* > > See <https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md#v261|CHANGELOG> for details. > > *v2.6.0* > > See <https://github.com/bitinn/node-fetch/blob/v2.6.0/CHANGELOG.md#v260|CHANGELOG>. > > *v2.5.0* > > See <https://github.com/bitinn/node-fetch/blob/v2.5.0/CHANGELOG.md#v250|CHANGELOG>. > > *v2.4.1* > > See <https://github.com/bitinn/node-fetch/blob/v2.4.1/CHANGELOG.md#v241|CHANGELOG>. > > *v2.4.0* > > See <https://github.com/bitinn/node-fetch/blob/v2.4.0/CHANGELOG.md#v240|CHANGELOG>. > > *v2.3.0* > > See <https://github.com/bitinn/node-fetch/blob/v2.3.0/CHANGELOG.md#v230|CHANGELOG>. > > *v2.2.1* > > See <https://github.com/bitinn/node-fetch/blob/v2.2.1/CHANGELOG.md#v221|CHANGELOG>. Commits • <https://github.com/node-fetch/node-fetch/commit/1ef4b560a17e644a02a3bfdea7631ffeee578b35|`1ef4b56`> backport of <https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1449|#1449> (<https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1453|#1453>) • <https://github.com/node-fetch/node-fetch/commit/8fe5c4ea66b9b8187600e6d5ec9b1b6781f44009|`8fe5c4e`> 2.x: Specify encoding as an optional peer dependency in package.json (<https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1310|#1310>) • <https://github.com/node-fetch/node-fetch/commit/f56b0c66d3dd2ef185436de1f2fd40f66bfea8f4|`f56b0c6`> fix(URL): prefer built in URL version when available and fallback to whatwg (... • <https://github.com/node-fetch/node-fetch/commit/b5417aea6a3275932283a200214522e6ab53f1ea|`b5417ae`> fix: import whatwg-url in a way compatible with ESM Node (<https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1303|#1303>) • <https://github.com/node-fetch/node-fetch/commit/18193c5922c64046b922e18faf41821290535f06|`18193c5`> fix v2.6.3 that did not sending query params (<https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1301|#1301>) • <https://github.com/node-fetch/node-fetch/commit/ace7536c955556be742d9910566738630cc3c2a6|`ace7536`> fix: properly encode url with unicode characters (<https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1291|#1291>) • <https://github.com/node-fetch/node-fetch/commit/152214ca2f6e2a5a17d71e4638114625d3be30c6|`152214c`> Fix(package.json): Corrected main file path in package.json (<https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/1274|#1274>) • <https://github.com/node-fetch/node-fetch/commit/b5e2e41b2b50bf2997720d6125accaf0dd68c0ab|`b5e2e41`> update version number • <https://github.com/node-fetch/node-fetch/commit/2358a6c2563d1730a0cdaccc197c611949f6a334|`2358a6c`> Honor the `size` option after following a redirect and revert data uri support • <https://github.com/node-fetch/node-fetch/commit/8c197f8982a238b3c345c64b17bfa92e16b4f7c4|`8c197f8`> docs: Fix typos and grammatical errors in README.md (<https://github-redirect.dependabot.com/node-fetch/node-fetch/issues/686|#686>) • Additional commits viewable in <https://github.com/node-fetch/node-fetch/compare/v2.2.0...v2.6.7|compare view> Maintainer changes This version was pushed to npm by <https://www.npmjs.com/~endless|endless>, a new releaser for node-fetch since your current version. <https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores|Dependabot compatibility score> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. * * * Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: • `@dependabot rebase` will rebase this PR • `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it • `@dependabot merge` will merge this PR after your CI passes on it • `@dependabot squash and merge` will squash and merge this PR after your CI passes on it • `@dependabot cancel merge` will cancel a previously requested merge and block automerging • `@dependabot reopen` will reopen this PR if it is closed • `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually • `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) • `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) • `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) • `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language • `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language • `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language • `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the <https://github.com/cofacts/rumors-fb-bot/network/alerts|Security Alerts page>.
Superseded by <https://github.com/cofacts/rumors-fb-bot/pull/36|#36>.
Superseded by <https://github.com/cofacts/rumors-fb-bot/pull/36|#36>.
thediplomat.com
Ukraine Disinformation Fight Sounds Warning Bells for Taiwan
Short of a drastic overhaul, Tsai Ing-wen’s administration must gain a firmer understanding of vulnerabilities in the domestic information environment.
<https://github.com/cofacts/takedowns/pull/77|#77 Create 0625-ads-and-scam.md>
前一張表有點久以前,所以開一張新的表來放二次詐騙
<https://github.com/cofacts/takedowns/pull/77|#77 Create 0625-ads-and-scam.md>
前一張表有點久以前,所以開一張新的表來放二次詐騙
AppleDaily
網傳內閣改組名單 總統府澄清:沒有改組打算|蘋果新聞網|蘋果日報
關於網路流傳一份名單,其中訛稱鄭文燦接任總統府秘書長、林佳龍任行政院副院長與林右昌接任交通部長,對此總統府今日(24日)回應,總統對於秘書長沒有異動的打算,也沒有內閣改組的打算,期盼各界勿以訛傳訛。
• Remove `feedback/yes` and `feedback/no` LIFF pages • Remove LINE bot GraphQL endpoints related to above pages - `context` query and `voteReply` mutation • Remove LIFF <> LINE bot graphql's bearer token mechanism • It <https://g0v.hackmd.io/860RnxUGTi6z2Kca6ojAbg#LIFF-ltgt-Chatbot-server-communication|was introduced> in LIFF as `token` URL param. LIFF forwards the token back in LINE bot GraphQL, so that LINE bot graphql can authenticate user when determining GraphQL context. • However, this whole mechanism is replaced by LIFF v2's ID token (or possibly access token if we remove ID token permission) • The last place we use such token was in `PositiveFeedback` and `NegativeFeedback` LIFF pages. • The mechanism can be removed after the aforementioned LIFF pages are removed • Remove `askingReplyFeedback` state handler and its related prefix logic
:white_check_mark: All checks have passed
• Remove `feedback/yes` and `feedback/no` LIFF pages • Remove LINE bot GraphQL endpoints related to above pages - `context` query and `voteReply` mutation • Remove LIFF <> LINE bot graphql's bearer token mechanism • It was introduced in LIFF as `token` URL param. LIFF forwards the token back in LINE bot GraphQL, so that LINE bot graphql can authenticate user when determining GraphQL context. • However, this whole mechanism is replaced by LIFF v2's ID token (or possibly access token if we remove ID token permission) • The last place we use such token was in `PositiveFeedback` and `NegativeFeedback` LIFF pages. • The mechanism can be removed after the aforementioned LIFF pages are removed • Remove `askingReplyFeedback` state handler and its related prefix logic
*Pull Request Test Coverage Report for <https://coveralls.io/builds/50354874|Build 2559819518>* • *2* of *2* *(100.0%)* changed or added relevant lines in *1* file are covered. • *1* unchanged line in *1* file lost coverage. • Overall coverage decreased (*-1.3%*) to *85.648%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*
*Pull Request Test Coverage Report for <https://coveralls.io/builds/50354874|Build 2559819518>* • *2* of *2* *(100.0%)* changed or added relevant lines in *1* file are covered. • *1* unchanged line in *1* file lost coverage. • Overall coverage decreased (*-1.3%*) to *85.648%* * * * * * * *:yellow_heart: - <https://coveralls.io|Coveralls>*
This branch has been deployed to <https://line.me/R/ti/p/%40nkq3195z|staging LINE bot>; everyone can give it a try.
This branch has been deployed to <https://line.me/R/ti/p/%40nkq3195z|staging LINE bot>; everyone can give it a try.
The bug was introduced in <https://github.com/cofacts/rumors-api/pull/284|#284> . Querying `ArticleType`'s `attachmentUrl` will trigger `Cannot read properties of undefined (reading 'split')` error. <https://user-images.githubusercontent.com/108608/175766904-0971cfe6-7706-4fcf-abab-98c124af4248.png|圖片> The root cause is that for non-image articles, `attachmentHash` is null. However, we send `null` to `MediaManager` to generate URL for `attachmentUrl` field. This PR: • Returns null for `attachmentUrl` if `attachmentHash` is null • Introduces a test case that will fail if this PR is not implemented
The bug was introduced in <https://github.com/cofacts/rumors-api/pull/284|#284> . Querying `ArticleType`'s `attachmentUrl` will trigger `Cannot read properties of undefined (reading 'split')` error. <https://user-images.githubusercontent.com/108608/175766904-0971cfe6-7706-4fcf-abab-98c124af4248.png|圖片> The root cause is that for non-image articles, `attachmentHash` is null. However, we send `null` to `MediaManager` to generate URL for `attachmentUrl` field. This PR: • Returns null for `attachmentUrl` if `attachmentHash` is null • Introduces a test case that will fail if this PR is not implemented
:white_check_mark: All checks have passed
<https://coveralls.io/builds/50355484|Coverage Status> Coverage increased (+0.02%) to 87.549% when pulling *<https://github.com/cofacts/rumors-api/commit/e4fc699c8ed2c6c9421af6b95069e58ab0adcbea|e4fc699> on fix-url-resolver* into *<https://github.com/cofacts/rumors-api/commit/6540c6cbb03e0166a125820344a6e8da5e744d61|6540c6c> on master*.
<https://coveralls.io/builds/50355484|Coverage Status> Coverage increased (+0.02%) to 87.549% when pulling *<https://github.com/cofacts/rumors-api/commit/e4fc699c8ed2c6c9421af6b95069e58ab0adcbea|e4fc699> on fix-url-resolver* into *<https://github.com/cofacts/rumors-api/commit/6540c6cbb03e0166a125820344a6e8da5e744d61|6540c6c> on master*.
This PR depends on API being released to production <https://github.com/cofacts/rumors-api/pull/286|cofacts/rumors-api#286> and feedback user IDs being <https://github.com/cofacts/rumors-api/pull/285#issuecomment-1159399583|fully migrated>. *Add category column in feedback table* Lists the article's category for each feedback. Fixes <https://github.com/cofacts/community-builder/issues/11|#11> <https://user-images.githubusercontent.com/108608/175810778-0344ac0f-c7df-4a31-95a1-d355a6cee866.png|圖片> *Show feedbacks for a specific article-reply creator* Introduces `articleReplyUserId` URL param that specifies the author of article replies. Fixes <https://github.com/cofacts/community-builder/issues/10|#10> <https://user-images.githubusercontent.com/108608/175810802-ee011c98-2b4a-489f-b45a-e4c51557fe54.png|圖片> *Add article text for reply request* This helps when we determine if a user-reported spamming reply request is replying to something relevant. Also it provides link to article so that we can click into it to see if there is other spamming comments. <https://user-images.githubusercontent.com/108608/175810744-26db3e31-a030-4466-aec4-d1f1865b7fae.png|圖片>
This PR depends on API being released to production <https://github.com/cofacts/rumors-api/pull/286|cofacts/rumors-api#286> and feedback user IDs being <https://github.com/cofacts/rumors-api/pull/285#issuecomment-1159399583|fully migrated>. *Add category column in feedback table* Lists the article's category for each feedback. Fixes <https://github.com/cofacts/community-builder/issues/11|#11> <https://user-images.githubusercontent.com/108608/175810778-0344ac0f-c7df-4a31-95a1-d355a6cee866.png|圖片> *Show feedbacks for a specific article-reply creator* Introduces `articleReplyUserId` URL param that specifies the author of article replies. Fixes <https://github.com/cofacts/community-builder/issues/10|#10> <https://user-images.githubusercontent.com/108608/175810802-ee011c98-2b4a-489f-b45a-e4c51557fe54.png|圖片> *Add article text for reply request* This helps when we determine if a user-reported spamming reply request is replying to something relevant. Also it provides link to article so that we can click into it to see if there is other spamming comments. <https://user-images.githubusercontent.com/108608/175810744-26db3e31-a030-4466-aec4-d1f1865b7fae.png|圖片>
:white_check_mark: All checks have passed
Modify attachment field and `CreateMediaArticle` for MediaManager v0.2.0 (PR: <https://github.com/cofacts/media-manager/pull/4|cofacts/media-manager#4> )
<https://github.com/cofacts/media-manager/issues/5|#5 Media Manager documentation>
Add its usage to README • 把 <https://github.com/cofacts/media-manager/|https://github.com/cofacts/media-manager/> 的 README 補上一些圖說 • Use <https://typedoc.org/|typedoc> (or <https://www.reddit.com/r/typescript/comments/q3ylku/i_created_a_documentation_generator_for/|other alternatives?>) to generate document and publish on github pages? Introduce its methodology in a open place (hackmd / google doc / Github wiki / etc) Ref: • <https://docs.google.com/document/d/1QeMLpwE1HeBqo8Aa-QJ3uzNtCxRPlUECC-xWTU-rdQU/edit|https://docs.google.com/document/d/1QeMLpwE1HeBqo8Aa-QJ3uzNtCxRPlUECC-xWTU-rdQU/edit> • <https://docs.google.com/document/d/146yZjgmuJvvWjcmniRyjyMLu85815L30-H7j90kYBtE/edit#heading=h.qiy6ovn65cn7|https://docs.google.com/document/d/146yZjgmuJvvWjcmniRyjyMLu85815L30-H7j90kYBtE/edit#heading=h.qiy6ovn65cn7> • <https://docs.google.com/document/d/1YcXSU5UdZfJHkZoUetMH4L-j16aIpHkl-oghDEFaSJU/edit#|https://docs.google.com/document/d/1YcXSU5UdZfJHkZoUetMH4L-j16aIpHkl-oghDEFaSJU/edit#>
g0v.hackmd.io
<https://github.com/cofacts/rumors-site/issues/492|#492 Filter in profile page>
From <https://g0v.hackmd.io/UP6DRljfTciCSv_mUtB7wQ#%E6%9C%AA%E7%AB%9F%E9%A0%85%E7%9B%AE1|https://g0v.hackmd.io/UP6DRljfTciCSv_mUtB7wQ#未竟項目1> <https://user-images.githubusercontent.com/108608/176455781-8f405b9a-b953-4a00-93b0-35a69048d0c6.png|圖片> • 「一個月內」filter 不是 for 這個使用者的 article reply 而是文章的最新 reply,導致 filter 不準確 • tab 裡的計數應該要跟 filter 連動,比較有用;tab 裡目前的數字跟最上面重複。 • filter 可能要移到 tab 上面,比較能呈現 filter 會影響 tab 這件事
<https://github.com/cofacts/rumors-site/issues/492|#492 Filter in profile page>
From <https://g0v.hackmd.io/UP6DRljfTciCSv_mUtB7wQ#%E6%9C%AA%E7%AB%9F%E9%A0%85%E7%9B%AE1|https://g0v.hackmd.io/UP6DRljfTciCSv_mUtB7wQ#未竟項目1> <https://user-images.githubusercontent.com/108608/176455781-8f405b9a-b953-4a00-93b0-35a69048d0c6.png|圖片> • 「一個月內」filter 不是 for 這個使用者的 article reply 而是文章的最新 reply,導致 filter 不準確 • tab 裡的計數應該要跟 filter 連動,比較有用;tab 裡目前的數字跟最上面重複。 • filter 可能要移到 tab 上面,比較能呈現 filter 會影響 tab 這件事
Already delivered in replies index v1.1.0 <https://github.com/cofacts/rumors-db/commit/5db5a2f14ee547ea0f063b454807484d693a4aa6|5db5a2f>
Already delivered in replies index v1.1.0 <https://github.com/cofacts/rumors-db/commit/5db5a2f14ee547ea0f063b454807484d693a4aa6|5db5a2f>
Fixed in <https://github.com/cofacts/rumors-db/pull/38|#38>
Fixed in <https://github.com/cofacts/rumors-db/pull/38|#38>
Duplicate of <https://github.com/cofacts/rumors-db/issues/34|#34>
Duplicate of <https://github.com/cofacts/rumors-db/issues/34|#34>