disfactory-notification

Month: 2021-02

2021-02-02

github 20:23:24

*<https://github.com/Disfactory/Disfactory/compare/da67437843ed...6c18830792cb|2 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/cdc824e2df9ef7befadf4883d03e471cdde268de|`cdc824e2`> - Set up automatic testing with GitHub Actions <https://github.com/Disfactory/Disfactory/commit/6c18830792cb6e5529abb6737f9c0ec0b0e584c2|`6c188307`> - Merge pull request #490 from Disfactory/github_action_test

2021-02-03

github 17:11:39

#491 修改 /api/factories 的回傳格式,一次回傳 factories, documents 與 report_records 減少前端需要的 query 次數

<https://user-images.githubusercontent.com/126123/106724389-22588280-6643-11eb-8067-11d53535f842.png|image> `/api/statistics/factories` 參數有 • townname • source • display_status • level 前三個是之前就有的就不多解釋,最主要就是多了一個 level level 可以接受的值是 `city` 與 `town` e.g. `/api/statistics/factories` 回傳全台灣的資料,但是不會有縣市與鄉鎮市區的資料 ``` { "factories": 53914, "documents": 200, "report_records": 0 } ``` `/api/statistics/factories?level=city` 回傳全台灣與縣市資料 ``` { "factories": 53914, "documents": 200, "report_records": 0, "cities": { "基隆市": { "factories": 0, "documents": 0, "report_records": 0 }, "臺北市": { "factories": 0, "documents": 0, "report_records": 0 }, ... } ``` `/api/statistics/factories?level=town` 回傳全台灣, 縣市與鄉鎮市區的資料 ``` { "factories": 53914, "documents": 200, "report_records": 0, "cities": { "基隆市": { "factories": 0, "documents": 0, "report_records": 0, "towns": { "仁愛區": { "factories": 0, "documents": 0, "report_records": 0 }, .... } ``` 如果跟 townname 結合的話 `/api/statistics/factories?townname=臺南市&amp;level=town` ``` { "factories": 53914, "documents": 200, "report_records": 0, "cities": { "臺南市": { "factories": 5732, "documents": 100, "report_records": 0, "towns": { "中西區": { "factories": 0, "documents": 0, "report_records": 0 }, .... ``` `/api/statistics/factories?townname=臺南市善化區` ``` { "factories": 53914, "documents": 200, "report_records": 0, "cities": { "臺南市": { "factories": 5732, "documents": 100, "report_records": 0, "towns": { "善化區": { "factories": 238, "documents": 0, "report_records": 0 } } } } } ``` `/api/statistics/factories?townname=臺南市` ``` { "factories": 53914, "documents": 200, "report_records": 0, "cities": { "臺南市": { "factories": 5732, "documents": 100, "report_records": 0 } } } ```

:white_check_mark: All checks have passed

github 22:32:58

*<https://github.com/Disfactory/about.disfactory.tw/compare/2368bebf84f1...79c38af5f3df|12 new commits> pushed to <https://github.com/Disfactory/about.disfactory.tw/tree/master|`master`>* <https://github.com/Disfactory/about.disfactory.tw/commit/f093cd107a47b6738b58b97f9c96d8fcb1291d9a|`f093cd10`> - chore: init the new nuxt project <https://github.com/Disfactory/about.disfactory.tw/commit/718ac20c5237d54616b27fbba280220e4dec2837|`718ac20c`> - feat: remove the unneeded features <https://github.com/Disfactory/about.disfactory.tw/commit/0f8471ce04d91f91efbb5c3f779052ba23f585b6|`0f8471ce`> - feat: reset css &amp; add the css settings <https://github.com/Disfactory/about.disfactory.tw/commit/fac4382b946d18ff6afec07e7c8f9669cd6e36c2|`fac4382b`> - feat: init the routes generator <https://github.com/Disfactory/about.disfactory.tw/commit/e5e47eeaa9eb5b2e35cdf6a385e0e2d0d2e2f175|`e5e47eea`> - feat: add the factories search &amp; display <https://github.com/Disfactory/about.disfactory.tw/commit/75baed007ebb22a4dd50bec6bf9da6ddf4519c0a|`75baed00`> - feat: add the data display &amp; the join us banner <https://github.com/Disfactory/about.disfactory.tw/commit/393d654ff6d82ca963da376e148faac23419c236|`393d654f`> - feat: add the report tutorial <https://github.com/Disfactory/about.disfactory.tw/commit/213ab8d7e1eb35fa9a986e949c42ad73e33a5080|`213ab8d7`> - feat: add the FAQ <https://github.com/Disfactory/about.disfactory.tw/commit/b04a887e59f8c7e497573812d73525e5a2b759be|`b04a887e`> - feat: add the charts <https://github.com/Disfactory/about.disfactory.tw/commit/e9e1bb924bf2cbef20d71b8014603b4e7f78f8de|`e9e1bb92`> - feat: add the media report <https://github.com/Disfactory/about.disfactory.tw/commit/14aad1e6c3b82da8dbfd751e3a5ca0acab21c4d1|`14aad1e6`> - feat: add the footer <https://github.com/Disfactory/about.disfactory.tw/commit/79c38af5f3df0d755d3c8d0c2951e44075b6a0be|`79c38af5`> - feat: add the navigation header

github 23:04:20

Successfully deployed <https://github.com/Disfactory/about.disfactory.tw/commit/1e4ad86b71764d44bda2ee98462e816c5852813b|`1e4ad86`> to github-pages

2021-02-04

github 00:02:40

Successfully deployed <https://github.com/Disfactory/about.disfactory.tw/commit/3b0155ed5befca0442007a62678da186dfd8ceb0|`3b0155e`> to github-pages

github 17:18:57

*<https://github.com/Disfactory/Disfactory/compare/6c18830792cb...d63e93f06add|2 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/cacc08eec65e0d4c235c861dddcaffe39c98d12e|`cacc08ee`> - Refactory statistics api, return factory number, document number and <https://github.com/Disfactory/Disfactory/commit/d63e93f06add73bef85f1da18fd21c9525f61cd0|`d63e93f0`> - Merge pull request #491 from Disfactory/statistics_api_v2

2021-02-05

github 14:16:36

#492 修正花蓮與台東有缺少鄉鎮的問題,並且在 /api/statistics/total 增加 documents 的欄位

1. 因為縣市列表的來源是從 <https://github.com/pixnet/TaiwanZipCodes/blob/master/tw_zipcode.json|https://github.com/pixnet/TaiwanZipCodes/blob/master/tw_zipcode.json> 來的, 並且他在花蓮與台東有缺少鄉鎮,因此產生出來的 zipcode.py 也有問題。 因此重新更新一次此檔案。 2. 在 `/api/statistics/total` 加入 `documents` 的欄位,所以現在回傳會類似 {'基隆市': {'factories': 0, 'report_records': 0, 'documents': 0, '未處理': 0, '處理中': 0, '已斷電': 0, '已拆除': 0}, ...```

:white_check_mark: All checks have passed

2021-02-06

github 01:26:53

*<https://github.com/Disfactory/about.disfactory.tw/compare/79c38af5f3df...77e261959b6e|2 new commits> pushed to <https://github.com/Disfactory/about.disfactory.tw/tree/master|`master`>* <https://github.com/Disfactory/about.disfactory.tw/commit/5b6b5f50ae57a62abb77980b7fd008e7d7f46689|`5b6b5f50`> - feat: use the new api &amp; process the data <https://github.com/Disfactory/about.disfactory.tw/commit/77e261959b6e5f7a19a35a3374fde2010eaf6c44|`77e26195`> - refactor: delete the unrelated file

github 01:38:06

Successfully deployed <https://github.com/Disfactory/about.disfactory.tw/commit/a988127e67de0827ad8fa389fab6eda36ef2596f|`a988127`> to github-pages

github 01:42:38

Successfully deployed <https://github.com/Disfactory/about.disfactory.tw/commit/d095a0bfbe3f6cc3f8de53e4cdaf0cef2cdd566d|`d095a0b`> to github-pages

github 02:45:48

Successfully deployed <https://github.com/Disfactory/about.disfactory.tw/commit/abc66cabfe9bb952c3470bde63c0b51f1bede540|`abc66ca`> to github-pages

github 12:43:48

Successfully deployed <https://github.com/Disfactory/about.disfactory.tw/commit/32cda1267ba377b8a998bd5aa5356dcb7c384e80|`32cda12`> to github-pages

github 15:50:10

*<https://github.com/Disfactory/about.disfactory.tw/compare/77e261959b6e...6f16f9b97be0|1 new commit> pushed to <https://github.com/Disfactory/about.disfactory.tw/tree/master|`master`>* <https://github.com/Disfactory/about.disfactory.tw/commit/6f16f9b97be05bed617831e4a1fc9a4537400e03|`6f16f9b9`> - feat: automatically generate the og imgs

2021-02-07

github 00:41:11

*<https://github.com/Disfactory/about.disfactory.tw/compare/6f16f9b97be0...9e330840d265|6 new commits> pushed to <https://github.com/Disfactory/about.disfactory.tw/tree/master|`master`>* <https://github.com/Disfactory/about.disfactory.tw/commit/1918b06ca5ab608fad76d669e9e9134763b548a5|`1918b06c`> - feat: display the different statistics according to the route <https://github.com/Disfactory/about.disfactory.tw/commit/58a6e2373aa0a875f33fd7a82f1c94a44da74ad9|`58a6e237`> - feat: enable users to share a result <https://github.com/Disfactory/about.disfactory.tw/commit/e5962f74fd7fc116a1e8b11996155f7319586a02|`e5962f74`> - feat: change the url path when users search factories <https://github.com/Disfactory/about.disfactory.tw/commit/506a8240f8f106860614c145d059f89c20cea8d0|`506a8240`> - fix: fix the data mismatch of heatmap chart <https://github.com/Disfactory/about.disfactory.tw/commit/c9215d1c2dc5f5272f764410e83073ab0d96ec6e|`c9215d1c`> - feat: response when users copy the url <https://github.com/Disfactory/about.disfactory.tw/commit/9e330840d265834ef0ef2254998dd1d6a56a6a50|`9e330840`> - feat: add the text &amp; the transitions

github 01:55:37

#71 Enable attribution control

Fix <https://github.com/Disfactory/frontend/issues/67|#67>

github 01:55:38

#71 Display map attribute

Fix <https://github.com/Disfactory/frontend/issues/67|#67>

:white_check_mark: 8 other checks have passed

github 16:31:41

Successfully deployed <https://github.com/Disfactory/about.disfactory.tw/commit/205715322a462484ac92b4696a0fb8c3b3fb8bf5|`2057153`> to github-pages

github 16:37:15

Successfully deployed <https://github.com/Disfactory/about.disfactory.tw/commit/dc295b279c63286a8749f8da1f4c13225e5a144a|`dc295b2`> to github-pages

github 17:13:08

*<https://github.com/Disfactory/about.disfactory.tw/compare/9e330840d265...1e2af19de774|3 new commits> pushed to <https://github.com/Disfactory/about.disfactory.tw/tree/master|`master`>* <https://github.com/Disfactory/about.disfactory.tw/commit/6f38b2f7deec2f7d3d63303877693ca096432335|`6f38b2f7`> - feat: cache the api data <https://github.com/Disfactory/about.disfactory.tw/commit/7148345cf6f50585778e6fd1a38525dc937635ab|`7148345c`> - feat: add the meta tags <https://github.com/Disfactory/about.disfactory.tw/commit/1e2af19de774bbc61db10cb54dc7f878ca0b5a78|`1e2af19d`> - feat: add GA

github 17:48:41

*<https://github.com/Disfactory/about.disfactory.tw/compare/1e2af19de774...af168666011d|1 new commit> pushed to <https://github.com/Disfactory/about.disfactory.tw/tree/master|`master`>* <https://github.com/Disfactory/about.disfactory.tw/commit/af168666011df8532b4e3a4411f4ad3d50b34962|`af168666`> - feat: generate all the og imgs &amp; deploy to the custom domain

github 17:52:09

Successfully deployed <https://github.com/Disfactory/about.disfactory.tw/commit/e6a515600bf5106180e59f195f738b1916f34a83|`e6a5156`> to github-pages

2021-02-08

github 00:48:21

*<https://github.com/Disfactory/about.disfactory.tw/compare/af168666011d...a27ef72f707f|6 new commits> pushed to <https://github.com/Disfactory/about.disfactory.tw/tree/master|`master`>* <https://github.com/Disfactory/about.disfactory.tw/commit/0268c4f0b90d413207e24511d34aa89bfc52b59d|`0268c4f0`> - fix: generate the "og:image" meta tags <https://github.com/Disfactory/about.disfactory.tw/commit/8f6f720e935e6b2723024c069c03c86140d65c1a|`8f6f720e`> - feat: modify the links &amp; text <https://github.com/Disfactory/about.disfactory.tw/commit/3e936cd64e8d94d672c369e1bc89c66a3564f1ed|`3e936cd6`> - fix: change the url correctly when users search the factories <https://github.com/Disfactory/about.disfactory.tw/commit/5ce9ab9cd415e3dc2b4f21182bcafbb10c078c38|`5ce9ab9c`> - feat: display the loading icon when the factories are being searching <https://github.com/Disfactory/about.disfactory.tw/commit/a65cc61fb84c27fcb8c12e5200a06c032af64634|`a65cc61f`> - perf: compress the imgs &amp; add the WebP formats <https://github.com/Disfactory/about.disfactory.tw/commit/a27ef72f707f1453e29d41fe03f774893f581e8e|`a27ef72f`> - feat: temporarily use the staging api in the production environment

github 00:54:23

Successfully deployed <https://github.com/Disfactory/about.disfactory.tw/commit/8f86f3911e72b350fbd5aa62b86618148c64069b|`8f86f39`> to github-pages

github 16:30:44

*<https://github.com/Disfactory/about.disfactory.tw/compare/a27ef72f707f...64a14d83666f|9 new commits> pushed to <https://github.com/Disfactory/about.disfactory.tw/tree/master|`master`>* <https://github.com/Disfactory/about.disfactory.tw/commit/f70a6e05eb9262b1fc25ee662dc58d057ebf1e29|`f70a6e05`> - fix: solve the problem of duplicate zip code <https://github.com/Disfactory/about.disfactory.tw/commit/119325937d73557b54ae030d2efe2ba16d0fc716|`11932593`> - feat: change the colors of heatmap chart <https://github.com/Disfactory/about.disfactory.tw/commit/027656065beae6137ff4ce7a1e1fba98c4ebf04b|`02765606`> - feat: add the inputmode attribute <https://github.com/Disfactory/about.disfactory.tw/commit/ac40885c7d9d3da9f9f04711f472fce362e4a70e|`ac40885c`> - refactor: remove the unnecessary ref <https://github.com/Disfactory/about.disfactory.tw/commit/02f7272b3f67600f2150d7ce089b308be5ae9143|`02f7272b`> - feat: enable users to press the Enter key to search the factories <https://github.com/Disfactory/about.disfactory.tw/commit/84977f2a66da02d45cdc35403025516f934d3868|`84977f2a`> - fix: remove the unneeded region 南海諸島 <https://github.com/Disfactory/about.disfactory.tw/commit/a8c887e1ce5ad4a62770460019e071e0023d1ffb|`a8c887e1`> - feat: enable users to locate to search the factories <https://github.com/Disfactory/about.disfactory.tw/commit/94c1efda881c4aac63057108caef2010293aeb89|`94c1efda`> - refactor: rename for consistency <https://github.com/Disfactory/about.disfactory.tw/commit/64a14d83666f980d5f9b69d39de79e49b85d80a7|`64a14d83`> - feat: add the GTM

github 16:36:18

Successfully deployed <https://github.com/Disfactory/about.disfactory.tw/commit/75b09ae2782c696a884d4332d18f6df9d86cb447|`75b09ae`> to github-pages

github 17:33:00

#12 手機版的「+」跑掉了

手機版首頁 數字的+跑掉了 <https://user-images.githubusercontent.com/60970217/107201201-a3dd5580-6a33-11eb-9c92-21b21ecf4200.jpg|IMG_0630>

github 17:45:15

*<https://github.com/Disfactory/about.disfactory.tw/compare/64a14d83666f...80270df50dfa|2 new commits> pushed to <https://github.com/Disfactory/about.disfactory.tw/tree/master|`master`>* <https://github.com/Disfactory/about.disfactory.tw/commit/4e5f031156206a8a220ddb7a5e6e77af0989ec5d|`4e5f0311`> - feat: change the GTM id <https://github.com/Disfactory/about.disfactory.tw/commit/80270df50dfa5a222703be8a68109949ef201bb6|`80270df5`> - feat: use the production api

github 17:45:44

*<https://github.com/Disfactory/about.disfactory.tw/compare/80270df50dfa...06005250c29a|1 new commit> pushed to <https://github.com/Disfactory/about.disfactory.tw/tree/master|`master`>* <https://github.com/Disfactory/about.disfactory.tw/commit/06005250c29a88c97bef7565a4efa8e3f634cbbe|`06005250`> - ci: deploy to <http://about.disfactory.tw|about.disfactory.tw>

github 23:07:31

*<https://github.com/Disfactory/Disfactory/compare/d63e93f06add...04aaa2d72356|4 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/aef9e611a3efa87f49593f57bd17b33113b8c9a5|`aef9e611`> - Fix zip code and add document number of city to /statistics/total api <https://github.com/Disfactory/Disfactory/commit/76784e7fcf8637069e3dcf9cbad1c2179e0de77d|`76784e7f`> - when the api /api/statistics/total calculates report_records, the same factory will only be counted once <https://github.com/Disfactory/Disfactory/commit/b2062e57b17df73718736f98f9871e7b506f1297|`b2062e57`> - 1. Add '已排程拆除' to '已處理' <https://github.com/Disfactory/Disfactory/commit/04aaa2d7235617f259e88896234f81f0e2369b1c|`04aaa2d7`> - Merge pull request #492 from Disfactory/fix_zipcode

2021-02-09

github 01:52:14

*<https://github.com/Disfactory/about.disfactory.tw/compare/06005250c29a...eee438bbd6fe|7 new commits> pushed to <https://github.com/Disfactory/about.disfactory.tw/tree/master|`master`>* <https://github.com/Disfactory/about.disfactory.tw/commit/af338025aef49acc7f580cc3eacda8ccc21b1282|`af338025`> - fix: fix the layout problem in Safari <https://github.com/Disfactory/about.disfactory.tw/commit/6e55d676c388a924f1f0bff4cdc41a36fa3dd7eb|`6e55d676`> - feat: add the links &amp; disable the GTM in dev mode <https://github.com/Disfactory/about.disfactory.tw/commit/9b6dbdb6820337ad8797872c90b9a55bfdc6fb5b|`9b6dbdb6`> - fix: clear the inner shadow of inputs on iPhone Safari <https://github.com/Disfactory/about.disfactory.tw/commit/e32961fa6cb7479181ced1c9204cfedc59ba293c|`e32961fa`> - feat: add the links &amp; disable the GTM in dev mode <https://github.com/Disfactory/about.disfactory.tw/commit/23b26c7f439da87f365a3171f47512d0686ec767|`23b26c7f`> - feat: cache &amp; add timestamps to the OG images <https://github.com/Disfactory/about.disfactory.tw/commit/d9462f50b36538a41ad7c8c4f6b51565653465e2|`d9462f50`> - ci: commit a change when the OG images &amp; og-imgs-cache.json are updated <https://github.com/Disfactory/about.disfactory.tw/commit/eee438bbd6fe781fbee89997c2fe27be264a5792|`eee438bb`> - feat: add the initial OG images &amp; their cache

github 02:12:00

*<https://github.com/Disfactory/about.disfactory.tw/compare/eee438bbd6fe...dd8a01f6c886|1 new commit> pushed to <https://github.com/Disfactory/about.disfactory.tw/tree/master|`master`>* <https://github.com/Disfactory/about.disfactory.tw/commit/dd8a01f6c886b4596163e3f74e2cc5094529b610|`dd8a01f6`> - fix: run ci

github 02:12:47

#14 fix: run ci

error: a step cannot have both the `uses` and `run` keys

github 02:41:24

#493 移除南海諸島

因為那邊不太可能會有人回報農地工廠

:white_check_mark: All checks have passed

github 02:44:29

#494 改善 `/api/statistics/factories?level=town` 的效能

因為有些 factories 的 towname 開頭是 `臺灣省花蓮縣` 有些則是 `花蓮縣` 所以之前是使用 `contains` 的方式來搜尋 townname。 但是這個效能很差,所以改用兩個 `startswith` 的 filter 來處理,也就是同時搜尋 `臺灣省花蓮縣` 與 `花蓮縣` 在我的電腦上這樣效能就可以從 14s 縮短到 4s 左右

:white_check_mark: All checks have passed

github 02:50:48

Successfully deployed <https://github.com/Disfactory/about.disfactory.tw/commit/fcf5c87e06e9cee4628febd4b7fcc18af2ae7e24|`fcf5c87`> to github-pages

github 08:07:32

#15 og image是舊的忍者圖

*The problem* 分享時,現在facebook的OG image跑不出來,twitter則是抓到舊的圖片 <https://user-images.githubusercontent.com/60970217/107296984-69180380-6aad-11eb-938b-818a082fcafb.png|截圖 2021-02-09 上午8 04 14> <https://user-images.githubusercontent.com/60970217/107296830-1d655a00-6aad-11eb-902f-6aa45d7bec79.png|截圖 2021-02-09 上午8 02 02> Device: Macbook Pro OS: MacOS Catalina Browser: Chrome 版本 88.0.4324.150

github 09:20:12

Successfully deployed <https://github.com/Disfactory/about.disfactory.tw/commit/60c73ee1fb03a28b2ffe8b3122ccd2e6540851b9|`60c73ee`> to github-pages

github 10:44:46

#16 員林市的統計

「員林市」統計是0,但好像是因為在about這邊被寫成「員林鎮」了 <https://user-images.githubusercontent.com/60970217/107308493-b2734d80-6ac3-11eb-8005-55c4e5127ba6.png|截圖 2021-02-09 上午10 43 46> <https://user-images.githubusercontent.com/60970217/107308528-c28b2d00-6ac3-11eb-81f2-30b6e7690607.png|截圖 2021-02-09 上午10 43 32>

github 12:20:55

#495 更新 zipcode '頭份市' '員林市'

這兩個縣轄市是在 2015 年升格,之前用的資料可能太舊所以沒有更新到

:white_check_mark: All checks have passed

github 20:12:23

*<https://github.com/Disfactory/Disfactory/compare/04aaa2d72356...89a7a3faa4c8|2 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/7e9647e35f60e1352cbb056e2bdf400f7a689478|`7e9647e3`> - replace 'contains' filter with 'startswith' filter <https://github.com/Disfactory/Disfactory/commit/89a7a3faa4c8d93f4a9bbb466234a7b504707a26|`89a7a3fa`> - Merge pull request #494 from Disfactory/improve_statistics_api_performance

github 20:24:45

*<https://github.com/Disfactory/Disfactory/compare/89a7a3faa4c8...9d55337355fb|2 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/82f6951797b26e3cce17943640ecba1a56dbc88d|`82f69517`> - update zipcode for '頭份市' and '員林市' <https://github.com/Disfactory/Disfactory/commit/9d55337355fb28691f169299cbabf409c8f9a369|`9d553373`> - Merge pull request #495 from Disfactory/fix_townname

github 20:26:31

*<https://github.com/Disfactory/Disfactory/compare/9d55337355fb...148cbe50aebd|2 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/565a23ec588c832fde82e27a384c490579d331ff|`565a23ec`> - Remove 南海諸島 <https://github.com/Disfactory/Disfactory/commit/148cbe50aebdf016d3376bff9f36922cd21ea56f|`148cbe50`> - Merge pull request #493 from Disfactory/remove_unused_city

github 20:51:57

#496 add a hint about how to restore backup file

提醒未來的自己

:white_check_mark: All checks have passed

github 21:07:40

#497 remove unused image api

已經很久沒用到這些 api 了。未來應該也是透過前端上傳,所以就把這些 API 和 view function 刪掉,以減少讀 code 的雜訊

:white_check_mark: All checks have passed

github 21:14:18

#498 add a util function for normalizing townname

重複了四次,應該可以為他寫一個 function

:white_check_mark: All checks have passed

2021-02-10

github 00:25:29

#499 use prefetch for query factories with serializer

用大量的 Prefetch 來減少 `FactorySerializer` 對 DB query 的次數,在我本機測(SSD)可以快個兩倍多一點 用以下腳本在 shell 測試 ``` from cProfile import Profile import pstats from django.http import JsonResponse from api.serializers import FactorySerializer from api.views.utils import _get_nearby_factories pr=Profile();pr.enable(); a = FactorySerializer(_get_nearby_factories(latitude=22.688508991021976, longitude=120.37539798859859, radius=5), many=True).data;pr.disable();ps = pstats.Stats(pr) ps.sort_stats('tottime').print_stats(20) ``` before: ``` 197461 function calls (191605 primitive calls) in 0.232 seconds Ordered by: internal time List reduced from 770 to 20 due to restriction &lt;20&gt; ncalls tottime percall cumtime percall filename:lineno(function) 202 0.059 0.000 0.061 0.000 {method 'execute' of 'psycopg2.extensions.cursor' objects} 404 0.005 0.000 0.039 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/sql/query.py:1154(build_filter) 607 0.003 0.000 0.006 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/sql/query.py:299(clone) 11025 0.003 0.000 0.003 0.000 {built-in method builtins.hasattr} 860 0.003 0.000 0.007 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/sql/query.py:1361(names_to_path) 14264 0.003 0.000 0.005 0.000 {built-in method builtins.isinstance} 556 0.003 0.000 0.004 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/base.py:401(__init__) 2085/1178 0.003 0.000 0.023 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/sql/compiler.py:400(compile) 758 0.003 0.000 0.145 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/query.py:49(__iter__) 404 0.003 0.000 0.051 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/sql/query.py:1298(_add_q) 1601 0.003 0.000 0.004 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/fields/related.py:630(foreign_related_fields) 457 0.003 0.000 0.009 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/sql/query.py:1457(setup_joins) 7356/7350 0.002 0.000 0.003 0.000 {built-in method builtins.getattr} 2566 0.002 0.000 0.004 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/sql/compiler.py:383(quote_name_unless_alias) 1 0.002 0.002 0.002 0.002 {built-in method psycopg2._psycopg._connect} 202 0.002 0.000 0.047 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/sql/compiler.py:464(as_sql) 202 0.002 0.000 0.008 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/sql/compiler.py:626(get_default_columns) 202 0.002 0.000 0.016 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/sql/compiler.py:191(get_select) 457 0.002 0.000 0.003 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/sql/query.py:1559(trim_joins) 800 0.002 0.000 0.005 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/fields/related.py:698(get_path_info) ``` after ``` 94971 function calls (91741 primitive calls) in 0.109 seconds Ordered by: internal time List reduced from 565 to 20 due to restriction &lt;20&gt; ncalls tottime percall cumtime percall filename:lineno(function) 5 0.030 0.006 0.030 0.006 {method 'execute' of 'psycopg2.extensions.cursor' objects} 556 0.005 0.000 0.006 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/base.py:401(__init__) 1666 0.003 0.000 0.004 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/fields/related.py:630(foreign_related_fields) 506 0.002 0.000 0.003 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/base.py:510(&lt;listcomp&gt;) 160 0.002 0.000 0.024 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/sql/query.py:1154(build_filter) 556 0.002 0.000 0.011 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/base.py:505(from_db) 556 0.002 0.000 0.002 0.000 /usr/local/lib/python3.7/uuid.py:121(__init__) 561 0.002 0.000 0.054 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/query.py:49(__iter__) 7349 0.002 0.000 0.002 0.000 {built-in method builtins.hasattr} 8271 0.002 0.000 0.002 0.000 {built-in method builtins.isinstance} 322 0.002 0.000 0.004 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/sql/query.py:1361(names_to_path) 759 0.001 0.000 0.004 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/fields/related.py:698(get_path_info) 163 0.001 0.000 0.005 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/sql/query.py:1457(setup_joins) 150 0.001 0.000 0.033 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/fields/related_descriptors.py:566(_apply_rel_filters) 176 0.001 0.000 0.003 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/sql/query.py:299(clone) 160 0.001 0.000 0.029 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/sql/query.py:1298(_add_q) 163 0.001 0.000 0.002 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/sql/query.py:1559(trim_joins) 300 0.001 0.000 0.003 0.000 /usr/local/lib/python3.7/site-packages/django/db/models/fields/related_lookups.py:26(get_normalized_value) 50 0.001 0.000 0.008 0.000 /usr/local/lib/python3.7/site-packages/rest_framework/serializers.py:508(to_representation) 3114 0.001 0.000 0.003 0.000 {built-in method builtins.getattr} ```

:white_check_mark: All checks have passed

github 00:41:06

#500 slightly refactor statistics view function

• `doc_num` 沒用到 • 計算數量的命名最好前綴 `n_`

:white_check_mark: All checks have passed

github 15:03:28

*<https://github.com/Disfactory/Disfactory/compare/af9310bdc908...a67c9ab373d5|2 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/dad33614cfc13667e96271127737c243ce94eaf2|`dad33614`> - slightly refactor statistics view function <https://github.com/Disfactory/Disfactory/commit/a67c9ab373d5286c7cc038d6e754d5775981ef21|`a67c9ab3`> - Merge pull request #500 from Disfactory/refactor-statistics

github 15:04:20

*<https://github.com/Disfactory/Disfactory/compare/a67c9ab373d5...e94530c14b8c|2 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/8610764f4f9145119dbbcc7d6b3acf5252e437dc|`8610764f`> - use prefetch for query factories with serializer <https://github.com/Disfactory/Disfactory/commit/e94530c14b8c1eda250924b9cc28f977a29a8494|`e94530c1`> - Merge pull request #499 from Disfactory/faster-factory-query-with-prefetch

github 16:19:01

*<https://github.com/Disfactory/frontend/compare/4324d8592a5f...acaf68fe62fe|5 new commits> pushed to <https://github.com/Disfactory/frontend/tree/master|`master`>* <https://github.com/Disfactory/frontend/commit/62547459c3da2fb54c32d209bc50ad2732449647|`62547459`> - Impl parseHashParams <https://github.com/Disfactory/frontend/commit/05afbff84b54eb8bbef84f04b8309dd5101a8d36|`05afbff8`> - Share factory url with factoryId <https://github.com/Disfactory/frontend/commit/ef7c611577f9802b8e7121a71c3eb0c5d55210d5|`ef7c6115`> - Fix feature zoom error <https://github.com/Disfactory/frontend/commit/523b06d43ba45209db903816fa2e8cda9bf94991|`523b06d4`> - Limit #addFactories updateFactory hook to added ones <https://github.com/Disfactory/frontend/commit/acaf68fe62fea7c170b76d460a9758b9baf78a7a|`acaf68fe`> - Merge pull request #68 from Disfactory/feature/revise-share-factory-link

github 16:19:01

*<https://github.com/Disfactory/frontend/compare/4324d8592a5f...acaf68fe62fe|5 new commits> pushed to <https://github.com/Disfactory/frontend/tree/master|`master`>* <https://github.com/Disfactory/frontend/commit/62547459c3da2fb54c32d209bc50ad2732449647|`62547459`> - Impl parseHashParams <https://github.com/Disfactory/frontend/commit/05afbff84b54eb8bbef84f04b8309dd5101a8d36|`05afbff8`> - Share factory url with factoryId <https://github.com/Disfactory/frontend/commit/ef7c611577f9802b8e7121a71c3eb0c5d55210d5|`ef7c6115`> - Fix feature zoom error <https://github.com/Disfactory/frontend/commit/523b06d43ba45209db903816fa2e8cda9bf94991|`523b06d4`> - Limit #addFactories updateFactory hook to added ones <https://github.com/Disfactory/frontend/commit/acaf68fe62fea7c170b76d460a9758b9baf78a7a|`acaf68fe`> - Merge pull request #68 from Disfactory/feature/revise-share-factory-link

github 16:19:16

*<https://github.com/Disfactory/frontend/compare/acaf68fe62fe...09a71fc260b5|2 new commits> pushed to <https://github.com/Disfactory/frontend/tree/master|`master`>* <https://github.com/Disfactory/frontend/commit/f7da19b1afe5a95e2844e350d6835e21b202b562|`f7da19b1`> - Enable attribution control <https://github.com/Disfactory/frontend/commit/09a71fc260b56071e3e33adbeaf72fe58777bf9a|`09a71fc2`> - Merge pull request #71 from Disfactory/feature/map-attributions

github 16:19:16

*<https://github.com/Disfactory/frontend/compare/acaf68fe62fe...09a71fc260b5|2 new commits> pushed to <https://github.com/Disfactory/frontend/tree/master|`master`>* <https://github.com/Disfactory/frontend/commit/f7da19b1afe5a95e2844e350d6835e21b202b562|`f7da19b1`> - Enable attribution control <https://github.com/Disfactory/frontend/commit/09a71fc260b56071e3e33adbeaf72fe58777bf9a|`09a71fc2`> - Merge pull request #71 from Disfactory/feature/map-attributions

github 16:24:16

Successfully deployed <https://github.com/Disfactory/frontend/commit/00cdc8275fc5870b2d9d88fc510f382d6ee5cfd9|`00cdc82`> to github-pages

github 16:24:16

Successfully deployed <https://github.com/Disfactory/frontend/commit/00cdc8275fc5870b2d9d88fc510f382d6ee5cfd9|`00cdc82`> to github-pages

github 16:24:36

Successfully deployed <https://github.com/Disfactory/frontend/commit/7d47275f2b3837d10a1ea642521006e46c35dce3|`7d47275`> to github-pages

github 16:24:36

Successfully deployed <https://github.com/Disfactory/frontend/commit/7d47275f2b3837d10a1ea642521006e46c35dce3|`7d47275`> to github-pages

ael 16:31:05
@yukai ++
github 16:37:15

Successfully deployed <https://github.com/Disfactory/frontend/commit/d4da504aa03b2aab096d41b5ef9c6059757d7d5f|`d4da504`> to github-pages

github 16:37:15

Successfully deployed <https://github.com/Disfactory/frontend/commit/d4da504aa03b2aab096d41b5ef9c6059757d7d5f|`d4da504`> to github-pages

github 16:37:34

Successfully deployed <https://github.com/Disfactory/frontend/commit/a680d92c84418c56e0c62d3d9aa9e4d999aec6a8|`a680d92`> to github-pages

github 16:37:34

Successfully deployed <https://github.com/Disfactory/frontend/commit/a680d92c84418c56e0c62d3d9aa9e4d999aec6a8|`a680d92`> to github-pages

github 16:46:23

#72 Production deploy

*Features* • Image lightbox • Share factory link *Enhancements* • Factory pin zIndex • Map attributes (OSM mark) • Unit test arch

github 16:46:23

#72 Production deploy

*Features* • Image lightbox • Share factory link *Enhancements* • Factory pin zIndex • Map attributes (OSM mark) • Unit test arch

:white_check_mark: 12 other checks have passed

github 16:59:59

*<https://github.com/Disfactory/disfactory.tw/compare/bca355fef985...ed1fdb47083f|1 new commit> pushed to <https://github.com/Disfactory/disfactory.tw/tree/gh-pages|`gh-pages`>* <https://github.com/Disfactory/disfactory.tw/commit/ed1fdb47083f90d75a16fa988827c8b7af51c3ae|`ed1fdb47`> - Deploy [ci skip]

github 17:00:16

Successfully deployed <https://github.com/Disfactory/disfactory.tw/commit/ed1fdb47083f90d75a16fa988827c8b7af51c3ae|`ed1fdb4`> to github-pages

2021-02-17

github 10:39:43

#501 某factory單一工廠資訊頁中,image沒跑出來

*Describe the bug* 在Factory object (e0603dad-0bd3-4993-973d-e0825d6d234d)中,回報者上傳的照片沒有顯示在其中 但拿這個factoryID去Image的table找,找得到有照片(Image object (c578bb70-2801-48e2-9291-ce039099d1c8)) *Screenshots* <https://user-images.githubusercontent.com/60970217/108148620-2d63e600-710c-11eb-9315-140c763d8c29.png|截圖 2021-02-17 上午10 37 42>

github 14:29:49

#502 document table: 台中市的cet staff欄出不來

*Describe the bug* 在document的table,台中市的cet staff都沒跑出來 *Screenshots* <https://user-images.githubusercontent.com/60970217/108164682-3369bf00-712c-11eb-87f1-9e854dd9c4e7.png|截圖 2021-02-17 下午2 26 55> *Addition Context* 在猜可能是台/臺問題

github 14:48:25

#503 document table:「輸出docx」出現502

*Describe the bug* 目前在document table無法「輸出docx」,會出現「Bad Gateway 502」的圖樣 *To Reproduce* 1. 勾選110004 ~ 110041的document 2. 選擇「輸出成docx」的action 3. 點「Go 」 *Desktop (please complete the following information):* • OS: macOS Catalina • Browser: chrome • Version: 88.0.4324.150 *Additional context* 已測試跳過沒有townname、cet_staff的document,依舊無法輸出

2021-02-24

github 20:22:02

#504 修正 cet staff 所負責的縣市名稱,臺中縣應該改為臺中市 (fix #502)

Fixed <https://github.com/Disfactory/Disfactory/issues/502|#502> 修正 cet staff 所負責的縣市名稱,臺中縣應該改為臺中市

github 20:30:16

*<https://github.com/Disfactory/Disfactory/compare/e94530c14b8c...dbdc60f88b1f|2 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/eab8f7ece5fe8863a38171222b70887d52e4c07e|`eab8f7ec`> - Replace 台中縣 with 台中市 (fix #502) <https://github.com/Disfactory/Disfactory/commit/dbdc60f88b1ff236669222789a5836aee68eb61a|`dbdc60f8`> - Merge pull request #504 from Swind/fix_502

github 20:51:04

*<https://github.com/Disfactory/findTaiwanLegislator/compare/1b323d98c78d...6e694021234b|2 new commits> pushed to <https://github.com/Disfactory/findTaiwanLegislator/tree/master|`master`>* <https://github.com/Disfactory/findTaiwanLegislator/commit/7761464d3ee0947f82df8989cf9a4705927a91be|`7761464d`> - Add result cache <https://github.com/Disfactory/findTaiwanLegislator/commit/6e694021234b88a5e01d69586f5aed8afc3d5938|`6e694021`> - Fix docs code style

github 20:51:17

Successfully deployed <https://github.com/Disfactory/findTaiwanLegislator/commit/6e694021234b88a5e01d69586f5aed8afc3d5938|`6e69402`> to github-pages

yukai 20:53:59
@yukai set the channel topic: Disfactory 的 GitHub 通知頻道,主頻道請往這邊走 → #disfactory
github 20:57:43

*<https://github.com/Disfactory/findTaiwanLegislator/compare/6e694021234b...a50b1fb9abda|1 new commit> pushed to <https://github.com/Disfactory/findTaiwanLegislator/tree/master|`master`>* <https://github.com/Disfactory/findTaiwanLegislator/commit/a50b1fb9abda12da15a3877bf59b0f756df17266|`a50b1fb9`> - Fix demo page

github 20:57:54

Successfully deployed <https://github.com/Disfactory/findTaiwanLegislator/commit/a50b1fb9abda12da15a3877bf59b0f756df17266|`a50b1fb`> to github-pages

github 21:10:28

#73 Use openlayer Clustered Features

<https://openlayers.org/en/latest/examples/cluster.html|https://openlayers.org/en/latest/examples/cluster.html> <https://user-images.githubusercontent.com/4230968/70860603-b3abf780-1f5e-11ea-97b1-5cb0f1045fdb.png|Screen Shot 2019-12-15 at 5 16 19 PM>

github 21:10:28

#73 Use openlayer Clustered Features

<https://openlayers.org/en/latest/examples/cluster.html|https://openlayers.org/en/latest/examples/cluster.html> <https://user-images.githubusercontent.com/4230968/70860603-b3abf780-1f5e-11ea-97b1-5cb0f1045fdb.png|Screen Shot 2019-12-15 at 5 16 19 PM>

github 21:24:40

#74 抽出語言檔字串到 YAML

方便編輯文字

github 21:24:40

#74 抽出語言檔字串到 YAML

方便編輯文字

github 21:25:33

#75 上傳的照片有時不會擺正

*Describe the bug* 如果手機橫著拍照,有時候上傳照片顯示的縮圖是旋轉 90 度的 *To Reproduce* Steps to reproduce the behavior: 1. 「新增」工廠照片 2. 將手機橫著拍照 3. 「上傳照片」 4. 有時候會旋轉 90 度 *Expected behavior* 自動擺正 *Screenshots* <https://user-images.githubusercontent.com/9480974/71483268-f82e7180-2841-11ea-9c5a-12bff7f44470.png|圖片> *Smartphone (please complete the following information):* • Device: unclear • OS: Android • Browser Chrome • Version: unclear *Additional context* 推測是沒有讀 EXIF?

github 21:25:33

#75 上傳的照片有時不會擺正

*Describe the bug* 如果手機橫著拍照,有時候上傳照片顯示的縮圖是旋轉 90 度的 *To Reproduce* Steps to reproduce the behavior: 1. 「新增」工廠照片 2. 將手機橫著拍照 3. 「上傳照片」 4. 有時候會旋轉 90 度 *Expected behavior* 自動擺正 *Screenshots* <https://user-images.githubusercontent.com/9480974/71483268-f82e7180-2841-11ea-9c5a-12bff7f44470.png|圖片> *Smartphone (please complete the following information):* • Device: unclear • OS: Android • Browser Chrome • Version: unclear *Additional context* 推測是沒有讀 EXIF?

github 21:28:27

#77 四塊均需 hover message

如 "T" 不敢按,因不知是什麼功能。 <https://user-images.githubusercontent.com/1230959/84601597-eefa9500-aeb3-11ea-86df-f22e9c946a70.jpg|3453-0> 故四塊均需 hoverover message saying what they do, e.g., 放大,縮小…

github 21:28:27

#77 四塊均需 hover message

如 "T" 不敢按,因不知是什麼功能。 <https://user-images.githubusercontent.com/1230959/84601597-eefa9500-aeb3-11ea-86df-f22e9c946a70.jpg|3453-0> 故四塊均需 hoverover message saying what they do, e.g., 放大,縮小…

github 21:39:04

#78 Upgrade openlayer package

☐ 看目前版本 openlayer 到最新版 Release note 有什麼 breaking change,並在 codebase 中檢查 API ☐ 在電腦版測試地圖功能(建立工廠、瀏覽工廠、更新工廠) ☐ 手機版測試地圖功能

github 21:40:16

#505 refactor: remove gis

*Summary* • 把使用 gis 相關ㄉ慢慢拿掉

:white_check_mark: All checks have passed

2021-02-25

github 01:05:54

*<https://github.com/Disfactory/about.disfactory.tw/compare/dd8a01f6c886...d32bc7043c88|2 new commits> pushed to <https://github.com/Disfactory/about.disfactory.tw/tree/master|`master`>* <https://github.com/Disfactory/about.disfactory.tw/commit/8e905d1363e82f291de69e145b2b6de64bdd13b0|`8e905d13`> - ci: modify the GitHub Actions <https://github.com/Disfactory/about.disfactory.tw/commit/d32bc7043c88cadf1dfef6c5de83cc17cec9cd8d|`d32bc704`> - ci: do not commit when there is no change

github 01:11:01

*<https://github.com/Disfactory/about.disfactory.tw/compare/d32bc7043c88...babe30c438cf|3 new commits> force-pushed to <https://github.com/Disfactory/about.disfactory.tw/tree/master|`master`>* <https://github.com/Disfactory/about.disfactory.tw/commit/dcf2f8e6b09cdc0ee8fa265225f6389942d3683d|`dcf2f8e6`> - fix: run ci <https://github.com/Disfactory/about.disfactory.tw/commit/e58459b9a6850364a0bdfe0554d907bde52a3290|`e58459b9`> - ci: modify the GitHub Actions <https://github.com/Disfactory/about.disfactory.tw/commit/babe30c438cfd0af3e39cc3ae29ff92a93167c14|`babe30c4`> - ci: do not commit when there is no change

github 01:14:20

*<https://github.com/Disfactory/about.disfactory.tw/compare/babe30c438cf...d32bc7043c88|5 new commits> force-pushed to <https://github.com/Disfactory/about.disfactory.tw/tree/master|`master`>* <https://github.com/Disfactory/about.disfactory.tw/commit/d9462f50b36538a41ad7c8c4f6b51565653465e2|`d9462f50`> - ci: commit a change when the OG images &amp; og-imgs-cache.json are updated <https://github.com/Disfactory/about.disfactory.tw/commit/eee438bbd6fe781fbee89997c2fe27be264a5792|`eee438bb`> - feat: add the initial OG images &amp; their cache <https://github.com/Disfactory/about.disfactory.tw/commit/dd8a01f6c886b4596163e3f74e2cc5094529b610|`dd8a01f6`> - fix: run ci <https://github.com/Disfactory/about.disfactory.tw/commit/8e905d1363e82f291de69e145b2b6de64bdd13b0|`8e905d13`> - ci: modify the GitHub Actions <https://github.com/Disfactory/about.disfactory.tw/commit/d32bc7043c88cadf1dfef6c5de83cc17cec9cd8d|`d32bc704`> - ci: do not commit when there is no change

github 02:04:12

*<https://github.com/Disfactory/about.disfactory.tw/compare/d32bc7043c88...460416547ad0|1 new commit> pushed to <https://github.com/Disfactory/about.disfactory.tw/tree/master|`master`>* <https://github.com/Disfactory/about.disfactory.tw/commit/460416547ad072cb679f771e2308e1c9c74a7cc2|`46041654`> - fix: generate the correct OG urls &amp; images

github 02:09:03

Successfully deployed <https://github.com/Disfactory/about.disfactory.tw/commit/3a7426c4f6469bfe7b795aab413784b56d0c2128|`3a7426c`> to github-pages

github 02:26:42

Successfully deployed <https://github.com/Disfactory/about.disfactory.tw/commit/7a2472d3a44339b1610c4caafd62ca2388f23273|`7a2472d`> to github-pages

github 03:03:39