Slack archive

disfactory-notification

Month: 2020-12

2020-12-01

github 18:40:34

#455 Add townname/secname/seccode to factory serializer

:white_check_mark: 2 other checks have passed

2020-12-02

github 10:53:47

*<https://github.com/Disfactory/frontend/compare/a5c6ecfea391...6c9540f4c1ac|1 new commit> pushed to <https://github.com/Disfactory/frontend/tree/master|`master`>* <https://github.com/Disfactory/frontend/commit/6c9540f4c1acee1a16fd0978b0cb42eaf756d997|`6c9540f4`> - Hide towninfo temporarily

github 10:53:47

*<https://github.com/Disfactory/frontend/compare/a5c6ecfea391...6c9540f4c1ac|1 new commit> pushed to <https://github.com/Disfactory/frontend/tree/master|`master`>* <https://github.com/Disfactory/frontend/commit/6c9540f4c1acee1a16fd0978b0cb42eaf756d997|`6c9540f4`> - Hide towninfo temporarily

github 10:58:12

Successfully deployed <https://github.com/Disfactory/frontend/commit/d2ba7f601d8bdcc1935ede62e7b846ccb4a8abea|`d2ba7f6`> to github-pages

github 10:58:13

Successfully deployed <https://github.com/Disfactory/frontend/commit/d2ba7f601d8bdcc1935ede62e7b846ccb4a8abea|`d2ba7f6`> to github-pages

github 10:58:32

Successfully deployed <https://github.com/Disfactory/frontend/commit/6d62d7609ddd00211251ebcfc48c1c440aeddcaf|`6d62d76`> to github-pages

github 10:58:32

Successfully deployed <https://github.com/Disfactory/frontend/commit/6d62d7609ddd00211251ebcfc48c1c440aeddcaf|`6d62d76`> to github-pages

github 10:58:59

*<https://github.com/Disfactory/disfactory.tw/compare/2247e8f5b717...00e83efe26c6|1 new commit> pushed to <https://github.com/Disfactory/disfactory.tw/tree/gh-pages|`gh-pages`>* <https://github.com/Disfactory/disfactory.tw/commit/00e83efe26c60f79ba09be8535e5ddac0996657e|`00e83efe`> - Deploy [ci skip]

github 10:59:12

Successfully deployed <https://github.com/Disfactory/disfactory.tw/commit/00e83efe26c60f79ba09be8535e5ddac0996657e|`00e83ef`> to github-pages

2020-12-04

github 12:06:46

*<https://github.com/Disfactory/frontend/compare/6c9540f4c1ac...3991610fdde2|1 new commit> pushed to <https://github.com/Disfactory/frontend/tree/master|`master`>* <https://github.com/Disfactory/frontend/commit/3991610fdde24cc54f6ce5969b865666b5b1c560|`3991610f`> - Update tutorial image

github 12:06:47

*<https://github.com/Disfactory/frontend/compare/6c9540f4c1ac...3991610fdde2|1 new commit> pushed to <https://github.com/Disfactory/frontend/tree/master|`master`>* <https://github.com/Disfactory/frontend/commit/3991610fdde24cc54f6ce5969b865666b5b1c560|`3991610f`> - Update tutorial image

github 12:11:04

*<https://github.com/Disfactory/disfactory.tw/compare/00e83efe26c6...62a029fc9539|1 new commit> pushed to <https://github.com/Disfactory/disfactory.tw/tree/gh-pages|`gh-pages`>* <https://github.com/Disfactory/disfactory.tw/commit/62a029fc9539e00f06f4ba6e0b40b25600e01516|`62a029fc`> - Deploy [ci skip]

github 12:11:15

Successfully deployed <https://github.com/Disfactory/disfactory.tw/commit/62a029fc9539e00f06f4ba6e0b40b25600e01516|`62a029f`> to github-pages

github 12:11:20

Successfully deployed <https://github.com/Disfactory/frontend/commit/9da8342cbe30174ecb12e3704b29d54f9377f5be|`9da8342`> to github-pages

github 12:11:20

Successfully deployed <https://github.com/Disfactory/frontend/commit/9da8342cbe30174ecb12e3704b29d54f9377f5be|`9da8342`> to github-pages

github 12:11:40

Successfully deployed <https://github.com/Disfactory/frontend/commit/59a3ba334cda4a4781fecdf9098d971e31e6505c|`59a3ba3`> to github-pages

github 12:11:40

Successfully deployed <https://github.com/Disfactory/frontend/commit/59a3ba334cda4a4781fecdf9098d971e31e6505c|`59a3ba3`> to github-pages

2020-12-08

github 15:09:04

#58 「補充照片」桌機版希望直接顯示

�目前是點開pin之後，照片欄那邊看到的都是已上傳的照片，但沅諭上次想新增照片，卻找不到在哪裏。經過我指點才知道要拉到最右邊。 <https://user-images.githubusercontent.com/60970217/101449491-d8fdf680-3963-11eb-86f8-69257913200e.png|MicrosoftTeams-image> <https://user-images.githubusercontent.com/60970217/101449469-d1d6e880-3963-11eb-9100-84fdd106a8fb.png|MicrosoftTeams-image (1)> 希望可以讓新增照片的圖示為預設出現（放到整個照片欄最左邊）

github 15:09:04

#58 「補充照片」桌機版希望直接顯示

�目前是點開pin之後，照片欄那邊看到的都是已上傳的照片，但沅諭上次想新增照片，卻找不到在哪裏。經過我指點才知道要拉到最右邊。 <https://user-images.githubusercontent.com/60970217/101449491-d8fdf680-3963-11eb-86f8-69257913200e.png|MicrosoftTeams-image> <https://user-images.githubusercontent.com/60970217/101449469-d1d6e880-3963-11eb-9100-84fdd106a8fb.png|MicrosoftTeams-image (1)> 希望可以讓新增照片的圖示為預設出現（放到整個照片欄最左邊）

2020-12-09

github 17:26:59

#456 「分享」網址進入後的畫面

*Is your feature request related to a problem? Please describe.* 從別人分享的連結進入之後，看起來只是進入了回報系統，不知道是哪一個 <https://cettw-my.sharepoint.com/:v:/g/personal/pisces_cet-taiwan_org/EaHG3YLOjEZLp89MrSw93b4BsNOaTGvNfWtKk4mOD9Amjw?e=Ggh8xa|問題螢幕錄影> *Describe the solution you'd like* ☐ 透過經緯度進入網站之後可以自動展開pin *Describe alternatives you've considered* ☐ 分享時可以自動抓該點有上傳的照片的縮圖，顯示在社群網站上

github 17:41:25

#457 輸出的公文，地段名稱未出現

*Describe the bug* 生成公文後地段名稱沒有出現 *To Reproduce* 在document頁面，勾任一公文，按下「輸出成docx檔」go *Expected behavior* 地段名稱依序為 [地段名]（[段號]） [地號] 地號 以這個為例是 白鷺段（1005）817地號 *Screenshots* <https://user-images.githubusercontent.com/60970217/101612029-2736f680-3a45-11eb-956e-1f3500591a2c.png|截圖 2020-12-09 下午5 35 56>

github 18:07:55

#458 修正輸出的公文，地段名稱未出現的問題 #457

在輸出 docx 檔的時候，完整的工廠位置名稱應該是 `&lt;factory.townname&gt;&lt;factory.sectname&gt; (&lt;factory.sectcode&gt;) &lt;factory.landcode&gt; 地號` e.g. `新北市雙溪區牡丹里武丹坑段五分小段 (<tel:1481)00180000|1481) 00180000> 地號` 其中 `武丹坑段五分小段` 就是之前漏掉沒有加上的地段名稱

:white_check_mark: All checks have passed

github 18:18:24

#459 省轄市「正本受文者」顯示名稱要改成縣市

*Describe the bug* 現在輸出的公文，正本受文者是「台灣省政府」 *Expected behavior* 把「台灣省政府」變成「ＸＸ縣政府」or「XX市政府」 *Screenshots* <https://user-images.githubusercontent.com/60970217/101616905-e4781d00-3a4a-11eb-8e0e-961049a142df.png|截圖 2020-12-09 下午6 12 25>

github 20:16:56

#460 後台經緯度修改後，地段號沒有隨之改變

*Is your feature request related to a problem? Please describe.* 因為有時候會有回報者標錯地點，deeper會在後台手動修改經緯度 但地段地號沒有隨之改變，會讓公文上的錯誤錯誤 *Describe the solution you'd like* 後台經緯度修改後，地段地號重抓一次 *Describe alternatives you've considered* 自己手動修改

github 20:27:16

#461 在factory後台中無法新增照片

*Is your feature request related to a problem? Please describe.* 因為審查過程可能會想幫該點新增google街景的截圖，所以想要上傳圖片。 但目前「add another image」是壞掉的，所以無法上傳 <https://user-images.githubusercontent.com/60970217/101629761-c74c4a00-3a5c-11eb-8882-43a7e11f1707.png|截圖 2020-12-09 下午8 26 05> *Describe the solution you'd like* 讓add another image運作 *Describe alternatives you've considered* 有個連回disfactory.tw該點位的連結

github 20:34:49

#462 document無法刪除

*Is your feature request related to a problem? Please describe.* 發現有針對重複案件的公文，需要把公文刪除，以免未來計算檢舉數量（和各縣市已/未處理數量）時有錯。 *Describe the solution you'd like* 可以刪除公文

github 20:35:24

#59 Fix #58 Detail page add photo place at first

Fix <https://github.com/Disfactory/frontend/issues/58|#58> Detail page add photo place at first

github 20:35:24

#59 Fix #58 Detail page add photo place at first

Fix <https://github.com/Disfactory/frontend/issues/58|#58> Detail page add photo place at first

:white_check_mark: 7 other checks have passed

github 20:42:45

*<https://github.com/Disfactory/frontend/compare/3991610fdde2...22df964f15ee|2 new commits> pushed to <https://github.com/Disfactory/frontend/tree/master|`master`>* <https://github.com/Disfactory/frontend/commit/b264a8cabd95ea575db2de97a8089b4c82ce739e|`b264a8ca`> - [Fix] Detail page add photo place at first <https://github.com/Disfactory/frontend/commit/22df964f15ee758df8e0c80cb3a9e265af23da79|`22df964f`> - Merge pull request #59 from Disfactory/fix/detailPage

github 20:42:45

*<https://github.com/Disfactory/frontend/compare/3991610fdde2...22df964f15ee|2 new commits> pushed to <https://github.com/Disfactory/frontend/tree/master|`master`>* <https://github.com/Disfactory/frontend/commit/b264a8cabd95ea575db2de97a8089b4c82ce739e|`b264a8ca`> - [Fix] Detail page add photo place at first <https://github.com/Disfactory/frontend/commit/22df964f15ee758df8e0c80cb3a9e265af23da79|`22df964f`> - Merge pull request #59 from Disfactory/fix/detailPage

github 20:43:57

#463 後台輸出各縣市各display status的數量

*Is your feature request related to a problem? Please describe.* 每個月地公會發月報告知大家各縣市進度，所以需要輸出這個數量 *Describe the solution you'd like* 可以輸出一個csv，以縣市為經，以display status為緯， <https://user-images.githubusercontent.com/60970217/101631353-2a3ee080-3a5f-11eb-955a-94a13ae8af17.png|截圖 2020-12-09 下午8 43 02> *Describe alternatives you've considered* 自己一個一個算QQ

github 20:47:06

Successfully deployed <https://github.com/Disfactory/frontend/commit/d5e2320030a75c89301245cc29741129b6f81720|`d5e2320`> to github-pages

github 20:47:06

Successfully deployed <https://github.com/Disfactory/frontend/commit/d5e2320030a75c89301245cc29741129b6f81720|`d5e2320`> to github-pages

github 20:47:25

Successfully deployed <https://github.com/Disfactory/frontend/commit/77f141f0f9cce7000eb4174214ab97b9f05ea500|`77f141f`> to github-pages

github 20:47:25

Successfully deployed <https://github.com/Disfactory/frontend/commit/77f141f0f9cce7000eb4174214ab97b9f05ea500|`77f141f`> to github-pages

github 20:54:58

#464 後台輸出回報總數量

*Is your feature request related to a problem? Please describe.* 想知道每個月份各縣市回報的數量 *Describe the solution you'd like* 輸出一個csv，以縣市為經，以數量為緯 <https://user-images.githubusercontent.com/60970217/101632783-522f4380-3a61-11eb-8bb9-227c0cab8eb4.png|截圖 2020-12-09 下午8 58 21> *Alternative* 等待我們的dashboard出來XD

github 22:26:50

#465 後台經緯度修改後，重新從 easymap 取得地段資訊 Fixed #460

後台經緯度修改後，重新從 easymap 取得地段資訊 Fixed <https://github.com/Disfactory/Disfactory/issues/460|#460>

:white_check_mark: All checks have passed

github 22:32:22

#466 公文聯絡電子信箱沒有隨名字更改

*Describe the bug* 公文聯絡電子信箱沒有隨名字更改 *Expected behavior* deeper的信箱 <mailto:pisces@cet-taiwan.org|pisces@cet-taiwan.org> 沅諭的信箱 <mailto:eva@cet-taiwan.org|eva@cet-taiwan.org> *screenshots* <https://user-images.githubusercontent.com/60970217/101642806-62015480-3a6e-11eb-96c6-abf850db9dcc.png|截圖 2020-12-09 下午10 32 10>

2020-12-12

github 16:26:33

#7 Bump ini from 1.3.5 to 1.3.8

Bumps <https://github.com/isaacs/ini|ini> from 1.3.5 to 1.3.8. Commits • <https://github.com/npm/ini/commit/a2c5da86604bc2238fe393c5ff083bf23a9910eb|`a2c5da8`> 1.3.8 • <https://github.com/npm/ini/commit/af5c6bb5dca6f0248c153aa87e25bddfc515ff6e|`af5c6bb`> Do not use Object.create(null) • <https://github.com/npm/ini/commit/8b648a1ac49e1b3b7686ea957e0b95e544bc6ec1|`8b648a1`> don't test where our devdeps don't even work • <https://github.com/npm/ini/commit/c74c8af35f32b801a7e82a8309eab792a95932f6|`c74c8af`> 1.3.7 • <https://github.com/npm/ini/commit/024b8b55ac1c980c6225607b007714c54eb501ba|`024b8b5`> update deps, add linting • <https://github.com/npm/ini/commit/032fbaf5f0b98fce70c8cc380e0d05177a9c9073|`032fbaf`> Use Object.create(null) to avoid default object property hazards • <https://github.com/npm/ini/commit/2da90391ef70db41d10f013e3a87f9a8c5d01a72|`2da9039`> 1.3.6 • <https://github.com/npm/ini/commit/cfea636f534b5ca7550d2c28b7d1a95d936d56c6|`cfea636`> better git push script, before publish instead of after • <https://github.com/npm/ini/commit/56d2805e07ccd94e2ba0984ac9240ff02d44b6f1|`56d2805`> do not allow invalid hazardous string as section name • See full diff in <https://github.com/isaacs/ini/compare/v1.3.5...v1.3.8|compare view> Maintainer changes This version was pushed to npm by <https://www.npmjs.com/~isaacs|isaacs>, a new releaser for ini since your current version. <https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores|Dependabot compatibility score> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. * * * Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: • `@dependabot rebase` will rebase this PR • `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it • `@dependabot merge` will merge this PR after your CI passes on it • `@dependabot squash and merge` will squash and merge this PR after your CI passes on it • `@dependabot cancel merge` will cancel a previously requested merge and block automerging • `@dependabot reopen` will reopen this PR if it is closed • `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually • `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) • `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) • `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) • `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language • `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language • `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language • `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the <https://github.com/Disfactory/about.disfactory.tw/network/alerts|Security Alerts page>.

2020-12-13

github 05:42:22

#8 chore(deps): bump ini from 1.3.5 to 1.3.8

Bumps <https://github.com/isaacs/ini|ini> from 1.3.5 to 1.3.8. Commits • <https://github.com/npm/ini/commit/a2c5da86604bc2238fe393c5ff083bf23a9910eb|`a2c5da8`> 1.3.8 • <https://github.com/npm/ini/commit/af5c6bb5dca6f0248c153aa87e25bddfc515ff6e|`af5c6bb`> Do not use Object.create(null) • <https://github.com/npm/ini/commit/8b648a1ac49e1b3b7686ea957e0b95e544bc6ec1|`8b648a1`> don't test where our devdeps don't even work • <https://github.com/npm/ini/commit/c74c8af35f32b801a7e82a8309eab792a95932f6|`c74c8af`> 1.3.7 • <https://github.com/npm/ini/commit/024b8b55ac1c980c6225607b007714c54eb501ba|`024b8b5`> update deps, add linting • <https://github.com/npm/ini/commit/032fbaf5f0b98fce70c8cc380e0d05177a9c9073|`032fbaf`> Use Object.create(null) to avoid default object property hazards • <https://github.com/npm/ini/commit/2da90391ef70db41d10f013e3a87f9a8c5d01a72|`2da9039`> 1.3.6 • <https://github.com/npm/ini/commit/cfea636f534b5ca7550d2c28b7d1a95d936d56c6|`cfea636`> better git push script, before publish instead of after • <https://github.com/npm/ini/commit/56d2805e07ccd94e2ba0984ac9240ff02d44b6f1|`56d2805`> do not allow invalid hazardous string as section name • See full diff in <https://github.com/isaacs/ini/compare/v1.3.5...v1.3.8|compare view> Maintainer changes This version was pushed to npm by <https://www.npmjs.com/~isaacs|isaacs>, a new releaser for ini since your current version. <https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores|Dependabot compatibility score> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. * * * Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: • `@dependabot rebase` will rebase this PR • `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it • `@dependabot merge` will merge this PR after your CI passes on it • `@dependabot squash and merge` will squash and merge this PR after your CI passes on it • `@dependabot cancel merge` will cancel a previously requested merge and block automerging • `@dependabot reopen` will reopen this PR if it is closed • `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually • `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) • `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) • `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) • `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language • `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language • `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language • `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the <https://github.com/Disfactory/license.disfactory.tw/network/alerts|Security Alerts page>.

2020-12-16

github 19:42:23

*<https://github.com/Disfactory/Disfactory/compare/51292f620d03...1c6025c20102|2 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/6b77ec09a6d15788ed30c5d7f1dc570013951463|`6b77ec09`> - Add townname/sectname/sectcode to factory serializer <https://github.com/Disfactory/Disfactory/commit/1c6025c201023cbda78a4d6b898e01d196905b55|`1c6025c2`> - Merge pull request #455 from Disfactory/feature/more-address-field-for-factory

github 19:43:10

*<https://github.com/Disfactory/Disfactory/compare/1c6025c20102...71a5e16e1ec7|3 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/239a4ec4fbe756adb3485ac47f80caaf144d9bf7|`239a4ec4`> - Add factory.sectname to docx title. (fixed #457) <https://github.com/Disfactory/Disfactory/commit/c35fdf56cc9071ede33755dc5d164ff3a6fea4a2|`c35fdf56`> - Remove 台灣省 or 臺灣省 from townname when generating docx <https://github.com/Disfactory/Disfactory/commit/71a5e16e1ec7e9e03b3c7e731026185981e8bd45|`71a5e16e`> - Merge pull request #458 from Disfactory/fix_457

github 19:43:55

*<https://github.com/Disfactory/Disfactory/compare/71a5e16e1ec7...17195a12bfa8|2 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/2d4b33c04af69d323fcf5394117a66391bf8d79c|`2d4b33c0`> - fixed #460 update landinfo when updating factory model <https://github.com/Disfactory/Disfactory/commit/17195a12bfa8ebfc11b5634e47c7c8bb29329afa|`17195a12`> - Merge pull request #465 from Disfactory/fix_460

github 20:22:25

#60 Add landcode to factory detail

<https://user-images.githubusercontent.com/4230968/102348200-80220400-3fdc-11eb-9d60-c2630cfa32d5.png|Screen Shot 2020-12-16 at 8 17 54 PM>

:white_check_mark: 7 other checks have passed

github 20:43:19

*<https://github.com/Disfactory/frontend/compare/22df964f15ee...357a9b358e56|3 new commits> pushed to <https://github.com/Disfactory/frontend/tree/master|`master`>* <https://github.com/Disfactory/frontend/commit/4473b3b36d98b39607e7382c8a7e976d9067a150|`4473b3b3`> - Add landcode to factory detail <https://github.com/Disfactory/frontend/commit/db880ff7599e8e6d37d8dc396cbe2f7278db2523|`db880ff7`> - Fix default value for landcode <https://github.com/Disfactory/frontend/commit/357a9b358e56688e8fef2d716fb2c0f587b9a9f9|`357a9b35`> - Merge pull request #60 from Disfactory/feature/add-landcode-to-detail-page

github 20:43:19

*<https://github.com/Disfactory/frontend/compare/22df964f15ee...357a9b358e56|3 new commits> pushed to <https://github.com/Disfactory/frontend/tree/master|`master`>* <https://github.com/Disfactory/frontend/commit/4473b3b36d98b39607e7382c8a7e976d9067a150|`4473b3b3`> - Add landcode to factory detail <https://github.com/Disfactory/frontend/commit/db880ff7599e8e6d37d8dc396cbe2f7278db2523|`db880ff7`> - Fix default value for landcode <https://github.com/Disfactory/frontend/commit/357a9b358e56688e8fef2d716fb2c0f587b9a9f9|`357a9b35`> - Merge pull request #60 from Disfactory/feature/add-landcode-to-detail-page

github 20:47:47

Successfully deployed <https://github.com/Disfactory/frontend/commit/c05259894655396731b1f21a9a58ce6175ff8812|`c052598`> to github-pages

github 20:47:47

Successfully deployed <https://github.com/Disfactory/frontend/commit/c05259894655396731b1f21a9a58ce6175ff8812|`c052598`> to github-pages

github 20:48:09

Successfully deployed <https://github.com/Disfactory/frontend/commit/d1b4f45d235152c33c3dfd7a7d0878b5d287cc43|`d1b4f45`> to github-pages

github 20:48:10

Successfully deployed <https://github.com/Disfactory/frontend/commit/d1b4f45d235152c33c3dfd7a7d0878b5d287cc43|`d1b4f45`> to github-pages

github 20:51:57

#467 feat: add disfactory map link in admin factory page

close <https://github.com/Disfactory/Disfactory/issues/461|#461> *Summary* • 完成替代方案： "有個連回disfactory.tw該點位的連結" <https://user-images.githubusercontent.com/11289529/102350772-65ea2500-3fe0-11eb-8c63-c4f43c834ac0.gif|Peek 2020-12-16 20-50>

:white_check_mark: All checks have passed

我愛 @f46284628
LittleWhiteYA 2020-12-17 21:31:53
XDDDDD

2020-12-17

2020-12-25

github 11:43:23

#468 document搜尋需要query段名、公文號

*Is your feature request related to a problem? Please describe.* 收到公文回函時，有時對方沒有寫是回哪一封、哪個區，有段名才能找到該document進行紀錄 *Describe the solution you'd like* 搜尋功能將sect_name加入要撈的資料庫 *Additional context* 像是這兩張公文回來的時候，我發現難以透過搜尋找到對應的document（因為在檢舉非常多的鄉鎮，單用鄉鎮名會看到七八個結果 <https://user-images.githubusercontent.com/60970217/103117688-87b16f00-46a6-11eb-81d1-2f26c8913390.png|截圖 2020-12-25 上午11 43 40> <https://user-images.githubusercontent.com/60970217/103117690-8bdd8c80-46a6-11eb-9fcd-ca4d13e09e56.png|截圖 2020-12-25 上午11 44 01>

2020-12-27

github 00:35:34

#61 test: init the test &amp; add the tests of TutorialModal

• 建置測試環境： • 為什麼不使用 `@vue/test-utils`？ • 依之前在公司測試的經驗，如<https://testing-library.com/docs/vue-testing-library/intro/|這篇>所說，`@vue/test-utils` 提供的方法容易引導開發者去測試細節，以致日後難以重構程式碼。 • 接著看完<https://medium.com/enjoy-life-enjoy-coding/react-unit-test-%E7%82%BA%E5%9F%B7%E8%A1%8C%E7%B4%B0%E7%AF%80%E5%AF%AB%E4%B8%8B%E6%B8%AC%E8%A9%A6-%E7%BF%BB%E8%AD%AF-7bec3bca4ee1|這篇文章>，以及認同 <https://testing-library.com/docs/guiding-principles|`@testing-library` 的設計理念>，決定嘗試看看 `@testing-library`。 • 為 `TutorialModal` 元件新增測試。

github 00:35:34

#61 test: init the test &amp; add the tests of TutorialModal

• 建置測試環境： • 為什麼不使用 `@vue/test-utils`？ • 依之前在公司測試的經驗，如<https://testing-library.com/docs/vue-testing-library/intro/|這篇>所說，`@vue/test-utils` 提供的方法容易引導開發者去測試細節，以致日後難以重構程式碼。 • 接著看完<https://medium.com/enjoy-life-enjoy-coding/react-unit-test-%E7%82%BA%E5%9F%B7%E8%A1%8C%E7%B4%B0%E7%AF%80%E5%AF%AB%E4%B8%8B%E6%B8%AC%E8%A9%A6-%E7%BF%BB%E8%AD%AF-7bec3bca4ee1|這篇文章>，以及認同 <https://testing-library.com/docs/guiding-principles|`@testing-library` 的設計理念>，決定嘗試看看 `@testing-library`。 • 為 `TutorialModal` 元件新增測試。

:white_check_mark: 1 other check has passed

2020-12-30

github 19:33:37

#62 指北鈕在 Firefox 上壞掉了

指北按鈕歸零按下去後不會正北朝上 _To Reproduce_ 1. 雙指縮放旋轉 2. 按下指北鈕 版本： Firefox 28.2 iOS 14.2 Note: fine on Chrome, Safari and Edge on iOS <https://user-images.githubusercontent.com/9480974/103348727-d95a5f00-4ad5-11eb-823d-6a097aa69ee9.jpeg|signal-2020-12-30-191933_002> <https://user-images.githubusercontent.com/9480974/103348729-dc554f80-4ad5-11eb-9cff-ac3b32a21513.jpeg|signal-2020-12-30-191933_003> <https://user-images.githubusercontent.com/9480974/103348733-dd867c80-4ad5-11eb-8c8a-4e0e9fe630e0.jpeg|signal-2020-12-30-191933_004>

github 19:33:37

#62 指北鈕在 Firefox 上壞掉了

指北按鈕歸零按下去後不會正北朝上 _To Reproduce_ 1. 雙指縮放旋轉 2. 按下指北鈕 版本： Firefox 28.2 iOS 14.2 Note: fine on Chrome, Safari and Edge on iOS <https://user-images.githubusercontent.com/9480974/103348727-d95a5f00-4ad5-11eb-823d-6a097aa69ee9.jpeg|signal-2020-12-30-191933_002> <https://user-images.githubusercontent.com/9480974/103348729-dc554f80-4ad5-11eb-9cff-ac3b32a21513.jpeg|signal-2020-12-30-191933_003> <https://user-images.githubusercontent.com/9480974/103348733-dd867c80-4ad5-11eb-8c8a-4e0e9fe630e0.jpeg|signal-2020-12-30-191933_004>

github 20:00:12

#63 有辦法讓有發出公文的 pin 不要被擋住嗎？

不容易看到有被檢舉的工廠 <https://user-images.githubusercontent.com/9480974/103349990-87b3d380-4ad9-11eb-9745-0235329b599a.jpeg|signal-2021-12-30-195850>

github 20:00:12

#63 有辦法讓有發出公文的 pin 不要被擋住嗎？

不容易看到有被檢舉的工廠 <https://user-images.githubusercontent.com/9480974/103349990-87b3d380-4ad9-11eb-9745-0235329b599a.jpeg|signal-2021-12-30-195850>

github 20:01:28

*<https://github.com/Disfactory/disfactory.tw/compare/62a029fc9539...bca355fef985|1 new commit> pushed to <https://github.com/Disfactory/disfactory.tw/tree/gh-pages|`gh-pages`>* <https://github.com/Disfactory/disfactory.tw/commit/bca355fef985e1e9169b501f860999b579119dbe|`bca355fe`> - Deploy [ci skip]

github 20:17:19

#64 工廠類型篩選狀態不明顯

<https://user-images.githubusercontent.com/4230968/103350729-dd897b00-4adb-11eb-88b5-66c66d7a3012.png|Screen Shot 2020-12-30 at 8 16 06 PM>

github 20:17:19

#64 工廠類型篩選狀態不明顯

<https://user-images.githubusercontent.com/4230968/103350729-dd897b00-4adb-11eb-88b5-66c66d7a3012.png|Screen Shot 2020-12-30 at 8 16 06 PM>

github 20:46:31

*<https://github.com/Disfactory/Disfactory/compare/17195a12bfa8...b1ee571bdf8e|2 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/18d7504c5a4da9c06bb92c73fbc18e06d6c65074|`18d7504c`> - refactor: use black format code <https://github.com/Disfactory/Disfactory/commit/b1ee571bdf8e27d55b70c39377c084476d62019f|`b1ee571b`> - Merge pull request #454 from Disfactory/black

github 20:47:53

*<https://github.com/Disfactory/Disfactory/compare/b1ee571bdf8e...a0d3865a2b7a|2 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/0deb5c606987c9f2a54b733c92bedc2c33ac5eaa|`0deb5c60`> - feat: add disfactory map link in admin factory page <https://github.com/Disfactory/Disfactory/commit/a0d3865a2b7afb072a53dba03c1836e587d280a2|`a0d3865a`> - Merge pull request #467 from Disfactory/add-disfactor-map

github 21:16:32

#469 add csv export action for document

<https://github.com/deeper747|@deeper747> 許願的，剛好很容易做的功能：可以輸出公文的 csv <https://user-images.githubusercontent.com/6868283/103353563-27765f00-4ae4-11eb-83a3-fc27502cceaf.png|image>

:white_check_mark: All checks have passed

github 21:18:08

#470 Document 輸出 csv

*Is your feature request related to a problem? Please describe.* 方便地公研究員做數據統計 需要再跟 <https://github.com/deeper747|@deeper747> 確認需要哪些欄位 *Additional context* <https://github.com/Disfactory/Disfactory/issues/464|#464> <https://github.com/Disfactory/Disfactory/issues/463|#463>

github 21:23:21

#471 fixed #466 - 公文聯絡電子信箱沒有隨名字更改

fixed <https://github.com/Disfactory/Disfactory/issues/466|#466> 應該要隨聯絡人改變

github 21:27:20

*<https://github.com/Disfactory/Disfactory/compare/a0d3865a2b7a...765b3fc48b88|2 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/46d545a22602a7398b28a944ddc2d731fa5200ad|`46d545a2`> - fixed #466 - 公文聯絡電子信箱沒有隨名字更改 <https://github.com/Disfactory/Disfactory/commit/765b3fc48b8897320337540097622a2ba25e4a54|`765b3fc4`> - Merge pull request #471 from Disfactory/fix_466

github 21:39:17

#65 Image lightbox

:white_check_mark: 7 other checks have passed

github 21:48:25

#472 Fix #226 與 #384

提供 swagger 與 redoc 頁面，讓使用者可以比較方便理解 API 的使用方式 另外為了避免 API 太容易被攻擊，所以不顯示 Create 與 Update 的 API <https://user-images.githubusercontent.com/126123/103355231-b71e0c80-4ae8-11eb-8f6f-02782e899403.png|image>

github 22:15:18

#473 fix #468 document 搜尋需要 query 段名、公文號

<https://github.com/Disfactory/Disfactory/issues/468|#468> 將 code, factory sectname 加入搜尋條件 使用 code 搜尋 <https://user-images.githubusercontent.com/126123/103356518-06197100-4aec-11eb-98cc-e8181f50be16.png|image> 使用段名搜尋 <https://user-images.githubusercontent.com/126123/103356712-77f1ba80-4aec-11eb-8773-f6cbea2358ef.png|image>

github 22:33:35

*<https://github.com/Disfactory/imgur-keeper/compare/1c3cc80173db...ccd0aabd5993|1 new commit> pushed to <https://github.com/Disfactory/imgur-keeper/tree/master|`master`>* <https://github.com/Disfactory/imgur-keeper/commit/ccd0aabd59931e497579d71948fe55423b569f69|`ccd0aabd`> - Fix bugs and trigger new images