#disfactory-notification
2021-07-01
github2
08:37:19
*<https://github.com/Disfactory/DisfactoryMonthlyReport/compare/ee9121a2f592...b7acc509a2b1|1 new commit> pushed to `<https://github.com/Disfactory/DisfactoryMonthlyReport/tree/master|master>` by github-actions[bot]* `<https://github.com/Disfactory/DisfactoryMonthlyReport/commit/b7acc509a2b14a7cc3452657832d8f5bd66a68d6|b7acc509>` - {chore: autopublish 2021-07-01T00:37:16Z}
github2
08:59:21
*<https://github.com/Disfactory/about.disfactory.tw/compare/f83e1da4d68f...f67778bc18e3|1 new commit> pushed to `<https://github.com/Disfactory/about.disfactory.tw/tree/dev|dev>` by github-actions[bot]* `<https://github.com/Disfactory/about.disfactory.tw/commit/f67778bc18e36078589815171b0b7256822438bd|f67778bc>` - feat: update the OG images & og-imgs-cache.json
2021-07-02
github2
08:59:44
*<https://github.com/Disfactory/about.disfactory.tw/compare/f67778bc18e3...79d5cc1783b8|1 new commit> pushed to `<https://github.com/Disfactory/about.disfactory.tw/tree/dev|dev>` by github-actions[bot]* `<https://github.com/Disfactory/about.disfactory.tw/commit/79d5cc1783b853e08fefcfe74a7a2b5eac254c87|79d5cc17>` - feat: update the OG images & og-imgs-cache.json
2021-07-04
github2
09:00:49
*<https://github.com/Disfactory/about.disfactory.tw/compare/79d5cc1783b8...3bf5e7f2fa43|1 new commit> pushed to `<https://github.com/Disfactory/about.disfactory.tw/tree/dev|dev>` by github-actions[bot]* `<https://github.com/Disfactory/about.disfactory.tw/commit/3bf5e7f2fa435d0569069ab47ec8468ca05050d9|3bf5e7f2>` - feat: update the OG images & og-imgs-cache.json
2021-07-05
github2
08:59:12
*<https://github.com/Disfactory/about.disfactory.tw/compare/3bf5e7f2fa43...c49ddd9493e7|1 new commit> pushed to `<https://github.com/Disfactory/about.disfactory.tw/tree/dev|dev>` by github-actions[bot]* `<https://github.com/Disfactory/about.disfactory.tw/commit/c49ddd9493e758666f9e0763c46f0e1bce85e563|c49ddd94>` - feat: update the OG images & og-imgs-cache.json
2021-07-06
github2
09:01:11
*<https://github.com/Disfactory/about.disfactory.tw/compare/c49ddd9493e7...be731e5fbae0|1 new commit> pushed to `<https://github.com/Disfactory/about.disfactory.tw/tree/dev|dev>` by github-actions[bot]* `<https://github.com/Disfactory/about.disfactory.tw/commit/be731e5fbae0730fe6f25140ec9bf07015e9894c|be731e5f>` - feat: update the OG images & og-imgs-cache.json
2021-07-07
github2
09:02:40
*<https://github.com/Disfactory/about.disfactory.tw/compare/be731e5fbae0...2599b13932c2|1 new commit> pushed to `<https://github.com/Disfactory/about.disfactory.tw/tree/dev|dev>` by github-actions[bot]* `<https://github.com/Disfactory/about.disfactory.tw/commit/2599b13932c2e57f4420dcc1da302d8ba240aaf0|2599b139>` - feat: update the OG images & og-imgs-cache.json
2021-07-08
github2
09:00:24
*<https://github.com/Disfactory/about.disfactory.tw/compare/2599b13932c2...5fbc40a83bb5|1 new commit> pushed to `<https://github.com/Disfactory/about.disfactory.tw/tree/dev|dev>` by github-actions[bot]* `<https://github.com/Disfactory/about.disfactory.tw/commit/5fbc40a83bb50e5d0c0368f61e4267d037b869de|5fbc40a8>` - feat: update the OG images & og-imgs-cache.json
2021-07-10
github2
08:56:22
*<https://github.com/Disfactory/about.disfactory.tw/compare/5fbc40a83bb5...82d8748f061b|1 new commit> pushed to `<https://github.com/Disfactory/about.disfactory.tw/tree/dev|dev>` by github-actions[bot]* `<https://github.com/Disfactory/about.disfactory.tw/commit/82d8748f061bac57d1a44222cd198f21cb795828|82d8748f>` - feat: update the OG images & og-imgs-cache.json
2021-07-12
github2
08:59:04
*<https://github.com/Disfactory/about.disfactory.tw/compare/82d8748f061b...87b60dcbb0c2|1 new commit> pushed to `<https://github.com/Disfactory/about.disfactory.tw/tree/dev|dev>` by github-actions[bot]* `<https://github.com/Disfactory/about.disfactory.tw/commit/87b60dcbb0c2b23ed1bd000607356c8d29aef473|87b60dcb>` - feat: update the OG images & og-imgs-cache.json
2021-07-13
github2
08:59:01
*<https://github.com/Disfactory/about.disfactory.tw/compare/87b60dcbb0c2...9cfd97102a99|1 new commit> pushed to `<https://github.com/Disfactory/about.disfactory.tw/tree/dev|dev>` by github-actions[bot]* `<https://github.com/Disfactory/about.disfactory.tw/commit/9cfd97102a99522ab2386056dd8ea177a87d0b8e|9cfd9710>` - feat: update the OG images & og-imgs-cache.json
2021-07-14
github2
08:56:54
*<https://github.com/Disfactory/about.disfactory.tw/compare/9cfd97102a99...9316222494cb|1 new commit> pushed to `<https://github.com/Disfactory/about.disfactory.tw/tree/dev|dev>` by github-actions[bot]* `<https://github.com/Disfactory/about.disfactory.tw/commit/9316222494cb2f1b02f1f7d36422d9796aa0c0ad|93162224>` - feat: update the OG images & og-imgs-cache.json
2021-07-17
github2
18:22:33
[Disfactory/frontend] Issue opened by cheweiliu
嵌入頁面 <https://g0v.hackmd.io/@chewei/gis/|https://g0v.hackmd.io/@chewei/gis/> 嵌入語法 <iframe width="100%" height="520" frameborder="0" src="<https://disfactory.tw/>" allowfullscreen webkitallowfullscreen mozallowfullscreen oallowfullscreen msallowfullscreen></iframe> * * * 網頁嵌入至 hackmd,會出現一個移動橫條 <https://user-images.githubusercontent.com/8068193/126033852-6ebb9b18-732b-4cb1-8dad-4a3e297c83e7.png|螢幕快照 2021-07-17 下午6 17 50>![]()
github2
18:22:43
[Disfactory/frontend] Issue opened by cheweiliu
嵌入頁面 <https://g0v.hackmd.io/@chewei/gis/|https://g0v.hackmd.io/@chewei/gis/> 嵌入語法 <iframe width="100%" height="520" frameborder="0" src="<https://disfactory.tw/>" allowfullscreen webkitallowfullscreen mozallowfullscreen oallowfullscreen msallowfullscreen></iframe> 網頁嵌入至 hackmd,會出現一個移動橫條 <https://user-images.githubusercontent.com/8068193/126033852-6ebb9b18-732b-4cb1-8dad-4a3e297c83e7.png|螢幕快照 2021-07-17 下午6 17 50>
2021-07-21
github2
19:49:44
[Disfactory/Disfactory] Pull request opened by Swind
增加下載經濟部資料與將經濟部資料轉換成 json 的 script 並且增加了 README 描述了尚未完成的部份
github2
20:53:58
[Disfactory/satellite] Issue opened by yeefun
*後端* • 資料庫 schema • 初始化資料庫 • API server • 規則建立 <https://github.com/deeper747|@deeper747> *前端* • 切版 • 動態邏輯
github2
21:42:03
[Disfactory/satellite] Issue opened by deeper747
• 每1000題為一個題組 • 每一題都回答完三輪才出下個題組給使用者 • 每個使用者一次回答五題 • 4題正式題目 • 1題測試題目(有正確答案)
2021-07-22
github2
15:36:36
[Disfactory/Disfactory] Issue opened by deeper747
*Describe the bug* 剛剛新增工廠之後沒有在django上出現 • 有看到「已新增成功」的提示 • staging亦同 • 還沒測試手機 *To Reproduce* 在disfactory.tw上新增一間工廠,上傳一張相片,並送出。 *Screenshots* django上的紀錄好像停在了7/13 <https://user-images.githubusercontent.com/60970217/126605083-7b69ffea-fe2d-42ba-9fad-e7acaa79e3c4.png|截圖 2021-07-22 下午3 43 14> *Desktop (please complete the following information):* • Mac OS • chrome • 91.0.4472.114![]()
deeper
2021-07-22 15:41:57
@swind @f46284628 出現奇怪的bug larrr
swind
2021-07-22 16:33:57
好我等等回去確認一下
swind
2021-07-22 16:34:32
我人在外面要一個小時後才有時間可以去確認
deeper
2021-07-22 16:35:19
沒問題 下禮拜三晚上一起來修也行
swind
2021-07-22 19:49:03
@cstsai 修好了你測試看看,主要原因在於 display_number
1. display_number 是唯一的(也就是不能重複)
2. 程式給新 factory display number 的時候會用現在的 display number 最大 factory 的 + 1
3. 被 delete 的 factory 不會被列出來( factory 的 delete 只是把 delete 欄位標示成 true,並沒有從資料庫中刪除)
4. 所以建立一個 factory 假設 (display_number 1000) 之後又立刻新增一個 factory 的話,因為他會覺的目前最大的是 999 (因為 1000 的被 delete 了看不到)所以他會給他 1000
5. display_number 重複,無法儲存
1. display_number 是唯一的(也就是不能重複)
2. 程式給新 factory display number 的時候會用現在的 display number 最大 factory 的 + 1
3. 被 delete 的 factory 不會被列出來( factory 的 delete 只是把 delete 欄位標示成 true,並沒有從資料庫中刪除)
4. 所以建立一個 factory 假設 (display_number 1000) 之後又立刻新增一個 factory 的話,因為他會覺的目前最大的是 999 (因為 1000 的被 delete 了看不到)所以他會給他 1000
5. display_number 重複,無法儲存
swind
2021-07-22 19:50:07
目前我是先快速 workaround,也就是去 Recycled factorys 手動把那個被刪除的 factory 的 display_number 改很大
swind
2021-07-22 19:50:40
這樣應該就可以先略過這個問題了 Orz 之後你們有刪除的 factory 的話,記得先去手動處理一下 display number
這個下星期三再來修
這個下星期三再來修
deeper
2021-07-22 19:51:02
了解!
deeper
2021-07-22 19:51:20
雖然我還不知道怎麼改display number XDA
deeper
2021-07-22 19:51:32
那這週上傳的…他們還在嗎
swind
2021-07-22 19:52:14
不在,因為完全無法儲存,我覺得很嚴重所以才先把這個修好
swind
2021-07-22 19:52:38
然後我發現 staging 的前端他 request 也是送到 https://api.disfactory.tw/api/ 這個要請前端修正一下
deeper
2021-07-22 19:52:53
瞭改QQ
swind
2021-07-22 19:53:24
你可以幫我測試一下能不能正常上傳嗎?
swind
2021-07-22 19:53:35
或者最近你們先不要刪除 factory
swind
2021-07-22 19:53:42
這樣應該就不會遇到這個問題
deeper
2021-07-22 19:56:06
好像一樣沒出現🥲
deeper
2021-07-22 19:56:39
咦不對
deeper
2021-07-22 19:56:40
有成功
deeper
2021-07-22 19:57:13
但是他沒有排序排到表格最上面
deeper
2021-07-22 19:58:05
現在的reportrecord latest created at 的排序依序是 無資料 > 離現在最近 > 離現在最久
deeper
2021-07-22 19:58:20
能否改成 無資料 > 離現在最久 > 離現在最近
deeper
2021-07-22 19:58:52
比如說我剛剛上傳到10754
deeper
2021-07-22 19:59:21
紀錄有更新 可是他不在factory table的第一頁@@
swind
2021-07-22 20:01:05
那這個你先開 issue
swind
2021-07-22 20:01:18
可以上傳不影響正常使用的話,我就之後來再來看了~
deeper
15:41:57
@swind @f46284628 出現奇怪的bug larrr
swind
16:33:57
好我等等回去確認一下
swind
16:34:32
我人在外面要一個小時後才有時間可以去確認
deeper
16:35:19
沒問題 下禮拜三晚上一起來修也行
swind
19:49:03
@cstsai 修好了你測試看看,主要原因在於 display_number
1. display_number 是唯一的(也就是不能重複)
2. 程式給新 factory display number 的時候會用現在的 display number 最大 factory 的 + 1
3. 被 delete 的 factory 不會被列出來( factory 的 delete 只是把 delete 欄位標示成 true,並沒有從資料庫中刪除)
4. 所以建立一個 factory 假設 (display_number 1000) 之後又立刻新增一個 factory 的話,因為他會覺的目前最大的是 999 (因為 1000 的被 delete 了看不到)所以他會給他 1000
5. display_number 重複,無法儲存
1. display_number 是唯一的(也就是不能重複)
2. 程式給新 factory display number 的時候會用現在的 display number 最大 factory 的 + 1
3. 被 delete 的 factory 不會被列出來( factory 的 delete 只是把 delete 欄位標示成 true,並沒有從資料庫中刪除)
4. 所以建立一個 factory 假設 (display_number 1000) 之後又立刻新增一個 factory 的話,因為他會覺的目前最大的是 999 (因為 1000 的被 delete 了看不到)所以他會給他 1000
5. display_number 重複,無法儲存
swind
19:50:07
目前我是先快速 workaround,也就是去 Recycled factorys 手動把那個被刪除的 factory 的 display_number 改很大
swind
19:50:40
這樣應該就可以先略過這個問題了 Orz 之後你們有刪除的 factory 的話,記得先去手動處理一下 display number
這個下星期三再來修
這個下星期三再來修
deeper
19:51:02
了解!
deeper
19:51:20
雖然我還不知道怎麼改display number XDA
deeper
19:51:32
那這週上傳的…他們還在嗎
swind
19:52:14
不在,因為完全無法儲存,我覺得很嚴重所以才先把這個修好
swind
19:52:38
然後我發現 staging 的前端他 request 也是送到 https://api.disfactory.tw/api/ 這個要請前端修正一下
deeper
19:52:53
瞭改QQ
swind
19:53:24
你可以幫我測試一下能不能正常上傳嗎?
swind
19:53:35
或者最近你們先不要刪除 factory
swind
19:53:42
這樣應該就不會遇到這個問題
deeper
19:56:06
好像一樣沒出現🥲
deeper
19:56:39
咦不對
deeper
19:56:40
有成功
deeper
19:57:13
但是他沒有排序排到表格最上面
deeper
19:58:05
現在的reportrecord latest created at 的排序依序是 無資料 > 離現在最近 > 離現在最久
deeper
19:58:20
能否改成 無資料 > 離現在最久 > 離現在最近
deeper
19:58:52
比如說我剛剛上傳到10754
deeper
19:59:21
紀錄有更新 可是他不在factory table的第一頁@@
swind
20:01:05
那這個你先開 issue
swind
20:01:18
可以上傳不影響正常使用的話,我就之後來再來看了~
2021-07-24
github2
09:01:24
*<https://github.com/Disfactory/about.disfactory.tw/compare/9316222494cb...2b767286d8fa|1 new commit> pushed to `<https://github.com/Disfactory/about.disfactory.tw/tree/dev|dev>` by github-actions[bot]* `<https://github.com/Disfactory/about.disfactory.tw/commit/2b767286d8fad29696d084c55b739a851f2c10ed|2b767286>` - feat: update the OG images & og-imgs-cache.json
github2
09:02:05
[Disfactory/about.disfactory.tw] Pull request opened by dependabot[bot]
Bumps <https://github.com/Qix-/color-string|color-string> from 1.5.4 to 1.6.0. Release notes _Sourced from <https://github.com/Qix-/color-string/releases|color-string's releases>._ > *1.6.0* > *Minor release 1.6.0* > > • <https://github.com/Qix-/color-string/issues/55|#55> - Add support for space-separated HSL > > Thanks <https://github.com/htunnicliff|`@htunnicliff`> for the contribution :) > > *1.5.5 (Patch/Security Release) - hwb() ReDos patch (low-severity)* > > > Release notes copied verbatim from the commit message, which can be found here: 0789e21284c33d89ebc4ab4ca6f759b9375ac9d3 > > ``` > Discovered by Yeting Li, c/o Colin Ife via <http://Snyk.io|Snyk.io>. > A ReDos (Regular Expression Denial of Service) vulnerability > was responsibly disclosed to me via email by Colin on > Mar 5 2021 regarding an exponential time complexity for > linearly increasing input lengths for hwb() color strings. > Strings reaching more than 5000 characters would see several > milliseconds of processing time; strings reaching more than > 50,000 characters began seeing 1500ms (1.5s) of processing time. > The cause was due to a the regular expression that parses > hwb() strings - specifically, the hue value - where > the integer portion of the hue value used a 0-or-more quantifier > shortly thereafter followed by a 1-or-more quantifier. > This caused excessive backtracking and a cartesian scan, > resulting in exponential time complexity given a linear > increase in input length. > Thank you Yeting Li and Colin Ife for bringing this to my > attention in a secure, responsible and professional manner. > > ``` Commits • <https://github.com/Qix-/color-string/commit/1a68f9e91266f504e33441fcab59af22fcb1358d|`1a68f9e`> 1.6.0 • <https://github.com/Qix-/color-string/commit/2b6f59cfa64288b6c1028e666d1ea8b6a4b0132e|`2b6f59c`> Add additional HSL examples to README • <https://github.com/Qix-/color-string/commit/6f73e205202c95ba7e6fd5afdffedd4552579a38|`6f73e20`> Update HSL regular expression • <https://github.com/Qix-/color-string/commit/02645465a23f5bcfb35bd44e29667397a4595ec2|`0264546`> Add tests for space-separated HSL syntax • <https://github.com/Qix-/color-string/commit/966ae4d80fc8f237674d099ce6214a9fb6a816bb|`966ae4d`> 1.5.5 • <https://github.com/Qix-/color-string/commit/0789e21284c33d89ebc4ab4ca6f759b9375ac9d3|`0789e21`> fix ReDos in hwb() parser (low-severity) • See full diff in <https://github.com/Qix-/color-string/compare/1.5.4...1.6.0|compare view> <https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores|Dependabot compatibility score> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. * * * Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: • `@dependabot rebase` will rebase this PR • `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it • `@dependabot merge` will merge this PR after your CI passes on it • `@dependabot squash and merge` will squash and merge this PR after your CI passes on it • `@dependabot cancel merge` will cancel a previously requested merge and block automerging • `@dependabot reopen` will reopen this PR if it is closed • `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually • `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) • `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) • `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) • `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language • `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language • `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language • `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the <https://github.com/Disfactory/about.disfactory.tw/network/alerts|Security Alerts page>.
2021-07-26
github2
08:57:51
*<https://github.com/Disfactory/about.disfactory.tw/compare/2b767286d8fa...04613b8d2db6|1 new commit> pushed to `<https://github.com/Disfactory/about.disfactory.tw/tree/dev|dev>` by github-actions[bot]* `<https://github.com/Disfactory/about.disfactory.tw/commit/04613b8d2db6f18e596c839d9d8d544c0a380785|04613b8d>` - feat: update the OG images & og-imgs-cache.json
2021-07-27
github2
09:00:17
*<https://github.com/Disfactory/about.disfactory.tw/compare/04613b8d2db6...0c135bff12a4|1 new commit> pushed to `<https://github.com/Disfactory/about.disfactory.tw/tree/dev|dev>` by github-actions[bot]* `<https://github.com/Disfactory/about.disfactory.tw/commit/0c135bff12a4b9e43297330222297514a82efc21|0c135bff>` - feat: update the OG images & og-imgs-cache.json
2021-07-28
github2
09:02:04
*<https://github.com/Disfactory/about.disfactory.tw/compare/0c135bff12a4...bc9f671c3559|1 new commit> pushed to `<https://github.com/Disfactory/about.disfactory.tw/tree/dev|dev>` by github-actions[bot]* `<https://github.com/Disfactory/about.disfactory.tw/commit/bc9f671c3559357c050ddb0d6b5292f4d86f8134|bc9f671c>` - feat: update the OG images & og-imgs-cache.json
2021-07-29
github2
08:57:15
*<https://github.com/Disfactory/about.disfactory.tw/compare/bc9f671c3559...6986e7988ebf|1 new commit> pushed to `<https://github.com/Disfactory/about.disfactory.tw/tree/dev|dev>` by github-actions[bot]* `<https://github.com/Disfactory/about.disfactory.tw/commit/6986e7988ebfe2450e897185e7e77389917c7d2f|6986e798>` - feat: update the OG images & og-imgs-cache.json
2021-07-31
github2
08:57:32
*<https://github.com/Disfactory/about.disfactory.tw/compare/6986e7988ebf...648bd5a44415|1 new commit> pushed to `<https://github.com/Disfactory/about.disfactory.tw/tree/dev|dev>` by github-actions[bot]* `<https://github.com/Disfactory/about.disfactory.tw/commit/648bd5a444154028f87c1eb73f21020e5f8323e4|648bd5a4>` - feat: update the OG images & og-imgs-cache.json