Slack archive

disfactory-notification

Month: 2020-10

2020-10-01

2020-10-07

github 20:37:20

#32 Use gh-pages cli for prod release

:white_check_mark: 7 other checks have passed

github 20:38:50

*<https://github.com/Disfactory/frontend/compare/4a4327488859...584e87054433|2 new commits> pushed to <https://github.com/Disfactory/frontend/tree/master|`master`>* <https://github.com/Disfactory/frontend/commit/82e9346154631c0ead3deadb5bde6ec29e2382d6|`82e93461`> - Use gh-pages cli for prod release <https://github.com/Disfactory/frontend/commit/584e870544333017bc097a538731c62203c2a711|`584e8705`> - Merge pull request #32 from Disfactory/fix-production-ci

github 20:38:51

*<https://github.com/Disfactory/frontend/compare/4a4327488859...584e87054433|2 new commits> pushed to <https://github.com/Disfactory/frontend/tree/master|`master`>* <https://github.com/Disfactory/frontend/commit/82e9346154631c0ead3deadb5bde6ec29e2382d6|`82e93461`> - Use gh-pages cli for prod release <https://github.com/Disfactory/frontend/commit/584e870544333017bc097a538731c62203c2a711|`584e8705`> - Merge pull request #32 from Disfactory/fix-production-ci

github 20:39:45

#33 Use gh-pages cli for prod release

:white_check_mark: 9 other checks have passed

github 20:52:10

*<https://github.com/Disfactory/disfactory.tw/compare/0bf7783dc9cc...104e814208d5|1 new commit> pushed to <https://github.com/Disfactory/disfactory.tw/tree/gh-pages|`gh-pages`>* <https://github.com/Disfactory/disfactory.tw/commit/104e814208d5515cf7b7dbbbaa9efba5b32b2914|`104e8142`> - Deploy [ci skip]

github 20:52:24

Successfully deployed <https://github.com/Disfactory/disfactory.tw/commit/104e814208d5515cf7b7dbbbaa9efba5b32b2914|`104e814`> to github-pages

1
github 21:14:49

#406 Display_status API

*Is your feature request related to a problem? Please describe.* A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] *Describe the solution you'd like* A clear and concise description of what you want to happen. *Describe alternatives you've considered* A clear and concise description of any alternative solutions or features you've considered. *Additional context* Add any other context or screenshots about the feature request here.

github 21:14:50

#406 Display_status API

*Is your feature request related to a problem? Please describe.* A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] *Describe the solution you'd like* A clear and concise description of what you want to happen. *Describe alternatives you've considered* A clear and concise description of any alternative solutions or features you've considered. *Additional context* Add any other context or screenshots about the feature request here.

github 21:19:23

#407 django政府來源工廠的updated time

*Describe the bug* 現在的updated time欄位顯示的是固定欄位的更新時間 *Expected behavior* 新增一個以reportrecord更新的時間的欄位 並且希望list view顯示上，上面這個欄位取代現在的updated time

github 21:19:23

#407 django政府來源工廠的updated time

*Describe the bug* 現在的updated time欄位顯示的是固定欄位的更新時間 *Expected behavior* 新增一個以reportrecord更新的時間的欄位 並且希望list view顯示上，上面這個欄位取代現在的updated time

github 22:21:23

#35 工廠描述補充完不會顯示在工廠資訊欄

1.bug 「工廠描述」補充完，沒有顯示在工廠資訊欄 2.expected behavior 可以看到補充欄新增的字串在工廠資訊欄 3.screenshot <https://user-images.githubusercontent.com/60970217/95343555-430a0900-08eb-11eb-9e73-bdf8d251f691.png|截圖 2020-10-07 下午10 19 42> <https://user-images.githubusercontent.com/60970217/95343565-469d9000-08eb-11eb-9e97-cbeb63569f30.png|截圖 2020-10-07 下午10 19 51> <https://user-images.githubusercontent.com/60970217/95343568-47362680-08eb-11eb-807c-08b1470cdd12.png|截圖 2020-10-07 下午10 19 56>

github 22:21:23

#35 工廠描述補充完不會顯示在工廠資訊欄

1.bug 「工廠描述」補充完，沒有顯示在工廠資訊欄 2.expected behavior 可以看到補充欄新增的字串在工廠資訊欄 3.screenshot <https://user-images.githubusercontent.com/60970217/95343555-430a0900-08eb-11eb-9e73-bdf8d251f691.png|截圖 2020-10-07 下午10 19 42> <https://user-images.githubusercontent.com/60970217/95343565-469d9000-08eb-11eb-9e97-cbeb63569f30.png|截圖 2020-10-07 下午10 19 51> <https://user-images.githubusercontent.com/60970217/95343568-47362680-08eb-11eb-807c-08b1470cdd12.png|截圖 2020-10-07 下午10 19 56>

github 22:25:41

#36 工廠外部文字無法修改

1. bug 已經新增的點位、既有工廠的工廠外部文字目前無法修改～～～ 2. expected behavior 像是現在的一樣可以修改工廠外部文字

github 22:25:41

#36 工廠外部文字無法修改

1. bug 已經新增的點位、既有工廠的工廠外部文字目前無法修改～～～ 2. expected behavior 像是現在的一樣可以修改工廠外部文字

github 22:43:59

#408 新增 Document 的 list view 與 change view

1. 新增 document admin list view 與 change view 2. 將 generate docx 的功能移到 document list view document list <https://user-images.githubusercontent.com/126123/95346308-4a7ee180-08ee-11eb-8c17-23784553fc7d.png|image> document change view <https://user-images.githubusercontent.com/126123/95346494-7ef29d80-08ee-11eb-90ea-75531a0fe8a1.png|image>

github 22:43:59

#408 新增 Document 的 list view 與 change view

1. 新增 document admin list view 與 change view 2. 將 generate docx 的功能移到 document list view document list <https://user-images.githubusercontent.com/126123/95346308-4a7ee180-08ee-11eb-8c17-23784553fc7d.png|image> document change view <https://user-images.githubusercontent.com/126123/95346494-7ef29d80-08ee-11eb-90ea-75531a0fe8a1.png|image>

:white_check_mark: All checks have passed

github 22:53:49

#409 feat(flake8): add flake8

*Summary* • 看 circleci 好像有要引入 flake8，先試改一些檔案

github 22:53:49

#409 feat(flake8): use flake8 to lint files

*Summary* • 看 circleci 好像有要引入 flake8，先試改一些檔案

:white_check_mark: All checks have passed

2020-10-09

github 14:51:52

*<https://github.com/Disfactory/Disfactory/compare/0f56a2f3745c...84ae71277b0b|2 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/6a2f089b5b0c8f11b69fa3fa42763ea904cc1538|`6a2f089b`> - feat(flake8): use flake8 to lint files <https://github.com/Disfactory/Disfactory/commit/84ae71277b0b15bf2e049db5d5eef5f3b005ea8d|`84ae7127`> - Merge pull request #409 from Disfactory/add-flake8

github 14:51:52

*<https://github.com/Disfactory/Disfactory/compare/0f56a2f3745c...84ae71277b0b|2 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/6a2f089b5b0c8f11b69fa3fa42763ea904cc1538|`6a2f089b`> - feat(flake8): use flake8 to lint files <https://github.com/Disfactory/Disfactory/commit/84ae71277b0b15bf2e049db5d5eef5f3b005ea8d|`84ae7127`> - Merge pull request #409 from Disfactory/add-flake8

github 16:57:19

#410 feat(api): return column `display_status` in `/factories` API

*Summary* • 新的需求是想要在 call API `/factories` 的時候多拿一個欄位 `document_display_status`，這欄位的值是根據 factory 底下 `created_at` 是最新的 document 的 `display_status` 值

github 16:57:19

#410 feat(api): return column `document_display_status` in `/factories` API

*Summary* • 新的需求是想要在 call API `/factories` 的時候多拿一個欄位 `document_display_status`，這欄位的值是根據 factory 底下 `created_at` 是最新的 document 的 `display_status` 值

:white_check_mark: All checks have passed

github 19:25:23

*<https://github.com/Disfactory/Disfactory/compare/84ae71277b0b...4b41c7d24f32|2 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/9b6fcb271df02c98afc1dc22b4403ac8c4bcc08a|`9b6fcb27`> - feat(api): return column `document_display_status` in `/factories` API <https://github.com/Disfactory/Disfactory/commit/4b41c7d24f322ee341f8b8356102a1cd3d5bd964|`4b41c7d2`> - Merge pull request #410 from Disfactory/api-display_status

github 19:25:23

*<https://github.com/Disfactory/Disfactory/compare/84ae71277b0b...4b41c7d24f32|2 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/9b6fcb271df02c98afc1dc22b4403ac8c4bcc08a|`9b6fcb27`> - feat(api): return column `document_display_status` in `/factories` API <https://github.com/Disfactory/Disfactory/commit/4b41c7d24f322ee341f8b8356102a1cd3d5bd964|`4b41c7d2`> - Merge pull request #410 from Disfactory/api-display_status

2020-10-17

github 17:15:27

#37 Filter buttons

:white_check_mark: All checks have passed

2020-10-18

github 20:19:38

*<https://github.com/Disfactory/Disfactory/compare/4b41c7d24f32...79d40a29d9d9|3 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/881119cc9560300f1b1022eccc11488df4b1c980|`881119cc`> - Add document add/change form and move the export docx action from factory list to document list <https://github.com/Disfactory/Disfactory/commit/886c9ff0c1168e6aa0a527a6b7e1baa89112dd8f|`886c9ff0`> - Add migration script to rename the document field of followup model <https://github.com/Disfactory/Disfactory/commit/79d40a29d9d959dc5bc1362d9da7c6a7c8a6cd98|`79d40a29`> - Merge pull request #408 from Disfactory/document_change_form_v2

github 20:19:39

*<https://github.com/Disfactory/Disfactory/compare/4b41c7d24f32...79d40a29d9d9|3 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/881119cc9560300f1b1022eccc11488df4b1c980|`881119cc`> - Add document add/change form and move the export docx action from factory list to document list <https://github.com/Disfactory/Disfactory/commit/886c9ff0c1168e6aa0a527a6b7e1baa89112dd8f|`886c9ff0`> - Add migration script to rename the document field of followup model <https://github.com/Disfactory/Disfactory/commit/79d40a29d9d959dc5bc1362d9da7c6a7c8a6cd98|`79d40a29`> - Merge pull request #408 from Disfactory/document_change_form_v2

2020-10-19

github 22:40:31

*<https://github.com/Disfactory/Disfactory/compare/79d40a29d9d9...89a667c48e1a|1 new commit> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/89a667c48e1aa2055f51b2091fc268604ac22f8b|`89a667c4`> - Refactor backend (#381)

github 22:40:31

*<https://github.com/Disfactory/Disfactory/compare/79d40a29d9d9...89a667c48e1a|1 new commit> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/89a667c48e1aa2055f51b2091fc268604ac22f8b|`89a667c4`> - Refactor backend (#381)

2020-10-21

github 20:27:46

#411 Document: 替 CET 增加用來管理公文進度與狀況的 Tag

*Document: CET 用來管理公文進度與狀況的 Tag* • cet_report_status : CET 內部管理用的進度 • cet_next： CET 下一步要做什麼 • gov_response_status: 可能會有針對四個地方政府單位進度不同的 tag 以上幾個 Tag 都會使用 Many to Many 的 Table 來實做， 讓每個欄位同時都可以多個 Tags，方便 CET 管理。

github 20:27:46

#411 Document: 替 CET 增加用來管理公文進度與狀況的 Tag

Document: CET 用來管理公文進度與狀況的 Tag cet_report_status: CET 內部管理用的進度 cet_next： CET 下一步要做什麼 gov_response_status: 可能會有針對四個地方政府單位進度不同的 tag

IU 20:43:09
/github unsubscribe Disfactory/Disfactory
github 20:43:09

Unsubscribed from <https://github.com/Disfactory/Disfactory|Disfactory/Disfactory>

2020-10-24

Guan 11:17:23
@guandragonx has joined the channel
Chelsea 11:17:45
@peekaboo2999 has joined the channel

2020-10-27

Chelsea 22:50:15
@peekaboo2999 has left the channel

2020-10-28

github 19:51:37

#412 document management list view

*Is your feature request related to a problem? Please describe.* 進行電話追蹤之前， 1.確定哪些需要打電話 2.確認同一通電話應該問哪些事情（同一個承辦手上有哪些案件？） *Describe the solution you'd like* 在document的list view中 1.可以依「cet_next」、「display_status」進行filter 2.可以依「承辦」進行搜尋（尚未有這個欄位，因為資料難以完整。因此和 ＠swind討論了下面的替代方案） *Describe alternatives you've considered* 2.可以依「鄉鎮」進行搜尋

github 20:49:07

#414 UI 2.0 使用教學

預計 11/18 code freeze 後，可以來截圖製作。

github 20:58:06

#415 「工廠描述」出現在「點位顯示資訊」中

*problem* 現在填完的「工廠描述」（`others`）不會顯示在點位的詳細資訊中 *Describe the solution you'd like* 讓大家補充的「工廠描述」可以依序出現在點位顯示資訊當中 *Additional context* 需提醒使用者「工廠描述」欄位會公開在網頁上，不宜留下可辨識的個人資訊

github 20:58:48

#38 「工廠描述」出現在「點位顯示資訊」中

*problem* 現在填完的「工廠描述」（`others`）不會顯示在點位的詳細資訊中 *Describe the solution you'd like* 讓大家補充的「工廠描述」可以依序出現在點位顯示資訊當中 *Additional context* 需提醒使用者「工廠描述」欄位會公開在網頁上，不宜留下可辨識的個人資訊

github 20:58:48

#38 「工廠描述」出現在「點位顯示資訊」中

*problem* 現在填完的「工廠描述」（`others`）不會顯示在點位的詳細資訊中 *Describe the solution you'd like* 讓大家補充的「工廠描述」可以依序出現在點位顯示資訊當中 *Additional context* 需提醒使用者「工廠描述」欄位會公開在網頁上，不宜留下可辨識的個人資訊

github 21:29:42

#39 Update factory type/name

:white_check_mark: All checks have passed

github 21:31:00

#416 Add documenttags (cet next, gov response status and cet report status) tags

Resolve <https://github.com/Disfactory/Disfactory/issues/412|#412> and <https://github.com/Disfactory/Disfactory/issues/411|#411> 1. 在 document 頁面新增 `cet next tags`, `gov response status tags` 與 `cet report status`，並且可以多選 <https://user-images.githubusercontent.com/126123/97441013-31080d00-1963-11eb-8ee2-00e4ee9dc354.png|image> 2. 在 document list view 中增加 filter 讓使用者可以用 cet next tags 與 display status 過濾 document <https://user-images.githubusercontent.com/126123/97442017-59443b80-1964-11eb-9f31-e4edee034613.png|image>

:white_check_mark: All checks have passed

github 21:40:42

#417 UI 2.0 User Feedbacks and enhancements

*希望先做的* Problem: [我想新增可疑工廠] 有點字太小或不明顯，兩位超過五十歲的測試者需要花超過 20 秒尋找，其中一位需要拿下眼鏡。 <https://user-images.githubusercontent.com/9480974/97443254-cc01e680-1965-11eb-9399-6d860fa45e7d.png|2020-10-28-213540_001> Problem: 新增工廠成功然後回到地圖之後，如果該地點點位附近已經有數個新增的民眾回報工廠，使用者會不知道哪個是自己新增的，無法確認自己是否新增成功。 <https://user-images.githubusercontent.com/9480974/97443484-08cddd80-1966-11eb-94d0-82715f62e3b8.jpeg|2020-10-28-213540_002> <https://user-images.githubusercontent.com/9480974/97443508-12efdc00-1966-11eb-808c-c875b0da199f.png|2020-10-28-213540_003> Problem: 分享複製連結後，地圖跳回以該工廠為中心的地圖，但是使用者還是不知道是哪間工廠。 possible solutions: 可能需要預先幫忙把該工廠的 bottom sheet 打開，讓使用者看見工廠資訊。或是選取的工廠要 mark？ Problem: 在上傳照片的步驟，因為沒有任何的地址或者座標資訊。使用者有疑惑，不知道是否需要補充填入地址，或者座標資訊。 <https://user-images.githubusercontent.com/9480974/97442627-05862200-1965-11eb-8a5c-f2741eb35522.png|image (2)> *Nice to have* ☐ Problem: 一開始進入地圖要求同意的頁面，文字和排版可能需要再解釋清楚網站使用目的 <https://github.com/deeper747|@deeper747> ☐ Problem: 一個工廠很多照片的話，補充照片因為放在最右側，需要 scroll 才能看到，有使用者誤以為無法新增照片。 ☐ Problem: 上傳照片上傳中的字樣，如果網路太慢拖太久的話，使用者不確定是當掉還是真的在上傳。 Solutions: 也許可以加動態 loading？ ☐ Problem: 返回步驟 1/3、2/3 使用者看不太懂 *待討論* • 新增可疑工廠之後，是不是要 call to action 讓使用者做下一步，例如：再新增一間工廠、去地球公民基金會看月報。 <https://github.com/deeper747|@deeper747> • 如果使用者對於非農地範圍有疑慮，是否能快速找到我們農地分區的資料來源

github 21:53:05

*<https://github.com/Disfactory/Disfactory/compare/89a667c48e1a...9fed893e2c10|2 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/4efec7a3a5042a5b363a2904a4fd143968b36198|`4efec7a3`> - Add documenttags (cet next, gov response status and cet report status) <https://github.com/Disfactory/Disfactory/commit/9fed893e2c10d720c912a6dc6d1aec5e90146b17|`9fed893e`> - Merge pull request #416 from Disfactory/add_document_tags

github 22:26:03

#418 feat(factory): add column from latest repordrecord created_at

<https://user-images.githubusercontent.com/11289529/97449214-682eec00-196c-11eb-95de-9cb0cf50f9e5.png|image> • 在 factory 頁面補上 reportrecord lastest created_at 並且可以根據此值排序

2020-10-29

github 00:41:28

*<https://github.com/Disfactory/Disfactory/compare/9fed893e2c10...89a8026971cf|2 new commits> pushed to <https://github.com/Disfactory/Disfactory/tree/master|`master`>* <https://github.com/Disfactory/Disfactory/commit/4b2c113e733a8c566783bc9fbad18eee247f18a0|`4b2c113e`> - feat(factory): add column from latest repordrecord created_at <https://github.com/Disfactory/Disfactory/commit/89a8026971cf7c410b6e9f9a8c0181b47d1e9acb|`89a80269`> - Merge pull request #418 from Disfactory/add-reportrecord-created-at

github 15:38:24

#40 初始popup內容、排版

<https://github.com/aelcenganda|@aelcenganda> 昨天跟我說到初始popup沒有把「新增建工廠」放在最優先的位置，排版也有些怪 <https://user-images.githubusercontent.com/60970217/97538046-bd194380-19fa-11eb-8723-930e34cfaf50.jpg|disfactory說明popup> 我重新看了一下，嘗試自己做了些微調整 <https://user-images.githubusercontent.com/60970217/97538060-c1ddf780-19fa-11eb-9181-b3dbd35a4b2a.jpg|disfactory說明popup2> 1.文案變成： 歡迎來到農地違章工廠回報系統！ 需要大家回報以下工廠之照片及資訊： • 2016.05.20後新增的農地違章工廠 • 中高污染工廠 以上資訊將由地球公民基金會彙整後，向政府舉報並追蹤拆除進度。 2.把第一句話變成置中 3.幫一些重點詞彙加上粗體 看 <https://github.com/Oriyar|@Oriyar> <https://github.com/JennyLan|@JennyLan> 有沒有什麼意見～

github 15:38:24

#40 初始popup內容、排版

<https://github.com/aelcenganda|@aelcenganda> 昨天跟我說到初始popup沒有把「新增建工廠」放在最優先的位置，排版也有些怪 <https://user-images.githubusercontent.com/60970217/97538046-bd194380-19fa-11eb-8723-930e34cfaf50.jpg|disfactory說明popup> 我重新看了一下，嘗試自己做了些微調整 <https://user-images.githubusercontent.com/60970217/97538060-c1ddf780-19fa-11eb-9181-b3dbd35a4b2a.jpg|disfactory說明popup2> 1.文案變成： 歡迎來到農地違章工廠回報系統！ 需要大家回報以下工廠之照片及資訊： • 2016.05.20後新增的農地違章工廠 • 中高污染工廠 以上資訊將由地球公民基金會彙整後，向政府舉報並追蹤拆除進度。 2.把第一句話變成置中 3.幫一些重點詞彙加上粗體 看 <https://github.com/Oriyar|@Oriyar> <https://github.com/JennyLan|@JennyLan> 有沒有什麼意見～

2020-10-31

github 18:47:48

#41 新增顯示設定畫面

:white_check_mark: All checks have passed