#disfactory-notification

2026-11-04
github2 11:51:24
`<https://github.com/Disfactory/devops/commit/016e9e399ff77bd19074a3a25c64c4b41544461c|016e9e39>` - docs: add production cutover TODO and live progress report
github2 11:51:24
`<https://github.com/Disfactory/devops/commit/016e9e399ff77bd19074a3a25c64c4b41544461c|016e9e39>` - docs: add production cutover TODO and live progress report
github2 11:52:06
`<https://github.com/Disfactory/devops/commit/a5967640114872b4e3f6cb152ae45189dcbd2545|a5967640>` - chore(cutover): disable old-prod cron, sync public_html, repo hygiene
github2 11:52:06
`<https://github.com/Disfactory/devops/commit/a5967640114872b4e3f6cb152ae45189dcbd2545|a5967640>` - chore(cutover): disable old-prod cron, sync public_html, repo hygiene
github2 12:01:59
`<https://github.com/Disfactory/devops/commit/02a53ecb16a91e332f20eb4ac950b88179236565|02a53ecb>` - docs(cutover): mark imgur archive migrated, decommission deferred
github2 12:01:59
`<https://github.com/Disfactory/devops/commit/02a53ecb16a91e332f20eb4ac950b88179236565|02a53ecb>` - docs(cutover): mark imgur archive migrated, decommission deferred
github2 12:09:01
`<https://github.com/Disfactory/devops/commit/49099a8b42677e1e40cdbaf8b119f420644b4b06|49099a8b>` - chore(cutover): rewrite prod inventory for new host, site.yml covers staging
github2 12:09:01
`<https://github.com/Disfactory/devops/commit/49099a8b42677e1e40cdbaf8b119f420644b4b06|49099a8b>` - chore(cutover): rewrite prod inventory for new host, site.yml covers staging
github2 12:10:35
`<https://github.com/Disfactory/devops/commit/72fb6d195d0037c6f7810f5f3b60c186b4baf798|72fb6d19>` - docs: refresh README and AGENTS.md to post-cutover status
github2 12:10:35
`<https://github.com/Disfactory/devops/commit/72fb6d195d0037c6f7810f5f3b60c186b4baf798|72fb6d19>` - docs: refresh README and AGENTS.md to post-cutover status
github2 12:10:45
`<https://github.com/Disfactory/devops/commit/1d79bba5fa768da6a92b1d785146d235374a606e|1d79bba5>` - docs: refresh CLAUDE.md (AGENTS.md symlink target) to post-cutover status
github2 12:10:45
`<https://github.com/Disfactory/devops/commit/1d79bba5fa768da6a92b1d785146d235374a606e|1d79bba5>` - docs: refresh CLAUDE.md (AGENTS.md symlink target) to post-cutover status
github2 13:41:29
`<https://github.com/Disfactory/Disfactory/commit/47cd7e67d73da8d7f246720034c32a6c56c2ff6f|47cd7e67>` - refactor: migrate easymap to new by-coord-db API endpoint (#698)
github2 13:41:29
`<https://github.com/Disfactory/Disfactory/commit/47cd7e67d73da8d7f246720034c32a6c56c2ff6f|47cd7e67>` - refactor: migrate easymap to new by-coord-db API endpoint (#698)
github2 13:45:36
Zeabur is deprecated and no longer used (service going down). This PR removes all Zeabur leftovers: *Deleted (9 files, ~2500 lines):* • `zeabur.yaml` + `zeabur-config.env` / `zeabur-config.example.env` • `scripts/zeabur-review-app.sh`, `scripts/test-zeabur-api.sh`, `scripts/test-service-cleanup.sh`, `scripts/README.md` (Zeabur-only) • `docs/zeabur-review-app.md` • `.github/workflows/zeabur-review-app.yml` (PR cleanup workflow) *Modified (2 files):* • `.github/workflows/build-backend-image.yml` — removed `deploy-review-app` job (used `Yukaii/zeabur-review-app-action` + `ZEABUR_*` secrets) and review-app dispatch inputs; restored to plain build-and-push on `master` (identical to pre-Zeabur version at `a8ef6be`, YAML-validated) • `README.md` — removed Zeabur one-click deploy section (Render section kept) Verified: zero remaining `zeabur` references (case-insensitive) in the repo.
github2 13:45:36
Zeabur is deprecated and no longer used (service going down). This PR removes all Zeabur leftovers: *Deleted (9 files, ~2500 lines):* • `zeabur.yaml` + `zeabur-config.env` / `zeabur-config.example.env` • `scripts/zeabur-review-app.sh`, `scripts/test-zeabur-api.sh`, `scripts/test-service-cleanup.sh`, `scripts/README.md` (Zeabur-only) • `docs/zeabur-review-app.md` • `.github/workflows/zeabur-review-app.yml` (PR cleanup workflow) *Modified (2 files):* • `.github/workflows/build-backend-image.yml` — removed `deploy-review-app` job (used `Yukaii/zeabur-review-app-action` + `ZEABUR_*` secrets) and review-app dispatch inputs; restored to plain build-and-push on `master` (identical to pre-Zeabur version at `a8ef6be`, YAML-validated) • `README.md` — removed Zeabur one-click deploy section (Render section kept) Verified: zero remaining `zeabur` references (case-insensitive) in the repo.
github2 13:50:21
`<https://github.com/Disfactory/Disfactory/commit/c33ea893ff7a92db015a727dcc3fb304ef51cde0|c33ea893>` - chore: remove deprecated Zeabur deployment files and review-app workflows (#700)
github2 13:50:21
`<https://github.com/Disfactory/Disfactory/commit/c33ea893ff7a92db015a727dcc3fb304ef51cde0|c33ea893>` - chore: remove deprecated Zeabur deployment files and review-app workflows (#700)
github2 13:54:53
因為現在 easymap 的 server 反應比較快,所以縮短 timeout 時間。 並且在無法取得 easymap 資料時,回傳空的資料,避免後續動作無法繼續進行。
github2 13:54:53
因為現在 easymap 的 server 反應比較快,所以縮短 timeout 時間。 並且在無法取得 easymap 資料時,回傳空的資料,避免後續動作無法繼續進行。
github2 13:54:58
This PR implements a comprehensive solution for multiple image upload backends to address Imgur API being blocked in Taiwan. *Problem* The current implementation only supports Imgur for image uploads, which is problematic because: • Imgur's API is blocked in Taiwan • No fallback mechanism when external services fail • Frontend handles image upload, limiting backend control *Solution* *:wrench: New Multi-Backend Image Upload Service* Created `api/services/image_upload.py` with: • *Abstract backend interface* for pluggable upload providers • *ImgurBackend* - Enhanced existing Imgur support with better error handling • *ImageBBBackend* - New backend supporting ImageBB API as Imgur alternative • *LocalBackend* - Fallback local storage when external services fail • *ImageUploadService* - Orchestrates backends with automatic failover *:rocket: New Direct Upload API Endpoint* Added `POST /factories/{id}/images/upload` supporting: • Direct multipart file uploads (no more frontend pre-upload) • All existing metadata: GPS coordinates, datetime, contact info • Automatic backend selection with graceful fallback • Same response format as existing endpoint *:gear: Enhanced Configuration* # Existing Imgur support DISFACTORY_IMGUR_CLIENT_ID=your_imgur_client_id # New ImageBB support DISFACTORY_IMAGEBB_API_KEY=your_imagebb_api_key Service automatically detects available backends and provides fallback order: *Imgur → ImageBB → Local Storage* *:arrows_counterclockwise: Backward Compatibility* • Existing `/factories/{id}/images` URL-based endpoint unchanged • Legacy `upload_image` task enhanced to use new multi-backend service • All existing functionality preserved • No database schema changes required *:test_tube: Comprehensive Testing* • Unit tests for all backend implementations • Integration tests for new file upload endpoint • Mock validation confirms service logic • Management commands for testing and maintenance *:books: Documentation &amp; Tools* • Complete user guide with API examples • Migration guide for frontend developers • Enhanced `reupload` management command with dry-run support • New `test_image_upload` command for service validation *Usage Examples* *Frontend Integration (New Direct Upload)* const formData = new FormData(); formData.append('image', imageFile); formData.append('nickname', 'Reporter'); formData.append('Latitude', '23.5'); fetch(`/api/factories/${factoryId}/images/upload`, { method: 'POST', body: formData }); *Backend Service Usage* from api.services.image_upload import ImageUploadService service = ImageUploadService() result = service.upload_image(image_buffer) # Automatically tries Imgur → ImageBB → Local with detailed logging *Benefits* :white_check_mark: *Reliability*: Multiple providers ensure upload success even when services are blocked :white_check_mark: *Flexibility*: Easy to add new backends (Cloudinary, AWS S3, etc.) :white_check_mark: *Control*: Backend handles uploads with better error handling and logging :white_check_mark: *Compatibility*: Existing integrations continue working unchanged :white_check_mark: *Monitoring*: Detailed logging shows which backend succeeded/failed This implementation ensures robust image upload functionality regardless of regional service restrictions while maintaining full backward compatibility. Fixes <https://github.com/Disfactory/Disfactory/issues/659|#659>. Warning Firewall rules blocked me from connecting to one or more addresses *I tried to connect to the following addresses, but was blocked by firewall rules:* • `<http://esm.ubuntu.com|esm.ubuntu.com>` • Triggering command: `/usr/lib/apt/methods/https ` (dns block) If you need me to access, download, or install something from one of these locations, you can either: • Configure <https://gh.io/copilot/actions-setup-steps|Actions setup steps> to set up my environment, which run before the firewall is enabled • Add the appropriate URLs or hosts to my <https://gh.io/copilot/firewall-config|firewall allow list> --- :speech_balloon: Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click <https://survey.alchemer.com/s3/8343779/Copilot-Coding-agent|here> to start the survey.
github2 13:54:58
This PR implements a comprehensive solution for multiple image upload backends to address Imgur API being blocked in Taiwan. *Problem* The current implementation only supports Imgur for image uploads, which is problematic because: • Imgur's API is blocked in Taiwan • No fallback mechanism when external services fail • Frontend handles image upload, limiting backend control *Solution* *:wrench: New Multi-Backend Image Upload Service* Created `api/services/image_upload.py` with: • *Abstract backend interface* for pluggable upload providers • *ImgurBackend* - Enhanced existing Imgur support with better error handling • *ImageBBBackend* - New backend supporting ImageBB API as Imgur alternative • *LocalBackend* - Fallback local storage when external services fail • *ImageUploadService* - Orchestrates backends with automatic failover *:rocket: New Direct Upload API Endpoint* Added `POST /factories/{id}/images/upload` supporting: • Direct multipart file uploads (no more frontend pre-upload) • All existing metadata: GPS coordinates, datetime, contact info • Automatic backend selection with graceful fallback • Same response format as existing endpoint *:gear: Enhanced Configuration* # Existing Imgur support DISFACTORY_IMGUR_CLIENT_ID=your_imgur_client_id # New ImageBB support DISFACTORY_IMAGEBB_API_KEY=your_imagebb_api_key Service automatically detects available backends and provides fallback order: *Imgur → ImageBB → Local Storage* *:arrows_counterclockwise: Backward Compatibility* • Existing `/factories/{id}/images` URL-based endpoint unchanged • Legacy `upload_image` task enhanced to use new multi-backend service • All existing functionality preserved • No database schema changes required *:test_tube: Comprehensive Testing* • Unit tests for all backend implementations • Integration tests for new file upload endpoint • Mock validation confirms service logic • Management commands for testing and maintenance *:books: Documentation &amp; Tools* • Complete user guide with API examples • Migration guide for frontend developers • Enhanced `reupload` management command with dry-run support • New `test_image_upload` command for service validation *Usage Examples* *Frontend Integration (New Direct Upload)* const formData = new FormData(); formData.append('image', imageFile); formData.append('nickname', 'Reporter'); formData.append('Latitude', '23.5'); fetch(`/api/factories/${factoryId}/images/upload`, { method: 'POST', body: formData }); *Backend Service Usage* from api.services.image_upload import ImageUploadService service = ImageUploadService() result = service.upload_image(image_buffer) # Automatically tries Imgur → ImageBB → Local with detailed logging *Benefits* :white_check_mark: *Reliability*: Multiple providers ensure upload success even when services are blocked :white_check_mark: *Flexibility*: Easy to add new backends (Cloudinary, AWS S3, etc.) :white_check_mark: *Control*: Backend handles uploads with better error handling and logging :white_check_mark: *Compatibility*: Existing integrations continue working unchanged :white_check_mark: *Monitoring*: Detailed logging shows which backend succeeded/failed This implementation ensures robust image upload functionality regardless of regional service restrictions while maintaining full backward compatibility. Fixes <https://github.com/Disfactory/Disfactory/issues/659|#659>. Warning Firewall rules blocked me from connecting to one or more addresses *I tried to connect to the following addresses, but was blocked by firewall rules:* • `<http://esm.ubuntu.com|esm.ubuntu.com>` • Triggering command: `/usr/lib/apt/methods/https ` (dns block) If you need me to access, download, or install something from one of these locations, you can either: • Configure <https://gh.io/copilot/actions-setup-steps|Actions setup steps> to set up my environment, which run before the firewall is enabled • Add the appropriate URLs or hosts to my <https://gh.io/copilot/firewall-config|firewall allow list> --- :speech_balloon: Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click <https://survey.alchemer.com/s3/8343779/Copilot-Coding-agent|here> to start the survey.
github2 14:12:08
Fresh restart of <https://github.com/Disfactory/Disfactory/pull/686|#686> (closed) with a corrected approach. *Why restart:* <https://github.com/Disfactory/Disfactory/pull/686|#686> declared `pytest-cov ^6.2.1` in `pyproject.toml`, but CI runs Python 3.7 and poetry 1.2.0 fails version solving for _every_ pytest-cov release there (verified empirically down to 3.0.0 — pytest-cov 4.1+ pulls `coverage&gt;=7.5` which needs Python ≥ 3.8). The dependency can only be bumped as part of the Python/UV stack upgrade. *This PR's approach (verified working on python:3.7):* • Install coverage tooling via pip inside the CI venv — pip correctly backtracks to pytest-cov 4.1.0 + coverage 7.2.7 on py3.7. `poetry.lock` untouched, `poetry install` stays green. • `pytest --cov=api --cov-report=xml --cov-report=term` in CI, Codecov upload via `codecov-action@v5` (`fail_ci_if_error: false`, non-blocking) • `make test-cov` target + README coverage badge Revisit (pin properly in lockfile) after the UV migration lands.
github2 14:12:08
Fresh restart of <https://github.com/Disfactory/Disfactory/pull/686|#686> (closed) with a corrected approach. *Why restart:* <https://github.com/Disfactory/Disfactory/pull/686|#686> declared `pytest-cov ^6.2.1` in `pyproject.toml`, but CI runs Python 3.7 and poetry 1.2.0 fails version solving for _every_ pytest-cov release there (verified empirically down to 3.0.0 — pytest-cov 4.1+ pulls `coverage&gt;=7.5` which needs Python ≥ 3.8). The dependency can only be bumped as part of the Python/UV stack upgrade. *This PR's approach (verified working on python:3.7):* • Install coverage tooling via pip inside the CI venv — pip correctly backtracks to pytest-cov 4.1.0 + coverage 7.2.7 on py3.7. `poetry.lock` untouched, `poetry install` stays green. • `pytest --cov=api --cov-report=xml --cov-report=term` in CI, Codecov upload via `codecov-action@v5` (`fail_ci_if_error: false`, non-blocking) • `make test-cov` target + README coverage badge Revisit (pin properly in lockfile) after the UV migration lands.
github2 14:14:46
`<https://github.com/Disfactory/Disfactory/commit/54b7514d8b97cef7ad2febdf87b83b8a4e6386f0|54b7514d>` - chore: add backend test coverage reporting (#701)
github2 14:14:46
`<https://github.com/Disfactory/Disfactory/commit/54b7514d8b97cef7ad2febdf87b83b8a4e6386f0|54b7514d>` - chore: add backend test coverage reporting (#701)
github2 14:18:13
Transition the project from using Poetry for dependency management to UV. Update scripts and configuration files to reflect this change, ensuring compatibility with the new tool. Adjust documentation to guide users on using UV instead of Poetry.
github2 14:18:13
Transition the project from using Poetry for dependency management to UV. Update scripts and configuration files to reflect this change, ensuring compatibility with the new tool. Adjust documentation to guide users on using UV instead of Poetry.
github2 14:23:11
Fresh restart of <https://github.com/Disfactory/Disfactory/pull/681|#681> (closed) off current master (`#698`+`#700`+`#701` included; old branch predated all three and its `uv.lock` was stale). *Scope discipline: same versions, tooling only.* `uv.lock` pins match `poetry.lock` exactly (spot-checked: django 2.2.27, psycopg2-binary 2.8.6, DRF 3.11.2, pillow 9.0.1, gunicorn 20.1.0, django-q 1.0.2). The actual dependency/Python bump comes next as a separate PR. *Changes:* • `pyproject.toml`: PEP 621 `[project]` + `[dependency-groups]` dev (not `optional-dependencies` — `uv sync --dev` targets groups, not extras; using extras silently skips dev deps, verified) • `uv.lock`: fresh resolve, 147 packages. uv's resolver correctly emits per-python pins for pytest-cov (4.1.0 on py&lt;3.8 → 7.1.0 on py≥3.9), which poetry 1.2.0 could never solve — this also retires the pip-install workaround from <https://github.com/Disfactory/Disfactory/pull/701|#701> • Deleted `poetry.lock`, stale `requirements.txt` (unreferenced poetry-export artifact) • Dockerfiles: uv binary + `uv sync --dev`/`--no-dev`; start scripts use `uv run` • `tests.yml`: `astral-sh/setup-uv`, uv cache, dropped poetry matrix • `backend/README.md`: uv setup instructions *Verified (not just CI):* replicated the CI job locally in `python:3.7` + `postgres:12-alpine` containers — `uv sync --dev` then the exact CI pytest invocation: *64 passed, 1 deselected (easymap), 88% total coverage*; Django test step also green.
github2 14:23:11
Fresh restart of <https://github.com/Disfactory/Disfactory/pull/681|#681> (closed) off current master (`#698`+`#700`+`#701` included; old branch predated all three and its `uv.lock` was stale). *Scope discipline: same versions, tooling only.* `uv.lock` pins match `poetry.lock` exactly (spot-checked: django 2.2.27, psycopg2-binary 2.8.6, DRF 3.11.2, pillow 9.0.1, gunicorn 20.1.0, django-q 1.0.2). The actual dependency/Python bump comes next as a separate PR. *Changes:* • `pyproject.toml`: PEP 621 `[project]` + `[dependency-groups]` dev (not `optional-dependencies` — `uv sync --dev` targets groups, not extras; using extras silently skips dev deps, verified) • `uv.lock`: fresh resolve, 147 packages. uv's resolver correctly emits per-python pins for pytest-cov (4.1.0 on py&lt;3.8 → 7.1.0 on py≥3.9), which poetry 1.2.0 could never solve — this also retires the pip-install workaround from <https://github.com/Disfactory/Disfactory/pull/701|#701> • Deleted `poetry.lock`, stale `requirements.txt` (unreferenced poetry-export artifact) • Dockerfiles: uv binary + `uv sync --dev`/`--no-dev`; start scripts use `uv run` • `tests.yml`: `astral-sh/setup-uv`, uv cache, dropped poetry matrix • `backend/README.md`: uv setup instructions *Verified (not just CI):* replicated the CI job locally in `python:3.7` + `postgres:12-alpine` containers — `uv sync --dev` then the exact CI pytest invocation: *64 passed, 1 deselected (easymap), 88% total coverage*; Django test step also green.
github2 14:29:55
`<https://github.com/Disfactory/Disfactory/commit/6e16bfc4c6ee5e3b99a0edf625c295835bd83a68|6e16bfc4>` - chore: migrate backend packaging from Poetry to uv (#702)
github2 14:29:55
`<https://github.com/Disfactory/Disfactory/commit/6e16bfc4c6ee5e3b99a0edf625c295835bd83a68|6e16bfc4>` - chore: migrate backend packaging from Poetry to uv (#702)
github2 14:31:53
Step 1 of the stack bump. CI ran `python:3.7` while the Dockerfiles and production run `python:3.9`. Django 2.2 supports 3.9, so this aligns everything on 3.9 *with zero app dependency changes* (uv.lock app pins verified unchanged). *Changes (3 files):* • `tests.yml`: CI container `python:3.7` → `python:3.9` • `pyproject.toml`: `requires-python &gt;=3.7.2` → `&gt;=3.9` • `uv.lock`: regenerated — only tooling versions move with the interpreter (pytest 7.4.4→8.4.2, pytest-cov 4.1.0→7.1.0, coverage 7.2.7→7.10.7, setuptools 68→75.3.4, still &lt;81 so pkg_resources survives for gunicorn 20.1.0) *Verified locally* (python:3.9 + postgres:12 containers, exact CI commands): 64 passed, 1 deselected (easymap), 89% total coverage; Django test step green. *Suggested next steps after this merges:* Django 2.2 → 3.2 LTS → 4.2 LTS (needs code changes: `url()`, `force_text`, `index_together`, etc.), then the remaining library upgrades (gunicorn 23, DRF, psycopg2 — unblocks <https://github.com/Disfactory/Disfactory/issues/683|#683>). Each as its own PR with the suite gating.
github2 14:31:53
Step 1 of the stack bump. CI ran `python:3.7` while the Dockerfiles and production run `python:3.9`. Django 2.2 supports 3.9, so this aligns everything on 3.9 *with zero app dependency changes* (uv.lock app pins verified unchanged). *Changes (3 files):* • `tests.yml`: CI container `python:3.7` → `python:3.9` • `pyproject.toml`: `requires-python &gt;=3.7.2` → `&gt;=3.9` • `uv.lock`: regenerated — only tooling versions move with the interpreter (pytest 7.4.4→8.4.2, pytest-cov 4.1.0→7.1.0, coverage 7.2.7→7.10.7, setuptools 68→75.3.4, still &lt;81 so pkg_resources survives for gunicorn 20.1.0) *Verified locally* (python:3.9 + postgres:12 containers, exact CI commands): 64 passed, 1 deselected (easymap), 89% total coverage; Django test step green. *Suggested next steps after this merges:* Django 2.2 → 3.2 LTS → 4.2 LTS (needs code changes: `url()`, `force_text`, `index_together`, etc.), then the remaining library upgrades (gunicorn 23, DRF, psycopg2 — unblocks <https://github.com/Disfactory/Disfactory/issues/683|#683>). Each as its own PR with the suite gating.
github2 14:40:52
Stacked on <https://github.com/Disfactory/Disfactory/pull/703|#703> (Python 3.9). Do not merge before <https://github.com/Disfactory/Disfactory/pull/703|#703>. *No app code changes required* — full suite passes unmodified (64 passed, 1 deselected easymap). *Changes:* • `django` 2.2.27 → 3.2.25 (last 3.2 LTS); asgiref/sqlparse follow via lock • `settings.py`: `DEFAULT_AUTO_FIELD = AutoField` — preserves pre-3.2 implicit PK behavior, silences W042, avoids surprise BigAutoField migrations under 4.x *Verified locally* (python:3.9 + postgres:12 containers): suite green, `manage.py check` clean of W042. Remaining warnings are third-party only (django-q, DRF). *Heads-up for the next stack step (3.2 → 4.2 LTS):* django-q 1.0.2 uses `ugettext_lazy` (`RemovedInDjango40Warning`) and DRF 3.11 uses `default_app_config` — that jump will need django-q + DRF upgrades in the same PR.
github2 14:40:52
Stacked on <https://github.com/Disfactory/Disfactory/pull/703|#703> (Python 3.9). Do not merge before <https://github.com/Disfactory/Disfactory/pull/703|#703>. *No app code changes required* — full suite passes unmodified (64 passed, 1 deselected easymap). *Changes:* • `django` 2.2.27 → 3.2.25 (last 3.2 LTS); asgiref/sqlparse follow via lock • `settings.py`: `DEFAULT_AUTO_FIELD = AutoField` — preserves pre-3.2 implicit PK behavior, silences W042, avoids surprise BigAutoField migrations under 4.x *Verified locally* (python:3.9 + postgres:12 containers): suite green, `manage.py check` clean of W042. Remaining warnings are third-party only (django-q, DRF). *Heads-up for the next stack step (3.2 → 4.2 LTS):* django-q 1.0.2 uses `ugettext_lazy` (`RemovedInDjango40Warning`) and DRF 3.11 uses `default_app_config` — that jump will need django-q + DRF upgrades in the same PR.
github2 14:52:09
Gives us the missing automated deploy-confidence pipeline for the backend API. No app code changes — test infrastructure only. *What it does:* `backend/scripts/e2e-api-test.sh` builds the prod image, boots it with the real prod entrypoint (`start_prod.sh` → gunicorn) against a throwaway PostGIS DB, applies migrations, then asserts over HTTP: statistics endpoints, swagger wiring, and a factory create → nearby-query round-trip. Self-contained with teardown trap; compose v2 with v1 fallback. *Also in this PR:* • `docker-compose.test.yml`: `SKIP_MIGRATION_EXTERNAL_API=true`. Migration 0015's expensive step (Easymap call per factory) is a no-op on empty test DBs; this pins fast/hermetic migrates by intent. Prod/staging unaffected (0015 applied years ago, restores don't re-run migrations). Verified the gated task now hits the new by-coord-db endpoint post-<https://github.com/Disfactory/Disfactory/pull/698|#698>. • `integration-test.sh`: hardcoded `/home/runner/work/...` path → script-relative (it was unrunnable anywhere else). • `.github/workflows/e2e.yml`: runs the e2e in CI on backend changes. • `docs/TESTING.md`: documented. *Verified:* full local run green (all 7 assertions pass). CI will confirm on runners.
github2 14:52:09
Gives us the missing automated deploy-confidence pipeline for the backend API. No app code changes — test infrastructure only. *What it does:* `backend/scripts/e2e-api-test.sh` builds the prod image, boots it with the real prod entrypoint (`start_prod.sh` → gunicorn) against a throwaway PostGIS DB, applies migrations, then asserts over HTTP: statistics endpoints, swagger wiring, and a factory create → nearby-query round-trip. Self-contained with teardown trap; compose v2 with v1 fallback. *Also in this PR:* • `docker-compose.test.yml`: `SKIP_MIGRATION_EXTERNAL_API=true`. Migration 0015's expensive step (Easymap call per factory) is a no-op on empty test DBs; this pins fast/hermetic migrates by intent. Prod/staging unaffected (0015 applied years ago, restores don't re-run migrations). Verified the gated task now hits the new by-coord-db endpoint post-<https://github.com/Disfactory/Disfactory/pull/698|#698>. • `integration-test.sh`: hardcoded `/home/runner/work/...` path → script-relative (it was unrunnable anywhere else). • `.github/workflows/e2e.yml`: runs the e2e in CI on backend changes. • `docs/TESTING.md`: documented. *Verified:* full local run green (all 7 assertions pass). CI will confirm on runners.
github2 14:58:00
`<https://github.com/Disfactory/Disfactory/commit/870d5f5bbcc3f67b0c7b7f1e878dd6b9259a405c|870d5f5b>` - chore: raise minimum Python to 3.9 (align CI with Docker images) (#703)
github2 14:58:00
`<https://github.com/Disfactory/Disfactory/commit/870d5f5bbcc3f67b0c7b7f1e878dd6b9259a405c|870d5f5b>` - chore: raise minimum Python to 3.9 (align CI with Docker images) (#703)
github2 14:59:27
`<https://github.com/Disfactory/Disfactory/commit/8fcd0b8685233d5d99229b4b52591c69c1879242|8fcd0b86>` - chore: upgrade Django 2.2 to 3.2 LTS (#704)
github2 14:59:27
`<https://github.com/Disfactory/Disfactory/commit/8fcd0b8685233d5d99229b4b52591c69c1879242|8fcd0b86>` - chore: upgrade Django 2.2 to 3.2 LTS (#704)
github2 14:59:59
`<https://github.com/Disfactory/Disfactory/commit/72d64a5349618a813b03a115db1fe578c97bcd4f|72d64a53>` - chore: add API end-to-end deploy-confidence test (#705)
github2 14:59:59
`<https://github.com/Disfactory/Disfactory/commit/72d64a5349618a813b03a115db1fe578c97bcd4f|72d64a53>` - chore: add API end-to-end deploy-confidence test (#705)
github2 15:02:56
*Context* Production cutover is done (traffic serves from the new host; legacy host retired to standby, cron disabled). Backend API, frontend, and SpotDiff API all healthy. This issue tracks the backend dependency/stack modernization that follows the cutover. It is the entry point for continuing agents — everything below is verifiable from this repo + CI. Current stack on `master`: *uv* packaging (`backend/pyproject.toml` + `backend/uv.lock`), *Python ≥ 3.9* (CI container `python:3.9`, same as Dockerfiles), *Django 3.2 LTS*, pytest with coverage gating (Codecov), plus an e2e deploy-confidence workflow (`.github/workflows/e2e.yml`). *Landed (Nov 2026, all squash-merged, CI green)* • <https://github.com/Disfactory/Disfactory/pull/700|#700> — removed deprecated Zeabur files, review-app workflows, and the review-app job from the image-build workflow. Follow-up done outside code: `ZEABUR_*` repo secrets/variables should be deleted in Settings. • <https://github.com/Disfactory/Disfactory/pull/701|#701> — backend test coverage reporting (fresh restart of <https://github.com/Disfactory/Disfactory/pull/686|#686>; the old approach of declaring `pytest-cov` in `pyproject.toml` could never work — the resolver can't handle it on old Python, so tooling installs via the lockfile now). • <https://github.com/Disfactory/Disfactory/pull/702|#702> — Poetry → uv migration (fresh restart of <https://github.com/Disfactory/Disfactory/pull/681|#681>). Same dependency versions, tooling only. Two fixes found by local verification, worth knowing: `uv sync` targets dependency *groups*, not `optional-dependencies` extras (using extras silently skips dev deps); and `setuptools&lt;81` is a declared runtime dep because gunicorn 20.1.0 imports `pkg_resources` (removed in setuptools ≥ 81). • <https://github.com/Disfactory/Disfactory/pull/703|#703> — minimum Python 3.7 → 3.9 (aligns CI with Docker images). No app dep changes. • <https://github.com/Disfactory/Disfactory/pull/704|#704> — Django 2.2 → 3.2 LTS (stacked on <https://github.com/Disfactory/Disfactory/pull/703|#703>). No app code changes; added `DEFAULT_AUTO_FIELD = AutoField` to preserve implicit-PK behavior. • <https://github.com/Disfactory/Disfactory/pull/698|#698> — Easymap migrated to the new by-coord-db API (was already running in production before merge). • <https://github.com/Disfactory/Disfactory/pull/693|#693> (Jan 2026) — filesystem image-upload API, live in production with daily uploads. *Closed as stale/superseded (no action needed)* • <https://github.com/Disfactory/Disfactory/pull/642|#642> (easymap timeout fix — superseded by <https://github.com/Disfactory/Disfactory/pull/698|#698>), <https://github.com/Disfactory/Disfactory/pull/555|#555> (2021 MOEA script), <https://github.com/Disfactory/Disfactory/pull/660|#660> (ImageBB upload backend — direction settled on local filesystem storage, S3/R2 tracked in <https://github.com/Disfactory/Disfactory/pull/678|#678>), <https://github.com/Disfactory/Disfactory/pull/686|#686> (restarted as <https://github.com/Disfactory/Disfactory/pull/701|#701>), <https://github.com/Disfactory/Disfactory/pull/681|#681> (restarted as <https://github.com/Disfactory/Disfactory/pull/702|#702>). *Open queue (needs triage/decision)* • <https://github.com/Disfactory/Disfactory/pull/678|#678> (S3/R2 extensible upload) vs <https://github.com/Disfactory/Disfactory/issues/676|#676> (migrate imgur to R2) — overlapping; decide one direction now that local storage is live. • <https://github.com/Disfactory/Disfactory/pull/686|#686> is closed; test-coverage follow-up issue <https://github.com/Disfactory/Disfactory/issues/664|#664> stays open for deeper coverage. • <https://github.com/Disfactory/Disfactory/pull/654|#654> / <https://github.com/Disfactory/Disfactory/pull/653|#653> / <https://github.com/Disfactory/Disfactory/pull/651|#651> — Dependabot bumps (gunicorn 23, jinja2, certifi). Hold until the Django 4.2 step lands, then take them. • <https://github.com/Disfactory/Disfactory/pull/640|#640> (expose 不檢討 factories, mergeable), <https://github.com/Disfactory/Disfactory/issues/184|#184> (frontend, mergeable) — small, reviewable. • <https://github.com/Disfactory/Disfactory/issues/697|#697>, <https://github.com/Disfactory/Disfactory/issues/696|#696>, <https://github.com/Disfactory/Disfactory/issues/695|#695>, <https://github.com/Disfactory/Disfactory/issues/689|#689>, <https://github.com/Disfactory/Disfactory/issues/687|#687>, <https://github.com/Disfactory/Disfactory/issues/684|#684>, <https://github.com/Disfactory/Disfactory/issues/657|#657>, <https://github.com/Disfactory/Disfactory/issues/655|#655>, <https://github.com/Disfactory/Disfactory/issues/652|#652>, <https://github.com/Disfactory/Disfactory/issues/635|#635>, <https://github.com/Disfactory/Disfactory/issues/629|#629>, <https://github.com/Disfactory/Disfactory/issues/475|#475>, <https://github.com/Disfactory/Disfactory/issues/328|#328> — 3.0 milestone backlog (see below). *Suggested next steps (in order)* 1. *Django 3.2 → 4.2 LTS.* Known blockers in the same PR: upgrade `django-q` (1.0.2 uses `ugettext_lazy`, removed in 4.0) and DRF (3.11 uses `default_app_config`). Watch for `index_together`, `force_text`, `url()` removals — current code is mostly clean already. 2. *Library upgrades* under uv (`uv lock --upgrade` per package so breakage is bisectable): gunicorn 20 → 23 (then the `setuptools&lt;81` hack can go), psycopg2 (unblocks <https://github.com/Disfactory/Disfactory/issues/683|#683>), DRF, then the Dependabot trio. 3. *Deeper backend coverage* on the new stack, targeted at whatever the upgrades touch. 4. *Milestone 3.0 連續再裁罰*: 12 backend + 3 frontend issues open, 0 closed — needs a triage pass (likely critical path: <https://github.com/Disfactory/Disfactory/issues/697|#697> timeline API, <https://github.com/Disfactory/Disfactory/issues/696|#696>/<https://github.com/Disfactory/Disfactory/issues/652|#652> 地號, frontend <https://github.com/Disfactory/Disfactory/issues/185|#185>/<https://github.com/Disfactory/Disfactory/issues/182|#182>/<https://github.com/Disfactory/Disfactory/pull/181|#181>). *Working conventions (please follow)* • One concern per PR, stacked with `--base` when dependent; never auto-merge — maintainer reviews everything. • `uv.lock` is the source of truth; keep app pins exact during tooling PRs. • Verify beyond CI before opening: replicate the CI job locally with `python:3.9` + `postgres:12` containers (`uv sync --dev`, then the exact pytest invocation), and `docker build` the prod targets (gunicorn must boot — see <https://github.com/Disfactory/Disfactory/pull/702|#702> notes). • CI must-have jobs: `backend-tests` (unit) and `e2e-api` (deploy confidence, boots the prod image and round-trips the HTTP API).
github2 15:02:56
*Context* Production cutover is done (traffic serves from the new host; legacy host retired to standby, cron disabled). Backend API, frontend, and SpotDiff API all healthy. This issue tracks the backend dependency/stack modernization that follows the cutover. It is the entry point for continuing agents — everything below is verifiable from this repo + CI. Current stack on `master`: *uv* packaging (`backend/pyproject.toml` + `backend/uv.lock`), *Python ≥ 3.9* (CI container `python:3.9`, same as Dockerfiles), *Django 3.2 LTS*, pytest with coverage gating (Codecov), plus an e2e deploy-confidence workflow (`.github/workflows/e2e.yml`). *Landed (Nov 2026, all squash-merged, CI green)* • <https://github.com/Disfactory/Disfactory/pull/700|#700> — removed deprecated Zeabur files, review-app workflows, and the review-app job from the image-build workflow. Follow-up done outside code: `ZEABUR_*` repo secrets/variables should be deleted in Settings. • <https://github.com/Disfactory/Disfactory/pull/701|#701> — backend test coverage reporting (fresh restart of <https://github.com/Disfactory/Disfactory/pull/686|#686>; the old approach of declaring `pytest-cov` in `pyproject.toml` could never work — the resolver can't handle it on old Python, so tooling installs via the lockfile now). • <https://github.com/Disfactory/Disfactory/pull/702|#702> — Poetry → uv migration (fresh restart of <https://github.com/Disfactory/Disfactory/pull/681|#681>). Same dependency versions, tooling only. Two fixes found by local verification, worth knowing: `uv sync` targets dependency *groups*, not `optional-dependencies` extras (using extras silently skips dev deps); and `setuptools&lt;81` is a declared runtime dep because gunicorn 20.1.0 imports `pkg_resources` (removed in setuptools ≥ 81). • <https://github.com/Disfactory/Disfactory/pull/703|#703> — minimum Python 3.7 → 3.9 (aligns CI with Docker images). No app dep changes. • <https://github.com/Disfactory/Disfactory/pull/704|#704> — Django 2.2 → 3.2 LTS (stacked on <https://github.com/Disfactory/Disfactory/pull/703|#703>). No app code changes; added `DEFAULT_AUTO_FIELD = AutoField` to preserve implicit-PK behavior. • <https://github.com/Disfactory/Disfactory/pull/698|#698> — Easymap migrated to the new by-coord-db API (was already running in production before merge). • <https://github.com/Disfactory/Disfactory/pull/693|#693> (Jan 2026) — filesystem image-upload API, live in production with daily uploads. *Closed as stale/superseded (no action needed)* • <https://github.com/Disfactory/Disfactory/pull/642|#642> (easymap timeout fix — superseded by <https://github.com/Disfactory/Disfactory/pull/698|#698>), <https://github.com/Disfactory/Disfactory/pull/555|#555> (2021 MOEA script), <https://github.com/Disfactory/Disfactory/pull/660|#660> (ImageBB upload backend — direction settled on local filesystem storage, S3/R2 tracked in <https://github.com/Disfactory/Disfactory/pull/678|#678>), <https://github.com/Disfactory/Disfactory/pull/686|#686> (restarted as <https://github.com/Disfactory/Disfactory/pull/701|#701>), <https://github.com/Disfactory/Disfactory/pull/681|#681> (restarted as <https://github.com/Disfactory/Disfactory/pull/702|#702>). *Open queue (needs triage/decision)* • <https://github.com/Disfactory/Disfactory/pull/678|#678> (S3/R2 extensible upload) vs <https://github.com/Disfactory/Disfactory/issues/676|#676> (migrate imgur to R2) — overlapping; decide one direction now that local storage is live. • <https://github.com/Disfactory/Disfactory/pull/686|#686> is closed; test-coverage follow-up issue <https://github.com/Disfactory/Disfactory/issues/664|#664> stays open for deeper coverage. • <https://github.com/Disfactory/Disfactory/pull/654|#654> / <https://github.com/Disfactory/Disfactory/pull/653|#653> / <https://github.com/Disfactory/Disfactory/pull/651|#651> — Dependabot bumps (gunicorn 23, jinja2, certifi). Hold until the Django 4.2 step lands, then take them. • <https://github.com/Disfactory/Disfactory/pull/640|#640> (expose 不檢討 factories, mergeable), <https://github.com/Disfactory/Disfactory/issues/184|#184> (frontend, mergeable) — small, reviewable. • <https://github.com/Disfactory/Disfactory/issues/697|#697>, <https://github.com/Disfactory/Disfactory/issues/696|#696>, <https://github.com/Disfactory/Disfactory/issues/695|#695>, <https://github.com/Disfactory/Disfactory/issues/689|#689>, <https://github.com/Disfactory/Disfactory/issues/687|#687>, <https://github.com/Disfactory/Disfactory/issues/684|#684>, <https://github.com/Disfactory/Disfactory/issues/657|#657>, <https://github.com/Disfactory/Disfactory/issues/655|#655>, <https://github.com/Disfactory/Disfactory/issues/652|#652>, <https://github.com/Disfactory/Disfactory/issues/635|#635>, <https://github.com/Disfactory/Disfactory/issues/629|#629>, <https://github.com/Disfactory/Disfactory/issues/475|#475>, <https://github.com/Disfactory/Disfactory/issues/328|#328> — 3.0 milestone backlog (see below). *Suggested next steps (in order)* 1. *Django 3.2 → 4.2 LTS.* Known blockers in the same PR: upgrade `django-q` (1.0.2 uses `ugettext_lazy`, removed in 4.0) and DRF (3.11 uses `default_app_config`). Watch for `index_together`, `force_text`, `url()` removals — current code is mostly clean already. 2. *Library upgrades* under uv (`uv lock --upgrade` per package so breakage is bisectable): gunicorn 20 → 23 (then the `setuptools&lt;81` hack can go), psycopg2 (unblocks <https://github.com/Disfactory/Disfactory/issues/683|#683>), DRF, then the Dependabot trio. 3. *Deeper backend coverage* on the new stack, targeted at whatever the upgrades touch. 4. *Milestone 3.0 連續再裁罰*: 12 backend + 3 frontend issues open, 0 closed — needs a triage pass (likely critical path: <https://github.com/Disfactory/Disfactory/issues/697|#697> timeline API, <https://github.com/Disfactory/Disfactory/issues/696|#696>/<https://github.com/Disfactory/Disfactory/issues/652|#652> 地號, frontend <https://github.com/Disfactory/Disfactory/issues/185|#185>/<https://github.com/Disfactory/Disfactory/issues/182|#182>/<https://github.com/Disfactory/Disfactory/pull/181|#181>). *Working conventions (please follow)* • One concern per PR, stacked with `--base` when dependent; never auto-merge — maintainer reviews everything. • `uv.lock` is the source of truth; keep app pins exact during tooling PRs. • Verify beyond CI before opening: replicate the CI job locally with `python:3.9` + `postgres:12` containers (`uv sync --dev`, then the exact pytest invocation), and `docker build` the prod targets (gunicorn must boot — see <https://github.com/Disfactory/Disfactory/pull/702|#702> notes). • CI must-have jobs: `backend-tests` (unit) and `e2e-api` (deploy confidence, boots the prod image and round-trips the HTTP API).
github2 15:13:42
Follows <https://github.com/Disfactory/Disfactory/issues/706|#706> suggested next step 1. *Companion upgrades (all py3.9-compatible, minimum viable for Django 4.2)* • django 3.2.25 -&gt; 4.2.30 • djangorestframework 3.11.2 -&gt; 3.15.2 • django-q 1.0.2 -&gt; django-q2 1.9.0 (maintained fork, same `django_q` app label; `async_task` import and Q_CLUSTER unchanged) • django-cors-headers 3.7.0 -&gt; 4.9.0 • django-admin-rangefilter 0.6.4 -&gt; 0.10.0 • drf-yasg 1.17.1 -&gt; 1.21.15 • django-import-export 2.5.0 -&gt; 3.3.9 • pytest-django 4.5.2 -&gt; 4.11.1 (dev) Out of scope (step 2 in <https://github.com/Disfactory/Disfactory/issues/706|#706>): gunicorn, psycopg2, requests, pillow bumps. *App-code fixes* • `api/migrations/0001_initial.py`: `django.contrib.postgres.fields.jsonb` (removed in Django 4.0) -&gt; `models.JSONField` • `api/models/report_record.py`: postgres `JSONField` -&gt; `django.db.models.JSONField` • `settings.py`: drop deprecated `USE_L10N`; rename `CORS_ORIGIN_WHITELIST` -&gt; `CORS_ALLOWED_ORIGINS` • `api/admin/factory.py`: `rangefilter.filter` -&gt; `rangefilter.filters` App code was otherwise clean: no ugettext/force_text/index_together/url() usage; URLs already use path(). *Verification (per <https://github.com/Disfactory/Disfactory/issues/706|#706> conventions, python:3.9 + postgres:12)* • `uv sync --dev` + `pytest -k 'not test_easymap'`: 64 passed • `python manage.py test`: 0 tests, OK (same as CI) • startup-scripts syntax test passes • e2e deploy-confidence (`scripts/e2e-api-test.sh`): prod image builds, migrations apply (incl. django_q), gunicorn boots, stats/swagger/factory-create/nearby-query round-trip • Remaining warnings are pre-existing third-party deprecations (docxcompose pkg_resources, drf-yasg renderers), unchanged by this PR.
github2 15:13:42
Follows <https://github.com/Disfactory/Disfactory/issues/706|#706> suggested next step 1. *Companion upgrades (all py3.9-compatible, minimum viable for Django 4.2)* • django 3.2.25 -&gt; 4.2.30 • djangorestframework 3.11.2 -&gt; 3.15.2 • django-q 1.0.2 -&gt; django-q2 1.9.0 (maintained fork, same `django_q` app label; `async_task` import and Q_CLUSTER unchanged) • django-cors-headers 3.7.0 -&gt; 4.9.0 • django-admin-rangefilter 0.6.4 -&gt; 0.10.0 • drf-yasg 1.17.1 -&gt; 1.21.15 • django-import-export 2.5.0 -&gt; 3.3.9 • pytest-django 4.5.2 -&gt; 4.11.1 (dev) Out of scope (step 2 in <https://github.com/Disfactory/Disfactory/issues/706|#706>): gunicorn, psycopg2, requests, pillow bumps. *App-code fixes* • `api/migrations/0001_initial.py`: `django.contrib.postgres.fields.jsonb` (removed in Django 4.0) -&gt; `models.JSONField` • `api/models/report_record.py`: postgres `JSONField` -&gt; `django.db.models.JSONField` • `settings.py`: drop deprecated `USE_L10N`; rename `CORS_ORIGIN_WHITELIST` -&gt; `CORS_ALLOWED_ORIGINS` • `api/admin/factory.py`: `rangefilter.filter` -&gt; `rangefilter.filters` App code was otherwise clean: no ugettext/force_text/index_together/url() usage; URLs already use path(). *Verification (per <https://github.com/Disfactory/Disfactory/issues/706|#706> conventions, python:3.9 + postgres:12)* • `uv sync --dev` + `pytest -k 'not test_easymap'`: 64 passed • `python manage.py test`: 0 tests, OK (same as CI) • startup-scripts syntax test passes • e2e deploy-confidence (`scripts/e2e-api-test.sh`): prod image builds, migrations apply (incl. django_q), gunicorn boots, stats/swagger/factory-create/nearby-query round-trip • Remaining warnings are pre-existing third-party deprecations (docxcompose pkg_resources, drf-yasg renderers), unchanged by this PR.
github2 15:50:54
`<https://github.com/Disfactory/devops/commit/c65be9a645090863858e5224a3bb4550ea1ba7f6|c65be9a6>` - fix(staging): serve /media/* from image-uploads dir (mirror production)
github2 15:50:54
`<https://github.com/Disfactory/devops/commit/c65be9a645090863858e5224a3bb4550ea1ba7f6|c65be9a6>` - fix(staging): serve /media/* from image-uploads dir (mirror production)
github2 15:57:09
Stacked on <https://github.com/Disfactory/Disfactory/pull/707|#707>. Follows <https://github.com/Disfactory/Disfactory/issues/706|#706> step 2 — one concern per commit so breakage is bisectable (verified as a whole below; bisect with the individual commits if CI flags anything). *Commits* • *gunicorn 20.1.0 -&gt; 23.0.0*, drop `setuptools&lt;81` pin (workaround from <https://github.com/Disfactory/Disfactory/pull/702|#702> no longer needed; setuptools remains only as unpinned transitive dep of docxcompose). Supersedes Dependabot <https://github.com/Disfactory/Disfactory/pull/654|#654>. • *psycopg2-binary 2.8.6 -&gt; 2.9.12* (2.8.6 ships no cp39 wheels; 2.9.12 is newest 2.9.x supporting Python 3.9 with manylinux cp39 wheels). Closes <https://github.com/Disfactory/Disfactory/issues/683|#683>. • *requests 2.25.1 -&gt; 2.32.5* (CVEs), *pillow 9.0.1 -&gt; 9.5.0* (only Image.open/verify in use), *python-dotenv 0.14.0 -&gt; 1.1.1* (newest supporting Python 3.9). chardet -&gt; charset-normalizer follows requests. • *djangorestframework 3.15.2 -&gt; 3.16.1* (newest supporting Python 3.9). *Already resolved, no action* • <https://github.com/Disfactory/Disfactory/pull/651|#651> (certifi bump): satisfied — lock already resolved certifi 2026.10.23 during <https://github.com/Disfactory/Disfactory/pull/707|#707>. Suggest closing. • <https://github.com/Disfactory/Disfactory/pull/653|#653> (jinja2 bump): obsolete — jinja2 is no longer in uv.lock after <https://github.com/Disfactory/Disfactory/pull/707|#707>. Suggest closing. *Verification (python:3.9 + postgres:12, per <https://github.com/Disfactory/Disfactory/issues/706|#706> conventions)* • `uv sync --dev` + `pytest -k 'not test_easymap'`: 64 passed, coverage 89% • `python manage.py test`: OK; startup-scripts test passes • e2e deploy-confidence: prod image builds, gunicorn 23 boots via prod entrypoint, migrations apply, all endpoint round-trips pass
github2 15:57:09
Stacked on <https://github.com/Disfactory/Disfactory/pull/707|#707>. Follows <https://github.com/Disfactory/Disfactory/issues/706|#706> step 2 — one concern per commit so breakage is bisectable (verified as a whole below; bisect with the individual commits if CI flags anything). *Commits* • *gunicorn 20.1.0 -&gt; 23.0.0*, drop `setuptools&lt;81` pin (workaround from <https://github.com/Disfactory/Disfactory/pull/702|#702> no longer needed; setuptools remains only as unpinned transitive dep of docxcompose). Supersedes Dependabot <https://github.com/Disfactory/Disfactory/pull/654|#654>. • *psycopg2-binary 2.8.6 -&gt; 2.9.12* (2.8.6 ships no cp39 wheels; 2.9.12 is newest 2.9.x supporting Python 3.9 with manylinux cp39 wheels). Closes <https://github.com/Disfactory/Disfactory/issues/683|#683>. • *requests 2.25.1 -&gt; 2.32.5* (CVEs), *pillow 9.0.1 -&gt; 9.5.0* (only Image.open/verify in use), *python-dotenv 0.14.0 -&gt; 1.1.1* (newest supporting Python 3.9). chardet -&gt; charset-normalizer follows requests. • *djangorestframework 3.15.2 -&gt; 3.16.1* (newest supporting Python 3.9). *Already resolved, no action* • <https://github.com/Disfactory/Disfactory/pull/651|#651> (certifi bump): satisfied — lock already resolved certifi 2026.10.23 during <https://github.com/Disfactory/Disfactory/pull/707|#707>. Suggest closing. • <https://github.com/Disfactory/Disfactory/pull/653|#653> (jinja2 bump): obsolete — jinja2 is no longer in uv.lock after <https://github.com/Disfactory/Disfactory/pull/707|#707>. Suggest closing. *Verification (python:3.9 + postgres:12, per <https://github.com/Disfactory/Disfactory/issues/706|#706> conventions)* • `uv sync --dev` + `pytest -k 'not test_easymap'`: 64 passed, coverage 89% • `python manage.py test`: OK; startup-scripts test passes • e2e deploy-confidence: prod image builds, gunicorn 23 boots via prod entrypoint, migrations apply, all endpoint round-trips pass
github2 16:01:59
`<https://github.com/Disfactory/devops/commit/1c5aa6762936c9b150f658ea305e1c390471b6c8|1c5aa676>` - docs(cutover): confirm staging feed switched to new prod backup
github2 16:01:59
`<https://github.com/Disfactory/devops/commit/1c5aa6762936c9b150f658ea305e1c390471b6c8|1c5aa676>` - docs(cutover): confirm staging feed switched to new prod backup
github2 17:00:31
`<https://github.com/Disfactory/devops/commit/e1d7ff7f850bad9ae290e8643f7e71ad5347b860|e1d7ff7f>` - docs(cutover): 17:00 check confirms backup feed, restore pending, note UTC lag
github2 17:00:31
`<https://github.com/Disfactory/devops/commit/e1d7ff7f850bad9ae290e8643f7e71ad5347b860|e1d7ff7f>` - docs(cutover): 17:00 check confirms backup feed, restore pending, note UTC lag
github2 17:10:17
Stacked on <https://github.com/Disfactory/Disfactory/pull/708|#708>. Step 3 of <https://github.com/Disfactory/Disfactory/issues/706|#706>, follow-up to <https://github.com/Disfactory/Disfactory/issues/664|#664> — targeted at what the upgrades touch. *Tests (64 -&gt; 97, coverage 89% -&gt; 92%)* • *tasks* (django-q paths, was 57%): imgur errors/credits fallback, bad-JSON fallback, update_landcode success/failure, upload_image missing-file/DB-failure/remove-failure. Now 100%. • *image_upload* (Pillow paths, was 91%): no-extension helper, OSError -&gt; 500, unexpected -&gt; 500. Now 100%. • *utils* (new test file): _get_client_ip variants, _sample, radius-sampling path. Now 100%. • *views*: location 404, sectcode missing/invalid/not-found, image datetime variants, statistics invalid-param 400s, DEMOLISHED total, get_action_change (previously 0 tests), serializer document_display_status, invalid update payload. *Bug fixes found by the new tests* • tasks.py: imgur non-JSON response crashed the handler itself (NameError on unbound resp_data). • statistics_r.py: invalid display_status 500'd (helper returned HttpResponse where callers expect a queryset) — validation moved into the three views via a shared helper; also fixed a swapped-argument HttpResponse(400, ...) on invalid level. *Verification (python:3.9 + postgres:12)* • pytest -k 'not test_easymap': 97 passed • e2e deploy-confidence: prod image builds, boots, migrations + API round-trips pass *Deliberately left out (pre-existing, out of scope)* • Admin action coverage (export_csv/merge factories, 12-39%) — untouched by upgrades. • Dead code flagged, not removed: factories_u:60 ('status' not a model field), statistics_r dead else, JSONDecodeError branches in image views (unreachable under DRF — request.data raises ParseError instead).
github2 17:10:17
Stacked on <https://github.com/Disfactory/Disfactory/pull/708|#708>. Step 3 of <https://github.com/Disfactory/Disfactory/issues/706|#706>, follow-up to <https://github.com/Disfactory/Disfactory/issues/664|#664> — targeted at what the upgrades touch. *Tests (64 -&gt; 97, coverage 89% -&gt; 92%)* • *tasks* (django-q paths, was 57%): imgur errors/credits fallback, bad-JSON fallback, update_landcode success/failure, upload_image missing-file/DB-failure/remove-failure. Now 100%. • *image_upload* (Pillow paths, was 91%): no-extension helper, OSError -&gt; 500, unexpected -&gt; 500. Now 100%. • *utils* (new test file): _get_client_ip variants, _sample, radius-sampling path. Now 100%. • *views*: location 404, sectcode missing/invalid/not-found, image datetime variants, statistics invalid-param 400s, DEMOLISHED total, get_action_change (previously 0 tests), serializer document_display_status, invalid update payload. *Bug fixes found by the new tests* • tasks.py: imgur non-JSON response crashed the handler itself (NameError on unbound resp_data). • statistics_r.py: invalid display_status 500'd (helper returned HttpResponse where callers expect a queryset) — validation moved into the three views via a shared helper; also fixed a swapped-argument HttpResponse(400, ...) on invalid level. *Verification (python:3.9 + postgres:12)* • pytest -k 'not test_easymap': 97 passed • e2e deploy-confidence: prod image builds, boots, migrations + API round-trips pass *Deliberately left out (pre-existing, out of scope)* • Admin action coverage (export_csv/merge factories, 12-39%) — untouched by upgrades. • Dead code flagged, not removed: factories_u:60 ('status' not a model field), statistics_r dead else, JSONDecodeError branches in image views (unreachable under DRF — request.data raises ParseError instead).
github2 17:28:51
Triage of the 3.0 連續再裁罰功能上線 milestone (12 open) plus <https://github.com/Disfactory/Disfactory/issues/695|#695>/<https://github.com/Disfactory/Disfactory/issues/687|#687> and frontend <https://github.com/Disfactory/Disfactory/issues/185|#185>/<https://github.com/Disfactory/Disfactory/issues/182|#182>/<https://github.com/Disfactory/Disfactory/pull/181|#181>, done 2026-11-05 on top of the Django 4.2 stack (<https://github.com/Disfactory/Disfactory/pull/707|#707>-<https://github.com/Disfactory/Disfactory/pull/709|#709>). Prerequisite: merge <https://github.com/Disfactory/Disfactory/pull/707|#707> → <https://github.com/Disfactory/Disfactory/pull/708|#708> → <https://github.com/Disfactory/Disfactory/pull/709|#709> and deploy to production. *Build queue (in order)* 1. *<https://github.com/Disfactory/Disfactory/issues/697|#697> Factory timeline API* — the only fully-specced backend task (plan in <https://github.com/Disfactory/Disfactory/issues/655|#655> thread: GET /api/factories//timeline + ReportRecordSerializer action_type/action_body). Core of the 再裁罰 UX. Self-contained, no blockers. 2. *<https://github.com/Disfactory/Disfactory/issues/635|#635> landing-page statistics API* — small quick win (cumulative reporters/documents/penalized factories; needs exact definitions: distinct reporters? which display_status counts as 裁罰?). Pairs well with <https://github.com/Disfactory/Disfactory/issues/697|#697>. 3. *<https://github.com/Disfactory/Disfactory/issues/652|#652> new landcode format* — small parse/normalize + verify task (zero-padded 8-digit 母號+子號). Unblocks the data work below. 4. *<https://github.com/Disfactory/Disfactory/issues/695|#695>/<https://github.com/Disfactory/Disfactory/issues/696|#696> landcode bulk conversion* — dupes, close <https://github.com/Disfactory/Disfactory/issues/696|#696> keep <https://github.com/Disfactory/Disfactory/issues/695|#695>. Needs data-source decision (easymap crawler per <https://github.com/Disfactory/Disfactory/issues/695|#695> comment vs MOI services in <https://github.com/Disfactory/Disfactory/issues/687|#687>). 5. *<https://github.com/Disfactory/Disfactory/issues/687|#687> converter freshness* — needs test cases first (待辦:找案例測試, factories 63522/63391); root cause stale-data vs mis-entry unresolved. 6. *Frontend (Disfactory/frontend): <https://github.com/Disfactory/Disfactory/issues/185|#185> photo upload broken* — highest severity in the set on a reporting platform; possibly linked to the <https://github.com/Disfactory/Disfactory/pull/693|#693> filesystem upload backend. Then <https://github.com/Disfactory/Disfactory/pull/181|#181> minimap, <https://github.com/Disfactory/Disfactory/issues/182|#182> mobile more-info. *Parked — needs an owner/decision, not engineering yet* • <https://github.com/Disfactory/Disfactory/issues/689|#689> (PRD is a stub, depends on <https://github.com/Disfactory/Disfactory/issues/389|#389> wiki), <https://github.com/Disfactory/Disfactory/issues/629|#629> (MOEA source + frontend design missing since 2023), <https://github.com/Disfactory/Disfactory/issues/475|#475> (email-vs-SMS + mail infra decision), <https://github.com/Disfactory/Disfactory/issues/684|#684>/<https://github.com/Disfactory/Disfactory/issues/682|#682>/<https://github.com/Disfactory/Disfactory/issues/657|#657> (research/compliance, need owners). *Suggested closes* • <https://github.com/Disfactory/Disfactory/pull/653|#653> (jinja2 — gone from uv.lock), <https://github.com/Disfactory/Disfactory/pull/651|#651> (certifi — lock already past the target), <https://github.com/Disfactory/Disfactory/issues/696|#696> (dupe of <https://github.com/Disfactory/Disfactory/issues/695|#695>), <https://github.com/Disfactory/Disfactory/issues/328|#328> (2020 one-liner, confirm against current UI). *Notes* • Coverage PR <https://github.com/Disfactory/Disfactory/pull/709|#709> fixed two latent bugs (tasks imgur NameError, statistics display_status/level 500s) and flagged dead code (factories_u status branch, statistics dead else, JSONDecodeError branches) — left for maintainer call. • Staging is at the tip of <https://github.com/Disfactory/Disfactory/pull/707|#707> → <https://github.com/Disfactory/Disfactory/pull/708|#708> → <https://github.com/Disfactory/Disfactory/pull/709|#709> and green.
github2 17:28:51
Triage of the 3.0 連續再裁罰功能上線 milestone (12 open) plus <https://github.com/Disfactory/Disfactory/issues/695|#695>/<https://github.com/Disfactory/Disfactory/issues/687|#687> and frontend <https://github.com/Disfactory/Disfactory/issues/185|#185>/<https://github.com/Disfactory/Disfactory/issues/182|#182>/<https://github.com/Disfactory/Disfactory/pull/181|#181>, done 2026-11-05 on top of the Django 4.2 stack (<https://github.com/Disfactory/Disfactory/pull/707|#707>-<https://github.com/Disfactory/Disfactory/pull/709|#709>). Prerequisite: merge <https://github.com/Disfactory/Disfactory/pull/707|#707> → <https://github.com/Disfactory/Disfactory/pull/708|#708> → <https://github.com/Disfactory/Disfactory/pull/709|#709> and deploy to production. *Build queue (in order)* 1. *<https://github.com/Disfactory/Disfactory/issues/697|#697> Factory timeline API* — the only fully-specced backend task (plan in <https://github.com/Disfactory/Disfactory/issues/655|#655> thread: GET /api/factories//timeline + ReportRecordSerializer action_type/action_body). Core of the 再裁罰 UX. Self-contained, no blockers. 2. *<https://github.com/Disfactory/Disfactory/issues/635|#635> landing-page statistics API* — small quick win (cumulative reporters/documents/penalized factories; needs exact definitions: distinct reporters? which display_status counts as 裁罰?). Pairs well with <https://github.com/Disfactory/Disfactory/issues/697|#697>. 3. *<https://github.com/Disfactory/Disfactory/issues/652|#652> new landcode format* — small parse/normalize + verify task (zero-padded 8-digit 母號+子號). Unblocks the data work below. 4. *<https://github.com/Disfactory/Disfactory/issues/695|#695>/<https://github.com/Disfactory/Disfactory/issues/696|#696> landcode bulk conversion* — dupes, close <https://github.com/Disfactory/Disfactory/issues/696|#696> keep <https://github.com/Disfactory/Disfactory/issues/695|#695>. Needs data-source decision (easymap crawler per <https://github.com/Disfactory/Disfactory/issues/695|#695> comment vs MOI services in <https://github.com/Disfactory/Disfactory/issues/687|#687>). 5. *<https://github.com/Disfactory/Disfactory/issues/687|#687> converter freshness* — needs test cases first (待辦:找案例測試, factories 63522/63391); root cause stale-data vs mis-entry unresolved. 6. *Frontend (Disfactory/frontend): <https://github.com/Disfactory/Disfactory/issues/185|#185> photo upload broken* — highest severity in the set on a reporting platform; possibly linked to the <https://github.com/Disfactory/Disfactory/pull/693|#693> filesystem upload backend. Then <https://github.com/Disfactory/Disfactory/pull/181|#181> minimap, <https://github.com/Disfactory/Disfactory/issues/182|#182> mobile more-info. *Parked — needs an owner/decision, not engineering yet* • <https://github.com/Disfactory/Disfactory/issues/689|#689> (PRD is a stub, depends on <https://github.com/Disfactory/Disfactory/issues/389|#389> wiki), <https://github.com/Disfactory/Disfactory/issues/629|#629> (MOEA source + frontend design missing since 2023), <https://github.com/Disfactory/Disfactory/issues/475|#475> (email-vs-SMS + mail infra decision), <https://github.com/Disfactory/Disfactory/issues/684|#684>/<https://github.com/Disfactory/Disfactory/issues/682|#682>/<https://github.com/Disfactory/Disfactory/issues/657|#657> (research/compliance, need owners). *Suggested closes* • <https://github.com/Disfactory/Disfactory/pull/653|#653> (jinja2 — gone from uv.lock), <https://github.com/Disfactory/Disfactory/pull/651|#651> (certifi — lock already past the target), <https://github.com/Disfactory/Disfactory/issues/696|#696> (dupe of <https://github.com/Disfactory/Disfactory/issues/695|#695>), <https://github.com/Disfactory/Disfactory/issues/328|#328> (2020 one-liner, confirm against current UI). *Notes* • Coverage PR <https://github.com/Disfactory/Disfactory/pull/709|#709> fixed two latent bugs (tasks imgur NameError, statistics display_status/level 500s) and flagged dead code (factories_u status branch, statistics dead else, JSONDecodeError branches) — left for maintainer call. • Staging is at the tip of <https://github.com/Disfactory/Disfactory/pull/707|#707> → <https://github.com/Disfactory/Disfactory/pull/708|#708> → <https://github.com/Disfactory/Disfactory/pull/709|#709> and green.
github2 17:53:01
在「上傳工廠照片」頁面無法上傳照片 *To Reproduce* Steps to reproduce the behavior: 1. Go to '<http://disfactory.tw|disfactory.tw>' 2. Click on '我想新增可疑工廠' 3. Scroll down to '工廠照片' 4. Click on '新增照片' 5. See error (「上傳錯誤」) *Expected behavior* 上傳照片後可以上傳,不會出現「上傳錯誤」的訊息 *Screenshots* <https://private-user-images.githubusercontent.com/81308197/452763642-949c6529-f5e4-4a32-9ebe-59e3289348c8.jpg?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTM3ODYyODAsIm5iZiI6MTc5Mzc4NTk4MCwicGF0aCI6Ii84MTMwODE5Ny80NTI3NjM2NDItOTQ5YzY1MjktZjVlNC00YTMyLTllYmUtNTllMzI4OTM0OGM4LmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTA0VDA5NTMwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY1Yzg5NzZjYWNmZTBiNWUyYWIxNTBjOGRjZWZjMGQyZWVjYTYzM2ExNjAyZmNjMjA1MTFhODViY2RhMTgwNGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRmpwZWcifQ.VeFkaq7jj1Bg5iP60C9-pTDeEv1bmGb_rp39KB6ufkY|Image> *Desktop (please complete the following information):* • OS: windows 10 • Browser : brave --- Please refer to the backend image upload API change in <https://github.com/Disfactory/Disfactory/pull/660|Disfactory/Disfactory#660>. Since Imgur is no longer working in Taiwan, we have switched to our own image uploading API instead.
github2 17:53:01
在「上傳工廠照片」頁面無法上傳照片 *To Reproduce* Steps to reproduce the behavior: 1. Go to '<http://disfactory.tw|disfactory.tw>' 2. Click on '我想新增可疑工廠' 3. Scroll down to '工廠照片' 4. Click on '新增照片' 5. See error (「上傳錯誤」) *Expected behavior* 上傳照片後可以上傳,不會出現「上傳錯誤」的訊息 *Screenshots* <https://private-user-images.githubusercontent.com/81308197/452763642-949c6529-f5e4-4a32-9ebe-59e3289348c8.jpg?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTM3ODYyODEsIm5iZiI6MTc5Mzc4NTk4MSwicGF0aCI6Ii84MTMwODE5Ny80NTI3NjM2NDItOTQ5YzY1MjktZjVlNC00YTMyLTllYmUtNTllMzI4OTM0OGM4LmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTA0VDA5NTMwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdmMTk0ZmM0N2I4ZjQzOTQ2MDkwZjY2YTA2YzAxMmQ5MjhjMWNmYzE4ZjJhYWZlN2VlYTI3M2VmNzdmOTVkNmQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRmpwZWcifQ.L2gAbPkK5sBxceTpL2nvUFA_7ae8cHwrRiocg6drvr4|Image> *Desktop (please complete the following information):* • OS: windows 10 • Browser : brave --- Please refer to the backend image upload API change in <https://github.com/Disfactory/Disfactory/pull/660|Disfactory/Disfactory#660>. Since Imgur is no longer working in Taiwan, we have switched to our own image uploading API instead.
github2 17:53:03
*Is your feature request related to a problem? Please describe.* A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] *Describe the solution you'd like* A clear and concise description of what you want to happen. *Describe alternatives you've considered* A clear and concise description of any alternative solutions or features you've considered. *Additional context* Add any other context or screenshots about the feature request here.
github2 17:53:03
*Is your feature request related to a problem? Please describe.* A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] *Describe the solution you'd like* A clear and concise description of what you want to happen. *Describe alternatives you've considered* A clear and concise description of any alternative solutions or features you've considered. *Additional context* Add any other context or screenshots about the feature request here.
github2 17:53:08
The image upload system was failing because Imgur's API is blocked in Taiwan. This PR fixes the issue by implementing direct backend uploads using the new multi-backend image upload service introduced in the backend. *Problem* Users in Taiwan were unable to upload factory photos due to the "上傳錯誤" (upload error) message. The frontend was trying to upload images to Imgur first, then sending the URL to the backend, but Imgur's API is blocked in Taiwan. *Solution* Updated the frontend to use direct backend uploads instead of the Imgur-first approach: *Factory Images (Main Fix)* • *Before*: Upload to Imgur → Send URL to `/factories/{id}/images` • *After*: Direct upload to `/factories/{id}/images/upload` with multipart form data *General Images* • *Before*: Upload to Imgur → Send URL to `/images` • *After*: Direct upload to `/images` with multipart form data *Key Changes* 1. *Replaced `updateFactoryImages`* to use the new `/factories/{id}/images/upload` endpoint 2. *Updated `uploadImages`* to upload directly to backend `/images` endpoint 3. *Removed unused Imgur code* (`uploadToImgur`, `uploadExifAndGetToken`, Imgur constants) 4. *Preserved all functionality*: EXIF data extraction, contact information, error handling *Technical Details* The new implementation: • Uploads image files directly as multipart form data • Includes EXIF metadata (GPS coordinates, datetime) in the request • Passes contact information (nickname, contact) for factory images • Maintains the same return format for backward compatibility • Leverages the backend's new multi-backend upload service (Imgur → ImageBB → Cloudflare R2 → Local fallback) *Testing* • :white_check_mark: Code compiles successfully • :white_check_mark: Passes linting with no new issues • :white_check_mark: Maintains existing TypeScript interfaces • :white_check_mark: Preserves all existing functionality This change ensures image uploads work reliably regardless of regional service restrictions while maintaining full backward compatibility. Fixes <https://github.com/Disfactory/frontend/issues/185|#185>. --- :bulb: You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more <https://gh.io/copilot-coding-agent-tips|Copilot coding agent tips> in the docs.
github2 17:53:08
The image upload system was failing because Imgur's API is blocked in Taiwan. This PR fixes the issue by implementing direct backend uploads using the new multi-backend image upload service introduced in the backend. *Problem* Users in Taiwan were unable to upload factory photos due to the "上傳錯誤" (upload error) message. The frontend was trying to upload images to Imgur first, then sending the URL to the backend, but Imgur's API is blocked in Taiwan. *Solution* Updated the frontend to use direct backend uploads instead of the Imgur-first approach: *Factory Images (Main Fix)* • *Before*: Upload to Imgur → Send URL to `/factories/{id}/images` • *After*: Direct upload to `/factories/{id}/images/upload` with multipart form data *General Images* • *Before*: Upload to Imgur → Send URL to `/images` • *After*: Direct upload to `/images` with multipart form data *Key Changes* 1. *Replaced `updateFactoryImages`* to use the new `/factories/{id}/images/upload` endpoint 2. *Updated `uploadImages`* to upload directly to backend `/images` endpoint 3. *Removed unused Imgur code* (`uploadToImgur`, `uploadExifAndGetToken`, Imgur constants) 4. *Preserved all functionality*: EXIF data extraction, contact information, error handling *Technical Details* The new implementation: • Uploads image files directly as multipart form data • Includes EXIF metadata (GPS coordinates, datetime) in the request • Passes contact information (nickname, contact) for factory images • Maintains the same return format for backward compatibility • Leverages the backend's new multi-backend upload service (Imgur → ImageBB → Cloudflare R2 → Local fallback) *Testing* • :white_check_mark: Code compiles successfully • :white_check_mark: Passes linting with no new issues • :white_check_mark: Maintains existing TypeScript interfaces • :white_check_mark: Preserves all existing functionality This change ensures image uploads work reliably regardless of regional service restrictions while maintaining full backward compatibility. Fixes <https://github.com/Disfactory/frontend/issues/185|#185>. --- :bulb: You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more <https://gh.io/copilot-coding-agent-tips|Copilot coding agent tips> in the docs.
github2 17:53:20
`<https://github.com/Disfactory/frontend/commit/777d318b6d75179ee7069a139da472f6f3b8bf8a|777d318b>` - fix: update button class for sticky positioning and adjust lightbox index type `<https://github.com/Disfactory/frontend/commit/0ab230897a28af7661688499a611e04071c918c5|0ab23089>` - Merge pull request #184 from Disfactory/fix/mobile-missing-more-info
github2 17:53:20
`<https://github.com/Disfactory/frontend/commit/777d318b6d75179ee7069a139da472f6f3b8bf8a|777d318b>` - fix: update button class for sticky positioning and adjust lightbox index type `<https://github.com/Disfactory/frontend/commit/0ab230897a28af7661688499a611e04071c918c5|0ab23089>` - Merge pull request #184 from Disfactory/fix/mobile-missing-more-info
github2 17:53:22
Enhance the button's functionality by applying a sticky position and modifying the lightbox index type to accept null values. try fixes <https://github.com/Disfactory/frontend/issues/182|#182>
github2 17:53:22
Enhance the button's functionality by applying a sticky position and modifying the lightbox index type to accept null values. try fixes <https://github.com/Disfactory/frontend/issues/182|#182>
github2 17:53:25
*Describe the bug* 用 pixel 5 手機 chrome browser 看單獨工廠的資訊時,找不到「更多資料」的點擊處,因此沒辦法查看更多資訊。 <https://private-user-images.githubusercontent.com/63245687/429482541-1aadecd8-f2c1-45da-abe6-54ece1d749eb.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTM3ODYzMDMsIm5iZiI6MTc5Mzc4NjAwMywicGF0aCI6Ii82MzI0NTY4Ny80Mjk0ODI1NDEtMWFhZGVjZDgtZjJjMS00NWRhLWFiZTYtNTRlY2UxZDc0OWViLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTA0VDA5NTMyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU5ZDFmODRhNjFmY2I0OWJjNzIyNTFlYjcwMTcyM2I1NzkzMmMyZTVjNzkwMmE5NjNkNmQzODgwMzBjZDQ4OWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.iRH8VYnZ2j-lFpvw_uZWwBxETegLy5n6uchoJv4fn2I|Image> *Expected behavior* 應該要有更多資料的點擊處 <https://private-user-images.githubusercontent.com/63245687/429482889-9a5ae894-ed7a-4f54-9f90-ccda09f16df4.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTM3ODYzMDMsIm5iZiI6MTc5Mzc4NjAwMywicGF0aCI6Ii82MzI0NTY4Ny80Mjk0ODI4ODktOWE1YWU4OTQtZWQ3YS00ZjU0LTlmOTAtY2NkYTA5ZjE2ZGY0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTA0VDA5NTMyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU0OTVjMDQ2ZDgyMmE0YWFmOGE0MDcyMDE1MjExOTQ3NjQyNGQ1NWI0MmRlYzNjZGM4M2Y5Mjk3YmYzZjVlNzEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.B0WHTwJb86Al9RXF7fgmNjjZ-EbYjPGtKSvLcQ7hDVI|Image> *Smartphone (please complete the following information):* • Device: pixel 5 • OS: android version 14 • Browser: chrome *Additional context* Add any other context about the problem here.
github2 17:53:25
*Describe the bug* 用 pixel 5 手機 chrome browser 看單獨工廠的資訊時,找不到「更多資料」的點擊處,因此沒辦法查看更多資訊。 <https://private-user-images.githubusercontent.com/63245687/429482541-1aadecd8-f2c1-45da-abe6-54ece1d749eb.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTM3ODYzMDQsIm5iZiI6MTc5Mzc4NjAwNCwicGF0aCI6Ii82MzI0NTY4Ny80Mjk0ODI1NDEtMWFhZGVjZDgtZjJjMS00NWRhLWFiZTYtNTRlY2UxZDc0OWViLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTA0VDA5NTMyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM2NzJkZmI1YWQ2Mjg1ODZmMzJhMTUzZmMzNWVmZjY2NjZmYTM5ZTUyNWNiMWJhYTZjM2FjYjc2OWM5MTI5NTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.vx18QIJdVHz_zz-_DmA83q8T1_R5bHAFltpNvX8xoTc|Image> *Expected behavior* 應該要有更多資料的點擊處 <https://private-user-images.githubusercontent.com/63245687/429482889-9a5ae894-ed7a-4f54-9f90-ccda09f16df4.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTM3ODYzMDQsIm5iZiI6MTc5Mzc4NjAwNCwicGF0aCI6Ii82MzI0NTY4Ny80Mjk0ODI4ODktOWE1YWU4OTQtZWQ3YS00ZjU0LTlmOTAtY2NkYTA5ZjE2ZGY0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTA0VDA5NTMyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFhODc2YzA3ODI4N2VkMmJjYjZmYmI5MmZiZWI1M2IwMTQwMzY5MjFhNjE1OTg3MDI0OGVhMjY2MjUyNjIxNGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.2zF0hIxQJv3y7ardp4_gjG8O2FNAinYWxSayOZNbQQc|Image> *Smartphone (please complete the following information):* • Device: pixel 5 • OS: android version 14 • Browser: chrome *Additional context* Add any other context about the problem here.
github2 17:58:48
在前端README建立一份前端Getting Started 文件
github2 17:58:48
在前端README建立一份前端Getting Started 文件
github2 17:58:52
<https://github.com/Disfactory/frontend/blob/66198942f8a2a14c37371a464a4b7198a8a756bb/src/lib/map.ts#L245|frontend/src/lib/map.ts> Line 245 in&lt;/Disfactory/frontend/commit/66198942f8a2a14c37371a464a4b7198a8a756bb|6619894&gt; | url: '<https://staging.disfactory.tw/tiles/{z}/{x}/{y}.pbf>', | | ----------------------------------------------------------- | <http://stage.disfactory.tw|stage.disfactory.tw> 換變數
github2 17:58:52
<https://github.com/Disfactory/frontend/blob/66198942f8a2a14c37371a464a4b7198a8a756bb/src/lib/map.ts#L245|frontend/src/lib/map.ts> Line 245 in&lt;/Disfactory/frontend/commit/66198942f8a2a14c37371a464a4b7198a8a756bb|6619894&gt; | url: '<https://staging.disfactory.tw/tiles/{z}/{x}/{y}.pbf>', | | ----------------------------------------------------------- | <http://stage.disfactory.tw|stage.disfactory.tw> 換變數
github2 17:58:54
*Describe the bug* A clear and concise description of what the bug is. 請清晰詳細的描述這個問題 *To Reproduce* Steps to reproduce the behavior: 列出可以重現問題的步驟: 1. Go to '...' 2. Click on '....' 3. Scroll down to '....' 4. See error *Expected behavior* A clear and concise description of what you expected to happen. *Screenshots* If applicable, add screenshots to help explain your problem. 截圖 *Desktop (please complete the following information):* • OS: [e.g. iOS] • Browser [e.g. chrome, safari] • Version [e.g. 22] *Smartphone (please complete the following information):* • Device: [e.g. iPhone6] • OS: [e.g. iOS8.1] • Browser [e.g. stock browser, safari] • Version [e.g. 22] *Additional context* Add any other context about the problem here.
github2 17:58:54
*Describe the bug* A clear and concise description of what the bug is. 請清晰詳細的描述這個問題 *To Reproduce* Steps to reproduce the behavior: 列出可以重現問題的步驟: 1. Go to '...' 2. Click on '....' 3. Scroll down to '....' 4. See error *Expected behavior* A clear and concise description of what you expected to happen. *Screenshots* If applicable, add screenshots to help explain your problem. 截圖 *Desktop (please complete the following information):* • OS: [e.g. iOS] • Browser [e.g. chrome, safari] • Version [e.g. 22] *Smartphone (please complete the following information):* • Device: [e.g. iPhone6] • OS: [e.g. iOS8.1] • Browser [e.g. stock browser, safari] • Version [e.g. 22] *Additional context* Add any other context about the problem here.
github2 17:59:07
This PR addresses issue #XXX by adding a comprehensive Getting Started section to the frontend README, making it easier for new contributors to set up and start developing with the Disfactory frontend. *What's Added* The new Getting Started section includes: *Prerequisites* - Clear requirements for Node.js 16+, npm, and Git with helpful download links and version manager recommendations *Quick Start Guide* - A streamlined 4-step process to get developers from zero to running: 1. Clone the repository 2. Install dependencies with `npm install` 3. Set up environment variables using the provided `.env.example` 4. Start the development server with `npm run serve` *Available Scripts Table* - Documentation of all npm commands with clear descriptions: • `npm run serve` - Development server with hot-reload • `npm run build` - Production build • `npm run test` - Unit tests • `npm run test:watch` - Tests in watch mode • `npm run lint` - Code linting • `npm run typecheck` - TypeScript type checking *Project Structure* - Visual overview of key directories (`src/`, `docs/`, `public/`) and their purposes *Development Environment* - Summary of the tech stack including Vue.js 2.7, Vuetify 2.x, OpenLayers, TypeScript, and Jest *Troubleshooting Section* - Practical solutions for common setup issues: • Node.js version conflicts • Port already in use errors • Build and dependency problems *Contributing Guidelines* - Step-by-step workflow for new contributors including branching, testing, and PR submission *Testing* All commands and instructions have been thoroughly tested to ensure they work correctly: • :white_check_mark: Development server starts successfully on `<http://localhost:8080>` • :white_check_mark: Production build completes without errors • :white_check_mark: All npm scripts execute as documented • :white_check_mark: Environment setup process works end-to-end The documentation maintains consistency with the existing structure while providing everything a new developer needs to quickly get started with the Disfactory frontend project. Fixes <https://github.com/Disfactory/frontend/issues/70|#70> --- :sparkles: Let Copilot coding agent <https://github.com/Disfactory/frontend/issues/new?title=%E2%9C%A8+Set+up+Copilot+instructions&amp;body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&amp;assignees=copilot|set things up for you> — coding agent works faster and does higher quality work when set up for your repo.
github2 17:59:07
This PR addresses issue #XXX by adding a comprehensive Getting Started section to the frontend README, making it easier for new contributors to set up and start developing with the Disfactory frontend. *What's Added* The new Getting Started section includes: *Prerequisites* - Clear requirements for Node.js 16+, npm, and Git with helpful download links and version manager recommendations *Quick Start Guide* - A streamlined 4-step process to get developers from zero to running: 1. Clone the repository 2. Install dependencies with `npm install` 3. Set up environment variables using the provided `.env.example` 4. Start the development server with `npm run serve` *Available Scripts Table* - Documentation of all npm commands with clear descriptions: • `npm run serve` - Development server with hot-reload • `npm run build` - Production build • `npm run test` - Unit tests • `npm run test:watch` - Tests in watch mode • `npm run lint` - Code linting • `npm run typecheck` - TypeScript type checking *Project Structure* - Visual overview of key directories (`src/`, `docs/`, `public/`) and their purposes *Development Environment* - Summary of the tech stack including Vue.js 2.7, Vuetify 2.x, OpenLayers, TypeScript, and Jest *Troubleshooting Section* - Practical solutions for common setup issues: • Node.js version conflicts • Port already in use errors • Build and dependency problems *Contributing Guidelines* - Step-by-step workflow for new contributors including branching, testing, and PR submission *Testing* All commands and instructions have been thoroughly tested to ensure they work correctly: • :white_check_mark: Development server starts successfully on `<http://localhost:8080>` • :white_check_mark: Production build completes without errors • :white_check_mark: All npm scripts execute as documented • :white_check_mark: Environment setup process works end-to-end The documentation maintains consistency with the existing structure while providing everything a new developer needs to quickly get started with the Disfactory frontend project. Fixes <https://github.com/Disfactory/frontend/issues/70|#70> --- :sparkles: Let Copilot coding agent <https://github.com/Disfactory/frontend/issues/new?title=%E2%9C%A8+Set+up+Copilot+instructions&amp;body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&amp;assignees=copilot|set things up for you> — coding agent works faster and does higher quality work when set up for your repo.
github2 17:59:26
github2 17:59:26
2026-11-05
github2 07:45:49
`<https://github.com/Disfactory/devops/commit/162e1bb35b7834a82b0c2366595eb85f12362e3c|162e1bb3>` - fix(staging): restore script uses venv python, close cutover feed check
github2 07:45:49
`<https://github.com/Disfactory/devops/commit/162e1bb35b7834a82b0c2366595eb85f12362e3c|162e1bb3>` - fix(staging): restore script uses venv python, close cutover feed check
github2 08:54:40
Stacked on <https://github.com/Disfactory/frontend/pull/200|#200>. Implements <https://github.com/Disfactory/frontend/issues/29|#29>. • New `usePwaStore` captures `beforeinstallprompt`/`appinstalled`, tracks standalone + iOS + dismissal/install persistence (localStorage, 30-day re-show). • New `PwaInstallBanner` renders in-flow under the header: native install CTA on Chromium, manual Add-to-Home-Screen guidance on iOS. Hidden when already standalone. • Covered by unit (`src/stores/__tests__/pwa.spec.ts`, 10 tests) and e2e (`e2e/pwa-install.spec.ts`). Verified: type-check, lint, unit (14/14), e2e (14/14), build.
github2 08:54:40
Stacked on <https://github.com/Disfactory/frontend/pull/200|#200>. Implements <https://github.com/Disfactory/frontend/issues/29|#29>. • New `usePwaStore` captures `beforeinstallprompt`/`appinstalled`, tracks standalone + iOS + dismissal/install persistence (localStorage, 30-day re-show). • New `PwaInstallBanner` renders in-flow under the header: native install CTA on Chromium, manual Add-to-Home-Screen guidance on iOS. Hidden when already standalone. • Covered by unit (`src/stores/__tests__/pwa.spec.ts`, 10 tests) and e2e (`e2e/pwa-install.spec.ts`). Verified: type-check, lint, unit (14/14), e2e (14/14), build.
github2 09:00:06
*Is your feature request related to a problem? Please describe.* A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] *Describe the solution you'd like* A clear and concise description of what you want to happen. *Describe alternatives you've considered* A clear and concise description of any alternative solutions or features you've considered. *Additional context* Add any other context or screenshots about the feature request here.
github2 09:00:06
*Is your feature request related to a problem? Please describe.* A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] *Describe the solution you'd like* A clear and concise description of what you want to happen. *Describe alternatives you've considered* A clear and concise description of any alternative solutions or features you've considered. *Additional context* Add any other context or screenshots about the feature request here.
github2 09:00:09
Partially addressed in <https://github.com/Disfactory/frontend/issues/149|#149> Need to upgrade `.nvmrc` and test building
github2 09:00:09
Partially addressed in <https://github.com/Disfactory/frontend/issues/149|#149> Need to upgrade `.nvmrc` and test building
github2 09:00:11
TutorialModal 有用到 vue-carousel,希望可以換成 vuetify 內建的,減少 dependency
github2 09:00:11
TutorialModal 有用到 vue-carousel,希望可以換成 vuetify 內建的,減少 dependency