cofacts

Month: 2020-06

2020-06-01

github 08:41:17

#42 Update all dependencies

This PR contains the following updates: * * * *Release Notes* elastic/elasticsearch-js *<https://togithub.com/elastic/elasticsearch-js/releases/v7.7.1|`v7.7.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.7.0...v7.7.1|Compare Source> <https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/current/changelog-client.html|Changelog> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.7.0|`v7.7.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.6.1...v7.7.0|Compare Source> Support for Elasticsearch `v7.7` <https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/7.x/changelog-client.html|Changelog> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.6.1|`v7.6.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.6.0...v7.6.1|Compare Source> *Fixes:* • Secure json parsing - <https://togithub.com/elastic/elasticsearch-js/issues/1110|#​1110> • ApiKey should take precedence over basic auth - <https://togithub.com/elastic/elasticsearch-js/issues/1115|#​1115> *Documentation:* • Fix typo in api reference - <https://togithub.com/elastic/elasticsearch-js/issues/1109|#​1109> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.6.0|`v7.6.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.5.1...v7.6.0|Compare Source> Support for Elasticsearch `v7.6`. *<https://togithub.com/elastic/elasticsearch-js/releases/v7.5.1|`v7.5.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.5.0...v7.5.1|Compare Source> *Fixes:* • Skip compression in case of empty string body - <https://togithub.com/elastic/elasticsearch-js/issues/1080|#​1080> • Fix typo in NoLivingConnectionsError - <https://togithub.com/elastic/elasticsearch-js/issues/1045|#​1045> • Change TransportRequestOptions.ignore to number[] - <https://togithub.com/elastic/elasticsearch-js/issues/1053|#​1053> • ClientOptions["cloud"] should have optional auth fields - <https://togithub.com/elastic/elasticsearch-js/issues/1032|#​1032> *Documentation:* • Docs: Return super in example Transport subclass - <https://togithub.com/elastic/elasticsearch-js/issues/980|#​980> • Add examples to reference - <https://togithub.com/elastic/elasticsearch-js/issues/1076|#​1076> • Added new examples - <https://togithub.com/elastic/elasticsearch-js/issues/1031|#​1031> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.5.0|`v7.5.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.4.0...v7.5.0|Compare Source> Support for Elasticsearch `v7.5`. *Features* • X-Opaque-Id support <https://togithub.com/elastic/elasticsearch-js/issues/997|#​997> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.4.0|`v7.4.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.3.0...v7.4.0|Compare Source> Support for Elasticsearch `v7.4`. *Fixes:* • Fix issue; node roles are defaulting to true when undefined is breaking usage of nodeFilter option - <https://togithub.com/elastic/elasticsearch-js/issues/967|#​967> *Documentation:* • Updated API reference doc - <https://togithub.com/elastic/elasticsearch-js/issues/945|#​945> <https://togithub.com/elastic/elasticsearch-js/issues/969|#​969> • Fix inaccurate description sniffEndpoint - <https://togithub.com/elastic/elasticsearch-js/issues/959|#​959> *Internals:* • Update code generation <https://togithub.com/elastic/elasticsearch-js/issues/969|#​969> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.3.0|`v7.3.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.2.0...v7.3.0|Compare Source> Support for Elasticsearch `v7.3`. *Features:* • Added `auth` option - <https://togithub.com/elastic/elasticsearch-js/issues/908|#​908> • Added support for `ApiKey` authentication - <https://togithub.com/elastic/elasticsearch-js/issues/908|#​908> *Fixes:* • fix(Typings): sniffInterval can also be boolean - <https://togithub.com/elastic/elasticsearch-js/issues/914|#​914> *Internals:* • Refactored connection pool - <https://togithub.com/elastic/elasticsearch-js/issues/913|#​913> *Documentation:* • Better reference code examples - <https://togithub.com/elastic/elasticsearch-js/issues/920|#​920> • Improve README - <https://togithub.com/elastic/elasticsearch-js/issues/909|#​909> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.2.0|`v7.2.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.1.0...v7.2.0|Compare Source> Support for Elasticsearch `v7.2` *Fixes:* • Remove auth data from inspect and toJSON in connection class - <https://togithub.com/elastic/elasticsearch-js/issues/887|#​887> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.1.0|`v7.1.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.0.1...v7.1.0|Compare Source> Support for Elasticsearch `v7.1` *Fixes:* • Support for non-friendly chars in url username and password - <https://togithub.com/elastic/elasticsearch-js/issues/858|#​858> • Patch deprecated parameters - <https://togithub.com/elastic/elasticsearch-js/issues/851|#​851> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.0.1|`v7.0.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.0.0...v7.0.1|Compare Source> *Fixes:* • Fix TypeScript export _(issue <https://togithub.com/elastic/elasticsearch-js/issues/841|#​841>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/842|#​842> • Fix http and https port handling _(issue <https://togithub.com/elastic/elasticsearch-js/issues/843|#​843>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/845|#​845> • Fix TypeScript definiton _(issue <https://togithub.com/elastic/elasticsearch-js/issues/803|#​803>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/846|#​846> • Added toJSON method to Connection class _(issue <https://togithub.com/elastic/elasticsearch-js/issues/848|#​848>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/849|#​849> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.0.0|`v7.0.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v6.8.7...v7.0.0|Compare Source> • Stable release. eslint/eslint *<https://togithub.com/eslint/eslint/releases/v7.1.0|`v7.1.0`>* <https://togithub.com/eslint/eslint/compare/v7.0.0...v7.1.0|Compare Source> • <https://togithub.com/eslint/eslint/commit/a93083af89c6f9714dcdd4a7f27c8655a0b0dba6|`a93083a`> Fix: astUtils.getNextLocation returns invalid location after CRLF (<https://togithub.com/eslint/eslint/issues/13275|#​13275>) (Milos Djermanovic) • <https://togithub.com/eslint/eslint/commit/df01af184d93b3d64b37cee786cad59bd0d7aacb|`df01af1`> Update: padded-blocks loc position changes (refs <https://togithub.com/eslint/eslint/issues/12334|#​12334>) (<https://togithub.com/eslint/eslint/issues/13328|#​13328>) (Anix) • <https://togithub.com/eslint/eslint/commit/bd3f092efa579944f75bfbc277b35f85e6d966ed|`bd3f092`> Fix: max-lines-per-function flagging arrow IIFEs (fixes <https://togithub.com/eslint/eslint/issues/13332|#​13332>) (<https://togithub.com/eslint/eslint/issues/13336|#​13336>) (cherryblossom000) • <https://togithub.com/eslint/eslint/commit/25462b23eac4ed1ded97eeae6187b5d8baa58e78|`25462b2`> Update: block-spacing changed loc for extra (refs <https://togithub.com/eslint/eslint/issues/12334|#​12334>) (<https://togithub.com/eslint/eslint/issues/13314|#​13314>) (Anix) • <https://togithub.com/eslint/eslint/commit/de0aab95005f172db72196fc3fd18e91ee9a5880|`de0aab9`> Fix: report end loc in one-var-declaration-per-line (refs <https://togithub.com/eslint/eslint/issues/12334|#​12334>) (<https://togithub.com/eslint/eslint/issues/13326|#​13326>) (YeonJuan) • <https://togithub.com/eslint/eslint/commit/1710296082083602a904b080908657bb431fb56c|`1710296`> Fix: no-new-symbol false positive with Symbol as an argument (<https://togithub.com/eslint/eslint/issues/13337|#​13337>) (Milos Djermanovic) • <https://togithub.com/eslint/eslint/commit/cc014514c29626e556acb0a528e3478b3725e284|`cc01451`> Fix: arrow-parens no reporting for comments inside (…

github 09:56:31

#173 Update all dependencies

This PR contains the following updates: * * * *Release Notes* elastic/elasticsearch-js *<https://togithub.com/elastic/elasticsearch-js/releases/v7.7.1|`v7.7.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.7.0...v7.7.1|Compare Source> <https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/current/changelog-client.html|Changelog> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.7.0|`v7.7.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.6.1...v7.7.0|Compare Source> Support for Elasticsearch `v7.7` <https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/7.x/changelog-client.html|Changelog> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.6.1|`v7.6.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.6.0...v7.6.1|Compare Source> *Fixes:* • Secure json parsing - <https://togithub.com/elastic/elasticsearch-js/issues/1110|#​1110> • ApiKey should take precedence over basic auth - <https://togithub.com/elastic/elasticsearch-js/issues/1115|#​1115> *Documentation:* • Fix typo in api reference - <https://togithub.com/elastic/elasticsearch-js/issues/1109|#​1109> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.6.0|`v7.6.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.5.1...v7.6.0|Compare Source> Support for Elasticsearch `v7.6`. *<https://togithub.com/elastic/elasticsearch-js/releases/v7.5.1|`v7.5.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.5.0...v7.5.1|Compare Source> *Fixes:* • Skip compression in case of empty string body - <https://togithub.com/elastic/elasticsearch-js/issues/1080|#​1080> • Fix typo in NoLivingConnectionsError - <https://togithub.com/elastic/elasticsearch-js/issues/1045|#​1045> • Change TransportRequestOptions.ignore to number[] - <https://togithub.com/elastic/elasticsearch-js/issues/1053|#​1053> • ClientOptions["cloud"] should have optional auth fields - <https://togithub.com/elastic/elasticsearch-js/issues/1032|#​1032> *Documentation:* • Docs: Return super in example Transport subclass - <https://togithub.com/elastic/elasticsearch-js/issues/980|#​980> • Add examples to reference - <https://togithub.com/elastic/elasticsearch-js/issues/1076|#​1076> • Added new examples - <https://togithub.com/elastic/elasticsearch-js/issues/1031|#​1031> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.5.0|`v7.5.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.4.0...v7.5.0|Compare Source> Support for Elasticsearch `v7.5`. *Features* • X-Opaque-Id support <https://togithub.com/elastic/elasticsearch-js/issues/997|#​997> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.4.0|`v7.4.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.3.0...v7.4.0|Compare Source> Support for Elasticsearch `v7.4`. *Fixes:* • Fix issue; node roles are defaulting to true when undefined is breaking usage of nodeFilter option - <https://togithub.com/elastic/elasticsearch-js/issues/967|#​967> *Documentation:* • Updated API reference doc - <https://togithub.com/elastic/elasticsearch-js/issues/945|#​945> <https://togithub.com/elastic/elasticsearch-js/issues/969|#​969> • Fix inaccurate description sniffEndpoint - <https://togithub.com/elastic/elasticsearch-js/issues/959|#​959> *Internals:* • Update code generation <https://togithub.com/elastic/elasticsearch-js/issues/969|#​969> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.3.0|`v7.3.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.2.0...v7.3.0|Compare Source> Support for Elasticsearch `v7.3`. *Features:* • Added `auth` option - <https://togithub.com/elastic/elasticsearch-js/issues/908|#​908> • Added support for `ApiKey` authentication - <https://togithub.com/elastic/elasticsearch-js/issues/908|#​908> *Fixes:* • fix(Typings): sniffInterval can also be boolean - <https://togithub.com/elastic/elasticsearch-js/issues/914|#​914> *Internals:* • Refactored connection pool - <https://togithub.com/elastic/elasticsearch-js/issues/913|#​913> *Documentation:* • Better reference code examples - <https://togithub.com/elastic/elasticsearch-js/issues/920|#​920> • Improve README - <https://togithub.com/elastic/elasticsearch-js/issues/909|#​909> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.2.0|`v7.2.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.1.0...v7.2.0|Compare Source> Support for Elasticsearch `v7.2` *Fixes:* • Remove auth data from inspect and toJSON in connection class - <https://togithub.com/elastic/elasticsearch-js/issues/887|#​887> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.1.0|`v7.1.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.0.1...v7.1.0|Compare Source> Support for Elasticsearch `v7.1` *Fixes:* • Support for non-friendly chars in url username and password - <https://togithub.com/elastic/elasticsearch-js/issues/858|#​858> • Patch deprecated parameters - <https://togithub.com/elastic/elasticsearch-js/issues/851|#​851> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.0.1|`v7.0.1`>* <https://togithub.com/elastic/elasticsearch-js/compare/v7.0.0...v7.0.1|Compare Source> *Fixes:* • Fix TypeScript export _(issue <https://togithub.com/elastic/elasticsearch-js/issues/841|#​841>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/842|#​842> • Fix http and https port handling _(issue <https://togithub.com/elastic/elasticsearch-js/issues/843|#​843>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/845|#​845> • Fix TypeScript definiton _(issue <https://togithub.com/elastic/elasticsearch-js/issues/803|#​803>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/846|#​846> • Added toJSON method to Connection class _(issue <https://togithub.com/elastic/elasticsearch-js/issues/848|#​848>)_ - <https://togithub.com/elastic/elasticsearch-js/issues/849|#​849> *<https://togithub.com/elastic/elasticsearch-js/releases/v7.0.0|`v7.0.0`>* <https://togithub.com/elastic/elasticsearch-js/compare/v6.8.7...v7.0.0|Compare Source> • Stable release. facebook/jest *<https://togithub.com/facebook/jest/blob/master/CHANGELOG.md#%E2%80%8B2601|`v26.0.1`>* <https://togithub.com/facebook/jest/compare/v26.0.0...v26.0.1|Compare Source> *Fixes* • `[jest-circus]` Backward compatibility for deprecated `DescribeBlock.tests` to not break e.g. Detox reporter *<https://togithub.com/facebook/jest/blob/master/CHANGELOG.md#%E2%80%8B2600|`v26.0.0`>* <https://togithub.com/facebook/jest/compare/v25.5.1...v26.0.0|Compare Source> *Features* • `[jest-environment-jsdom]` [*BREAKING*] Upgrade `jsdom` to v16 (<https://togithub.com/facebook/jest/pull/9606|#​9606>) • `[@jest/fake-timers]` Add possibility to use a modern implementation of fake timers, backed by `@sinonjs/fake-timers` (<https://togithub.com/facebook/jest/pull/7776|#​7776>) • `[jest-runtime]` Add `createMockFromModule` as an alias for `genMockFromModule` (<https://togithub.com/facebook/jest/pull/9962|#​9962>) *Fixes* • `[babel-jest]` Handle `null` being passed to `createTransformer` (<https://togithub.com/facebook/jest/pull/9955|#​9955>) • `[jest-circus, jest-console, jest-jasmine2, jest-reporters, jest-util, pretty-format]` Fix time durating formatting and consolidate time formatting code (<https://togithub.com/facebook/jest/pull/9765|#​9765>) • `[jest-circus]` [*BREAKING*] Fail tests if a test takes a done callback and have return values (<https://togithub.com/facebook/jest/pull/9129|#​9129>) • `[jest-circus]` [*BREAKING*] Throw a proper error if a test / hook is defined asynchronously (<https://togithub.com/facebook/jest/pull/8096|#​8096>) • `[jest-circus]` Throw more descriptive error if hook is defined inside test (<https://togithub.com/facebook/jest/pull/9957|#​9957>) • `[jest-circus]` [*BREAKING*] Align execution order of tests to match `jasmine`'s top to bottom order (<https://togithub.com/facebook/jest/pull/9965|#​9965>) • `[jest-config, jest-resolve]` [*BREAKING*] Rem…

github 09:59:03

Comment on #173 Update all dependencies

<https://coveralls.io/builds/31149862|Coverage Status> Coverage remained the same at 86.578% when pulling *<https://github.com/cofacts/rumors-api/commit/0e5bceddae3f11ff621f96737844962c031db52d|0e5bced> on renovate/all* into *<https://github.com/cofacts/rumors-api/commit/1ef3790da93aec2ee26426d5561766ff1708ae13|1ef3790> on master*.

github 10:59:18

#2 Update all dependencies

This PR contains the following updates: * * * *Release Notes* testing-library/jest-dom *<https://togithub.com/testing-library/jest-dom/releases/v5.9.0|`v5.9.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.8.0...v5.9.0|Compare Source> *Features* • Deprecate toBeEmpty in favour of toBeEmptyDomElement (<https://togithub.com/testing-library/jest-dom/issues/216|#​216>) (<https://togithub.com/testing-library/jest-dom/issues/254|#​254>) (<https://togithub.com/testing-library/jest-dom/commit/927c5a4f898369524ab6e96d67f2e1004f1714d5|927c5a4>) *<https://togithub.com/testing-library/jest-dom/releases/v5.8.0|`v5.8.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.7.0...v5.8.0|Compare Source> *Features* • add toBePartiallyChecked matcher (<https://togithub.com/testing-library/jest-dom/issues/249|#​249>) (<https://togithub.com/testing-library/jest-dom/commit/e46299b8fe4d57b6fbfc5ae8e312eacc8419ee34|e46299b>) *<https://togithub.com/testing-library/jest-dom/releases/v5.7.0|`v5.7.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.6.0...v5.7.0|Compare Source> *Features* • Allow to use regex on toHaveDisplayValue (<https://togithub.com/testing-library/jest-dom/issues/242|#​242>) (<https://togithub.com/testing-library/jest-dom/commit/5c9e8e5a1a18e58c0bf8147baaf568259c3c2a13|5c9e8e5>) *<https://togithub.com/testing-library/jest-dom/releases/v5.6.0|`v5.6.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.5.0...v5.6.0|Compare Source> *Features* • Add new custom matcher toHaveDescription (<https://togithub.com/testing-library/jest-dom/issues/244|#​244>) (<https://togithub.com/testing-library/jest-dom/commit/943a0c9783de6acc83a397b5dab22570f2611c3c|943a0c9>) *<https://togithub.com/testing-library/jest-dom/releases/v5.5.0|`v5.5.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.4.0...v5.5.0|Compare Source> *Features* • Add `toHaveDisplayValue()` matcher (<https://togithub.com/testing-library/jest-dom/issues/223|#​223>) (<https://togithub.com/testing-library/jest-dom/commit/840414f73864226852199b5f0c9cb591d7cfc140|840414f>) *<https://togithub.com/testing-library/jest-dom/releases/v5.4.0|`v5.4.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.3.0...v5.4.0|Compare Source> *Features* • add switch role to toBeChecked (<https://togithub.com/testing-library/jest-dom/issues/228|#​228>) (<https://togithub.com/testing-library/jest-dom/commit/144c647fcf5586312ae7e1a16ff4654713097209|144c647>) *<https://togithub.com/testing-library/jest-dom/releases/v5.3.0|`v5.3.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.2.0...v5.3.0|Compare Source> *Features* • add exact mode option for toHaveClass (<https://togithub.com/testing-library/jest-dom/issues/176|#​176>) (<https://togithub.com/testing-library/jest-dom/issues/217|#​217>) (<https://togithub.com/testing-library/jest-dom/commit/cc8721e10637137ec15e731db2aa8af4b13bf21e|cc8721e>) *<https://togithub.com/testing-library/jest-dom/releases/v5.2.0|`v5.2.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.1.1...v5.2.0|Compare Source> *Features* • *toHaveValue:* Enhanced error message with type information… (<https://togithub.com/testing-library/jest-dom/issues/219|#​219>) (<https://togithub.com/testing-library/jest-dom/commit/eb51c17438a6fbdaa027bc35cdd07a031a167338|eb51c17>) *<https://togithub.com/testing-library/jest-dom/releases/v5.1.1|`v5.1.1`>* <https://togithub.com/testing-library/jest-dom/compare/v5.1.0...v5.1.1|Compare Source> *Bug Fixes* • root matchers module (closes <https://togithub.com/testing-library/jest-dom/issues/197|#​197>) (<https://togithub.com/testing-library/jest-dom/issues/200|#​200>) (<https://togithub.com/testing-library/jest-dom/commit/3b98d4d16b51b7b8d9d9ca77172b5367503f203f|3b98d4d>) *<https://togithub.com/testing-library/jest-dom/releases/v5.1.0|`v5.1.0`>* <https://togithub.com/testing-library/jest-dom/compare/v5.0.2...v5.1.0|Compare Source> *Features* • Enhance toHaveStyle to accept JS as css (<https://togithub.com/testing-library/jest-dom/issues/196|#​196>) (<https://togithub.com/testing-library/jest-dom/commit/7921e4a0a9e21e419122951eb28ed270c13209c5|7921e4a>) *<https://togithub.com/testing-library/jest-dom/releases/v5.0.2|`v5.0.2`>* <https://togithub.com/testing-library/jest-dom/compare/v5.0.1...v5.0.2|Compare Source> *Bug Fixes* • toBeVisible ignoring Details element (<https://togithub.com/testing-library/jest-dom/issues/184|#​184>) (<https://togithub.com/testing-library/jest-dom/commit/e4d61c2ef16018197c316135f57f905bf5b2ca2a|e4d61c2>) *<https://togithub.com/testing-library/jest-dom/releases/v5.0.1|`v5.0.1`>* <https://togithub.com/testing-library/jest-dom/compare/v5.0.0...v5.0.1|Compare Source> *Bug Fixes* • Add <https://togithub.com/types/testing-library|@​types/testing-library>__jest-dom dependency (<https://togithub.com/testing-library/jest-dom/issues/189|#​189>) (<https://togithub.com/testing-library/jest-dom/commit/030da6207a2e4862035b7b9d9f915328c5ff4e2f|030da62>), closes <https://togithub.com/testing-library/jest-dom/issues/123|#​123> <https://togithub.com/testing-library/jest-dom/issues/160|#​160> <https://togithub.com/testing-library/jest-dom/issues/185|#​185> *<https://togithub.com/testing-library/jest-dom/releases/v5.0.0|`v5.0.0`>* <https://togithub.com/testing-library/jest-dom/compare/v4.2.4...v5.0.0|Compare Source> • Remove extend-expect typings (<https://togithub.com/testing-library/jest-dom/issues/182|#​182>) (<https://togithub.com/testing-library/jest-dom/commit/c76f8c548b3d99b8639aea05f76c111997c5bce5|c76f8c5>), closes <https://togithub.com/testing-library/jest-dom/issues/182|#​182> *BREAKING CHANGES* • moving typings to <https://togithub.com/types/testing-library|@​types/testing-library>__jest-dom • This version does not includes types. The next patch release v5.0.1 will. If you need the type definitions please do not update to v.5.0.0. testing-library/react-testing-library *<https://togithub.com/testing-library/react-testing-library/releases/v10.0.4|`v10.0.4`>* <https://togithub.com/testing-library/react-testing-library/compare/v10.0.3...v10.0.4|Compare Source> *Bug Fixes* • upgrade all dependencies (and fix UMD build) (<https://togithub.com/testing-library/react-testing-library/issues/653|#​653>) (<https://togithub.com/testing-library/react-testing-library/commit/a75fa350399857cd889ee0b878b08a79c2101206|a75fa35>) *<https://togithub.com/testing-library/react-testing-library/releases/v10.0.3|`v10.0.3`>* <https://togithub.com/testing-library/react-testing-library/compare/v10.0.2...v10.0.3|Compare Source> *Bug Fixes* • restore this when requiring timers (<https://togithub.com/testing-library/react-testing-library/issues/644|#​644>) (<https://togithub.com/testing-library/react-testing-library/commit/59a2de1e689be718f0931656b518509d43f5ac29|59a2de1>), closes <https://togithub.com/testing-library/react-testing-library/issues/614|#​614> *<https://togithub.com/testing-library/react-testing-library/releases/v10.0.2|`v10.0.2`>* <https://togithub.com/testing-library/react-testing-library/compare/v10.0.1...v10.0.2|Compare Source> *Bug Fixes* • Bump types dependency (<https://togithub.com/testing-library/react-testing-library/issues/625|#​625>) (<https://togithub.com/testing-library/react-testing-library/commit/afce94fec01d18f654d919e8e091a814afd63da1|afce94f>) *<https://togithub.com/testing-library/react-testing-library/releases/v10.0.1|`v10.0.1`>* <https://togithub.com/testing-library/react-testing-library/compare/v10.0.0...v10.0.1|Compare Source> *Bug Fixes* • support Node &gt;=10 (<https://togithub.com/testing-library/react-testing-library/issues/611|#​611>) (<https://togithub.com/testing-library/react-testing-library/commit/3bc13d94c05df06ae4cff5bf98ac1fd0cddb4783|3bc13d9>) *<https://togithub.com/testing-library/react-testing-library/releases/v10.0.0|`v10.0.0`>* <https://togithub.com/testing-library/react-testing-library/compare/v9…

mrorz 14:39:17
@lucien 目前搜尋頁面的 spec 還是寫「同 https://g0v.hackmd.io/ahtI6xsFRQyxktrIlc1VcQ|可疑訊息 頁」 https://g0v.hackmd.io/@NFi0czulSemxCM8RNSlz8Q/HJ8xT3QVU/%2FoWSar1t0SzWo150Dsbepxw

但是不按照「相關度」排序的搜尋頁面,根本無法使用囧

g0v.hackmd.io

[Spec] 可疑轉傳訊息 - HackMD

mrorz 14:39:49
現在我跟比鄰要找 cofacts 的訊息,都是用 google 的 `site: http://cofacts.g0v.tw|cofacts.g0v.tw` 來找的囧
github 14:48:46

Review on #256 Feature/search page

Thanks for the PR! I think the PR's size is pretty easy to read :) Sorry that the review is postponed a bit because we are traveling to Tainan. I have made some comments so that the website can function more like the mockup suggests. Regarding the sort order in <https://g0v.hackmd.io/@NFi0czulSemxCM8RNSlz8Q/HJ8xT3QVU/%2FoWSar1t0SzWo150Dsbepxw|design spec>, I find that the sort order defined in spec &amp; mockup ("同 可疑訊息 頁") is very difficult to use, as the search result is barely relevant. Discussion here: <https://g0v-tw.slack.com/archives/C2PPMRQGP/p1590993557102800|https://g0v-tw.slack.com/archives/C2PPMRQGP/p1590993557102800> I am a bit concerned about `ReplySearchPageLayout` -- it looks pretty close to ArticlePageLayout and do shares a lot of common items. I can understand that the duplication is to mitigate the difference of its underlying data model (`ListArticle` query v.s. `ListReply` query). I think some of their items (such as `FilterGroup`) should be extracted to common components, and the difference in its data model / logic lives within each page. But this is too much for this PR, so I think we can leave it as-is.

github 14:48:46

Comment on #256 Feature/search page

We can set the component of this box to `form` so that • Instead of putting handler on submit button, we put `onSubmit` handler on the form • Browsers (especially soft keyboard of mobile browsers) _may_ adapt its input to smooth out the interaction of form submission • We don't need to implement `onChange` in the textarea; just put a `name` to the textarea, and we can get the value of textarea using `event.target.&lt;textarea name&gt;.value`. • As long as we implement form's `onSubmit`, we can just put `type="submit"` to the current `searchIcon` button and remove its `onClick` handler.

github 14:48:46

Comment on #256 Feature/search page

Please align `.view` to the center of `openModalButton` vertically <https://user-images.githubusercontent.com/108608/83379101-4ce7a100-a40d-11ea-9c8f-b6d9acc63280.png|image>

github 14:48:46

Comment on #256 Feature/search page

Please set the `defaultValue` to the currently searched item so that the textarea can be filled with the text in search box, as shown in mockup <https://user-images.githubusercontent.com/108608/83380244-0d6e8400-a410-11ea-9f6e-9106d4f943e4.png|image>

github 14:48:46

Comment on #256 Feature/search page

Since this button is supposed to show "other" messages, we should not repeat the article (first original article) shown outside of the dialog. Please filter out the article that is already shown above. <https://user-images.githubusercontent.com/108608/83380873-b36ebe00-a411-11ea-9aa1-080d0e5846f0.png|螢幕快照 2020-06-01 下午2 09 28>

github 14:48:47

Comment on #256 Feature/search page

This button should show only when `articleReplies.length` &gt; 1. If there is only one `articleReply`, it means that the reply is only used in one aritcle, and there is no "other messages" to show. The second item in the mockup shows the variant of `ReplySearchItem` with `articleReply.length` === 1. <https://user-images.githubusercontent.com/108608/83380674-0eec7c00-a411-11ea-83c2-5a3f9cf16966.png|image>

github 14:54:00

Comment on #256 Feature/search page

I forgot to mention that the search result page currently have a mysterious horizontal scroll. Please find what caused this scroll and eliminate it. <https://user-images.githubusercontent.com/108608/83383438-b4a2e980-a417-11ea-8577-f8666b353b87.gif|search-page-horizontal>

github 16:52:14

Comment on #258 Enable react hook lint rules

<https://github.com/yanglin5689446|@yanglin5689446> This is causing lint error because of the use of `setAndUpdateValue`, which is updated every `render`. The logic in this hook is a bit complicated and its side effect (invoking `setAndUpdateValue`) is costly. Would you take a look at this and determine an appropriate dependency list here?

2020-06-02

github 10:53:36

Comment on #258 Enable react hook lint rules

I think it's safe to include only `range` as dependency, because this effect should only run when props passed from parent update, only when this happen the effect should be run and bound to new closure, though I'm not pretty sure if it works as I expected :sweat_smile:

github 10:56:48

Comment on #258 Enable react hook lint rules

with `customValue` included in deps list, the state in component will always override the props passed from parent so the props update from parent never applied(correct me if I'm wrong)

2020-06-03

yanglin 12:29:15
@lucien @mrorz 不好意思這個我可能問得不夠清楚 XD
下面這些回應有辦法連到 Reply Detail 頁面嗎?
也就是獨立顯示 Reply 的頁面
或著 Reply Detail 的頁面現在要怎麼樣進入呢?
https://www.figma.com/file/zpD45j8nqDB2XfA6m2QskO?node-id=889:306#25793084

Figma

Cofacts website

Created with Figma

github 17:48:27

Comment on #256 Feature/search page

&gt; I forgot to mention that the search result page currently have a mysterious horizontal scroll. Please find what caused this scroll and eliminate it. &gt; &gt; <https://user-images.githubusercontent.com/108608/83383438-b4a2e980-a417-11ea-8577-f8666b353b87.gif|search-page-horizontal> I can't reproduce this issue, can you provide more information about the platform or testcase?

github 19:00:33

#174 use parameter getter for createArticleCategory Mutation to avoid re-compilation

try to solve dynamic script compilation problem by using the same script in this mutation related discussion: <https://user-images.githubusercontent.com/4010549/83629327-77cc2380-a5cc-11ea-9724-2aeaccf42733.png|image> <https://user-images.githubusercontent.com/4010549/83629337-7d296e00-a5cc-11ea-98ce-04b0d7f0e9d3.png|image> reference: <https://stackoverflow.com/questions/60234600/too-many-dynamic-script-compilations-within-max-75-5m|https://stackoverflow.com/questions/60234600/too-many-dynamic-script-compilations-within-max-75-5m>

github 19:03:06

Comment on #174 use parameter getter for createArticleCategory Mutation to avoid re-compilation

<https://coveralls.io/builds/31209071|Coverage Status> Coverage remained the same at 86.578% when pulling *<https://github.com/cofacts/rumors-api/commit/7a66dcc805e8189e4ad4396a9dec533e3491bc54|7a66dcc> on create-categories-params* into *<https://github.com/cofacts/rumors-api/commit/1ef3790da93aec2ee26426d5561766ff1708ae13|1ef3790> on master*.

github 21:53:17

Comment on #162 Setup database on staging &amp; production

Done in <https://github.com/cofacts/rumors-line-bot/pull/182|#182> and is deployed

github 21:53:48

Comment on #145 Update article source wordings

Finished in <https://github.com/cofacts/rumors-line-bot/issues/121|#121>

2020-06-04

github 02:25:29

#193 line auth

因為 line-auth branch 太舊,就直接跟 dev compare 了 已知問題:IDToken 會過期(<https://developers.line.biz/en/reference/liff/#get-decoded-id-token|liff.getDecodedIDToken>),要在過期之前讓 user 重新登入 Setup : 1.set liff endpoint url for login callback 2.set channel token in .env file.