Slack archive

marriage-equality

Month: 2018-11

2018-11-13

kjcl 17:22:40
@kevinliao has joined the channel
kjcl 17:23:12
@kevinliao has renamed the channel from "2good3bad" to "marriage-equality"
kjcl 17:24:19
@kevinliao set the channel topic: https://github.com/g0v/for-marriage-equality
mrorz 17:35:41
@mrorz has joined the channel
👋 2
bess 18:14:16
@besslee has joined the channel
patcon 18:17:21
@patcon has joined the channel
bil 18:18:34
@bil has joined the channel
agameofprivacy 18:24:19
@agameofprivacy has joined the channel
kjcl 18:42:56
city picker is working. I pushed it before I took a nap.
kjcl 18:43:24
it’s very ugly though
agameofprivacy 2018-11-13 18:58:27
u sure about city picker working? is it on `ec/show-shifts`?
one second
pull
agameofprivacy 2018-11-13 19:00:46
got the new <select> but still not working.
change it to yilan?
agameofprivacy 2018-11-13 19:01:05
what might i be doing wrong?
it should narrow things down.
are you on mobile
agameofprivacy 2018-11-13 19:01:10
k
?
agameofprivacy 2018-11-13 19:02:13
ugh gosh as if I didn’t know about console--
here’s the error:
agameofprivacy 2018-11-13 19:02:17
Warning: Failed prop type: You provided a `value` prop to a form field without an `onChange` handler. This will render a read-only field. If the field should be mutable use `defaultValue`. Otherwise, set either `onChange` or `readOnly`.
agameofprivacy 2018-11-13 19:02:45
would that be a showstopper?
agameofprivacy 2018-11-13 19:02:50
I’m on desktop Chrome
ooooh this might be a showstopper.
Working on it. Thanks!
Fix pushed.
agameofprivacy 2018-11-13 19:10:41
it’s perfect! 🙏
I want to add datepicker now.
agameofprivacy 2018-11-13 19:12:39
sounds good. I’ll do css when you’re done with all the search/filter stuff!
What would a good datepicker with only 11 days left look like?
from a UX perspective
agameofprivacy 2018-11-13 19:14:11
I’d do a simple select, perhaps remove dates in the past as we go?
agameofprivacy 2018-11-13 19:14:23
if that’s not too much trouble…
hm okay. I’ll just reuse someone’s datepicker.
kjcl 18:43:32
because I’m very bad at css 😞
agameofprivacy 2018-11-13 18:56:26
that’s ok. it’s much worse to be bad at js. 👈
kjcl 19:47:24
@agameofprivacy datepicker is now in the bar, but it does not filter. the frontend should not change. I just need to add a filter now. You can go ahead and style without breaking anything now. 🙂
agameofprivacy 19:47:46
thanks @kevinliao
kjcl 19:47:47
woops it’s on master
kjcl 19:47:50
I’ll rebase
agameofprivacy 19:48:12
kk
kjcl 19:48:26
done.
agameofprivacy 19:56:43
pushed a commit to support multiple CanvassType--works, but may be dirty.
kjcl 19:56:50
okay
kjcl 19:56:53
pulling
kjcl 19:58:42
still looks like this
Screen Shot 2018-11-13 at 7.58.18 PM.png
agameofprivacy 19:59:48
yep, doing styles now!
agameofprivacy 19:59:59
gimme 10-15
kjcl 20:00:24
got it! my bad. take your time! 🙂
🙌 1
agameofprivacy 20:14:40
pushed--optimizing for mobile now.
kjcl 20:16:47
thanks! I’m working on getting that filter working. 🙂
💪 1
kjcl 20:25:39
beautiful!!!
kjcl 20:58:22
Datepicker is working!
kjcl 20:58:25
Pushing。
agameofprivacy 21:04:03
pushed to _not master_?
kjcl 21:09:34
Woops. To master.
kjcl 21:09:46
I keep pushing to master because I forget to chec back in after redeploy. :facepalm:
kjcl 21:09:49
🤦‍♂️🏼
kjcl 21:12:05
@agameofprivacy how do you rebuild sass?
kjcl 21:12:21
I’m writing one last little thing.
agameofprivacy 21:12:39
`sass --watch src/index.scss:src/index.css`
kjcl 21:12:47
thank you!
agameofprivacy 21:12:48
if you have sass installed
agameofprivacy 21:13:06
hold on… I just found out line url schemes don’t work anymore
agameofprivacy 21:13:20
need to replace with official button I think--gimme one sec
agameofprivacy 21:16:30
nvm, it doesn’t look like there’s an easy way. best workaround is probably copy lineID on button click?
agameofprivacy 21:16:39
any thoughts?
kjcl 21:28:12
I don’t have any experience with LineID 😛
kjcl 21:28:46
Added this!
Screen Shot 2018-11-13 at 9.28.12 PM.png
1
kjcl 21:29:35
Is there a way to make the search bar align with everything else?
kjcl 21:29:39
it feels weird how it sticks out like that.
agameofprivacy 21:32:14
yep!
agameofprivacy 21:32:18
ok I’ll work on that now
kjcl 21:46:27
@agameofprivacy what does index.css.map do?
agameofprivacy 21:47:01
not sure, I think that probably resulted from the sass watch.
kjcl 21:47:09
okay. hm.
agameofprivacy 21:51:07
I ran into trouble with importing a react lib with typescript, help?
agameofprivacy 21:52:25
it’s in `Action.tsx`
agameofprivacy 21:52:46
the lines that are commented out.
kjcl 21:57:19
Paste?
agameofprivacy 21:57:38
is that a library?
kjcl 21:57:42
Like what is the error?
kjcl 21:57:46
and what is the library?
agameofprivacy 21:57:46
ahh
agameofprivacy 21:57:53
`react-copy-to-clipboard`
kjcl 21:58:07
New dependency?
agameofprivacy 21:58:16
yep
kjcl 21:58:43
okay what is the error?
kjcl 21:59:22
`import {CopyToClipboard} from 'react-copy-to-clipboard';`?
agameofprivacy 22:00:59
@kevinliao
Screen Shot 2018-11-13 at 9.59.35 PM.png
kjcl 22:01:11
oh yeah
kjcl 22:01:12
run
kjcl 22:01:19
are you using npm or yarn
agameofprivacy 22:01:23
yarn
kjcl 22:01:39
run `yarn add -D @types/react-copy-to-clipboard`.
kjcl 22:01:41
See if that helps.
agameofprivacy 22:01:53
thx
kjcl 22:02:07
That way TypeScript gets to know the types of the library so we get less errors 😉
kjcl 22:02:18
This is my first project programming with TS too 😉
👍 1
kjcl 22:05:19
Did it work?
agameofprivacy 22:05:45
it got less bad haha
kjcl 22:05:48
can I see?
kjcl 22:05:54
or do you have it under control ?
agameofprivacy 22:06:13
Screen Shot 2018-11-13 at 10.05.48 PM.png
agameofprivacy 22:06:24
nope I’m ¯\_(ツ)_/¯
agameofprivacy 22:09:08
yay got it to work
2 1
agameofprivacy 22:12:25
Just pushed to `ec/show-shifts`
agameofprivacy 22:12:45
Thanks for all the help. Gonna wrap for the night. Great work! 🙌
kjcl 22:13:13
YAYYYYY!!!! !
kjcl 22:13:15
Thanks so much!!!!!
bess 22:14:40

2018-11-14

patcon 15:41:13
is there a live demo site on heroku?
agameofprivacy 2018-11-14 15:57:51
It’s running on github pages here: https://g0v.github.io/for-marriage-equality/ :pray:
cool! thanks! May I humbly suggest adding that to the URL of the repo, as that's often a quick place people look 🙂
Okay I’ll do that
HuangFu 15:42:26
@aoisoranoko has joined the channel
kjcl 21:18:34
add og:meta data so sharing on facebook is prettier.
bess 21:22:24
https://www.facebook.com/g0v.tw/photos/a.456791061028852/2323908694317070/?type=3&theater

facebook.com

g0v.tw 台灣零時政府

平權讓更多人有機會選擇如何去愛。 　 擅長前端的 g0v 貢獻者寫出網站，串接婚姻平權大平台搜集全台上百個發文宣、掃街或對話的志工開團資訊，可以用區域、日期尋找開團資訊，讓資訊更容易閱讀。 　 公民科技也讓更多人有機會選擇如何行動。 　 :heartbeat: 「兩好三壞，全台開團資訊」網站 <https://g0v.github.io/for-marriage-equality/> :heartbeat: 網站資料來源...

❤️ 3 🌈 3
chihao 22:52:55
@chihao has joined the channel
HuangFu 23:29:40
感謝製作網站，請問資料從 google spreadsheets 到網頁是靠工人智慧嗎?目前這兩處資訊不完全同步，是不是把 `(11/?? 更新)` 加回去標題比較好呢?
agameofprivacy 2018-11-15 13:15:01
是的，謝謝您的提醒！
agameofprivacy 2018-11-15 13:16:36
@kevinliao here’s the pr: https://github.com/g0v/for-marriage-equality/pull/4

if you’ve got some time, perhaps we could look into https://github.com/giladaya/get-sheet-done as @patcon recommended? :pray:
agameofprivacy 2018-11-15 13:19:18
And here’s the dup spreadsheet I used to 工人智慧 line and phone info: https://docs.google.com/spreadsheets/d/1ImulYFRVtvb43L68E1Y1GdCAiLkOajHP0Mn9Pq0Cl_4/edit?usp=sharing

@aoisoranoko 請問您有編輯原始資料google sheet的權限嗎？謝謝！
Accepting.
agameofprivacy 2018-11-15 13:28:02
好謝謝！

2018-11-15

mrorz 10:35:37
看起來不是動態抓的 QQ
https://github.com/g0v/for-marriage-equality/#how-it-works

GitHub

g0v/for-marriage-equality

Contribute to g0v/for-marriage-equality development by creating an account on GitHub.

kjcl 12:30:03
Is not.
kjcl 12:30:10
Take google sheet export to cab
kjcl 12:30:13
Csv
kjcl 12:30:16
And readd
kjcl 12:30:24
Do I need to readd data?
kjcl 12:30:29
I am on mrt right now.
agameofprivacy 13:19:18
And here’s the dup spreadsheet I used to 工人智慧 line and phone info: https://docs.google.com/spreadsheets/d/1ImulYFRVtvb43L68E1Y1GdCAiLkOajHP0Mn9Pq0Cl_4/edit?usp=sharing

@aoisoranoko 請問您有編輯原始資料google sheet的權限嗎？謝謝！
agameofprivacy 13:29:00
@kevinliao starting a new branch `live-data-first` to work on pulling in live data by using _get-sheet-done_. will forego Line and Call buttons in favor of raw contact info text for now.
agameofprivacy 2018-11-15 14:11:43
Sorry got pulled into work stuff. Have to work on this later.. :(
agameofprivacy 2018-11-15 21:40:36
@kevinliao it’s mostly done. could you take a look? since we don’t have edit access to the master spreadsheet, I had to use a copy still: https://docs.google.com/spreadsheets/d/1Fc0BbQW6GWIlOtK5woKI-6zCjQ_V874KUzo8gcFUdnY/edit?usp=sharing
agameofprivacy 2018-11-15 21:40:54
🙏
I will be home soon and look!
Checking.
@agameofprivacy so right now, it pulls from your spreadsheet copy or from their spreadsheet?
agameofprivacy 2018-11-15 23:37:04
My spreadsheet copy of their 11/15 version.
agameofprivacy 2018-11-15 23:38:05
In order to pull from theirs we’d need to hit “publish for web” on their spreadsheet, which requires edit permissions.
agameofprivacy 2018-11-15 23:39:01
GetSheetDone also doesn’t seem to support blank rows out of the box, so I had to edit them out of my copy. :(
Is hitting ‘publish for web’ something we only need to do once
?
I can talk to them.
agameofprivacy 2018-11-15 23:47:39
I think so. Once they do it, we need to get the document key from the shareable url.
agameofprivacy 2018-11-15 23:48:26
And replace the key that’s currently in `app.tsx` or `index.tsx`
agameofprivacy 2018-11-15 23:49:14
And figure out how to get GetSheetDone to handle empty rows that currently exist on their spreadsheet.
agameofprivacy 2018-11-15 23:49:46
The key should be a 44-char string
I can just tell them to get rid of empty rows. 😛
agameofprivacy 2018-11-15 23:50:47
Hahahahaha or that. ;)
I pushed. I will talk to equallove.tw
2

2018-11-16