#marriage-equality
2018-11-13
@kevinliao has joined the channel
@kevinliao has renamed the channel from "2good3bad" to "marriage-equality"
@kevinliao set the channel topic: https://github.com/g0v/for-marriage-equality
@mrorz has joined the channel
- 👋2
@besslee has joined the channel
@patcon has joined the channel
@bil has joined the channel
@agameofprivacy has joined the channel
city picker is working. I pushed it before I took a nap.
it’s very ugly though
u sure about city picker working? is it on `ec/show-shifts`?
one second
pull
got the new <select> but still not working.
change it to yilan?
what might i be doing wrong?
it should narrow things down.
are you on mobile
k
?
ugh gosh as if I didn’t know about console--
here’s the error:
here’s the error:
Warning: Failed prop type: You provided a `value` prop to a form field without an `onChange` handler. This will render a read-only field. If the field should be mutable use `defaultValue`. Otherwise, set either `onChange` or `readOnly`.
would that be a showstopper?
I’m on desktop Chrome
ooooh this might be a showstopper.
Working on it. Thanks!
Fix pushed.
it’s perfect! 🙏
I want to add datepicker now.
sounds good. I’ll do css when you’re done with all the search/filter stuff!
What would a good datepicker with only 11 days left look like?
from a UX perspective
I’d do a simple select, perhaps remove dates in the past as we go?
if that’s not too much trouble… 
hm okay. I’ll just reuse someone’s datepicker.
because I’m very bad at css 😞
that’s ok. it’s much worse to be bad at js. 👈
that’s ok. it’s much worse to be bad at js. 👈
u sure about city picker working? is it on `ec/show-shifts`?
one second
- 👍1
pull
got the new <select> but still not working.
change it to yilan?
what might i be doing wrong?
it should narrow things down.
are you on mobile
k
?
ugh gosh as if I didn’t know about console--
here’s the error:
here’s the error:
Warning: Failed prop type: You provided a `value` prop to a form field without an `onChange` handler. This will render a read-only field. If the field should be mutable use `defaultValue`. Otherwise, set either `onChange` or `readOnly`.
would that be a showstopper?
I’m on desktop Chrome
ooooh this might be a showstopper.
- 👍1
Working on it. Thanks!
- 🙌1
Fix pushed.
it’s perfect! 🙏
I want to add datepicker now.
sounds good. I’ll do css when you’re done with all the search/filter stuff!
What would a good datepicker with only 11 days left look like?
from a UX perspective
I’d do a simple select, perhaps remove dates in the past as we go?
if that’s not too much trouble…
hm okay. I’ll just reuse someone’s datepicker.
- 😆1
- 👍1
@agameofprivacy datepicker is now in the bar, but it does not filter. the frontend should not change. I just need to add a filter now. You can go ahead and style without breaking anything now. 🙂
thanks @kevinliao
woops it’s on master
I’ll rebase
kk
done.
pushed a commit to support multiple CanvassType--works, but may be dirty.
okay
pulling
still looks like this
yep, doing styles now!
gimme 10-15
got it! my bad. take your time! 🙂
- 🙌1
pushed--optimizing for mobile now.
thanks! I’m working on getting that filter working. 🙂
- 💪1
beautiful!!!
Datepicker is working!
Pushing。
pushed to _not master_?
Woops. To master.
I keep pushing to master because I forget to chec back in after redeploy. :facepalm:
🤦♂️🏼
@agameofprivacy how do you rebuild sass?
I’m writing one last little thing.
`sass --watch src/index.scss:src/index.css`
thank you!
if you have sass installed
hold on… I just found out line url schemes don’t work anymore
need to replace with official button I think--gimme one sec
nvm, it doesn’t look like there’s an easy way. best workaround is probably copy lineID on button click?
any thoughts?
I don’t have any experience with LineID 😛
Added this!
1
Is there a way to make the search bar align with everything else?
it feels weird how it sticks out like that.
yep!
ok I’ll work on that now
@agameofprivacy what does index.css.map do?
not sure, I think that probably resulted from the sass watch.
okay. hm.
I ran into trouble with importing a react lib with typescript, help?
it’s in `Action.tsx`
the lines that are commented out.
Paste?
is that a library?
Like what is the error?
and what is the library?
ahh
`react-copy-to-clipboard`
New dependency?
yep
okay what is the error?
`import {CopyToClipboard} from 'react-copy-to-clipboard';`?
@kevinliao
oh yeah
run
are you using npm or yarn
yarn
run `yarn add -D @types/react-copy-to-clipboard`.
See if that helps.
thx
That way TypeScript gets to know the types of the library so we get less errors 😉
This is my first project programming with TS too 😉
- 👍1
Did it work?
it got less bad haha
can I see?
or do you have it under control ?
nope I’m ¯\_(ツ)_/¯
yay got it to work
- 2
1
Just pushed to `ec/show-shifts`
Thanks for all the help. Gonna wrap for the night. Great work! 🙌
YAYYYYY!!!! !
Thanks so much!!!!!
2018-11-14
is there a live demo site on heroku?
It’s running on github pages here: https://g0v.github.io/for-marriage-equality/ :pray:
cool! thanks! May I humbly suggest adding that to the URL of the repo, as that's often a quick place people look 🙂
Okay I’ll do that
@aoisoranoko has joined the channel
It’s running on github pages here: https://g0v.github.io/for-marriage-equality/ :pray:
cool! thanks! May I humbly suggest adding that to the URL of the repo, as that's often a quick place people look 🙂
Okay I’ll do that
- 🙏1
add og:meta data so sharing on facebook is prettier.
facebook.com
平權讓更多人有機會選擇如何去愛。 擅長前端的 g0v 貢獻者寫出網站，串接婚姻平權大平台搜集全台上百個發文宣、掃街或對話的志工開團資訊，可以用區域、日期尋找開團資訊，讓資訊更容易閱讀。 公民科技也讓更多人有機會選擇如何行動。 :heartbeat: 「兩好三壞，全台開團資訊」網站 <https://g0v.github.io/for-marriage-equality/> :heartbeat: 網站資料來源...
- ❤️3
- 🌈3
@chihao has joined the channel
感謝製作網站，請問資料從 google spreadsheets 到網頁是靠工人智慧嗎?目前這兩處資訊不完全同步，是不是把 `(11/?? 更新)` 加回去標題比較好呢?
是的，謝謝您的提醒！
@kevinliao here’s the pr: https://github.com/g0v/for-marriage-equality/pull/4
if you’ve got some time, perhaps we could look into https://github.com/giladaya/get-sheet-done as @patcon recommended? :pray:
if you’ve got some time, perhaps we could look into https://github.com/giladaya/get-sheet-done as @patcon recommended? :pray:
And here’s the dup spreadsheet I used to 工人智慧 line and phone info: https://docs.google.com/spreadsheets/d/1ImulYFRVtvb43L68E1Y1GdCAiLkOajHP0Mn9Pq0Cl_4/edit?usp=sharing
@aoisoranoko 請問您有編輯原始資料google sheet的權限嗎？謝謝！
@aoisoranoko 請問您有編輯原始資料google sheet的權限嗎？謝謝！
Accepting.
@agameofprivacy 我沒有原始 spreadsheets 的編輯權限，但應該是這個 FB 社團裡的人在更新的，你可以詢問他們
https://www.facebook.com/groups/EqualRightsCuties/?fref=mentions&__xts__[0]=68.ARCtp--4RI_r8JyodIoz7usO1GlGOVpDXVBf42QucuR2XIAMYp2lzQteTzeyr_NkV276Y3gXAnWG3BStLl3lUJGIGMaTrDTkFYMZn50vE3VuLVCmX3wgiINHpSTuvk0AFlR_yoXEPNuPkSUdGJN756NWK6YJBsl7sG4EMV4kqt4337e6XcdMlpYXV9qpnhTBalN0x4-VBHjsInmG_GlS4firEx18CqoL10-RFWPJvyQIFXw2sNcFm1JgN1OuauytmerF-tHhUUO6piAV_AYVnz6e_YY4Y9Jq6JfO8XgNH9h5qtlR_--vykmG62LntGJRaQi1xoBeLsoGXjt-V0Ry9PU&__tn__=K-R
https://www.facebook.com/groups/EqualRightsCuties/?fref=mentions&__xts__[0]=68.ARCtp--4RI_r8JyodIoz7usO1GlGOVpDXVBf42QucuR2XIAMYp2lzQteTzeyr_NkV276Y3gXAnWG3BStLl3lUJGIGMaTrDTkFYMZn50vE3VuLVCmX3wgiINHpSTuvk0AFlR_yoXEPNuPkSUdGJN756NWK6YJBsl7sG4EMV4kqt4337e6XcdMlpYXV9qpnhTBalN0x4-VBHjsInmG_GlS4firEx18CqoL10-RFWPJvyQIFXw2sNcFm1JgN1OuauytmerF-tHhUUO6piAV_AYVnz6e_YY4Y9Jq6JfO8XgNH9h5qtlR_--vykmG62LntGJRaQi1xoBeLsoGXjt-V0Ry9PU&__tn__=K-R
好謝謝！
2018-11-15
GitHub
Contribute to g0v/for-marriage-equality development by creating an account on GitHub.
Is not.
Take google sheet export to cab
Csv
And readd
Do I need to readd data?
I am on mrt right now.
是的，謝謝您的提醒！
@kevinliao here’s the pr: https://github.com/g0v/for-marriage-equality/pull/4
if you’ve got some time, perhaps we could look into https://github.com/giladaya/get-sheet-done as @patcon recommended? :pray:
if you’ve got some time, perhaps we could look into https://github.com/giladaya/get-sheet-done as @patcon recommended? :pray:
since we aren't pulling in live data (yet), we need this.
Pull data from google spreadsheets. Contribute to giladaya/get-sheet-done development by creating an account on GitHub.
Replied to a thread: 2018-11-14 23:29:40
And here’s the dup spreadsheet I used to 工人智慧 line and phone info: https://docs.google.com/spreadsheets/d/1ImulYFRVtvb43L68E1Y1GdCAiLkOajHP0Mn9Pq0Cl_4/edit?usp=sharing
@aoisoranoko 請問您有編輯原始資料google sheet的權限嗎？謝謝！
@aoisoranoko 請問您有編輯原始資料google sheet的權限嗎？謝謝！
Accepting.
- 🙏1
@agameofprivacy 我沒有原始 spreadsheets 的編輯權限，但應該是這個 FB 社團裡的人在更新的，你可以詢問他們
https://www.facebook.com/groups/EqualRightsCuties/?fref=mentions&__xts__[0]=68.ARCtp--4RI_r8JyodIoz7usO1GlGOVpDXVBf42QucuR2XIAMYp2lzQteTzeyr_NkV276Y3gXAnWG3BStLl3lUJGIGMaTrDTkFYMZn50vE3VuLVCmX3wgiINHpSTuvk0AFlR_yoXEPNuPkSUdGJN756NWK6YJBsl7sG4EMV4kqt4337e6XcdMlpYXV9qpnhTBalN0x4-VBHjsInmG_GlS4firEx18CqoL10-RFWPJvyQIFXw2sNcFm1JgN1OuauytmerF-tHhUUO6piAV_AYVnz6e_YY4Y9Jq6JfO8XgNH9h5qtlR_--vykmG62LntGJRaQi1xoBeLsoGXjt-V0Ry9PU&__tn__=K-R
https://www.facebook.com/groups/EqualRightsCuties/?fref=mentions&__xts__[0]=68.ARCtp--4RI_r8JyodIoz7usO1GlGOVpDXVBf42QucuR2XIAMYp2lzQteTzeyr_NkV276Y3gXAnWG3BStLl3lUJGIGMaTrDTkFYMZn50vE3VuLVCmX3wgiINHpSTuvk0AFlR_yoXEPNuPkSUdGJN756NWK6YJBsl7sG4EMV4kqt4337e6XcdMlpYXV9qpnhTBalN0x4-VBHjsInmG_GlS4firEx18CqoL10-RFWPJvyQIFXw2sNcFm1JgN1OuauytmerF-tHhUUO6piAV_AYVnz6e_YY4Y9Jq6JfO8XgNH9h5qtlR_--vykmG62LntGJRaQi1xoBeLsoGXjt-V0Ry9PU&__tn__=K-R
這是一個暫時性的社團，新加入的夥伴請先查看社團公告。 社團設立目的為方便大家自行開團、宣傳正確性平教育與婚平知識，以及互相支援。擴大群眾瞭解2018年底11/24公投項目，支持平權2公投，投下反同/反性平3公投不同意票。 跑攤過程有任何問題也可於社團內討論。 #請先閱讀社團置頂文公告 #歡迎加入志同道合的夥伴
好謝謝！
@kevinliao starting a new branch `live-data-first` to work on pulling in live data by using _get-sheet-done_. will forego Line and Call buttons in favor of raw contact info text for now.
2
Sorry got pulled into work stuff. Have to work on this later.. :(
@kevinliao it’s mostly done. could you take a look? since we don’t have edit access to the master spreadsheet, I had to use a copy still: https://docs.google.com/spreadsheets/d/1Fc0BbQW6GWIlOtK5woKI-6zCjQ_V874KUzo8gcFUdnY/edit?usp=sharing
🙏
I will be home soon and look!
Checking.
@agameofprivacy so right now, it pulls from your spreadsheet copy or from their spreadsheet?
My spreadsheet copy of their 11/15 version.
In order to pull from theirs we’d need to hit “publish for web” on their spreadsheet, which requires edit permissions.
GetSheetDone also doesn’t seem to support blank rows out of the box, so I had to edit them out of my copy. :(
Is hitting ‘publish for web’ something we only need to do once
?
I can talk to them.
I think so. Once they do it, we need to get the document key from the shareable url.
And replace the key that’s currently in `app.tsx` or `index.tsx`
And figure out how to get GetSheetDone to handle empty rows that currently exist on their spreadsheet.
The key should be a 44-char string
I can just tell them to get rid of empty rows. 😛
Hahahahaha or that. ;)
I pushed. I will talk to equallove.tw
Sorry got pulled into work stuff. Have to work on this later.. :(
@kevinliao it’s mostly done. could you take a look? since we don’t have edit access to the master spreadsheet, I had to use a copy still: https://docs.google.com/spreadsheets/d/1Fc0BbQW6GWIlOtK5woKI-6zCjQ_V874KUzo8gcFUdnY/edit?usp=sharing
🙏
I will be home soon and look!
- 🙌1
Checking.
- 🙏1
@agameofprivacy so right now, it pulls from your spreadsheet copy or from their spreadsheet?
My spreadsheet copy of their 11/15 version.
In order to pull from theirs we’d need to hit “publish for web” on their spreadsheet, which requires edit permissions.
GetSheetDone also doesn’t seem to support blank rows out of the box, so I had to edit them out of my copy. :(
Is hitting ‘publish for web’ something we only need to do once
?
I can talk to them.
I think so. Once they do it, we need to get the document key from the shareable url.
And replace the key that’s currently in `app.tsx` or `index.tsx`
And figure out how to get GetSheetDone to handle empty rows that currently exist on their spreadsheet.
The key should be a 44-char string
I can just tell them to get rid of empty rows. 😛
Hahahahaha or that. ;)
2018-11-16
I pushed. I will talk to equallove.tw
- 🙏1
@whus6207 has joined the channel
@kevinliao finished the nearby features and added some more polish--along with updating sheet with latest info from master. Let me know if I could help get this up on gh-pages!
WOW.
I’ll deploy in a second.
- 🙏2
hmm I think I should update the color used in location labels…
now it’s a bit close to the other side’s theme color.
What else is there to work on?
just hoping to get closer collab with equallove on their sheet so I can stop manually syncing across sheets for nearby. 😉
do you have time to reach out?
I’m reaching out right now.
I imagine more and more canvasses will be posted in the coming week.
anything else you’d like to work on? after the referendum I wanna look into making this more reusable so folks can street-organize more rapidly..
hmm I think I should update the color used in location labels…
now it’s a bit close to the other side’s theme color.
I’m reaching out right now.
- 🙏1
I was thinking if we could find a way to easily share individual canvasses
so an organizer could share a link and say “hey everyone I’m going to be canvassing on this ‘date’“.
2- 💯1
This would be an interesting problem.
But we will probably have to use a static site generator, or React-Router for this.
And I hate react-router.
hahaha
Also, we would have to make sure the links persist after each time we refresh.
Md5 Hash of several combined-unique and unchanging fields?
To give them permalinks, that is?
right
the ever changing info on the sheet might cause some issues also?
Md5 Hash of several combined-unique and unchanging fields?
To give them permalinks, that is?
Feature request, a link to "database" spreadsheet (in the footer, maybe). Let's not hide the raw data we rely on, as maybe some student might have an even more clever idea :) yay for always making the open data that drives things discoverable
2
2018-11-17
@kevinliao thanks for merging! Perhaps we should update `gh-pages`? 🙌
Thanks for deploying! 😄 lemme know if there’s anything else I could help with. 💪
Thanks for deploying! 😄 lemme know if there’s anything else I could help with. 💪
2018-11-18
waiting for response from equallove.tw they say they are working on giving me access and removing empty lines.
- 🐳2
- 1
Wow how come I never saw this before? Pretty cool: https://www.facebook.com/200363073753153/posts/582489122207211/
選前最後衝刺！ :secret:秘密武器介紹:secret: 這個秘密武器就是兩好三壞陣營的官方 line@ 不但不會一直打擾你，還有智慧型（？）選單讓你依自己的需要拿到新鮮+正確的素材。 這些素材，可以讓你在謠言四竄的各大群組颯爽登場自在洗版喔！ 手刀加入官方 line@ ID：@2yes3no (要加@小老鼠喔） 或點擊連結：<https://goo.gl/E1iVtq>
@agameofprivacy i have removed the empty rows. how do i give read/write access to the app
published.
oh cool, thanks!
could I help with adding in GPS coords?
also, I think my stupid :hover css is blocking text selection on iOS (and perhaps android), making it hard to copy contact info...:man-facepalming: I’ll work on a fix now--could you deploy to gh-pages when ready? :pray:
Yeah. But what is the Google Sheets ID I should use to get the real-time data working? I’m trying to find it but it’s not working on my end.
“131ImXHRXARx8j8t9esNCJhrLUfZQG347L1k3GsJ1m1Q”
？
Thisone？
wait it’s worknig…. but nothin gis displaying for some reason.
131ImXHRXARx8j8t9esNCJhrLUfZQG347L1k3GsJ1m1Q
we need to add a column named “經緯度”
it has to look like this…
Hmmm… Okay.
I can transfer the coords over
as long as you add the column name the page should render tho
by default everything is 9999km away and distance label won’t show.
as I transfer coords over they’ll start showing.
How do you generate the coords?
I can deploy now. It’s working on my end.
let me push the commit to remove hover
okay.
I manually looked up the coords :shame:
😮 WOW that’s dedication 😮
yeah anything for marriage equality.
lol
Hm. I think before we deploy:
but that does create the need to maintain.
We should have a graceful behaviour for if something has no location.
Because right now it just explodes.
And what if they add a new shift but don’t give it a location
then our site will go down.
If there is no location, what should we do?
Like no coordinates.
really? I thought it would just hide the location label?
i must be mistaken.
shifts without given location should be assigned 9999
hover removal at `ec/fix-hover` could you merge into master?
thanks.
do the coords match up 100% with the latest master sheet? I last updated them this morning.
I don’t know I just copy and pasted them >.< I go check now.
Looks good to me.
yep, thanks a lot!!
@kevinliao you’re probably already on it, but like you said, we might wanna make the default value assignment here safer: `line 70` in `App.tsx`
- 2
🛑
oh and don’t forget to update the footer url to the master sheet’s.
- 1
anyway we could make this dynamic? `<G0vbar width="1137px" />`?
Could make it max-width
I’d have to republish to npm and yarn update here though, so I will do that later. Low priority, I guess.
sounds good. or maybe we could pass auto to the width prop?
it’s making mobile funny haha, but absolutely no rush!
do you have a mobile screenshot?
Latest version deployed. I’ll write what we talked about here into Github issues.
Sounds good! go get some sleep
what do you need in the mobile ss?
2018-11-19
oh don’t wory about that
i was curious to see what g0vbar was breaking on mobile
oh I see
I got it
okay lol I’ll fix it tomorrow
Thanks!! Get some 💤
I’ll write an issue tomorrow detailing the text selection bug on mobile too. Text selection seems disabled (at least on iOS) after date picker set.
@kevinliao looks like someone updated the spreadsheet, adding back empty rows and removing the 經緯度 column. the site has exploded. 😞
I reached out to them on fb.. let me know if I could be of any help today!
Gsheets has a robust QUERY formula. We could create our own spreadsheet that sanitize theirs (and protects the site) through a few layers of our own sheets
@patcon 🆒 we should definitely do that, but I’m terrible at sheets (:help:). Given how we’re so down to the wire now, I’m down to whichever approach, including manually maintain a separate spreadsheet with a 5-10mins delay. @kevinliao lemme know!
I'm on mobile, but this sheet uses QUERY and should demo how it works (top left cell is the one with the range formula that populates rest of sheet)
https://docs.google.com/spreadsheets/d/1-5LKHB8ZZsGpXDV7_uw9EgDSq2FiReUh5wpzuG6iewk/edit?usp=drivesdk
https://docs.google.com/spreadsheets/d/1-5LKHB8ZZsGpXDV7_uw9EgDSq2FiReUh5wpzuG6iewk/edit?usp=drivesdk
Wish I could do more right now, but I'll check in later
Great, I’ll take a good at it! 🙏
Replied to a thread: 2018-11-19 07:00:44
I reached out to them on fb.. let me know if I could be of any help today!
Gsheets has a robust QUERY formula. We could create our own spreadsheet that sanitize theirs (and protects the site) through a few layers of our own sheets
@patcon 🆒 we should definitely do that, but I’m terrible at sheets (:help:). Given how we’re so down to the wire now, I’m down to whichever approach, including manually maintain a separate spreadsheet with a 5-10mins delay. @kevinliao lemme know!
I'm on mobile, but this sheet uses QUERY and should demo how it works (top left cell is the one with the range formula that populates rest of sheet)
https://docs.google.com/spreadsheets/d/1-5LKHB8ZZsGpXDV7_uw9EgDSq2FiReUh5wpzuG6iewk/edit?usp=drivesdk
https://docs.google.com/spreadsheets/d/1-5LKHB8ZZsGpXDV7_uw9EgDSq2FiReUh5wpzuG6iewk/edit?usp=drivesdk
Wish I could do more right now, but I'll check in later
Great, I’ll take a good at it! 🙏
What if we just wrote our own backend
i think the problem is keeping the spreadsheet and the UI in sync. It is the synchronization that breaks stuff, but the sync is essential (since all of us need the latest info for the following days)
If their changing spreadsheet breaks UI when UI directly pulls data from spreadsheet,
it will break our backend as well if we implement our backend.
If their changing spreadsheet breaks UI when UI directly pulls data from spreadsheet,
it will break our backend as well if we implement our backend.
@kevinliao @mrorz I’m terrible at spreadsheets but here’s something @patcon was suggesting: https://docs.google.com/spreadsheets/d/1i3Y4VTelUNFySPXMys6rLlN3wZlC9T_vLKR1X-9rnmY/edit#gid=0
Hmm I think using QUERY is a great idea
OurOwn pulls from the other two sheets.
we should read from OurOwn
but remember to change the share setting of the spreadsheet so that UI can read
currently I cannot access https://docs.google.com/spreadsheets/d/1i3Y4VTelUNFySPXMys6rLlN3wZlC9T_vLKR1X-9rnmY/edit#gid=0
yeah we will need to move OurOwn into equallove’s worksheet so 開團資訊 will always be updated.
there are also two to-dos I don’t know how to do: 1) remove empty rows from `OurOwn` 2) keeping only unique locations in `開團地點資訊`
may i ask what is `OurOwn`?
it’s the name of the second sheet.
sheet?
oh dang
sorry
Heh we can't see it yet @agameofprivacy (needs sharing perms changed)
I think we can try query data across spreadsheets
https://wp.nyu.edu/technology/2016/02/23/google-sheets-querying-data-in-another-spreadsheet/
https://wp.nyu.edu/technology/2016/02/23/google-sheets-querying-data-in-another-spreadsheet/
wooooah
- 1
Also, ignore blanks with `where C = ''` in query
Or any column we know will be blank not just "C"
- 🙏1
Hi sorry I was working on cofacts. I'm online now.
- 🙌1
- 🙏1
- 🐳1
Okay. I think we need to:
1. Implement a more graceful failure for location
Currently the constructor for Canvass probably throws an error when we parse location if location is not there.
Data source of 兩好三壞: https://docs.google.com/spreadsheets/d/131ImXHRXARx8j8t9esNCJhrLUfZQG347L1k3GsJ1m1Q/edit#gid=0
Reading the above spreadsheet from another spreadsheet (which we can do pre-processing in):
https://docs.google.com/spreadsheets/d/1rIoa0LiXidVm9fteDswZdAJC1BRWAR5S2OMd61P_6js/edit?usp=sharing
Reading the above spreadsheet from another spreadsheet (which we can do pre-processing in):
https://docs.google.com/spreadsheets/d/1rIoa0LiXidVm9fteDswZdAJC1BRWAR5S2OMd61P_6js/edit?usp=sharing
So that I think if we put `=IMPORTRANGE("https://docs.google.com/spreadsheets/d/131ImXHRXARx8j8t9esNCJhrLUfZQG347L1k3GsJ1m1Q/edit","開團資訊!A:L")` into @agameofprivacy’s spreadsheet ( https://docs.google.com/spreadsheets/d/1i3Y4VTelUNFySPXMys6rLlN3wZlC9T_vLKR1X-9rnmY/edit#gid=762424920 ) then we can get a always-updated OurOwn?
@mrorz you should be able to test that without breaking anything given we are using equallove's spreadsheet right now.
@mrorz I can’t seem to get `importrange` to work inside `query`.
yeah so let’s do it separately
in sheet “開團資訊” i put importrange
then in OurOwn we use data from “開團資訊”
K! sounds good 🙌
I’ll fix the constructor to handle null location more gracefully.
- 👍2
I already edited “開團資訊”
thanks, @kevinliao!
seems that it’s working. If you delete any cell content other than A1 in 開團資訊 it will be re-filled immediately. That means `importrange` in A1 works.
💥
I think what’s left is connecting the UI to `OurOwn` ?
yep
🚀
just published OurOwn @kevinliao should be this doc ID: `131ImXHRXARx8j8t9esNCJhrLUfZQG347L1k3GsJ1m1Q`
gonna test locally now
if it does work let me know I’ll deploy right away.
The last concern is that in 開團資訊 the last row is empty except A column. (離島外海)
does that break UI?
oh maybe we should do check on date also?
worth a try
I am currently looking at issue of lack of 經緯度 for “捷運七張站1出口”
vlookup should work, but it’s empty
weird
oh I’m silly
it’s an issue of 捷運七張站1出口 v.s. 捷運七張站1出口
Fixing “開團地點資訊”
thanks
I’m working to get GetSheetDone to read the right sheet.
sometimes 集合地 and 地點 are different. No idea how we should support this. Using 地點 is fine i think
yeah I used 地點 to get the rough coordinates
can’t get GSD to read sheetNum = 2
Pull data from google spreadsheets. Contribute to giladaya/get-sheet-done development by creating an account on GitHub.
I’ve deployed null constructor and it’s working again
but
a lot of data is not showing
I think that’s the GSD issue.
yeah because we should use https://docs.google.com/spreadsheets/d/1i3Y4VTelUNFySPXMys6rLlN3wZlC9T_vLKR1X-9rnmY/edit#gid=0 instead
`OurOwn` table
the original one (131ImXHRXARx8j8t9esNCJhrLUfZQG347L1k3GsJ1m1Q) contains empty rows, that’s probably why
Okay one moment.
thanks folks, sorry got pulled away. 😞
Using this ID still only not a lot of shifts
only 14 showing up
Only the 14 on Monday.
As for geolocation visualization, google fusiontable offers some visualization. However, the data does not update by iteslf 😞
https://fusiontables.google.com/data?docid=1mDd1Mev0pfQABx_kzU8zHI0hNPiSbtYdykRIQbNV#map:id=3
https://fusiontables.google.com/data?docid=1mDd1Mev0pfQABx_kzU8zHI0hNPiSbtYdykRIQbNV#map:id=3
I’m very confused to why GSD is only pulling the first 14…
wait hang on derp.
I saved sheetNum to 2 it’s working onw.
Deploying. I think it’s saved.
👍
Good work everyone! 🌈
Will think about how this can be more resilient. 😛
is it still deploying?
working on my end.
Just deployed. Try refreshing.
🌈🙌🌈
Good work!!! Let’s go!!!! ❤️
- 🚀4
- 🐳1
- 🐈1
- 2
- 🐄1
是說大家是不是只更新 gh-pages 沒上 master branch 呀 @@
tried pulling down master branch, cannot run cuz of constructor issue
One moment
What is error
I think I deployed from master.
Sorry! I deployed from local branch! I just merged to master. Try again @mrorz1
@mrorz
thanks
nice!
I think I really like this way of using layers of Google spreadsheets to process 🙂 I feel like maybe it's a good pattern, for a couple reasons:
1. keeps the regular people from getting yelled at for breaking things, which is nice
2. allows the app to "protect" itself through a gsheet layer
3. working on gsheet layer is accessible to non-programmers, so don't need coding skills to help improve the app or fix an accidental breakage
1. keeps the regular people from getting yelled at for breaking things, which is nice
2. allows the app to "protect" itself through a gsheet layer
3. working on gsheet layer is accessible to non-programmers, so don't need coding skills to help improve the app or fix an accidental breakage
- 1
Hi I added a map view, please review
https://github.com/g0v/for-marriage-equality/pull/6
The popup of markers (`InfoWindoow`) can be changed in the future. It do support lots of customizations: https://developers.google.com/maps/documentation/javascript/examples/infowindow-simple
https://github.com/g0v/for-marriage-equality/pull/6
The popup of markers (`InfoWindoow`) can be changed in the future. It do support lots of customizations: https://developers.google.com/maps/documentation/javascript/examples/infowindow-simple
Major changes Adds a state: view to <App> and a <Selector> for user to choose from &quot;卡片&quot; or &quot;地圖&quot;. Add <Map> component. Once mounted, its DOM is manipulated by ...
Rooms of improvements (that I won’t have time to implement)
- Better popup (`InfoWindow`)
- Better markers (ex: color-coding according to 開團形式)
- Automatic zooming by selection
- Give Map view a link so that users can open map views directly
- Better popup (`InfoWindow`)
- Better markers (ex: color-coding according to 開團形式)
- Automatic zooming by selection
- Give Map view a link so that users can open map views directly
- 🐳2
- ❤️2
WOW!!
I’ll take a look once I get home!
WOW!!
I’ll take a look once I get home!
I’ll go take a look!
@mrorz I am working on using a toggle button to switch states rather than a dropdown, which I think is more intuitive.
- 💎2
@mrorz You appear to have committed an API Key. Is this intentional? Should I purge it?
The toggle is setting state correctly, but the maps API is silently failing…
I’ve found typescript types for the Maps API. I’m going to add them to the PR so that we are never unsafe without TypeScript.
- 🙌1
Stack Overflow
How can it be done - I've tried combinations of typings install [googlemaps | google.maps] [--ambient] --save and end up with variations on this error typings ERR! message Unable to find "goog...
Maps is throwing an error and I really can’t figure out why.
The latest version of Map.tsx is now in TypeScript and requires doing a yarn install to add the typings fro Google maps.
That aside, I have not changed any of the code and I’m really unsure why it’s failing without an error message.
It was working earlier, but just stopped working and I really don’t know why.
The toggle component is fully working so if any of us can figure out why maps is breaking i can merge.
I added a filter to remove any components without proper latitude and longitude
so it should not break if equallove is doing something silly with their data again.
- 🙏1
Okay I can’t figure it out. I’m going to give up on maps and wait for mrorz
😛
in the mean time, get excited for the toggle to look like this
- 2
I’ll leave the difficult engineering to you folks. in the meantime, I filled in all the blank coordinates. haha 🌐
could I move the toggle to right and bottom for visuals/ux?
I’ll work on mobile styling for the toggles.
any chance we could update the g0vbar component to at least be width auto?
toggles on the right.
toggles on mobile
I wonder how well map view works on mobile?
2018-11-20
API key is public
it’s meant to be public https://developers.google.com/maps/documentation/javascript/tutorial
Google Developers
Get started with the Google Maps JavaScript API. View a simple example, learn the concepts, and create custom maps for your site.
I have added http referral restriction so that the key only works on localhost and g0v.github.io/for-marriage-equality
Sorry that in my initial PR the code added style to index.css, but i did not notice that it’s generated from index.scss.
This causes `.map__root`’s style to disappear, which actually contains a style that gives .map__root a decent height
Another thing is that, actually create-react-app supports scss (see webpack config), it just need node-sass to work (see: https://facebook.github.io/create-react-app/docs/adding-a-sass-stylesheet )
facebook.github.io
> Note: this feature is available with `react-scripts@2.0.0` and higher.
I am wrapping up and update the PR now
On the mobile, the 1137px-wide `<G0vbar>` is generating a horizontal scroll. I have no idea why we should set it to 1137px wide…
This causes `.map__root`’s style to disappear, which actually contains a style that gives .map__root a decent height
Major changes Adds a state: view to <App> and a <Selector> for user to choose from &quot;卡片&quot; or &quot;地圖&quot;. Add <Map> component. Once mounted, its DOM is manipulated by ...
Yeah. I’ll update g0v-banner now.
Simple fix. Sorry I was so lazy. Pushing.
g0vbar fix pushed to npm. do a git pull and yarn install to fix. Fix has been deployed to gh-pages.
@mrorz with latest commit, maps is still not working for me.
nevermind i’m running pull again something is better now
Google Maps JavaScript API error: RefererNotAllowedMapError
https://developers.google.com/maps/documentation/javascript/error-messages#referer-not-allowed-map-error
Your site URL to be authorized: https://g0v.github.io/for-marriage-equality/ js:51:50
https://developers.google.com/maps/documentation/javascript/error-messages#referer-not-allowed-map-error
Your site URL to be authorized: https://g0v.github.io/for-marriage-equality/ js:51:50
It’s deployed. Just waiting for the domain authorization and we should be good to go!!!!
Thank you so much @mrorz for all of your hard work on this!
i am checking my config on google api console
okay google api key’s “referrers” don’t accept URL with paths.
https://stackoverflow.com/a/38577184
so when I set to `https://g0v.github.io/for-marriage-equality` it errors, but if I set to `https://g0v.github.io/*` it works.
I would definitely call it a bug lol
https://stackoverflow.com/a/38577184
so when I set to `https://g0v.github.io/for-marriage-equality` it errors, but if I set to `https://g0v.github.io/*` it works.
I would definitely call it a bug lol
We're trying to develop an geoplacement app for one of our clients, and we want first to test it in out own domain. We have signed for Google Maps JavaScript API, and we have a valid browser key a...
anyway the map works now!
🌈 🌈 🌈
whenever you’ve got some time--here’s a one-line PR to prevent toggles from obstructing the date picker’s popper: https://github.com/g0v/for-marriage-equality/pull/7
🙏
deploying
I’m going to spend some more time cleaning up the code and moving more things from App.tsx into components
Thank you!!! I’ll clean up `index.scss` when I get a chance.
I’ve added TSLint to our code and my god we have a lot to fix hahaha
- 😄2
I added TSLint and decided to use AirBnB JS standards to lint our code. It now looks a lot more consistent.
Changed everything hahaha
- 1
- 🐳1
You should yarn install to install tslint
then run TSLint on all your files before you commit. I can add an npm script to do that.
then run TSLint on all your files before you commit. I can add an npm script to do that.
2018-11-21
@kevinliao @mrorz just sent edit permissions for the spreadsheets to your emails. wanted to lock down public edit access to prevent foul-play. ✊
- 👍2
Okay!
Hi everyone! I went out canvassing today and all the volunteers showed up because they saw our website. WE ARE MAKING A BIG DIFFERENCE.
- 🙌3
- 2
- 🐳2
wow! it’s great to know that!
holy shit, that's such amazing feedback
is it possible to message the leads to have them all ask similar sorts of questions? maybe make a quick google form to them to get the data back
I think they’re swamped enough
as is
i don’t want to bother them
true true say
ok, maybe this is crazy, but what about something like this:
- bitly link
- email lead, and ask them to just delegate to one volunteer with a phone
- the link quickly gives the volunteer the info they need to get analytics on the group
tl;dr - design for delegation?
- bitly link
- email lead, and ask them to just delegate to one volunteer with a phone
- the link quickly gives the volunteer the info they need to get analytics on the group
tl;dr - design for delegation?
the volunteers are gathering a lot of data already
i would really like this data too
haha but this is like obama campaign sorta strategies. maybe data isn't something that could be benefit for organizers
but i want to make this about them and not us
i think it’s too late to implement at this sstage.
as in, even if we implemented it now, it would be too late for them to pivot anyways
gotcha. wasn;t thinking this was about the app, but more about helping organizers understand where people came from and what worked
but yes, tough timelines
(and i don't want to assume they're not collecting their own information 🙂 )
honestly, a lot of the organizers are a little frustrated. that it took our frontend to drive a lot of volunteers in the last week lead-up. they’ve been canvassing for months and only after the website, a lot of people suddenly are showing up.
it goes to show the importance of this work, but we definitely should move a lot faster in the future.
it goes to show the importance of this work, but we definitely should move a lot faster in the future.
🤔
Hmm I was one of the members canvassing pedestrians to sign up for the referendum petition. The number also suddenly goes up for the last week. Maybe it’s not all because we are late to put up the site, but the audiences won’t do anything before the last week lol
yeah.
we also don’t have 護家盟 money
😛
correlation and causation: HOW DOES THEY WORK?
wow! it’s great to know that!
holy shit, that's such amazing feedback
is it possible to message the leads to have them all ask similar sorts of questions? maybe make a quick google form to them to get the data back
I think they’re swamped enough
as is
i don’t want to bother them
true true say
ok, maybe this is crazy, but what about something like this:
- bitly link
- email lead, and ask them to just delegate to one volunteer with a phone
- the link quickly gives the volunteer the info they need to get analytics on the group
tl;dr - design for delegation?
- bitly link
- email lead, and ask them to just delegate to one volunteer with a phone
- the link quickly gives the volunteer the info they need to get analytics on the group
tl;dr - design for delegation?
the volunteers are gathering a lot of data already
i would really like this data too
haha but this is like obama campaign sorta strategies. maybe data isn't something that could be benefit for organizers
but i want to make this about them and not us
i think it’s too late to implement at this sstage.
as in, even if we implemented it now, it would be too late for them to pivot anyways
- ❤️2
gotcha. wasn;t thinking this was about the app, but more about helping organizers understand where people came from and what worked
but yes, tough timelines
(and i don't want to assume they're not collecting their own information 🙂 )
Replied to a thread: 2018-11-21 14:28:51
honestly, a lot of the organizers are a little frustrated. that it took our frontend to drive a lot of volunteers in the last week lead-up. they’ve been canvassing for months and only after the website, a lot of people suddenly are showing up.
it goes to show the importance of this work, but we definitely should move a lot faster in the future.
it goes to show the importance of this work, but we definitely should move a lot faster in the future.
- 🖖1
a conversation today went something like “Why is it that I’ve only heard about this in the last week? Have you not been doing anything?” “We have, for months. But it took the new website for people to pay attention.”
> Have you not been doing anything?
oof. that would be hard to hear
oof. that would be hard to hear
Yeah. That’s why people are upset.
in my opinion, before the website established, the canvassing are more around a closing group, it isn’t opend for public, that’s why even someone would like to help but in vain.
I agree.
I tried to look for ways to help but I didn't know where.
🤔
Hmm I was one of the members canvassing pedestrians to sign up for the referendum petition. The number also suddenly goes up for the last week. Maybe it’s not all because we are late to put up the site, but the audiences won’t do anything before the last week lol
- 🌈2
- 💯2
yeah.
we also don’t have 護家盟 money
😛
correlation and causation: HOW DOES THEY WORK?
> Have you not been doing anything?
oof. that would be hard to hear
oof. that would be hard to hear
Yeah. That’s why people are upset.
in my opinion, before the website established, the canvassing are more around a closing group, it isn’t opend for public, that’s why even someone would like to help but in vain.
I agree.
I tried to look for ways to help but I didn't know where.
2018-11-22
@kevinliao perhaps we could remove the last updated date from 兩好三壞，全台開團資訊（11月16日更新）to avoid further confusion? 😉
here’s a PR: https://github.com/g0v/for-marriage-equality/pull/9
Sorry I went out to volunteer these last few days and didn’t check slack.
:(
No worries! We’ll keep fighting. 🌈
here’s a PR: https://github.com/g0v/for-marriage-equality/pull/9
We no longer need last updated date. Two-decimal distance labels caused layout imperfections.
2018-11-24
大家辛苦了。大家加油。
- ❤️4
- 3
Sorry I went out to volunteer these last few days and didn’t check slack.
:(
No worries! We’ll keep fighting. 🌈
2018-11-28
@pmewolf has joined the channel